Issues in DataSourceCollectionTrait.php - New Issues - Inspection of "removed the old collections component" - cubiche/collections - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d6f0bd...41a21b )

by Ivannis Suárez

created 2016-06-06 14:48 UTC

DataSourceCollectionTrait.php (4 issues)

Labels

Bug 4

Severity

Minor 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * This file is part of the Cubiche package.
 *
 * Copyright (c) Cubiche
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
namespace Cubiche\Core\Collections;

use Cubiche\Core\Collections\DataSource\DataSourceInterface;
use Cubiche\Core\Specification\SpecificationInterface;

/**
 * DataSourceCollection Trait.
 *
 * @author Karel Osorio Ramírez <[email protected]>
 * @author Ivannis Suárez Jerez <[email protected]>
 */
trait DataSourceCollectionTrait
{
    /**
     * @var DataSourceInterface
     */
    protected $dataSource;

    /**
     * @param DataSourceInterface $dataSource
     */
    public function __construct(DataSourceInterface $dataSource)
    {
        $this->dataSource = $dataSource;
    }

    /**
     * {@inheritdoc}
     */
    public function count()
    {
        if ($this->isInitialized()) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            return parent::count();
        }

        return $this->dataSource->count();
    }

    /**
     * {@inheritdoc}
     */
    public function getIterator()
    {
        if ($this->isInitialized()) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            return parent::getIterator();
        }

        return $this->dataSource->getIterator();
    }

    /**
     * {@inheritdoc}
     */
    public function slice($offset, $length = null)
    {
        if ($this->isInitialized()) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            return parent::slice($offset, $length);
        }

        return new self($this->dataSource->slicedDataSource($offset, $length));
    }

    /**
     * {@inheritdoc}
     */
    public function find(SpecificationInterface $criteria)
    {
        if ($this->isInitialized()) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            return parent::find($criteria);
        }

        return new self($this->dataSource->filteredDataSource($criteria));
    }
}


1			<?php
2
3			/**
4			* This file is part of the Cubiche package.
5			*
6			* Copyright (c) Cubiche
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11			namespace Cubiche\Core\Collections;
12
13			use Cubiche\Core\Collections\DataSource\DataSourceInterface;
14			use Cubiche\Core\Specification\SpecificationInterface;
15
16			/**
17			* DataSourceCollection Trait.
18			*
19			* @author Karel Osorio Ramírez <[email protected]>
20			* @author Ivannis Suárez Jerez <[email protected]>
21			*/
22			trait DataSourceCollectionTrait
23			{
24			/**
25			* @var DataSourceInterface
26			*/
27			protected $dataSource;
28
29			/**
30			* @param DataSourceInterface $dataSource
31			*/
32			public function __construct(DataSourceInterface $dataSource)
33			{
34			$this->dataSource = $dataSource;
35			}
36
37			/**
38			* {@inheritdoc}
39			*/
40			public function count()
41			{
42			if ($this->isInitialized()) {
			0 ignored issues – show Bug introduced 2016-06-06 14:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `isInitialized()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
43			return parent::count();
44			}
45
46			return $this->dataSource->count();
47			}
48
49			/**
50			* {@inheritdoc}
51			*/
52			public function getIterator()
53			{
54			if ($this->isInitialized()) {
			0 ignored issues – show Bug introduced 2016-06-06 14:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `isInitialized()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
55			return parent::getIterator();
56			}
57
58			return $this->dataSource->getIterator();
59			}
60
61			/**
62			* {@inheritdoc}
63			*/
64			public function slice($offset, $length = null)
65			{
66			if ($this->isInitialized()) {
			0 ignored issues – show Bug introduced 2016-06-06 14:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `isInitialized()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
67			return parent::slice($offset, $length);
68			}
69
70			return new self($this->dataSource->slicedDataSource($offset, $length));
71			}
72
73			/**
74			* {@inheritdoc}
75			*/
76			public function find(SpecificationInterface $criteria)
77			{
78			if ($this->isInitialized()) {
			0 ignored issues – show Bug introduced 2016-06-06 14:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `isInitialized()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
79			return parent::find($criteria);
80			}
81
82			return new self($this->dataSource->filteredDataSource($criteria));
83			}
84			}
85

cubiche / collections

Push — master ( d6f0bd...41a21b )

DataSourceCollectionTrait.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like