Cubiche\Core\Bus\Tests\Units\BusTests

Complexity

Total Complexity

4

Size/Duplication

Total Lines	80
Duplicated Lines	50 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	testCreateWithInvalidMiddleware()	0	11	1
A	testDispatch()	0	11	1
A	testAddMiddlewareBefore()	20	20	1
A	testAddMiddlewareAfter()	20	20	1

<?php
/**
 * This file is part of the Cubiche package.
 *
 * Copyright (c) Cubiche
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
namespace Cubiche\Core\Bus\Tests\Units;

use Cubiche\Core\Bus\Bus;
use Cubiche\Core\Bus\Exception\InvalidMiddlewareException;
use Cubiche\Core\Bus\Middlewares\Locking\LockingMiddleware;
use Cubiche\Core\Bus\Tests\Fixtures\FooMessage;

/**
 * BusTests class.
 *
 * @author Ivannis Suárez Jerez <ivannis.suarez@gmail.com>
 */
class BusTests extends TestCase
{
    /**
     * Test create with invalid middleware.
     */
    public function testCreateWithInvalidMiddleware()
    {
        $this
            ->given($middleware = new LockingMiddleware())
            ->then()
                ->exception(function () use ($middleware) {
                    new Bus([$middleware, new \StdClass()]);

array($middleware, new \StdClass()) is of type array<integer,object<Cubiche\Core\Bus\Middlewares\Locking\LockingMiddleware>|object<stdClass>,{"0":"object<Cubiche\\Core\\Bus\\Middlewares\\Locking\\LockingMiddleware>","1":"object<stdClass>"}>, but the function expects a array<integer,object<Cubiche\Core\Bus\Middlewares\MiddlewareInterface>>.

                })
                ->isInstanceOf(InvalidMiddlewareException::class)
        ;
    }

    /**
     * Test dispatch method.
     */
    public function testDispatch()
    {
        $this
            ->given($middleware = new LockingMiddleware())
            ->and($bus = new Bus([12 => $middleware]))
            ->when($result = $bus->dispatch(new FooMessage()))
            ->then()
                ->variable($result)
                    ->isNull()
        ;
    }

    /**
     * Test addMiddlewareBefore method.
     */
    public function testAddMiddlewareBefore()

This method seems to be duplicated in your project.

    {
        $this
            ->given($middleware = new LockingMiddleware())
            ->and($bus = new Bus([12 => $middleware]))
            ->when($result = $bus->addMiddlewareBefore($middleware, $middleware))

Are you sure the assignment to $result is correct as $bus->addMiddlewareBefore($middleware, $middleware) (which targets Cubiche\Core\Bus\Bus::addMiddlewareBefore()) seems to always return null.

            ->then()
                ->variable($result)
                    ->isNull()
        ;

        $this
            ->given($middleware = new LockingMiddleware())
            ->and($bus = new Bus())
            ->then()
                ->exception(function () use ($bus, $middleware) {
                    $bus->addMiddlewareBefore($middleware, $middleware);
                })->isInstanceOf(\InvalidArgumentException::class)
        ;
    }

    /**
     * Test addMiddlewareAfter method.
     */
    public function testAddMiddlewareAfter()

This method seems to be duplicated in your project.

    {
        $this
            ->given($middleware = new LockingMiddleware())
            ->and($bus = new Bus([12 => $middleware]))
            ->when($result = $bus->addMiddlewareAfter($middleware, $middleware))

Are you sure the assignment to $result is correct as $bus->addMiddlewareAfter($middleware, $middleware) (which targets Cubiche\Core\Bus\Bus::addMiddlewareAfter()) seems to always return null.

            ->then()
                ->variable($result)
                    ->isNull()
        ;

        $this
            ->given($middleware = new LockingMiddleware())
            ->and($bus = new Bus())
            ->then()
                ->exception(function () use ($bus, $middleware) {
                    $bus->addMiddlewareAfter($middleware, $middleware);
                })->isInstanceOf(\InvalidArgumentException::class)
        ;
    }
}