CancelDeferredTrait::cancel() - Code Metrics - cubiche/async - Measure and Improve Code Quality continuously with Scrutinizer

CancelDeferredTrait::cancel() A
last analyzed 2017-03-16 11:38 UTC

↳ Parent: CancelDeferredTrait

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	5
nc	2
nop	0

<?php

/*
 * This file is part of the Cubiche package.
 *
 * Copyright (c) Cubiche
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Cubiche\Core\Async\Promise;

/**
 * Cancel Deferred trait.
 *
 * @author Karel Osorio Ramírez <[email protected]>
 */
trait CancelDeferredTrait
{
    /**
     * @return bool
     */
    public function cancel()
    {
        if ($this->promise()->state()->equals(State::PENDING())) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $this->reject(new CancellationException());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

            return true;
        }

        return false;
    }
}


1			<?php
2
3			/*
4			* This file is part of the Cubiche package.
5			*
6			* Copyright (c) Cubiche
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Cubiche\Core\Async\Promise;
13
14			/**
15			* Cancel Deferred trait.
16			*
17			* @author Karel Osorio Ramírez <[email protected]>
18			*/
19			trait CancelDeferredTrait
20			{
21			/**
22			* @return bool
23			*/
24			public function cancel()
25			{
26			if ($this->promise()->state()->equals(State::PENDING())) {
			0 ignored issues – show Bug introduced 2016-05-01 16:50 UTC by Report Bug Copy Issue Report It seems like `promise()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
27			$this->reject(new CancellationException());
			0 ignored issues – show Bug introduced 2016-05-01 16:50 UTC by Report Bug Copy Issue Report It seems like `reject()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
28
29			return true;
30			}
31
32			return false;
33			}
34			}
35

cubiche / async

CancelDeferredTrait::cancel() A last analyzed 2017-03-16 11:38 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

CancelDeferredTrait::cancel() A
last analyzed 2017-03-16 11:38 UTC