csphere\core\session\Session

Complexity

Total Complexity

10

Size/Duplication

Total Lines	113
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	13	3
B	_start()	0	26	3
A	destroy()	0	14	1
A	get()	0	11	2
A	set()	0	6	1

<?php

/**
 * Provides a session with a client to work with
 *
 * PHP Version 5
 *
 * @category  Core
 * @package   Session
 * @author    Hans-Joachim Piepereit <contact@csphere.eu>
 * @copyright 2013 cSphere Team
 * @license   http://opensource.org/licenses/bsd-license Simplified BSD License
 * @link      http://www.csphere.eu
 **/

namespace csphere\core\session;

/**
 * Provides a session with a client to work with
 *
 * @category  Core
 * @package   Session
 * @author    Hans-Joachim Piepereit <contact@csphere.eu>
 * @copyright 2013 cSphere Team
 * @license   http://opensource.org/licenses/bsd-license Simplified BSD License
 * @link      http://www.csphere.eu
 **/

class Session
{

    /**
     * Creates a new session object
     *
     * @return \csphere\core\session\Session
     **/

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

There must be no blank lines after the function comment

    public function __construct()
    {
        // Check for an active session
        $status = session_status();

        $active = ($status == PHP_SESSION_ACTIVE) ? true : false;

        // If there is no active session create one
        if (empty($active)) {

            $this->_start();
        }
    }

    /**
     * Cares about session settings and starts a new one
     *
     * @return void
     **/

There must be no blank lines after the function comment

    private function _start()
    {
        // Set some session settings, httponly is set by cookie_params
        ini_set('session.use_trans_sid', 0);
        ini_set('session.use_cookies', 1);
        ini_set('session.use_only_cookies', 1);

        // Change session name and cookie params
        $request = \csphere\core\http\Request::get();

        $dns = ($request['dns'] == 'localhost') ? '' : $request['dns'];

        //ToDo: Fix Session Management
        //$salt = mcrypt_create_iv(40, MCRYPT_DEV_URANDOM);

        //$name = 'csphere_' . md5($request['dns'] . $request['dirname'] . $salt);

        //session_name($name);

        $secure = ($request['protocol'] == 'https') ? true : false;

        session_set_cookie_params(0, $request['dirname'], $dns, $secure, true);

        // Start a new session
        session_start();
    }

    /**
     * Clears all session data
     *
     * @return boolean
     **/

There must be no blank lines after the function comment

    public function destroy()
    {
        // Empty all session contents
        session_unset();
        session_destroy();

        // Disable future changes
        session_write_close();

        // Get a new id to kill the old one for sure
        session_regenerate_id(true);

        return true;
    }

    /**
     * Retrieves the data stored in a session
     *
     * @param string $name Name of the session key to retrieve
     *
     * @return string
     **/

There must be no blank lines after the function comment

    public function get($name)
    {
        $string = '';

        if (isset($_SESSION[$name])) {

            $string = $_SESSION[$name];
        }

        return $string;
    }

    /**
     * Stores session data
     *
     * @param string $name  Name of the session key to set
     * @param string $value The value of the session key
     *
     * @return boolean
     **/

There must be no blank lines after the function comment

    public function set($name, $value)
    {
        $_SESSION[$name] = $value;

        return true;
    }
}