csphere\core\init\Config

Complexity

Total Complexity

7

Size/Duplication

Total Lines	77
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
B	_configFile()	0	24	4
A	get()	0	4	1
A	error()	0	4	1

<?php

/**
 * Holds the configuration details
 *
 * PHP Version 5
 *
 * @category  Core
 * @package   Init
 * @author    Hans-Joachim Piepereit <contact@csphere.eu>
 * @copyright 2013 cSphere Team
 * @license   http://opensource.org/licenses/bsd-license Simplified BSD License
 * @link      http://www.csphere.eu
 **/

namespace csphere\core\init;

/**
 * Holds the configuration details
 *
 * @category  Core
 * @package   Init
 * @author    Hans-Joachim Piepereit <contact@csphere.eu>
 * @copyright 2013 cSphere Team
 * @license   http://opensource.org/licenses/bsd-license Simplified BSD License
 * @link      http://www.csphere.eu
 **/

class Config
{
    /**
     * Array with config settings
     **/
    private $_config = [];

    /**
     * Error details as an array
     **/
    private $_error = [];

    /**
     * Prepare configuration
     *
     * @return \csphere\core\init\Config
     **/

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

There must be no blank lines after the function comment

    public function __construct()
    {
        // Try to load config file
        $this->_configFile();
    }

    /**
     * Loads the configuration file
     *
     * @return void
     **/

There must be no blank lines after the function comment

    private function _configFile()
    {
        $config = [];

        // Try to load the config file
        $file = \csphere\core\init\path() . 'csphere/config/config.php';

        if (file_exists($file)) {

            include $file;

        } else {

            $this->_error = ['error' => 'config_missing', 'file' => $file];
        }

        // Check for config array to be correct
        if (!isset($config) || !is_array($config)) {

            $this->_error = ['error' => 'config_corrupt', 'file' => $file];
        }

        $this->_config = $config;

It seems like $config can be null. However, the property $_config is declared as array. Maybe change the type of the property to array|null or add a type check?

    }

    /**
     * Pass configuration details
     *
     * @return array
     **/

There must be no blank lines after the function comment

    public function get()
    {
        return $this->_config;
    }

    /**
     * Pass error details
     *
     * @return array
     **/

There must be no blank lines after the function comment

    public function error()
    {
        return $this->_error;
    }
}