csphere\core\date\Unixtime

Complexity

Total Complexity

11

Size/Duplication

Total Lines	126
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	userTimeZone()	0	23	3
A	userOffset()	0	11	1
A	userDateTime()	0	17	2
B	string()	0	37	5

<?php

/**
 * Contains some tools to work with unixtimes
 *
 * PHP Version 5
 *
 * @category  Core
 * @package   Date
 * @author    Hans-Joachim Piepereit <contact@csphere.eu>
 * @copyright 2013 cSphere Team
 * @license   http://opensource.org/licenses/bsd-license Simplified BSD License
 * @link      http://www.csphere.eu
 **/

namespace csphere\core\date;

/**
 * Class for unixtime operations
 *
 * @category  Core
 * @package   Date
 * @author    Hans-Joachim Piepereit <contact@csphere.eu>
 * @copyright 2013 cSphere Team
 * @license   http://opensource.org/licenses/bsd-license Simplified BSD License
 * @link      http://www.csphere.eu
 **/

class Unixtime
{
    /**
     * Creates a DateTimeZone object with the users timezone setting
     *
     * @return \DateTimeZone
     **/

There must be no blank lines after the function comment

    public static function userTimeZone()
    {
        static $timezone = null;

        if ($timezone === null) {

            // @TODO: Get time zone of user
            $user_zone = 'Europe/Berlin';

            // Test if the user has a valid timezone and use German otherwise
            $timezones = \DateTimeZone::listIdentifiers();

            if (in_array($user_zone, $timezones)) {

                $timezone = new \DateTimeZone($user_zone);
            } else {

                $timezone = new \DateTimeZone('UTC');
            }
        }

        return $timezone;
    }

    /**
     * Looks for the timezone difference in seconds
     *
     * @param int $unix Unixtime
     *
     * @return int
     **/

There must be no blank lines after the function comment

    public static function userOffset($unix)
    {
        $core_zone = new \DateTimeZone('UTC');
        $user_zone = self::userTimeZone();

        // Create date object to work with
        $date = \DateTime::createFromFormat('U', $unix, $core_zone);

        return $user_zone->getOffset($date);

    }

    /**
     * Translates a UTC+0 time to the user time
     *
     * @param int $unix Unixtime
     *
     * @return \DateTime
     **/

There must be no blank lines after the function comment

    public static function userDateTime($unix)
    {
        if ($unix < 0) {

            $unix = time();
        }

        $core_zone = new \DateTimeZone('UTC');
        $user_zone = self::userTimeZone();

        // Create date object to work with
        $date = \DateTime::createFromFormat('U', $unix, $core_zone);

The expression \DateTime::createFromFormat('U', $unix, $core_zone); of type DateTime|false adds false to the return on line 104 which is incompatible with the return type documented by csphere\core\date\Unixtime::userDateTime of type DateTime. It seems like you forgot to handle an error condition.

        $date->setTimezone($user_zone);

        return $date;
    }

    /**
     * Converts a Unixtime to String
     *
     * @param int  $unix        Timestamp
     * @param bool $dateEnabled Return Date Flag
     * @param bool $timeEnabled Return Time Flag
     *
     * @return string
     **/

There must be no blank lines after the function comment

    public static function string($unix, $dateEnabled=true, $timeEnabled=true)
    {

        $date = Unixtime::userDateTime($unix);

        $result="";

        if ($dateEnabled) {
            $date_format=\csphere\core\translation\fetch::key(
                "default",
                "datetime_format_date"
            );
            $result .= $date->format($date_format);
        }

        if ($dateEnabled && $timeEnabled) {
            $concat=\csphere\core\translation\fetch::key(
                "default",
                "datetime_format_concat"
            );
            $result.=" ".$concat." ";
        }

        if ($timeEnabled) {
            $time_format=\csphere\core\translation\fetch::key(
                "default",
                "datetime_format_time"
            );
            $time_appendix=\csphere\core\translation\fetch::key(
                "default",
                "datetime_format_appendix"
            );
            $result .=$date->format($time_format)." ".$time_appendix;
        }

        return $result;
    }
}