csphere\core\authentication\Users

Complexity

Total Complexity

10

Size/Duplication

Total Lines	136
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
B	status()	0	24	3
B	login()	0	22	4
B	_newLogin()	0	25	1
A	logout()	0	7	1

<?php

/**
 * Login support for users plugin
 *
 * PHP Version 5
 *
 * @category  Authentication
 * @package   Users
 * @author    Hans-Joachim Piepereit <contact@csphere.eu>
 * @copyright 2013 cSphere Team
 * @license   http://opensource.org/licenses/bsd-license Simplified BSD License
 * @link      http://www.csphere.eu
 **/

namespace csphere\core\authentication;

/**
 * Login support for users plugin
 *
 * @category  Authentication
 * @package   Users
 * @author    Hans-Joachim Piepereit <contact@csphere.eu>
 * @copyright 2013 cSphere Team
 * @license   http://opensource.org/licenses/bsd-license Simplified BSD License
 * @link      http://www.csphere.eu
 **/

class Users
{
    /**
     * Session object
     **/
     private $_session = null;

Line indented incorrectly; expected 4 spaces, found 5

    /**
     * Datamapper object for users table
     **/
     private $_mapper = null;

Line indented incorrectly; expected 4 spaces, found 5

    /**
     * Prepare values that are needed for later usage
     *
     * @return \csphere\core\authentication\Users
     **/

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

There must be no blank lines after the function comment

    public function __construct()
    {
        // Create session and user table datamapper object
        $this->_mapper  = new \csphere\core\datamapper\Model('users');
        $this->_session = new \csphere\core\session\Session();
    }

    /**
     * Whether someone is logged in at the moment
     *
     * @return boolean
     **/

There must be no blank lines after the function comment

    public function status()
    {
        // Check if user is still logged in
        $result  = false;
        $user_id = $this->_session->get('user_id');

        if (!empty($user_id)) {

            // Get user active info and check for existence
            $user = $this->_mapper->read($user_id, 'user_id');

            if (empty($user['user_active'])) {

                // Kick user auth
                $this->logout();

            } else {

                $result = true;
            }
        }

        return $result;
    }

    /**
     * Attempt to authenticate a user
     *
     * @param string $name     User name
     * @param string $password User password
     *
     * @return boolean
     **/

There must be no blank lines after the function comment

    public function login($name, $password)
    {
        // Get user from database
        $user   = $this->_mapper->read($name, 'user_name');
        $verify = false;

        // Verify password if both vars are not empty
        if (isset($user['user_password']) && !empty($password)) {

            $verify = \csphere\core\authentication\Password::compare(
                $password, $user['user_password']
            );
        }

        // Only grant access if password check is true
        if ($verify === true) {

            $this->_newLogin($user);
        }

        return $verify;
    }

    /**
     * Update content on fresh logins
     *
     * @param array $user Array with user data
     *
     * @return void
     **/

There must be no blank lines after the function comment

    private function _newLogin(array $user)
    {
        // Set session data
        $this->_session->set('user_id', $user['user_id']);
        $this->_session->set('user_name', $user['user_name']);
        $this->_session->set('user_lang', $user['user_lang']);

        // Notify users_logins about new visit
        $web  = \csphere\core\http\Input::get('server', 'HTTP_USER_AGENT');
        $time = time();

        $dm_logins = new \csphere\core\datamapper\Model('users', 'logins');
        $login     = $dm_logins->create();

        $login['user_id']       = $user['user_id'];
        $login['login_since']   = $time;
        $login['login_browser'] = $web;

        $dm_logins->insert($login);

        // Update date of last login
        $update = ['user_id' => $user['user_id'], 'user_laston' => $time];

        $this->_mapper->update($update);
    }

    /**
     * Clear session data
     *
     * @return boolean
     **/

There must be no blank lines after the function comment

    public function logout()
    {
        // Destroy current session
        $this->_session->destroy();

        return true;
    }
}