CSlant\Blog\Api\Http\Middlewares\TrackPostView::handle()

Complexity

Conditions	5
Paths	7

Size

Total Lines	40
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

<?php
    public function handle($request, Closure $next)
    {
        $postId = $request->route('id');
        $ipAddress = $request->ip();

        $post = Post::find($postId);
        if (!$post) {

$post is of type Illuminate\Database\Eloquent\Builder, thus it always evaluated to true.

            return $next($request);
        }

        $postView = PostView::where('post_id', $postId)
            ->where('ip_address', $ipAddress)
            ->first();

        $shouldIncrementView = false;

        if (!$postView) {
            // Access this post for the first time from this IP
            PostView::create([
                'post_id' => $postId,
                'ip_address' => $ipAddress,
                'time_check' => Carbon::now()->addHours(),
            ]);
            $shouldIncrementView = true;
        } else {
            // Check if field time_check is passed
            if (Carbon::now()->isAfter($postView->time_check)) {

The property time_check does not seem to exist on CSlant\Blog\Api\Models\PostView. Are you sure there is no database migration missing?

                // Update the field time_check
                $postView->update([
                    'time_check' => Carbon::now()->addHours(),
                ]);
                $shouldIncrementView = true;
            }
        }

        if ($shouldIncrementView) {
            $post->increment('views');
        }

        return $next($request);
    }