Completed
Push — master ( bbd140...a7f3dd )
by Chris
03:02
created
php/hamle/Parse.php 2 patches
Unused Use Statements   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -24,8 +24,8 @@
 block discarded – undo
24 24
 
25 25
  */
26 26
 namespace Seufert\Hamle;
27
-use Seufert\Hamle\Exception\ParseError;
28
-use Seufert\Hamle\Parse\Filter;
27
+use Seufert\Hamle\Exception\ParseError;
28
+use Seufert\Hamle\Parse\Filter;
29 29
 use Seufert\Hamle\Text;
30 30
 
31 31
 /**
Please login to merge, or discard this patch.
Braces   +61 added lines, -41 removed lines patch added patch discarded remove patch
@@ -108,22 +108,25 @@  discard block
 block discarded – undo
108 108
     $revSnip = array();
109 109
     /** @var Tag $roots */
110 110
     $roots = array();
111
-    foreach ($this->root as $snip)
112
-      if ($snip instanceOf Tag\Snippet) {
111
+    foreach ($this->root as $snip) {
112
+          if ($snip instanceOf Tag\Snippet) {
113 113
         if ($snip->getType() == "append") {
114
-          array_unshift($revSnip, $snip);
114
+          array_unshift($revSnip, $snip);
115
+    }
115 116
         } else {
116 117
           $fwdSnip[] = $snip;
117 118
         }
118 119
       } else {
119 120
         $roots[] = $snip;
120 121
       }
121
-    foreach ($fwdSnip as $snip)
122
-      foreach ($roots as $root)
123
-        $snip->apply($root);
124
-    foreach ($revSnip as $snip)
125
-      foreach ($roots as $root)
126
-        $snip->apply($root);
122
+    foreach ($fwdSnip as $snip) {
123
+          foreach ($roots as $root)
124
+        $snip->apply($root);
125
+    }
126
+    foreach ($revSnip as $snip) {
127
+          foreach ($roots as $root)
128
+        $snip->apply($root);
129
+    }
127 130
     $this->root = $roots;
128 131
   }
129 132
 
@@ -143,9 +146,11 @@  discard block
 block discarded – undo
143 146
     $heir = array();
144 147
     while ($this->lineNo < $this->lineCount) {
145 148
       $line = $this->lines[$this->lineNo];
146
-      if (trim($line)) if (preg_match(self::REGEX_PARSE_LINE, $line, $m)) {
149
+      if (trim($line)) {
150
+        if (preg_match(self::REGEX_PARSE_LINE, $line, $m)) {
147 151
         if (FALSE !== strpos($m[1], "\t"))
148
-          throw new ParseError("Tabs are not supported in templates at this time");
152
+          throw new ParseError("Tabs are not supported in templates at this time");
153
+      }
149 154
         $indent = strlen($m[1]);
150 155
         $tag = isset($m[2]) ? $tag = $m[2] : "";
151 156
         $classid = isset($m[3]) ? $m[3] : "";
@@ -157,13 +162,13 @@  discard block
 block discarded – undo
157 162
         unset($m[0]);
158 163
         switch (strlen($code) ? $code[0] : ($textcode ? $textcode : "")) {
159 164
           case "|": //Control Tag
160
-            if ($code == "|snippet")
161
-              $hTag = new Tag\Snippet($text);
162
-            elseif ($code == "|form")
163
-              $hTag = new Tag\Form($text);
164
-            elseif ($code == "|formhint")
165
-              $hTag = new Tag\FormHint($text);
166
-            elseif ($code == "|else") {
165
+            if ($code == "|snippet") {
166
+                          $hTag = new Tag\Snippet($text);
167
+            } elseif ($code == "|form") {
168
+                          $hTag = new Tag\Form($text);
169
+            } elseif ($code == "|formhint") {
170
+                          $hTag = new Tag\FormHint($text);
171
+            } elseif ($code == "|else") {
167 172
               $hTag = new Tag\Control(substr($code, 1), $heir[$i - 1]);
168 173
               $hTag->setVar($text);
169 174
             } else {
@@ -174,8 +179,9 @@  discard block
 block discarded – undo
174 179
           case ":": //Filter Tag
175 180
             $hTag = new Tag\Filter(substr($code, 1));
176 181
             $hTag->addContent($text, Text::TOKEN_CODE);
177
-            foreach ($this->consumeBlock($indent) as $l)
178
-              $hTag->addContent($l, Text::TOKEN_CODE);
182
+            foreach ($this->consumeBlock($indent) as $l) {
183
+                          $hTag->addContent($l, Text::TOKEN_CODE);
184
+            }
179 185
             break;
180 186
           case "_": //String Tag
181 187
           case "__": //Unescape String Tag
@@ -186,8 +192,9 @@  discard block
 block discarded – undo
186 192
           case "//": // Non Printed Comment
187 193
             $hTag = new Tag\Comment($textcode);
188 194
             $hTag->addContent($text);
189
-            foreach ($this->consumeBlock($indent) as $l)
190
-              $hTag->addContent($l, Text::TOKEN_CODE);
195
+            foreach ($this->consumeBlock($indent) as $l) {
196
+                          $hTag->addContent($l, Text::TOKEN_CODE);
197
+            }
191 198
             break;
192 199
           default:
193 200
             $attr = array();
@@ -198,33 +205,43 @@  discard block
 block discarded – undo
198 205
             }
199 206
             $class = array(); $id = ""; $ref = "";
200 207
             preg_match_all('/[#\.!][a-zA-Z0-9\-\_]+/m', $classid, $cid);
201
-            if (isset($cid[0])) foreach ($cid[0] as $s) {
202
-              if ($s[0] == "#") $id = substr($s, 1);
203
-              if ($s[0] == ".") $class[] = substr($s, 1);
204
-              if ($s[0] == "!") $ref = substr($s, 1);
208
+            if (isset($cid[0])) {
209
+              foreach ($cid[0] as $s) {
210
+              if ($s[0] == "#") $id = substr($s, 1);
211
+            }
212
+              if ($s[0] == ".") {
213
+                $class[] = substr($s, 1);
214
+              }
215
+              if ($s[0] == "!") {
216
+                $ref = substr($s, 1);
217
+              }
205 218
             }
206
-            if($ref)
207
-              $hTag = new Tag\DynHtml($tag, $class, $attr, $id, $ref);
208
-            else
209
-              $hTag = new Tag\Html($tag, $class, $attr, $id);
219
+            if($ref) {
220
+                          $hTag = new Tag\DynHtml($tag, $class, $attr, $id, $ref);
221
+            } else {
222
+                          $hTag = new Tag\Html($tag, $class, $attr, $id);
223
+            }
210 224
             $hTag->addContent($text);
211 225
             break;
212 226
         }
213 227
         $heir[$i] = $hTag;
214
-        if ($i > 0)
215
-          $heir[$i - 1]->addChild($hTag);
216
-        else
217
-          $this->root[] = $hTag;
218
-      } else
219
-        throw new ParseError("Unable to parse line {$this->lineNo}\n\"$line\"/" . preg_last_error());
228
+        if ($i > 0) {
229
+                  $heir[$i - 1]->addChild($hTag);
230
+        } else {
231
+                  $this->root[] = $hTag;
232
+        }
233
+      } else {
234
+              throw new ParseError("Unable to parse line {$this->lineNo}\n\"$line\"/" . preg_last_error());
235
+      }
220 236
       $this->lineNo++;
221 237
     }
222 238
   }
223 239
 
224 240
   function output() {
225 241
     $out = "<?php\nuse Seufert\\Hamle;\n?>";
226
-    foreach ($this->root as $tag)
227
-      $out .= $tag->render();
242
+    foreach ($this->root as $tag) {
243
+          $out .= $tag->render();
244
+    }
228 245
     return $out;
229 246
 
230 247
   }
@@ -236,15 +253,18 @@  discard block
 block discarded – undo
236 253
         (!trim($this->lines[$this->lineNo + 1]) ||
237 254
             preg_match('/^(\s){' . $indent . '}((\s)+[^\s].*)$/',
238 255
                 $this->lines[$this->lineNo + 1], $m))) {
239
-      if (trim($this->lines[$this->lineNo + 1]))
240
-        $out[] = $m[2];
256
+      if (trim($this->lines[$this->lineNo + 1])) {
257
+              $out[] = $m[2];
258
+      }
241 259
       $this->lineNo++;
242 260
     }
243 261
     return $out;
244 262
   }
245 263
 
246 264
   function indentLevel($indent) {
247
-    if (!isset($this->indents)) $this->indents = array();
265
+    if (!isset($this->indents)) {
266
+      $this->indents = array();
267
+    }
248 268
     if (!count($this->indents)) {
249 269
       $this->indents = array(0 => $indent);
250 270
       // Key = indent level, Value = Depth in spaces
Please login to merge, or discard this patch.
php/hamle/Run.php 2 patches
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@
 block discarded – undo
25 25
  */
26 26
 namespace Seufert\Hamle;
27 27
 
28
-use Seufert\Hamle\Exception\RunTime;
28
+use Seufert\Hamle\Exception\RunTime;
29 29
 use Seufert\Hamle\Model;
30 30
 
31 31
 /**
Please login to merge, or discard this patch.
Braces   +8 added lines, -5 removed lines patch added patch discarded remove patch
@@ -54,10 +54,11 @@  discard block
 block discarded – undo
54 54
    */
55 55
   static function popInstance() {
56 56
     array_pop(self::$hamleList);
57
-    if (self::$hamleList)
58
-      self::$hamle = self::$hamleList[count(self::$hamleList) - 1];
59
-    else
60
-      self::$hamle = NULL;
57
+    if (self::$hamleList) {
58
+          self::$hamle = self::$hamleList[count(self::$hamleList) - 1];
59
+    } else {
60
+          self::$hamle = NULL;
61
+    }
61 62
   }
62 63
 
63 64
   /**
@@ -116,7 +117,9 @@  discard block
 block discarded – undo
116 117
   static function modelId($id, $sortDir = 0, $sortField = "", $limit = 0, $offset = 0) {
117 118
     $o = self::$hamle->setup->getModelDefault($id,
118 119
         $sortDir, $sortField, $limit, $offset);
119
-    if (!$o instanceOf Model) throw new RunTime("Application must return instance of hamleModel");
120
+    if (!$o instanceOf Model) {
121
+      throw new RunTime("Application must return instance of hamleModel");
122
+    }
120 123
     return $o;
121 124
   }
122 125
 
Please login to merge, or discard this patch.
php/hamle/Scope.php 2 patches
Unused Use Statements   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,9 +1,9 @@
 block discarded – undo
1 1
 <?php
2 2
 namespace Seufert\Hamle;
3 3
 
4
-use Seufert\Hamle\Exception\OutOfScope;
5
-use Seufert\Hamle\Exception\Unsupported;
6
-use Seufert\Hamle\Exception\RunTime;
4
+use Seufert\Hamle\Exception\OutOfScope;
5
+use Seufert\Hamle\Exception\Unsupported;
6
+use Seufert\Hamle\Exception\RunTime;
7 7
 use Seufert\Hamle\Model;
8 8
 
9 9
 /**
Please login to merge, or discard this patch.
Braces   +23 added lines, -14 removed lines patch added patch discarded remove patch
@@ -18,12 +18,14 @@  discard block
 block discarded – undo
18 18
   static $namedScopes = array();
19 19
 
20 20
   static function add($model, $name = null) {
21
-    if (!$model instanceOf Model)
22
-      throw new Unsupported("Unsupported Model (".get_class($model)."), Needs to implement hamleModel Interface");
23
-    if ($name)
24
-      self::$namedScopes[$name] = $model;
25
-    else
26
-      self::$scopes[] = $model;
21
+    if (!$model instanceOf Model) {
22
+          throw new Unsupported("Unsupported Model (".get_class($model)."), Needs to implement hamleModel Interface");
23
+    }
24
+    if ($name) {
25
+          self::$namedScopes[$name] = $model;
26
+    } else {
27
+          self::$scopes[] = $model;
28
+    }
27 29
   }
28 30
 
29 31
   static function done() {
@@ -41,15 +43,21 @@  discard block
 block discarded – undo
41 43
    */
42 44
   static function get($id = 0) {
43 45
     if (0 == $id) {
44
-      if ($scope = end(self::$scopes))
45
-        return $scope;
46
+      if ($scope = end(self::$scopes)) {
47
+              return $scope;
48
+      }
46 49
       throw new OutOfScope("Unable to find Scope ($id)");
47 50
     }
48 51
     $key = $id - 1;
49
-    if ($id < 0) $key = count(self::$scopes) + $id - 1;
50
-    if ($id == 0) $key = count(self::$scopes) - 1;
51
-    if (!isset(self::$scopes[$key]))
52
-      throw new OutOfScope("Unable to find Scope ($id) or $key");
52
+    if ($id < 0) {
53
+      $key = count(self::$scopes) + $id - 1;
54
+    }
55
+    if ($id == 0) {
56
+      $key = count(self::$scopes) - 1;
57
+    }
58
+    if (!isset(self::$scopes[$key])) {
59
+          throw new OutOfScope("Unable to find Scope ($id) or $key");
60
+    }
53 61
     return self::$scopes[$key];
54 62
   }
55 63
 
@@ -64,8 +72,9 @@  discard block
 block discarded – undo
64 72
     if ($name && isset(self::$namedScopes[$name])) {
65 73
       self::$namedScopes[$name]->rewind();
66 74
       return self::$namedScopes[$name];
67
-    } else
68
-      throw new RunTime("Unable to find scope ($name)");
75
+    } else {
76
+          throw new RunTime("Unable to find scope ($name)");
77
+    }
69 78
   }
70 79
 
71 80
 }
Please login to merge, or discard this patch.
php/autoload.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -38,7 +38,9 @@
 block discarded – undo
38 38
     $s = DIRECTORY_SEPARATOR;
39 39
     $class = str_replace("\\",$s,substr($class,14));
40 40
     $path = __DIR__.$s."hamle".$s."$class.php";
41
-    if(is_file($path)) include_once($path);
41
+    if(is_file($path)) {
42
+      include_once($path);
43
+    }
42 44
   }
43 45
 },true,true);
44 46
 
Please login to merge, or discard this patch.
php/hamle/Field.php 1 patch
Braces   +26 added lines, -16 removed lines patch added patch discarded remove patch
@@ -66,7 +66,9 @@  discard block
 block discarded – undo
66 66
   }
67 67
 
68 68
   function __call($name, $valarray) {
69
-    if (count($valarray) < 1) return $this->__get($name);
69
+    if (count($valarray) < 1) {
70
+      return $this->__get($name);
71
+    }
70 72
     $val = count($valarray) == 1 ? current($valarray) : $valarray;
71 73
     switch ($name) {
72 74
       case "name":
@@ -111,12 +113,15 @@  discard block
 block discarded – undo
111 113
   }
112 114
 
113 115
   function getValue() {
114
-    if (!is_null($this->setValue)) return $this->setValue;
116
+    if (!is_null($this->setValue)) {
117
+      return $this->setValue;
118
+    }
115 119
     if (isset($_REQUEST[$this->form . "_" . $this->name])) {
116
-      if (get_magic_quotes_runtime())
117
-        return stripslashes($_REQUEST[$this->form . "_" . $this->name]);
118
-      else
119
-        return $_REQUEST[$this->form . "_" . $this->name];
120
+      if (get_magic_quotes_runtime()) {
121
+              return stripslashes($_REQUEST[$this->form . "_" . $this->name]);
122
+      } else {
123
+              return $_REQUEST[$this->form . "_" . $this->name];
124
+      }
120 125
     }
121 126
     return $this->opt['default'];
122 127
   }
@@ -133,12 +138,15 @@  discard block
 block discarded – undo
133 138
     if (!$this->valid) {
134 139
       $atts['class'][] = "hamleFormError";
135 140
     }
136
-    if ($this->opt["disabled"])
137
-      $atts['disabled'] = "disabled";
138
-    if ($this->opt['required'])
139
-      $atts['required'] = "required";
140
-    if ($this->opt['help'])
141
-      $atts['title'] = $this->opt['help'];
141
+    if ($this->opt["disabled"]) {
142
+          $atts['disabled'] = "disabled";
143
+    }
144
+    if ($this->opt['required']) {
145
+          $atts['required'] = "required";
146
+    }
147
+    if ($this->opt['help']) {
148
+          $atts['title'] = $this->opt['help'];
149
+    }
142 150
   }
143 151
 
144 152
   function getLabelAttStatic(&$atts, &$type, &$content) {
@@ -176,10 +184,12 @@  discard block
 block discarded – undo
176 184
   function doProcess($submit) {
177 185
     if ($submit) {
178 186
       $value = $this->getValue();
179
-      if ($this->opt['required'])
180
-        $this->valid = $this->valid && strlen($value);
181
-      if ($this->opt['regex'])
182
-        $this->valid = $this->valid && preg_match($this->opt['regex'], $value);
187
+      if ($this->opt['required']) {
188
+              $this->valid = $this->valid && strlen($value);
189
+      }
190
+      if ($this->opt['regex']) {
191
+              $this->valid = $this->valid && preg_match($this->opt['regex'], $value);
192
+      }
183 193
     }
184 194
   }
185 195
 
Please login to merge, or discard this patch.
php/hamle/Filter/Sass.php 1 patch
Braces   +9 added lines, -5 removed lines patch added patch discarded remove patch
@@ -34,14 +34,18 @@
 block discarded – undo
34 34
   static function filterText($s) {
35 35
     $as = explode("\n", $s);
36 36
     $indent = -1;
37
-    foreach ($as as $line)
38
-      if (preg_match('/^(\s+).*$/', $line, $m)) {
37
+    foreach ($as as $line) {
38
+          if (preg_match('/^(\s+).*$/', $line, $m)) {
39 39
         $lnInd = strlen($m[1]);
40
-        if ($indent < 0) $indent = $lnInd;
40
+    }
41
+        if ($indent < 0) {
42
+          $indent = $lnInd;
43
+        }
41 44
         $indent = min($indent, $lnInd);
42 45
       }
43
-    foreach ($as as $k => $v)
44
-      $as[$k] = substr($v, $indent);
46
+    foreach ($as as $k => $v) {
47
+          $as[$k] = substr($v, $indent);
48
+    }
45 49
     $s = implode("\n", $as);
46 50
 
47 51
     require_once ME_DIR . "/lib/phpsass/SassParser.php";
Please login to merge, or discard this patch.
php/hamle/Text.php 1 patch
Braces   +27 added lines, -16 removed lines patch added patch discarded remove patch
@@ -53,39 +53,48 @@  discard block
 block discarded – undo
53 53
     $pos = 0;
54 54
     $this->nodes = array();
55 55
     $rFlag = PREG_OFFSET_CAPTURE + PREG_SET_ORDER;
56
-    if (strlen(trim($s)) == 0) return;
56
+    if (strlen(trim($s)) == 0) {
57
+      return;
58
+    }
57 59
     if ($mode == self::TOKEN_CONTROL) {
58 60
       if (preg_match('/^"(.*)"$/', trim($s), $m)) {
59 61
         $this->nodes[] = new Text($m[1]);
60
-      } else
61
-        $this->nodes[] = new Text\Complex(trim($s));
62
+      } else {
63
+              $this->nodes[] = new Text\Complex(trim($s));
64
+      }
62 65
       return;
63 66
     }
64 67
     preg_match_all(self::REGEX_HTML, $s, $m, $rFlag);
65 68
     foreach ($m as $match) {
66 69
       if ($mode & self::FIND_BARDOLLAR && isset($match[2])) {
67
-        if ($match[2][1] != $pos)
68
-          $this->nodes[] = new Text\Plain(
70
+        if ($match[2][1] != $pos) {
71
+                  $this->nodes[] = new Text\Plain(
69 72
               substr($s, $pos, $match[2][1] - $pos), $mode);
73
+        }
70 74
         $this->nodes[] = new Text\Complex(substr($match[2][0], 1, -1));
71 75
         $pos = $match[2][1] + strlen($match[2][0]);
72 76
       } elseif ($mode & self::FIND_DOLLARVAR) {
73
-        if ($match[1][1] > 0 && $s[$match[1][1] - 1] == '\\') continue;
74
-        if ($match[1][1] != $pos)
75
-          $this->nodes[] = new Text\Plain(
77
+        if ($match[1][1] > 0 && $s[$match[1][1] - 1] == '\\') {
78
+          continue;
79
+        }
80
+        if ($match[1][1] != $pos) {
81
+                  $this->nodes[] = new Text\Plain(
76 82
               substr($s, $pos, $match[1][1] - $pos), $mode);
83
+        }
77 84
         $this->nodes[] = new Text\SimpleVar($match[1][0]);
78 85
         $pos = $match[1][1] + strlen($match[1][0]);
79 86
       }
80 87
     }
81
-    if ($pos != strlen($s))
82
-      $this->nodes[] = new Text\Plain(substr($s, $pos), $mode);
88
+    if ($pos != strlen($s)) {
89
+          $this->nodes[] = new Text\Plain(substr($s, $pos), $mode);
90
+    }
83 91
   }
84 92
 
85 93
   function toHTML($escape = false) {
86 94
     $out = array();
87
-    foreach ($this->nodes as $string)
88
-      $out[] = $string->toHTML($escape);
95
+    foreach ($this->nodes as $string) {
96
+          $out[] = $string->toHTML($escape);
97
+    }
89 98
     return implode("", $out);
90 99
   }
91 100
 
@@ -95,8 +104,9 @@  discard block
 block discarded – undo
95 104
 
96 105
   function toPHP() {
97 106
     $out = array();
98
-    foreach ($this->nodes as $string)
99
-      $out[] = $string->toPHP();
107
+    foreach ($this->nodes as $string) {
108
+          $out[] = $string->toPHP();
109
+    }
100 110
     return implode(".", $out);
101 111
   }
102 112
 
@@ -107,8 +117,9 @@  discard block
 block discarded – undo
107 117
   static function varToCode($var) {
108 118
     if (is_array($var)) {
109 119
       $code = array();
110
-      foreach ($var as $key => $value)
111
-        $code[] = self::varToCode($key) . "=>" . self::varToCode($value);
120
+      foreach ($var as $key => $value) {
121
+              $code[] = self::varToCode($key) . "=>" . self::varToCode($value);
122
+      }
112 123
       return 'array(' . implode(",", $code) . ')'; //remove unnecessary coma
113 124
     } elseif (is_bool($var)) {
114 125
       return ($var ? 'TRUE' : 'FALSE');
Please login to merge, or discard this patch.
php/hamle/Tag/DynHtml.php 1 patch
Braces   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -60,11 +60,14 @@
 block discarded – undo
60 60
     $out = "<" . $d['type'] . " ";
61 61
     foreach ($d['opt'] as $k => $v) {
62 62
       if (is_array($v)) {
63
-        foreach ($v as $k2 => $v2)
64
-          if ($v[$k2] instanceof Text) $v[$k2] = eval('return ' . $v[$k2]->toPHP() . ';');
63
+        foreach ($v as $k2 => $v2) {
64
+                  if ($v[$k2] instanceof Text) $v[$k2] = eval('return ' . $v[$k2]->toPHP() . ';');
65
+        }
65 66
         $v = implode(" ", $v);
66 67
       }
67
-      if ($v instanceOf H\Text) $v = eval('return ' . $v->toPHP() . ';');
68
+      if ($v instanceOf H\Text) {
69
+        $v = eval('return ' . $v->toPHP() . ';');
70
+      }
68 71
       $out .= $k . "=\"" . htmlspecialchars($v) . "\" ";
69 72
     }
70 73
     $out .= in_array($d['type'], self::$selfCloseTags) ? "/>" : ">";
Please login to merge, or discard this patch.
php/hamle/Tag/Text.php 1 patch
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -43,8 +43,9 @@
 block discarded – undo
43 43
       if ($this->escape) {
44 44
         $parse = new H\Text($s, $strtype);
45 45
         $this->content[] = $parse->toHTML();
46
-      } else
47
-        $this->content[] = $s;
46
+      } else {
47
+              $this->content[] = $s;
48
+      }
48 49
     }
49 50
   }
50 51
 
Please login to merge, or discard this patch.