Passed
Push — master ( dabfe1...dbcc75 )
by Chris
02:03
created
php/hamle/Text/FormField.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -35,10 +35,10 @@
 block discarded – undo
35 35
   }
36 36
 
37 37
   function toPHP() {
38
-    return '$form->getField(' . Text::varToCode($this->var) . ')->getValue()';
38
+    return '$form->getField('.Text::varToCode($this->var).')->getValue()';
39 39
   }
40 40
 
41 41
   function toHTML($escape = false) {
42
-    return '<?=' . $this->toPHP() . '?>';
42
+    return '<?='.$this->toPHP().'?>';
43 43
   }
44 44
 }
45 45
\ No newline at end of file
Please login to merge, or discard this patch.
php/hamle/Scope.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@
 block discarded – undo
67 67
       self::$namedScopes[$name]->rewind();
68 68
       return self::$namedScopes[$name];
69 69
     } else
70
-      if(self::$returnZeroOnNoScope)
70
+      if (self::$returnZeroOnNoScope)
71 71
         return new Model\Zero();
72 72
       throw new RunTime("Unable to find scope ($name)");
73 73
   }
Please login to merge, or discard this patch.
Braces   +23 added lines, -14 removed lines patch added patch discarded remove patch
@@ -18,12 +18,14 @@  discard block
 block discarded – undo
18 18
   static $namedScopes = array();
19 19
 
20 20
   static function add($model, $name = null) {
21
-    if (!$model instanceOf Model)
22
-      throw new Unsupported("Unsupported Model (".get_class($model)."), Needs to implement hamleModel Interface");
23
-    if ($name)
24
-      self::$namedScopes[$name] = $model;
25
-    else
26
-      self::$scopes[] = $model;
21
+    if (!$model instanceOf Model) {
22
+          throw new Unsupported("Unsupported Model (".get_class($model)."), Needs to implement hamleModel Interface");
23
+    }
24
+    if ($name) {
25
+          self::$namedScopes[$name] = $model;
26
+    } else {
27
+          self::$scopes[] = $model;
28
+    }
27 29
   }
28 30
 
29 31
   static function done() {
@@ -41,15 +43,21 @@  discard block
 block discarded – undo
41 43
    */
42 44
   static function get($id = 0) {
43 45
     if (0 == $id) {
44
-      if ($scope = end(self::$scopes))
45
-        return $scope;
46
+      if ($scope = end(self::$scopes)) {
47
+              return $scope;
48
+      }
46 49
       throw new OutOfScope("Unable to find Scope ($id)");
47 50
     }
48 51
     $key = $id - 1;
49
-    if ($id < 0) $key = count(self::$scopes) + $id - 1;
50
-    if ($id == 0) $key = count(self::$scopes) - 1;
51
-    if (!isset(self::$scopes[$key]))
52
-      throw new OutOfScope("Unable to find Scope ($id) or $key");
52
+    if ($id < 0) {
53
+      $key = count(self::$scopes) + $id - 1;
54
+    }
55
+    if ($id == 0) {
56
+      $key = count(self::$scopes) - 1;
57
+    }
58
+    if (!isset(self::$scopes[$key])) {
59
+          throw new OutOfScope("Unable to find Scope ($id) or $key");
60
+    }
53 61
     return self::$scopes[$key];
54 62
   }
55 63
 
@@ -67,8 +75,9 @@  discard block
 block discarded – undo
67 75
       self::$namedScopes[$name]->rewind();
68 76
       return self::$namedScopes[$name];
69 77
     } else
70
-      if(self::$returnZeroOnNoScope)
71
-        return new Model\Zero();
78
+      if(self::$returnZeroOnNoScope) {
79
+              return new Model\Zero();
80
+      }
72 81
       throw new RunTime("Unable to find scope ($name)");
73 82
   }
74 83
 
Please login to merge, or discard this patch.
php/hamle/Field/Button.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -42,6 +42,6 @@
 block discarded – undo
42 42
   }
43 43
 
44 44
   function isClicked() {
45
-    return isset($_REQUEST[$this->form . "_" . $this->name]);
45
+    return isset($_REQUEST[$this->form."_".$this->name]);
46 46
   }
47 47
 }
48 48
\ No newline at end of file
Please login to merge, or discard this patch.
php/hamle/Parse.php 2 patches
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -157,7 +157,7 @@  discard block
 block discarded – undo
157 157
         $i = self::indentLevel($indent);
158 158
         unset($m[0]);
159 159
         switch (strlen($code) ? $code[0] : ($textcode ? $textcode : "")) {
160
-          case "|": //Control Tag
160
+          case "|" : //Control Tag
161 161
             if ($code == "|snippet")
162 162
               $hTag = new Tag\Snippet($text);
163 163
             elseif ($code == "|form")
@@ -192,10 +192,10 @@  discard block
 block discarded – undo
192 192
             break;
193 193
           default:
194 194
             $attr = array();
195
-            if(isset($params[0]) && $params[0] == "[") {
195
+            if (isset($params[0]) && $params[0] == "[") {
196 196
               $param = substr($params, 1, strlen($params) - 2);
197
-              $param = str_replace('+','%2B', $param);
198
-              $param = str_replace('\\&','%26', $param);
197
+              $param = str_replace('+', '%2B', $param);
198
+              $param = str_replace('\\&', '%26', $param);
199 199
 //              parse_str($param, $attr);
200 200
               $attr = $this->parseQueryString($param);
201 201
             }
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
               if ($s[0] == ".") $class[] = substr($s, 1);
207 207
               if ($s[0] == "!") $ref = substr($s, 1);
208 208
             }
209
-            if($ref)
209
+            if ($ref)
210 210
               $hTag = new Tag\DynHtml($tag, $class, $attr, $id, $ref);
211 211
             else
212 212
               $hTag = new Tag\Html($tag, $class, $attr, $id);
@@ -219,16 +219,16 @@  discard block
 block discarded – undo
219 219
         else
220 220
           $this->root[] = $hTag;
221 221
       } else
222
-        throw new ParseError("Unable to parse line {$this->lineNo}\n\"$line\"/" . preg_last_error());
222
+        throw new ParseError("Unable to parse line {$this->lineNo}\n\"$line\"/".preg_last_error());
223 223
       $this->lineNo++;
224 224
     }
225 225
   }
226 226
 
227 227
   function parseQueryString($qs) {
228 228
     $out = [];
229
-    foreach(explode('&',$qs) as $s) {
230
-      $kv = explode('=',$s,2);
231
-      $out[urldecode($kv[0])] = isset($kv[1])?urldecode($kv[1]):null;
229
+    foreach (explode('&', $qs) as $s) {
230
+      $kv = explode('=', $s, 2);
231
+      $out[urldecode($kv[0])] = isset($kv[1]) ?urldecode($kv[1]) : null;
232 232
     }
233 233
     return $out;
234 234
   }
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
246 246
     $m = array();
247 247
     while ($this->lineNo + 1 < $this->lineCount &&
248 248
         (!trim($this->lines[$this->lineNo + 1]) ||
249
-            preg_match('/^(\s){' . $indent . '}((\s)+[^\s].*)$/',
249
+            preg_match('/^(\s){'.$indent.'}((\s)+[^\s].*)$/',
250 250
                 $this->lines[$this->lineNo + 1], $m))) {
251 251
       if (trim($this->lines[$this->lineNo + 1]))
252 252
         $out[] = $m[2];
Please login to merge, or discard this patch.
Braces   +61 added lines, -41 removed lines patch added patch discarded remove patch
@@ -109,22 +109,25 @@  discard block
 block discarded – undo
109 109
     $revSnip = array();
110 110
     /** @var Tag[] $roots */
111 111
     $roots = array();
112
-    foreach ($this->root as $snip)
113
-      if ($snip instanceOf Tag\Snippet) {
112
+    foreach ($this->root as $snip) {
113
+          if ($snip instanceOf Tag\Snippet) {
114 114
         if ($snip->getType() == "append") {
115
-          array_unshift($revSnip, $snip);
115
+          array_unshift($revSnip, $snip);
116
+    }
116 117
         } else {
117 118
           $fwdSnip[] = $snip;
118 119
         }
119 120
       } else {
120 121
         $roots[] = $snip;
121 122
       }
122
-    foreach ($fwdSnip as $snip)
123
-      foreach ($roots as $root)
124
-        $snip->apply($root);
125
-    foreach ($revSnip as $snip)
126
-      foreach ($roots as $root)
127
-        $snip->apply($root);
123
+    foreach ($fwdSnip as $snip) {
124
+          foreach ($roots as $root)
125
+        $snip->apply($root);
126
+    }
127
+    foreach ($revSnip as $snip) {
128
+          foreach ($roots as $root)
129
+        $snip->apply($root);
130
+    }
128 131
     $this->root = $roots;
129 132
   }
130 133
 
@@ -144,9 +147,11 @@  discard block
 block discarded – undo
144 147
     $heir = array();
145 148
     while ($this->lineNo < $this->lineCount) {
146 149
       $line = $this->lines[$this->lineNo];
147
-      if (trim($line)) if (preg_match(self::REGEX_PARSE_LINE, $line, $m)) {
150
+      if (trim($line)) {
151
+        if (preg_match(self::REGEX_PARSE_LINE, $line, $m)) {
148 152
         if (FALSE !== strpos($m[1], "\t"))
149
-          throw new ParseError("Tabs are not supported in templates at this time");
153
+          throw new ParseError("Tabs are not supported in templates at this time");
154
+      }
150 155
         $indent = strlen($m[1]);
151 156
         $tag = isset($m[2]) ? $tag = $m[2] : "";
152 157
         $classid = isset($m[3]) ? $m[3] : "";
@@ -158,13 +163,13 @@  discard block
 block discarded – undo
158 163
         unset($m[0]);
159 164
         switch (strlen($code) ? $code[0] : ($textcode ? $textcode : "")) {
160 165
           case "|": //Control Tag
161
-            if ($code == "|snippet")
162
-              $hTag = new Tag\Snippet($text);
163
-            elseif ($code == "|form")
164
-              $hTag = new Tag\Form($text);
165
-            elseif ($code == "|formhint")
166
-              $hTag = new Tag\FormHint($text);
167
-            elseif ($code == "|else") {
166
+            if ($code == "|snippet") {
167
+                          $hTag = new Tag\Snippet($text);
168
+            } elseif ($code == "|form") {
169
+                          $hTag = new Tag\Form($text);
170
+            } elseif ($code == "|formhint") {
171
+                          $hTag = new Tag\FormHint($text);
172
+            } elseif ($code == "|else") {
168 173
               $hTag = new Tag\Control(substr($code, 1), $heir[$i - 1]);
169 174
               $hTag->setVar($text);
170 175
             } else {
@@ -175,8 +180,9 @@  discard block
 block discarded – undo
175 180
           case ":": //Filter Tag
176 181
             $hTag = new Tag\Filter(substr($code, 1));
177 182
             $hTag->addContent($text, Text::TOKEN_CODE);
178
-            foreach ($this->consumeBlock($indent) as $l)
179
-              $hTag->addContent($l, Text::TOKEN_CODE);
183
+            foreach ($this->consumeBlock($indent) as $l) {
184
+                          $hTag->addContent($l, Text::TOKEN_CODE);
185
+            }
180 186
             break;
181 187
           case "_": //String Tag
182 188
           case "__": //Unescape String Tag
@@ -187,8 +193,9 @@  discard block
 block discarded – undo
187 193
           case "//": // Non Printed Comment
188 194
             $hTag = new Tag\Comment($textcode);
189 195
             $hTag->addContent($text);
190
-            foreach ($this->consumeBlock($indent) as $l)
191
-              $hTag->addContent($l, Text::TOKEN_CODE);
196
+            foreach ($this->consumeBlock($indent) as $l) {
197
+                          $hTag->addContent($l, Text::TOKEN_CODE);
198
+            }
192 199
             break;
193 200
           default:
194 201
             $attr = array();
@@ -201,25 +208,34 @@  discard block
 block discarded – undo
201 208
             }
202 209
             $class = array(); $id = ""; $ref = "";
203 210
             preg_match_all('/[#\.!][a-zA-Z0-9\-\_]+/m', $classid, $cid);
204
-            if (isset($cid[0])) foreach ($cid[0] as $s) {
205
-              if ($s[0] == "#") $id = substr($s, 1);
206
-              if ($s[0] == ".") $class[] = substr($s, 1);
207
-              if ($s[0] == "!") $ref = substr($s, 1);
211
+            if (isset($cid[0])) {
212
+              foreach ($cid[0] as $s) {
213
+              if ($s[0] == "#") $id = substr($s, 1);
214
+            }
215
+              if ($s[0] == ".") {
216
+                $class[] = substr($s, 1);
217
+              }
218
+              if ($s[0] == "!") {
219
+                $ref = substr($s, 1);
220
+              }
208 221
             }
209
-            if($ref)
210
-              $hTag = new Tag\DynHtml($tag, $class, $attr, $id, $ref);
211
-            else
212
-              $hTag = new Tag\Html($tag, $class, $attr, $id);
222
+            if($ref) {
223
+                          $hTag = new Tag\DynHtml($tag, $class, $attr, $id, $ref);
224
+            } else {
225
+                          $hTag = new Tag\Html($tag, $class, $attr, $id);
226
+            }
213 227
             $hTag->addContent($text);
214 228
             break;
215 229
         }
216 230
         $heir[$i] = $hTag;
217
-        if ($i > 0)
218
-          $heir[$i - 1]->addChild($hTag);
219
-        else
220
-          $this->root[] = $hTag;
221
-      } else
222
-        throw new ParseError("Unable to parse line {$this->lineNo}\n\"$line\"/" . preg_last_error());
231
+        if ($i > 0) {
232
+                  $heir[$i - 1]->addChild($hTag);
233
+        } else {
234
+                  $this->root[] = $hTag;
235
+        }
236
+      } else {
237
+              throw new ParseError("Unable to parse line {$this->lineNo}\n\"$line\"/" . preg_last_error());
238
+      }
223 239
       $this->lineNo++;
224 240
     }
225 241
   }
@@ -235,8 +251,9 @@  discard block
 block discarded – undo
235 251
 
236 252
   function output($minify = false) {
237 253
     $out = "<?php\nuse Seufert\\Hamle;\n?>";
238
-    foreach ($this->root as $tag)
239
-      $out .= $tag->render(0, $minify);
254
+    foreach ($this->root as $tag) {
255
+          $out .= $tag->render(0, $minify);
256
+    }
240 257
     return $out;
241 258
 
242 259
   }
@@ -248,15 +265,18 @@  discard block
 block discarded – undo
248 265
         (!trim($this->lines[$this->lineNo + 1]) ||
249 266
             preg_match('/^(\s){' . $indent . '}((\s)+[^\s].*)$/',
250 267
                 $this->lines[$this->lineNo + 1], $m))) {
251
-      if (trim($this->lines[$this->lineNo + 1]))
252
-        $out[] = $m[2];
268
+      if (trim($this->lines[$this->lineNo + 1])) {
269
+              $out[] = $m[2];
270
+      }
253 271
       $this->lineNo++;
254 272
     }
255 273
     return $out;
256 274
   }
257 275
 
258 276
   function indentLevel($indent) {
259
-    if (!isset($this->indents)) $this->indents = array();
277
+    if (!isset($this->indents)) {
278
+      $this->indents = array();
279
+    }
260 280
     if (!count($this->indents)) {
261 281
       $this->indents = array(0 => $indent);
262 282
       // Key = indent level, Value = Depth in spaces
Please login to merge, or discard this patch.
php/hamle/Text/Scope.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -36,17 +36,17 @@  discard block
 block discarded – undo
36 36
   function __construct($s) {
37 37
     $m = [];
38 38
     //var_dump($s);
39
-    if(!preg_match('/\$\[(-?[0-9]+|[a-zA-Z][a-zA-Z0-9]+)\]/', $s, $m)) {
39
+    if (!preg_match('/\$\[(-?[0-9]+|[a-zA-Z][a-zA-Z0-9]+)\]/', $s, $m)) {
40 40
       throw new ParseError("Unable to match scope ($s)");
41 41
     }
42 42
     $this->scope = $m[1];
43 43
   }
44 44
 
45 45
   function toPHP() {
46
-    if(is_numeric($this->scope)) {
47
-      return "Hamle\\Scope::get(" . Text::varToCode($this->scope) . ")";
46
+    if (is_numeric($this->scope)) {
47
+      return "Hamle\\Scope::get(".Text::varToCode($this->scope).")";
48 48
     } else {
49
-      return "Hamle\\Scope::getName(" . Text::varToCode($this->scope) . ")";
49
+      return "Hamle\\Scope::getName(".Text::varToCode($this->scope).")";
50 50
     }
51 51
   }
52 52
 
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
 
61 61
 
62 62
   function getOrCreateModel(Model $parent = null) {
63
-    if(is_numeric($this->scope)) {
63
+    if (is_numeric($this->scope)) {
64 64
       return \Seufert\Hamle\Scope::get($this->scope);
65 65
     }
66 66
     return \Seufert\Hamle\Scope::getName($this->scope);
Please login to merge, or discard this patch.
php/hamle/Text/SimpleVar.php 2 patches
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -35,26 +35,26 @@  discard block
 block discarded – undo
35 35
   protected $filter;
36 36
 
37 37
   function __construct($s) {
38
-    if(FALSE !== $pos = strpos($s,'|')) {
39
-      $this->var = substr($s,1,$pos-1);
40
-      $this->filter = new Filter(substr($s, $pos+1), $this);
38
+    if (FALSE !== $pos = strpos($s, '|')) {
39
+      $this->var = substr($s, 1, $pos - 1);
40
+      $this->filter = new Filter(substr($s, $pos + 1), $this);
41 41
     } else {
42 42
       $this->var = substr($s, 1);
43 43
     }
44 44
   }
45 45
 
46 46
   function toHTML($escape = false) {
47
-    if($escape)
48
-      return "<?=htmlspecialchars(" .$this->toPHP() . ")?>";
49
-    return "<?=" . $this->toPHP() . "?>";
47
+    if ($escape)
48
+      return "<?=htmlspecialchars(".$this->toPHP().")?>";
49
+    return "<?=".$this->toPHP()."?>";
50 50
   }
51 51
 
52 52
   function toPHP() {
53
-    return $this->filter?$this->filter->toPHP():$this->toPHPVar();
53
+    return $this->filter ? $this->filter->toPHP() : $this->toPHPVar();
54 54
   }
55 55
 
56 56
   function toPHPVar() {
57
-    return "Hamle\\Scope::get()->hamleGet(" . Text::varToCode($this->var) . ")";
57
+    return "Hamle\\Scope::get()->hamleGet(".Text::varToCode($this->var).")";
58 58
   }
59 59
 
60 60
   function getOrCreateModel(Model $parent = null) {
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
    */
68 68
   function setValue($value) {
69 69
     $model = $this->getOrCreateModel();
70
-    if(!$model instanceof WriteModel)
70
+    if (!$model instanceof WriteModel)
71 71
       throw new \RuntimeException('Can only write to model that implements WriteModel');
72 72
     $model->hamleSet($this->var, $value);
73 73
     return $model;
Please login to merge, or discard this patch.
Braces   +6 added lines, -4 removed lines patch added patch discarded remove patch
@@ -44,8 +44,9 @@  discard block
 block discarded – undo
44 44
   }
45 45
 
46 46
   function toHTML($escape = false) {
47
-    if($escape)
48
-      return "<?=htmlspecialchars(" .$this->toPHP() . ")?>";
47
+    if($escape) {
48
+          return "<?=htmlspecialchars(" .$this->toPHP() . ")?>";
49
+    }
49 50
     return "<?=" . $this->toPHP() . "?>";
50 51
   }
51 52
 
@@ -67,8 +68,9 @@  discard block
 block discarded – undo
67 68
    */
68 69
   function setValue($value) {
69 70
     $model = $this->getOrCreateModel();
70
-    if(!$model instanceof WriteModel)
71
-      throw new \RuntimeException('Can only write to model that implements WriteModel');
71
+    if(!$model instanceof WriteModel) {
72
+          throw new \RuntimeException('Can only write to model that implements WriteModel');
73
+    }
72 74
     $model->hamleSet($this->var, $value);
73 75
     return $model;
74 76
   }
Please login to merge, or discard this patch.
php/hamle/Run.php 1 patch
Braces   +8 added lines, -5 removed lines patch added patch discarded remove patch
@@ -54,10 +54,11 @@  discard block
 block discarded – undo
54 54
    */
55 55
   static function popInstance() {
56 56
     array_pop(self::$hamleList);
57
-    if (self::$hamleList)
58
-      self::$hamle = self::$hamleList[count(self::$hamleList) - 1];
59
-    else
60
-      self::$hamle = NULL;
57
+    if (self::$hamleList) {
58
+          self::$hamle = self::$hamleList[count(self::$hamleList) - 1];
59
+    } else {
60
+          self::$hamle = NULL;
61
+    }
61 62
   }
62 63
 
63 64
   /**
@@ -113,7 +114,9 @@  discard block
 block discarded – undo
113 114
    */
114 115
   static function modelId($id, $sort = [], $limit = 0, $offset = 0) {
115 116
     $o = self::$hamle->setup->getModelDefault($id, $sort, $limit, $offset);
116
-    if (!$o instanceOf Model) throw new RunTime("Application must return instance of hamleModel");
117
+    if (!$o instanceOf Model) {
118
+      throw new RunTime("Application must return instance of hamleModel");
119
+    }
117 120
     return $o;
118 121
   }
119 122
 
Please login to merge, or discard this patch.
php/hamle/Text/Complex.php 2 patches
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -38,9 +38,9 @@  discard block
 block discarded – undo
38 38
   protected $filter;
39 39
 
40 40
   function __construct($s) {
41
-    if(FALSE !== $pos = strpos($s,'|')) {
42
-      $this->filter = new Filter(substr($s, $pos+1), $this);
43
-      $s = substr($s,0,$pos);
41
+    if (FALSE !== $pos = strpos($s, '|')) {
42
+      $this->filter = new Filter(substr($s, $pos + 1), $this);
43
+      $s = substr($s, 0, $pos);
44 44
     }
45 45
     $s = preg_split("/-[>!]/", $s);
46 46
     // if(count($s) == 1) $s = explode("-!",$s[0]);
@@ -56,27 +56,27 @@  discard block
 block discarded – undo
56 56
   }
57 57
 
58 58
   function toHTML($escape = false) {
59
-    if($escape)
60
-      return "<?=htmlspecialchars(" .$this->toPHP() . ")?>";
61
-    return "<?=" . $this->toPHP() . "?>";
59
+    if ($escape)
60
+      return "<?=htmlspecialchars(".$this->toPHP().")?>";
61
+    return "<?=".$this->toPHP()."?>";
62 62
   }
63 63
   function toPHP() {
64
-    return $this->filter?$this->filter->toPHP():$this->toPHPVar();
64
+    return $this->filter ? $this->filter->toPHP() : $this->toPHPVar();
65 65
   }
66 66
   function toPHPVar() {
67 67
     if ($this->sel) {
68 68
       $sel = array();
69 69
       foreach ($this->sel as $s)
70 70
         $sel[] = "hamleGet('$s')";
71
-      return $this->func->toPHP() . "->" . implode('->', $sel);
71
+      return $this->func->toPHP()."->".implode('->', $sel);
72 72
     } else
73 73
       return $this->func->toPHP();
74 74
   }
75 75
 
76 76
   function getOrCreateModel(Model $parent = null) {
77
-    if($this->func instanceof Text\Scope)
77
+    if ($this->func instanceof Text\Scope)
78 78
       return $this->func->getOrCreateModel($parent);
79
-    if($this->func instanceof Text\Func)
79
+    if ($this->func instanceof Text\Func)
80 80
       return $this->func->getOrCreateModel($parent);
81 81
   }
82 82
 
@@ -85,10 +85,10 @@  discard block
 block discarded – undo
85 85
    * @return WriteModel
86 86
    */
87 87
   function setValue($value) {
88
-    if(!$this->sel || count($this->sel) != 1)
88
+    if (!$this->sel || count($this->sel) != 1)
89 89
       throw new \RuntimeException('Can only set values, when one var name is present');
90 90
     $model = $this->getOrCreateModel();
91
-    if(!$model instanceof WriteModel)
91
+    if (!$model instanceof WriteModel)
92 92
       throw new \RuntimeException('Can only set values on WriteModel, got '.get_class($model));
93 93
     $model->hamleSet($this->sel[0], $value);
94 94
     return $model;
Please login to merge, or discard this patch.
Braces   +31 added lines, -21 removed lines patch added patch discarded remove patch
@@ -44,20 +44,24 @@  discard block
 block discarded – undo
44 44
     }
45 45
     $s = preg_split("/-[>!]/", $s);
46 46
     // if(count($s) == 1) $s = explode("-!",$s[0]);
47
-    if (!$s[0]) throw new ParseError("Unable to parse Complex Expression");
48
-    if ($s[0][1] == "(")
49
-      $this->func = new Text\Func($s[0]);
50
-    elseif ($s[0][1] == "[")
51
-      $this->func = new Text\Scope($s[0]);
52
-    else
53
-      $this->func = new SimpleVar($s[0]);
47
+    if (!$s[0]) {
48
+      throw new ParseError("Unable to parse Complex Expression");
49
+    }
50
+    if ($s[0][1] == "(") {
51
+          $this->func = new Text\Func($s[0]);
52
+    } elseif ($s[0][1] == "[") {
53
+          $this->func = new Text\Scope($s[0]);
54
+    } else {
55
+          $this->func = new SimpleVar($s[0]);
56
+    }
54 57
     array_shift($s);
55 58
     $this->sel = $s;
56 59
   }
57 60
 
58 61
   function toHTML($escape = false) {
59
-    if($escape)
60
-      return "<?=htmlspecialchars(" .$this->toPHP() . ")?>";
62
+    if($escape) {
63
+          return "<?=htmlspecialchars(" .$this->toPHP() . ")?>";
64
+    }
61 65
     return "<?=" . $this->toPHP() . "?>";
62 66
   }
63 67
   function toPHP() {
@@ -66,18 +70,22 @@  discard block
 block discarded – undo
66 70
   function toPHPVar() {
67 71
     if ($this->sel) {
68 72
       $sel = array();
69
-      foreach ($this->sel as $s)
70
-        $sel[] = "hamleGet('$s')";
73
+      foreach ($this->sel as $s) {
74
+              $sel[] = "hamleGet('$s')";
75
+      }
71 76
       return $this->func->toPHP() . "->" . implode('->', $sel);
72
-    } else
73
-      return $this->func->toPHP();
77
+    } else {
78
+          return $this->func->toPHP();
79
+    }
74 80
   }
75 81
 
76 82
   function getOrCreateModel(Model $parent = null) {
77
-    if($this->func instanceof Text\Scope)
78
-      return $this->func->getOrCreateModel($parent);
79
-    if($this->func instanceof Text\Func)
80
-      return $this->func->getOrCreateModel($parent);
83
+    if($this->func instanceof Text\Scope) {
84
+          return $this->func->getOrCreateModel($parent);
85
+    }
86
+    if($this->func instanceof Text\Func) {
87
+          return $this->func->getOrCreateModel($parent);
88
+    }
81 89
   }
82 90
 
83 91
   /**
@@ -85,11 +93,13 @@  discard block
 block discarded – undo
85 93
    * @return WriteModel
86 94
    */
87 95
   function setValue($value) {
88
-    if(!$this->sel || count($this->sel) != 1)
89
-      throw new \RuntimeException('Can only set values, when one var name is present');
96
+    if(!$this->sel || count($this->sel) != 1) {
97
+          throw new \RuntimeException('Can only set values, when one var name is present');
98
+    }
90 99
     $model = $this->getOrCreateModel();
91
-    if(!$model instanceof WriteModel)
92
-      throw new \RuntimeException('Can only set values on WriteModel, got '.get_class($model));
100
+    if(!$model instanceof WriteModel) {
101
+          throw new \RuntimeException('Can only set values on WriteModel, got '.get_class($model));
102
+    }
93 103
     $model->hamleSet($this->sel[0], $value);
94 104
     return $model;
95 105
   }
Please login to merge, or discard this patch.
php/hamle/Text/FuncSub.php 2 patches
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
    */
40 40
   public function __construct($s) {
41 41
     $m = array();
42
-    if (!preg_match('/^ +([><]) +('.self::REGEX_FUNCSEL . '+)(.*)$/', $s, $m))
42
+    if (!preg_match('/^ +([><]) +('.self::REGEX_FUNCSEL.'+)(.*)$/', $s, $m))
43 43
       throw new ParseError("Unable to read \$ sub func in '$s'");
44 44
     if ($m[1] == "<") $this->dir = Hamle\Hamle::REL_PARENT;
45 45
     elseif ($m[1] == ">") $this->dir = Hamle\Hamle::REL_CHILD;
@@ -57,24 +57,24 @@  discard block
 block discarded – undo
57 57
    * @return string
58 58
    */
59 59
   public function toPHP() {
60
-    $limit = Hamle\Text::varToCode($this->sortlimit['sort']) . "," .
61
-        $this->sortlimit['limit'] . "," . $this->sortlimit['offset'] . "," .
60
+    $limit = Hamle\Text::varToCode($this->sortlimit['sort']).",".
61
+        $this->sortlimit['limit'].",".$this->sortlimit['offset'].",".
62 62
         $this->grouptype['grouptype'];
63
-    $sub = $this->sub ? "->" . $this->sub->toPHP() : "";
64
-    return "hamleRel(" . $this->dir . "," .
65
-    Hamle\Text::varToCode($this->filt['tag']) . ",$limit)$sub";
63
+    $sub = $this->sub ? "->".$this->sub->toPHP() : "";
64
+    return "hamleRel(".$this->dir.",".
65
+    Hamle\Text::varToCode($this->filt['tag']).",$limit)$sub";
66 66
   }
67 67
 
68 68
   public function getOrCreateModel(Model $parent = null) {
69 69
     $model = $parent->hamleRel($this->dir, $this->filt['tag'], $this->sortlimit['sort'],
70 70
       $this->sortlimit['limit'], $this->sortlimit['offset']);
71
-    if(!$model->valid()) {
72
-      if(!$parent instanceof Hamle\WriteModel)
73
-        throw new \Exception('Cant create model, ' . get_class($parent) . ' must implement Hamle\\WriteModel.');
71
+    if (!$model->valid()) {
72
+      if (!$parent instanceof Hamle\WriteModel)
73
+        throw new \Exception('Cant create model, '.get_class($parent).' must implement Hamle\\WriteModel.');
74 74
       $model = $parent->current()->hamleCreateRel($this->dir, $this->filt['tag'], $this->sortlimit['sort'],
75 75
         $this->sortlimit['limit'], $this->sortlimit['offset']);
76 76
     }
77
-    if($this->sub)
77
+    if ($this->sub)
78 78
       return $this->sub->getOrCreateModel($model)->current();
79 79
     return $model->current();
80 80
   }
Please login to merge, or discard this patch.
Braces   +22 added lines, -12 removed lines patch added patch discarded remove patch
@@ -39,17 +39,25 @@  discard block
 block discarded – undo
39 39
    */
40 40
   public function __construct($s) {
41 41
     $m = array();
42
-    if (!preg_match('/^ +([><]) +('.self::REGEX_FUNCSEL . '+)(.*)$/', $s, $m))
43
-      throw new ParseError("Unable to read \$ sub func in '$s'");
44
-    if ($m[1] == "<") $this->dir = Hamle\Hamle::REL_PARENT;
45
-    elseif ($m[1] == ">") $this->dir = Hamle\Hamle::REL_CHILD;
46
-    else $this->dir = Hamle\Hamle::REL_ANY;
42
+    if (!preg_match('/^ +([><]) +('.self::REGEX_FUNCSEL . '+)(.*)$/', $s, $m)) {
43
+          throw new ParseError("Unable to read \$ sub func in '$s'");
44
+    }
45
+    if ($m[1] == "<") {
46
+      $this->dir = Hamle\Hamle::REL_PARENT;
47
+    } elseif ($m[1] == ">") {
48
+      $this->dir = Hamle\Hamle::REL_CHILD;
49
+    } else {
50
+      $this->dir = Hamle\Hamle::REL_ANY;
51
+    }
47 52
     $this->sortlimit = $this->attSortLimit($m[2]);
48 53
     $this->filt = $this->attIdTag($m[2]);
49 54
     $this->grouptype = $this->attGroupType($m[2]);
50
-    if ($this->filt['id']) throw new ParseError("Unable to select by id");
51
-    if (trim($m[3]))
52
-      $this->sub = new FuncSub($m[3]);
55
+    if ($this->filt['id']) {
56
+      throw new ParseError("Unable to select by id");
57
+    }
58
+    if (trim($m[3])) {
59
+          $this->sub = new FuncSub($m[3]);
60
+    }
53 61
   }
54 62
 
55 63
   /**
@@ -69,13 +77,15 @@  discard block
 block discarded – undo
69 77
     $model = $parent->hamleRel($this->dir, $this->filt['tag'], $this->sortlimit['sort'],
70 78
       $this->sortlimit['limit'], $this->sortlimit['offset']);
71 79
     if(!$model->valid()) {
72
-      if(!$parent instanceof Hamle\WriteModel)
73
-        throw new \Exception('Cant create model, ' . get_class($parent) . ' must implement Hamle\\WriteModel.');
80
+      if(!$parent instanceof Hamle\WriteModel) {
81
+              throw new \Exception('Cant create model, ' . get_class($parent) . ' must implement Hamle\\WriteModel.');
82
+      }
74 83
       $model = $parent->current()->hamleCreateRel($this->dir, $this->filt['tag'], $this->sortlimit['sort'],
75 84
         $this->sortlimit['limit'], $this->sortlimit['offset']);
76 85
     }
77
-    if($this->sub)
78
-      return $this->sub->getOrCreateModel($model)->current();
86
+    if($this->sub) {
87
+          return $this->sub->getOrCreateModel($model)->current();
88
+    }
79 89
     return $model->current();
80 90
   }
81 91
 
Please login to merge, or discard this patch.