Filter::iterSplit() - Code Metrics - Inspection of "Added a filter to split a field and turn into a li..." - cseufert/hamle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e103ac...127bed )

by Chris

created 2016-01-28 06:20 UTC

Filter::iterSplit() A

↳ Parent: Filter

Complexity

Conditions	3
Paths	3

Size

Total Lines	8
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	8
rs	9.4285
cc	3
eloc	6
nc	3
nop	2

<?php
/*
This project is Licenced under The MIT License (MIT)

Copyright (c) 2014 Christopher Seufert

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.

 */
namespace Seufert\Hamle\Text;

use Seufert\Hamle\Exception\ParseError;
use Seufert\Hamle\Model\WrapArray;
use Seufert\Hamle\Text;

class Filter extends Text {
  protected $filter;

  protected $vars;

  /** @var SimpleVar  */
  protected $what;

  function __construct($s, Text $what) {

    if(preg_match("/^([a-z]+)(\\((.*)\\))?$/",$s, $m)) {
      $this->filter = $m[1];
      $this->vars = isset($m[3])?explode(',',$m[3]):[];
    } else {
      throw new ParseError("Unable to parse filter expression \"$s\"");
    }
    if(!in_array($this->filter,['itersplit','round','strtoupper','strtolower','ucfirst'])) {
      throw new ParseError("Unknown Filter Type \"{$this->filter}\"");
    }
    if($this->filter == "itersplit") {
      $this->filter = "Seufert\\Hamle\\Text\\Filter::iterSplit";
    }
    $this->what = $what;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
  }

  function toHTML($escape = false) {

    if($escape)
      return "<?=htmlspecialchars(" .$this->toPHP() . ")?>";
    return "<?=" . $this->toPHP() . "?>";
  }

  function toPHP() {

    $o = [$this->what->toPHPVar()] ;
    foreach($this->vars as $v)
      $o[] = $this->varToCode($v);
    return "{$this->filter}(" . implode(',',$o) . ")";
  }

  static function iterSplit($v, $sep = ",") {

    $o = [];
    foreach(explode($sep, $v) as $k=>$i) {
      if($i)
        $o[] = ['v'=>trim($i), 'value'=>trim($i), 'k'=>$k,'key'=>$k];
    }
    return new WrapArray($o);
  }
}

1			<?php
2			/*
3			This project is Licenced under The MIT License (MIT)
4
5			Copyright (c) 2014 Christopher Seufert
6
7			Permission is hereby granted, free of charge, to any person obtaining a copy
8			of this software and associated documentation files (the "Software"), to deal
9			in the Software without restriction, including without limitation the rights
10			to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
11			copies of the Software, and to permit persons to whom the Software is
12			furnished to do so, subject to the following conditions:
13
14			The above copyright notice and this permission notice shall be included in
15			all copies or substantial portions of the Software.
16
17			THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
18			IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
19			FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
20			AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
21			LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
22			OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
23			THE SOFTWARE.
24
25			*/
26			namespace Seufert\Hamle\Text;
27
28			use Seufert\Hamle\Exception\ParseError;
29			use Seufert\Hamle\Model\WrapArray;
30			use Seufert\Hamle\Text;
31
32			class Filter extends Text {
33			protected $filter;
34
35			protected $vars;
36
37			/** @var SimpleVar */
38			protected $what;
39
40			function __construct($s, Text $what) {
			0 ignored issues – show Best Practice introduced 2016-01-18 04:20 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
41			if(preg_match("/^([a-z]+)(\\((.*)\\))?$/",$s, $m)) {
42			$this->filter = $m[1];
43			$this->vars = isset($m[3])?explode(',',$m[3]):[];
44			} else {
45			throw new ParseError("Unable to parse filter expression \"$s\"");
46			}
47			if(!in_array($this->filter,['itersplit','round','strtoupper','strtolower','ucfirst'])) {
48			throw new ParseError("Unknown Filter Type \"{$this->filter}\"");
49			}
50			if($this->filter == "itersplit") {
51			$this->filter = "Seufert\\Hamle\\Text\\Filter::iterSplit";
52			}
53			$this->what = $what;
			0 ignored issues – show Documentation Bug introduced 2016-01-18 04:20 UTC by Report Bug Copy Issue Report `$what` is of type `object<Seufert\Hamle\Text>`, but the property `$what` was declared to be of type `object<Seufert\Hamle\Text\SimpleVar>`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
54			}
55
56			function toHTML($escape = false) {
			0 ignored issues – show Best Practice introduced 2016-01-18 04:20 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
57			if($escape)
58			return "<?=htmlspecialchars(" .$this->toPHP() . ")?>";
59			return "<?=" . $this->toPHP() . "?>";
60			}
61
62			function toPHP() {
			0 ignored issues – show Best Practice introduced 2016-01-18 04:20 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
63			$o = [$this->what->toPHPVar()] ;
64			foreach($this->vars as $v)
65			$o[] = $this->varToCode($v);
66			return "{$this->filter}(" . implode(',',$o) . ")";
67			}
68
69			static function iterSplit($v, $sep = ",") {
			0 ignored issues – show Best Practice introduced 2016-01-28 06:24 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
70			$o = [];
71			foreach(explode($sep, $v) as $k=>$i) {
72			if($i)
73			$o[] = ['v'=>trim($i), 'value'=>trim($i), 'k'=>$k,'key'=>$k];
74			}
75			return new WrapArray($o);
76			}
77			}

cseufert / hamle

Push — master ( e103ac...127bed )

Filter::iterSplit() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like