Seufert\Hamle\Text\Filter

Complexity

Total Complexity

15

Size/Duplication

Total Lines	58
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	5
Bugs	0	Features	4

6 Methods

Rating	Name	Duplication	Size	Complexity
B	__construct()	0	18	6
A	toHTML()	0	5	2
A	toPHP()	0	6	2
A	itersplit()	0	8	3
A	newlinebr()	0	3	1
A	replace()	0	3	1

<?php
/*
This project is Licenced under The MIT License (MIT)

Copyright (c) 2014 Christopher Seufert

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.

 */
namespace Seufert\Hamle\Text;

use Seufert\Hamle\Exception\ParseError;
use Seufert\Hamle\Model\WrapArray;
use Seufert\Hamle\Text;

class Filter extends Text {
  protected $filter;

  protected $vars;

  /** @var SimpleVar */
  protected $what;

  function __construct($s, Text $what) {

It is generally recommended to explicitly declare the visibility for methods.

    if(preg_match("/^([a-z]+)(\\((.*)\\))?$/", $s, $m)) {
      $this->filter = $m[1];
      $this->vars = isset($m[3]) ? explode(',', $m[3]) : [];
      foreach($this->vars as $k=>$v)
        $this->vars[$k] = str_replace(",",',',$v);
    } else {
      throw new ParseError("Unable to parse filter expression \"$s\"");
    }
    if(!in_array($this->filter, ['itersplit', 'newlinebr', 'round',
        'strtoupper', 'strtolower', 'ucfirst','replace'])) {
      throw new ParseError("Unknown Filter Type \"{$this->filter}\"");
    }
    if(in_array($this->filter,['itersplit','newlinebr', 'replace'])) {
        $this->filter = "Seufert\\Hamle\\Text\\Filter::{$this->filter}";
    }
    $this->what = $what;

$what is of type object<Seufert\Hamle\Text>, but the property $what was declared to be of type object<Seufert\Hamle\Text\SimpleVar>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

  }

  function toHTML($escape = false) {

It is generally recommended to explicitly declare the visibility for methods.

    if($escape)
      return "<?=htmlspecialchars(" .$this->toPHP() . ")?>";
    return "<?=" . $this->toPHP() . "?>";
  }

  function toPHP() {

It is generally recommended to explicitly declare the visibility for methods.

    $o = [$this->what->toPHPVar()] ;
    foreach($this->vars as $v)
      $o[] = $this->varToCode($v);
    return "{$this->filter}(" . implode(',',$o) . ")";
  }

  static function itersplit($v, $sep = ",") {

It is generally recommended to explicitly declare the visibility for methods.

    $o = [];
    foreach(explode($sep, $v) as $k=>$i) {
      if($i)
        $o[] = ['v'=>trim($i), 'value'=>trim($i), 'k'=>$k,'key'=>$k];
    }
    return new WrapArray($o);
  }

  static function newlinebr($v) {

It is generally recommended to explicitly declare the visibility for methods.

    return str_replace("\n","<br />\n",$v);
  }

  static function replace($v, $src, $dst) {

It is generally recommended to explicitly declare the visibility for methods.

    return str_replace($src,$dst,$v);
  }

}