Issues in BrowscapOrg.php (master) - Issues in master - crossjoin/Browscap - Measure and Improve Code Quality continuously with Scrutinizer

Issues (27)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Source/Ini/BrowscapOrg.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
declare(strict_types=1);

namespace Crossjoin\Browscap\Source\Ini;

use Crossjoin\Browscap\Exception\SourceConditionNotSatisfiedException;
use Crossjoin\Browscap\Exception\SourceUnavailableException;
use Crossjoin\Browscap\Exception\UnexpectedValueException;
use Crossjoin\Browscap\Source\DownloadAbstract;
use Crossjoin\Browscap\Source\SourceFactoryInterface;
use Crossjoin\Browscap\Source\SourceInterface;
use Crossjoin\Browscap\Type;

/**
 * Class BrowscapOrg
 *
 * @package Crossjoin\Browscap\Source\Ini
 * @author Christoph Ziegenberg <[email protected]>
 * @link https://github.com/crossjoin/browscap
 */
class BrowscapOrg extends DownloadAbstract implements SourceInterface, SourceFactoryInterface
{
    use DataSetsFromContentTrait { getContent as private getContentIgnore; }

    const BASE_URI = 'http://browscap.org';

    /**
     * @var int
     */
    protected $type;

    /**
     * BrowscapOrg constructor.
     *
     * @param int $type
     * @param array $clientOptions
     *
     * @throws SourceConditionNotSatisfiedException
     * @throws UnexpectedValueException
     */
    public function __construct(int $type = Type::STANDARD, array $clientOptions = [])
    {
        $this->setType($type);
        parent::__construct($this->getSourceUri(), $clientOptions);
    }

    /**
     * @inheritdoc
     *
     * @throws SourceUnavailableException
     * @throws \RuntimeException
     */
    public function getReleaseTime() : int
    {
        $stream = $this->loadContent(self::BASE_URI . '/version');

        if (!$stream->isReadable()) {
            throw new SourceUnavailableException('Source stream is not readable.', 1459162265);
        }

        return max(0, strtotime($stream->getContents()));
    }

    /**
     * @inheritdoc
     *
     * @throws SourceUnavailableException
     * @throws \RuntimeException
     */
    public function getVersion() : int
    {
        $stream = $this->loadContent(self::BASE_URI . '/version-number');

        if (!$stream->isReadable()) {
            throw new SourceUnavailableException('Source stream is not readable.', 1459162266);
        }

        return (int)$stream->getContents();
    }

    /**
     * @param int $type
     *
     * @throws UnexpectedValueException
     */
    protected function setType(int $type)
    {
        switch ($type) {
            case Type::LITE:
                $sourceType = 'Lite_PHP_BrowscapINI';
                break;
            case Type::FULL:
                $sourceType = 'Full_PHP_BrowscapINI';
                break;
            case Type::STANDARD:
                $sourceType = 'PHP_BrowscapINI';
                break;
            default:
                throw new UnexpectedValueException("Invalid value '$type' for argument 'type'.");
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
        }

        $this->type = $type;
        $this->setSourceUri(self::BASE_URI . '/stream?q=' . $sourceType);
    }

    /**
     * @inheritdoc
     */
    public function getType() : int
    {
        return $this->type;
    }

    /**
     * Needs to be defined again, because the trait used here replaces
     * the method of the parent class.
     *
     * @inheritdoc
     */
    public function getContent() : \Generator
    {
        return parent::getContent();
    }
}


1			<?php
2			declare(strict_types=1);
3
4			namespace Crossjoin\Browscap\Source\Ini;
5
6			use Crossjoin\Browscap\Exception\SourceConditionNotSatisfiedException;
7			use Crossjoin\Browscap\Exception\SourceUnavailableException;
8			use Crossjoin\Browscap\Exception\UnexpectedValueException;
9			use Crossjoin\Browscap\Source\DownloadAbstract;
10			use Crossjoin\Browscap\Source\SourceFactoryInterface;
11			use Crossjoin\Browscap\Source\SourceInterface;
12			use Crossjoin\Browscap\Type;
13
14			/**
15			* Class BrowscapOrg
16			*
17			* @package Crossjoin\Browscap\Source\Ini
18			* @author Christoph Ziegenberg <[email protected]>
19			* @link https://github.com/crossjoin/browscap
20			*/
21			class BrowscapOrg extends DownloadAbstract implements SourceInterface, SourceFactoryInterface
22			{
23			use DataSetsFromContentTrait { getContent as private getContentIgnore; }
24
25			const BASE_URI = 'http://browscap.org';
26
27			/**
28			* @var int
29			*/
30			protected $type;
31
32			/**
33			* BrowscapOrg constructor.
34			*
35			* @param int $type
36			* @param array $clientOptions
37			*
38			* @throws SourceConditionNotSatisfiedException
39			* @throws UnexpectedValueException
40			*/
41			public function __construct(int $type = Type::STANDARD, array $clientOptions = [])
42			{
43			$this->setType($type);
44			parent::__construct($this->getSourceUri(), $clientOptions);
45			}
46
47			/**
48			* @inheritdoc
49			*
50			* @throws SourceUnavailableException
51			* @throws \RuntimeException
52			*/
53			public function getReleaseTime() : int
54			{
55			$stream = $this->loadContent(self::BASE_URI . '/version');
56
57			if (!$stream->isReadable()) {
58			throw new SourceUnavailableException('Source stream is not readable.', 1459162265);
59			}
60
61			return max(0, strtotime($stream->getContents()));
62			}
63
64			/**
65			* @inheritdoc
66			*
67			* @throws SourceUnavailableException
68			* @throws \RuntimeException
69			*/
70			public function getVersion() : int
71			{
72			$stream = $this->loadContent(self::BASE_URI . '/version-number');
73
74			if (!$stream->isReadable()) {
75			throw new SourceUnavailableException('Source stream is not readable.', 1459162266);
76			}
77
78			return (int)$stream->getContents();
79			}
80
81			/**
82			* @param int $type
83			*
84			* @throws UnexpectedValueException
85			*/
86			protected function setType(int $type)
87			{
88			switch ($type) {
89			case Type::LITE:
90			$sourceType = 'Lite_PHP_BrowscapINI';
91			break;
92			case Type::FULL:
93			$sourceType = 'Full_PHP_BrowscapINI';
94			break;
95			case Type::STANDARD:
96			$sourceType = 'PHP_BrowscapINI';
97			break;
98			default:
99			throw new UnexpectedValueException("Invalid value '$type' for argument 'type'.");
			0 ignored issues – show Coding Style Best Practice introduced 2016-04-09 08:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this As per coding-style, please use concatenation or `sprintf` for the variable `$type` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history...
100			}
101
102			$this->type = $type;
103			$this->setSourceUri(self::BASE_URI . '/stream?q=' . $sourceType);
104			}
105
106			/**
107			* @inheritdoc
108			*/
109			public function getType() : int
110			{
111			return $this->type;
112			}
113
114			/**
115			* Needs to be defined again, because the trait used here replaces
116			* the method of the parent class.
117			*
118			* @inheritdoc
119			*/
120			public function getContent() : \Generator
121			{
122			return parent::getContent();
123			}
124			}
125

crossjoin / Browscap

Issues (27)

Security Analysis not enabled

src/Source/Ini/BrowscapOrg.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like