Issues in FileAbstract.php (master) - Issues in master - crossjoin/Browscap - Measure and Improve Code Quality continuously with Scrutinizer

Issues (27)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Source/FileAbstract.php (3 issues)

Labels

Severity

Minor 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
declare(strict_types=1);

namespace Crossjoin\Browscap\Source;

use Crossjoin\Browscap\Exception\SourceUnavailableException;

/**
 * Class FileAbstract
 *
 * @package Crossjoin\Browscap\Source
 * @author Christoph Ziegenberg <[email protected]>
 * @link https://github.com/crossjoin/browscap
 */
abstract class FileAbstract
{
    /**
     * @var string
     */
    protected $file;

    /**
     * File constructor.
     *
     * @param string $file
     *
     * @throws SourceUnavailableException
     */
    public function __construct(string $file)
    {
        $this->setFilePath($file);
    }

    /**
     * @return string
     */
    protected function getFilePath() : string
    {
        return $this->file;
    }

    /**
     * @param string $file
     *
     * @throws SourceUnavailableException
     */
    protected function setFilePath(string $file)
    {
        if (!$this->isFileReadable($file)) {
            if (!file_exists($file)) {
                throw new SourceUnavailableException("File '$file' does not exist.", 1458977223);
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
            } else {
                throw new SourceUnavailableException("File '$file' exists but is not readable.", 1458977224);
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
            }
        }
        $this->file = $file;
    }

    /**
     * @param string $file
     *
     * @return bool
     */
    protected function isFileReadable(string $file) : bool
    {
        return is_readable($file);
    }

    /**
     * @inheritdoc
     *
     * @codeCoverageIgnore All covered, but analysis does't work with Generators.
     *
     * @throws SourceUnavailableException
     */
    public function getContent() : \Generator
    {
        $file = $this->getFilePath();

        $handle = @fopen($file, 'r');
        if ($handle !== false) {
            while (!feof($handle)) {
                yield fread($handle, 4096);
            }
            fclose($handle);
        } else {
            throw new SourceUnavailableException("Could not open file '$file' for reading.", 1458977225);
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
        }
    }
}


1			<?php
2			declare(strict_types=1);
3
4			namespace Crossjoin\Browscap\Source;
5
6			use Crossjoin\Browscap\Exception\SourceUnavailableException;
7
8			/**
9			* Class FileAbstract
10			*
11			* @package Crossjoin\Browscap\Source
12			* @author Christoph Ziegenberg <[email protected]>
13			* @link https://github.com/crossjoin/browscap
14			*/
15			abstract class FileAbstract
16			{
17			/**
18			* @var string
19			*/
20			protected $file;
21
22			/**
23			* File constructor.
24			*
25			* @param string $file
26			*
27			* @throws SourceUnavailableException
28			*/
29			public function __construct(string $file)
30			{
31			$this->setFilePath($file);
32			}
33
34			/**
35			* @return string
36			*/
37			protected function getFilePath() : string
38			{
39			return $this->file;
40			}
41
42			/**
43			* @param string $file
44			*
45			* @throws SourceUnavailableException
46			*/
47			protected function setFilePath(string $file)
48			{
49			if (!$this->isFileReadable($file)) {
50			if (!file_exists($file)) {
51			throw new SourceUnavailableException("File '$file' does not exist.", 1458977223);
			0 ignored issues – show Coding Style Best Practice introduced 2016-04-09 08:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this As per coding-style, please use concatenation or `sprintf` for the variable `$file` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history...
52			} else {
53			throw new SourceUnavailableException("File '$file' exists but is not readable.", 1458977224);
			0 ignored issues – show Coding Style Best Practice introduced 2016-04-09 08:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this As per coding-style, please use concatenation or `sprintf` for the variable `$file` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history...
54			}
55			}
56			$this->file = $file;
57			}
58
59			/**
60			* @param string $file
61			*
62			* @return bool
63			*/
64			protected function isFileReadable(string $file) : bool
65			{
66			return is_readable($file);
67			}
68
69			/**
70			* @inheritdoc
71			*
72			* @codeCoverageIgnore All covered, but analysis does't work with Generators.
73			*
74			* @throws SourceUnavailableException
75			*/
76			public function getContent() : \Generator
77			{
78			$file = $this->getFilePath();
79
80			$handle = @fopen($file, 'r');
81			if ($handle !== false) {
82			while (!feof($handle)) {
83			yield fread($handle, 4096);
84			}
85			fclose($handle);
86			} else {
87			throw new SourceUnavailableException("Could not open file '$file' for reading.", 1458977225);
			0 ignored issues – show Coding Style Best Practice introduced 2016-04-09 08:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this As per coding-style, please use concatenation or `sprintf` for the variable `$file` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history...
88			}
89			}
90			}
91

crossjoin / Browscap

Issues (27)

Security Analysis not enabled

src/Source/FileAbstract.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like