JobboardController::__construct() - Code Metrics - Inspection of "[Jobs] makes it possible to pass the query as a ro..." - cross-solution/YAWIK - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 968b21...29aade )

unknown

created 2017-03-06 11:54 UTC

JobboardController::__construct() A

↳ Parent: JobboardController

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	5
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	2

<?php
/**
 * YAWIK
 *
 * @filesource
 * @copyright (c) 2013 - 2016 Cross Solution (http://cross-solution.de)
 * @license   MIT
 */

/** ActionController of Jobs */
namespace Jobs\Controller;

use Core\Form\SearchForm;
use Jobs\Form\ListFilter;
use Zend\Mvc\Controller\AbstractActionController;
use Zend\Session\Container as Session;
use Jobs\Repository;
use Zend\View\Model\ViewModel;

/**
 * @method \Auth\Controller\Plugin\Auth auth()
 * @method \Core\Controller\Plugin\CreatePaginatorService paginatorService()
 *
 * Controller for jobboard actions
 */
class JobboardController extends AbstractActionController
{
    /**
     * @var Repository\Job $jobRepository
     */
    private $jobRepository;

    /**
     * @var array
     */
    private $options = [
        'count' => 10
    ];

    /**
     * Construct the jobboard controller
     *
     * @param Repository\Job $jobRepository
     */
    public function __construct(Repository\Job $jobRepository, $options)
    {
        $this->jobRepository = $jobRepository;
        $this->options = $options;
    }
    /**
     * attaches further Listeners for generating / processing the output
     * @return $this
     */
    public function attachDefaultListeners()

    {
        parent::attachDefaultListeners();
        $serviceLocator = $this->serviceLocator;
        $defaultServices = $serviceLocator->get('DefaultListeners');
        $events          = $this->getEventManager();
        $events->attach($defaultServices);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        return $this;
    }

    /**
     * List jobs
     *
     * @return ViewModel

     */
    public function indexAction()
    {
        /* @todo: move this into a listener.
         *
         * The following lines allow to override get param[q] with the
         * param from route. This feature is needed for a landing-page feature, where
         * human readable urls like http://yawik.org/demo/de/jobs/sales.html 
         *
         * move the Logic into a Listener, which can be activated, if needed
         */
        $request = $this->getRequest();
        $getParams = $request->getQuery();
        $routeParams = $this->params()->fromRoute();
        if (isset($routeParams['q']) && !isset($getParams['q'])){
            $getParams['q']=$routeParams['q'];
        }

        $result = $this->pagination([
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                'params' => ['Jobs_Board', [
                    'q',
                    'count' => $this->options['count'],
                    'page' => 1,
                    'l',
                    'd' => 10]
                ],
                'form' => ['as' => 'filterForm', 'Jobs/JobboardSearch'],
                'paginator' => ['as' => 'jobs', 'Jobs/Board']
            ]);

        $params['by'] = "guest";
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

        $organizationImageCache = $this->serviceLocator->get('Organizations\ImageFileCache\Manager');

        $result['organizationImageCache'] = $organizationImageCache;

        return $result;
    }
}


1		<?php
2		/**
3		* YAWIK
4		*
5		* @filesource
6		* @copyright (c) 2013 - 2016 Cross Solution (http://cross-solution.de)
7		* @license MIT
8		*/
9
10		/** ActionController of Jobs */
11		namespace Jobs\Controller;
12
13		use Core\Form\SearchForm;
14		use Jobs\Form\ListFilter;
15		use Zend\Mvc\Controller\AbstractActionController;
16		use Zend\Session\Container as Session;
17		use Jobs\Repository;
18		use Zend\View\Model\ViewModel;
19
20		/**
21		* @method \Auth\Controller\Plugin\Auth auth()
22		* @method \Core\Controller\Plugin\CreatePaginatorService paginatorService()
23		*
24		* Controller for jobboard actions
25		*/
26		class JobboardController extends AbstractActionController
27		{
28		/**
29		* @var Repository\Job $jobRepository
30		*/
31		private $jobRepository;
32
33		/**
34		* @var array
35		*/
36		private $options = [
37		'count' => 10
38		];
39
40		/**
41		* Construct the jobboard controller
42		*
43		* @param Repository\Job $jobRepository
44		*/
45		public function __construct(Repository\Job $jobRepository, $options)
46		{
47		$this->jobRepository = $jobRepository;
48		$this->options = $options;
49		}
50		/**
51		* attaches further Listeners for generating / processing the output
52		* @return $this
53		*/
54	View Code Duplication	public function attachDefaultListeners()
		0 ignored issues – show Duplication introduced 2015-11-30 11:54 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
55		{
56		parent::attachDefaultListeners();
57		$serviceLocator = $this->serviceLocator;
58		$defaultServices = $serviceLocator->get('DefaultListeners');
59		$events = $this->getEventManager();
60		$events->attach($defaultServices);
		0 ignored issues – show Documentation introduced 2015-11-30 11:54 UTC by Report Bug Copy Issue Report `$defaultServices` is of type `object\|array`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
61		return $this;
62		}
63
64		/**
65		* List jobs
66		*
67		* @return ViewModel
		0 ignored issues – show Documentation introduced 2017-02-13 15:58 UTC by Report Bug Copy Issue Report Should the return type not be `array<string,object\|array>`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
68		*/
69		public function indexAction()
70		{
71		/* @todo: move this into a listener.
72		*
73		* The following lines allow to override get param[q] with the
74		* param from route. This feature is needed for a landing-page feature, where
75		* human readable urls like http://yawik.org/demo/de/jobs/sales.html
76		*
77		* move the Logic into a Listener, which can be activated, if needed
78		*/
79		$request = $this->getRequest();
80		$getParams = $request->getQuery();
81		$routeParams = $this->params()->fromRoute();
82		if (isset($routeParams['q']) && !isset($getParams['q'])){
83		$getParams['q']=$routeParams['q'];
84		}
85
86		$result = $this->pagination([
		0 ignored issues – show Documentation Bug introduced 2017-01-19 12:24 UTC by Report Bug Copy Issue Report The method `pagination` does not exist on `object<Jobs\Controller\JobboardController>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
87		'params' => ['Jobs_Board', [
88		'q',
89		'count' => $this->options['count'],
90		'page' => 1,
91		'l',
92		'd' => 10]
93		],
94		'form' => ['as' => 'filterForm', 'Jobs/JobboardSearch'],
95		'paginator' => ['as' => 'jobs', 'Jobs/Board']
96		]);
97
98		$params['by'] = "guest";
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-01-19 12:24 UTC by Report Bug Copy Issue Report `$params` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$params = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
99
100		$organizationImageCache = $this->serviceLocator->get('Organizations\ImageFileCache\Manager');
101
102		$result['organizationImageCache'] = $organizationImageCache;
103
104		return $result;
105		}
106		}
107

cross-solution / YAWIK

Push — develop ( 968b21...29aade )

JobboardController::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like