Completed
Push — develop ( 06c328...a78ff6 )
by Carsten
17:00 queued 08:38
created
module/Jobs/src/Jobs/Form/Hydrator/Strategy/JobDescriptionTitleStrategy.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@
 block discarded – undo
17 17
     public function extract($value)
18 18
     {
19 19
         $result = null;
20
-        if (method_exists($value,'getTemplateValues')) {
20
+        if (method_exists($value, 'getTemplateValues')) {
21 21
             $result = $value->getTemplateValues()->getTitle();
22 22
         }
23 23
         return $result;
Please login to merge, or discard this patch.
module/Jobs/src/Jobs/Form/CustomerNoteFieldset.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
 
29 29
     public function init()
30 30
     {
31
-    	$this->setAttribute('id','customerNoteFieldset');
31
+    	$this->setAttribute('id', 'customerNoteFieldset');
32 32
     	$this->setName('customerNote');
33 33
         $this->add([
34 34
                 'type' => 'Textarea',
Please login to merge, or discard this patch.
module/Applications/config/module.config.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
                 * for multiple paths.
32 32
                 * example https://github.com/doctrine/DoctrineORMModule
33 33
                 */
34
-               'paths' => [ __DIR__ . '/../src/Applications/Entity']
34
+               'paths' => [__DIR__.'/../src/Applications/Entity']
35 35
             ],
36 36
         ],
37 37
         'eventmanager' => [
@@ -91,10 +91,10 @@  discard block
 block discarded – undo
91 91
             'Applications\Controller\MultiManage' => 'Applications\Controller\MultimanageController',
92 92
         ],
93 93
 	    'factories' => [
94
-		    'Applications/Controller/Manage' => [ManageController::class,'factory'],
95
-		    'Applications\Controller\Apply' => [ApplyController::class,'factory'],
96
-		    'Applications/CommentController' => [CommentController::class,'factory'],
97
-		    'Applications/Console' => [ConsoleController::class,'factory'],
94
+		    'Applications/Controller/Manage' => [ManageController::class, 'factory'],
95
+		    'Applications\Controller\Apply' => [ApplyController::class, 'factory'],
96
+		    'Applications/CommentController' => [CommentController::class, 'factory'],
97
+		    'Applications/Console' => [ConsoleController::class, 'factory'],
98 98
 	    ]
99 99
     ],
100 100
     
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
         'translation_file_patterns' => [
154 154
             [
155 155
                 'type' => 'gettext',
156
-                'base_dir' => __DIR__ . '/../language',
156
+                'base_dir' => __DIR__.'/../language',
157 157
                 'pattern' => '%s.mo',
158 158
             ],
159 159
         ],
@@ -161,16 +161,16 @@  discard block
 block discarded – undo
161 161
     // Configure the view service manager
162 162
     'view_manager' => [
163 163
         'template_path_stack' => [
164
-            'Applications' => __DIR__ . '/../view',
164
+            'Applications' => __DIR__.'/../view',
165 165
         ],
166 166
         'template_map' => [
167
-            'applications/error/not-found' => __DIR__ . '/../view/error/not-found.phtml',
168
-            'layout/apply' => __DIR__ . '/../view/layout/layout.phtml',
169
-            'applications/sidebar/manage' => __DIR__ . '/../view/sidebar/manage.phtml',
170
-            'applications/mail/forward' => __DIR__ . '/../view/mail/forward.phtml',
171
-            'applications/detail/pdf' => __DIR__ . '/../view/applications/manage/detail.pdf.phtml',
172
-            'applications/index/disclaimer' => __DIR__ . '/../view/applications/index/disclaimer.phtml',
173
-            'content/applications-privacy-policy' => __DIR__ . '/../view/applications/index/disclaimer.phtml',
167
+            'applications/error/not-found' => __DIR__.'/../view/error/not-found.phtml',
168
+            'layout/apply' => __DIR__.'/../view/layout/layout.phtml',
169
+            'applications/sidebar/manage' => __DIR__.'/../view/sidebar/manage.phtml',
170
+            'applications/mail/forward' => __DIR__.'/../view/mail/forward.phtml',
171
+            'applications/detail/pdf' => __DIR__.'/../view/applications/manage/detail.pdf.phtml',
172
+            'applications/index/disclaimer' => __DIR__.'/../view/applications/index/disclaimer.phtml',
173
+            'content/applications-privacy-policy' => __DIR__.'/../view/applications/index/disclaimer.phtml',
174 174
         ]
175 175
     ],
176 176
     'view_helpers' => [
@@ -240,7 +240,7 @@  discard block
 block discarded – undo
240 240
         'factories' => [
241 241
             'Applications/NewApplication' => 'Applications\Factory\Mail\NewApplicationFactory',
242 242
             Mail\Confirmation::class      => Factory\Mail\ConfirmationFactory::class,
243
-            'Applications/Forward'        => [Forward::class,'factory'],
243
+            'Applications/Forward'        => [Forward::class, 'factory'],
244 244
         ],
245 245
         'aliases' => [
246 246
             'Applications/Confirmation'   => Mail\Confirmation::class,
Please login to merge, or discard this patch.
module/Applications/src/Applications/Options/ModuleOptions.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -237,7 +237,7 @@
 block discarded – undo
237 237
      */
238 238
     public function setAllowSubsequentAttachmentUpload($allowSubsequentAttachmentUpload)
239 239
     {
240
-        $this->allowSubsequentAttachmentUpload = (bool)$allowSubsequentAttachmentUpload;
240
+        $this->allowSubsequentAttachmentUpload = (bool) $allowSubsequentAttachmentUpload;
241 241
         
242 242
         return $this;
243 243
     }
Please login to merge, or discard this patch.
Applications/src/Applications/Repository/Filter/PaginationQueryFactory.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -26,9 +26,9 @@  discard block
 block discarded – undo
26 26
  */
27 27
 class PaginationQueryFactory implements FactoryInterface
28 28
 {
29
-	public function __invoke( ContainerInterface $container, $requestedName, array $options = null )
29
+	public function __invoke(ContainerInterface $container, $requestedName, array $options = null)
30 30
 	{
31
-		$auth  = $container->get('AuthenticationService');
31
+		$auth = $container->get('AuthenticationService');
32 32
 		$filter = new PaginationQuery($auth);
33 33
 		return $filter;
34 34
 	}
@@ -44,6 +44,6 @@  discard block
 block discarded – undo
44 44
 	 */
45 45
     public function createService(ContainerInterface $container)
46 46
     {
47
-		return $this($container,PaginationQuery::class);
47
+		return $this($container, PaginationQuery::class);
48 48
     }
49 49
 }
Please login to merge, or discard this patch.
module/Applications/src/Applications/Listener/StatusChange.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
      *
69 69
      * @param ApplicationEvent $e
70 70
      */
71
-    public function prepareFormData(ApplicationEvent $e){
71
+    public function prepareFormData(ApplicationEvent $e) {
72 72
     	$target = $e->getTarget();
73 73
         if ($target->isPostRequest()) {
74 74
             return;
@@ -96,13 +96,13 @@  discard block
 block discarded – undo
96 96
                 $key = 'mailRejectionText';
97 97
                 break;
98 98
             default:
99
-                throw new \InvalidArgumentException('Unknown status value: ' .$status);
99
+                throw new \InvalidArgumentException('Unknown status value: '.$status);
100 100
         }
101
-        $mailText      = $settings->$key ? $settings->$key : '';
101
+        $mailText = $settings->$key ? $settings->$key : '';
102 102
         $mail->setBody($mailText);
103 103
         $mail->setApplication($this->application);
104 104
         $mailText = $mail->getBodyText();
105
-        $mailSubject   = sprintf(
105
+        $mailSubject = sprintf(
106 106
             $this->translator->translate('Your application dated %s'),
107 107
             strftime('%x', $this->application->getDateCreated()->getTimestamp())
108 108
         );
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
      *
123 123
      * @param ApplicationEvent $event
124 124
      */
125
-    public function sendMail(ApplicationEvent $event){
125
+    public function sendMail(ApplicationEvent $event) {
126 126
     	$event = $event->getTarget();
127 127
         if (!$event->isPostRequest()) {
128 128
             return;
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
         $this->mailService->send($mail);
170 170
 
171 171
 
172
-        $historyText = sprintf($this->translator->translate('Mail was sent to %s'), key($recipient) ?: $recipient[0] );
172
+        $historyText = sprintf($this->translator->translate('Mail was sent to %s'), key($recipient) ?: $recipient[0]);
173 173
         $this->application->changeStatus($status, $historyText);
174 174
         $event->setNotification($historyText);
175 175
     }
@@ -180,7 +180,7 @@  discard block
 block discarded – undo
180 180
      *
181 181
      * @return AddressList
182 182
      */
183
-    protected function getRecipient( Application $application, $status) {
183
+    protected function getRecipient(Application $application, $status) {
184 184
 
185 185
         $recipient = Status::ACCEPTED == $status
186 186
             ? $application->getJob()->getUser()->getInfo()
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
         $email = $recipient->getEmail();
190 190
         $name  = $recipient->getDisplayName(false);
191 191
 
192
-        return $name ? [ $email => $name ] : [ $email ];
192
+        return $name ? [$email => $name] : [$email];
193 193
     }
194 194
 
195 195
 }
196 196
\ No newline at end of file
Please login to merge, or discard this patch.
module/Applications/src/Applications/Factory/Mail/ConfirmationFactory.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
         $auth = $container->get('AuthenticationService');
31 31
         $user = $auth->getUser();
32 32
         $options['user'] = $user;
33
-        $mail   = new Confirmation($options);
33
+        $mail = new Confirmation($options);
34 34
 
35 35
         return $mail;
36 36
     }
Please login to merge, or discard this patch.
module/Applications/src/Applications/Controller/ConsoleController.php 1 patch
Spacing   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
                 
99 99
         echo "Generate keywords for $count applications ...\n";
100 100
         
101
-        $progress     = new ProgressBar($count);
101
+        $progress = new ProgressBar($count);
102 102
 
103 103
         /** @var \Core\Repository\Filter\PropertyToKeywords $filter */
104 104
         $filter = $this->filterManager->get('Core/Repository/PropertyToKeywords');
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
 
107 107
         /** @var \Applications\Entity\Application $application */
108 108
         foreach ($applications as $application) {
109
-            $progress->update($i++, 'Application ' . $i . ' / ' . $count);
109
+            $progress->update($i++, 'Application '.$i.' / '.$count);
110 110
             $keywords = $filter->filter($application);
111 111
             
112 112
             $application->setKeywords($keywords);
@@ -132,13 +132,13 @@  discard block
 block discarded – undo
132 132
     {
133 133
         $applications = $this->fetchApplications();
134 134
         $count = count($applications);
135
-        $i=0;
136
-        echo "Calculate rating for " . $count . " applications ...\n";
135
+        $i = 0;
136
+        echo "Calculate rating for ".$count." applications ...\n";
137 137
         
138 138
         $progress = new ProgressBar($count);
139 139
         /** @var  \Applications\Entity\Application $application */
140 140
         foreach ($applications as $application) {
141
-            $progress->update($i++, 'Application ' . $i . ' / ' . $count);
141
+            $progress->update($i++, 'Application '.$i.' / '.$count);
142 142
             $application->getRating(/* recalculate */ true);
143 143
         }
144 144
         $progress->update($i, 'Write to database...');
@@ -165,17 +165,17 @@  discard block
 block discarded – undo
165 165
         $documentManager = $this->documentManager;
166 166
 
167 167
         $count = count($applications);
168
-        $i=0;
168
+        $i = 0;
169 169
 
170
-        echo  $count . " applications in Draft Mode and older than " . $days . " days will be deleted\n";
170
+        echo  $count." applications in Draft Mode and older than ".$days." days will be deleted\n";
171 171
 
172 172
         $progress = new ProgressBar($count);
173 173
 
174 174
         foreach ($applications as $application) {
175
-            $progress->update($i++, 'Application ' . $i . ' / ' . $count);
175
+            $progress->update($i++, 'Application '.$i.' / '.$count);
176 176
             try {
177 177
                 $documentManager->remove($application);
178
-            } catch (\Exception $e){
178
+            } catch (\Exception $e) {
179 179
                 // log something
180 180
                 $e->getCode();
181 181
             }
@@ -199,17 +199,17 @@  discard block
 block discarded – undo
199 199
 
200 200
         $table->appendRow(array('Module', 'Name', 'Description'));
201 201
 
202
-        $offset=strlen(getcwd())+1;
203
-        $links="";
204
-        $github='https://github.com/cross-solution/YAWIK/blob/master/';
202
+        $offset = strlen(getcwd()) + 1;
203
+        $links = "";
204
+        $github = 'https://github.com/cross-solution/YAWIK/blob/master/';
205 205
 
206 206
         foreach ($config['view_manager']['template_map'] as $key => $absolute_filename) {
207 207
             // strip the application_root plus an additional slash
208
-            $filename=substr(realpath($absolute_filename), $offset);
208
+            $filename = substr(realpath($absolute_filename), $offset);
209 209
             if (preg_match('~module/([^/]+)~', $filename, $match)) {
210
-                $module=$match[1];
210
+                $module = $match[1];
211 211
             } else {
212
-                $module="not found ($key)";
212
+                $module = "not found ($key)";
213 213
             }
214 214
 
215 215
             $viewModel = new ViewModel();
@@ -218,17 +218,17 @@  discard block
 block discarded – undo
218 218
             $row = new Row();
219 219
             $row->appendColumn(new Column($module));
220 220
             if ($filename) {
221
-                $row->appendColumn(new Column('`' . $key . '`_'));
222
-                $links.='.. _'. $key .': '. $github.$filename .PHP_EOL;
221
+                $row->appendColumn(new Column('`'.$key.'`_'));
222
+                $links .= '.. _'.$key.': '.$github.$filename.PHP_EOL;
223 223
             } else {
224 224
                 $row->appendColumn(new Column("WRONG CONFIGURATION"));
225 225
             }
226
-            $comment="";
226
+            $comment = "";
227 227
             if (file_exists($absolute_filename)) {
228
-                $src=file_get_contents($absolute_filename);
229
-                $comment="file exists";
228
+                $src = file_get_contents($absolute_filename);
229
+                $comment = "file exists";
230 230
                 if (preg_match("/{{rtd:\s*(.*)}}/", $src, $match)) {
231
-                    $comment=$match['1'];
231
+                    $comment = $match['1'];
232 232
                 }
233 233
             }
234 234
             $row->appendColumn(new Column($comment));
@@ -245,7 +245,7 @@  discard block
 block discarded – undo
245 245
     {
246 246
         echo "Loading applications... ";
247 247
 
248
-        $filter       = \Zend\Json\Json::decode($this->params('filter', '{}'), \Zend\Json\Json::TYPE_ARRAY);
248
+        $filter = \Zend\Json\Json::decode($this->params('filter', '{}'), \Zend\Json\Json::TYPE_ARRAY);
249 249
         $filter['$or'] = array(
250 250
             array('attachments' => array('$exists' => 1)),
251 251
             array('contact.image' => array('$exists' => 1)),
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
             return;
260 260
         }
261 261
         $progress = new ProgressBar($count);
262
-        $i=0;
262
+        $i = 0;
263 263
 
264 264
         foreach ($applications as $app) {
265 265
             $progress->update($i++, "Process $i / $count");
Please login to merge, or discard this patch.
module/Applications/src/Applications/Controller/ApplyController.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
         return $ob;
73 73
     }
74 74
 	
75
-	public function setContainer( ContainerInterface $container )
75
+	public function setContainer(ContainerInterface $container)
76 76
 	{
77 77
 		$this->config            = $container->get('Config');
78 78
 		$this->imageCacheManager = $container->get('Organizations\ImageFileCache\Manager');
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
                 throw new \RuntimeException('Invalid application id.');
126 126
             }
127 127
 
128
-            $action     = 'process';
128
+            $action = 'process';
129 129
 
130 130
             $routeMatch->setParam('action', $action);
131 131
         } else {
@@ -209,14 +209,14 @@  discard block
 block discarded – undo
209 209
         
210 210
         $container->setEntity($application);
211 211
         $this->configureContainer($container);
212
-        $this->formContainer     = $container;
212
+        $this->formContainer = $container;
213 213
     }
214 214
     
215 215
     public function jobNotFoundAction()
216 216
     {
217 217
         $this->response->setStatusCode(410);
218 218
         $model = new ViewModel(
219
-            [ 'content' => /*@translate*/ 'Invalid apply id']
219
+            ['content' => /*@translate*/ 'Invalid apply id']
220 220
         );
221 221
         $model->setTemplate('applications/error/not-found');
222 222
         return $model;
@@ -335,7 +335,7 @@  discard block
 block discarded – undo
335 335
         $postData  = $form->getOption('use_post_array') ? $params->fromPost() : array();
336 336
 	    //@TODO: [ZF3] option use_files_array is false by default
337 337
         //$filesData = $form->getOption('use_files_array') ? $params->fromFiles() : array();
338
-        $form->setData(array_merge($postData,$_FILES));
338
+        $form->setData(array_merge($postData, $_FILES));
339 339
         
340 340
         if (!$form->isValid()) {
341 341
             return new JsonModel(
@@ -397,13 +397,13 @@  discard block
 block discarded – undo
397 397
         }
398 398
 
399 399
         if ('previewmail' == $this->params()->fromQuery('do')) {
400
-            $this->mailer('Applications/CarbonCopy', [ 'application' => $application], true);
400
+            $this->mailer('Applications/CarbonCopy', ['application' => $application], true);
401 401
             $this->notification()->success(/*@translate*/ 'Mail has been send');
402 402
             return new JsonModel();
403 403
         }
404 404
 
405 405
         if ('sendmail' == $this->params()->fromQuery('do')) {
406
-            $jobEntity         = $application->getJob();
406
+            $jobEntity = $application->getJob();
407 407
 
408 408
             $mailData = array(
409 409
                 'application' => $application,
@@ -434,8 +434,8 @@  discard block
 block discarded – undo
434 434
 
435 435
         $repositories->store($application);
436 436
         
437
-        $events   = $this->appEvents;
438
-        $events->trigger(ApplicationEvent::EVENT_APPLICATION_POST_CREATE, $this, [ 'application' => $application ]);
437
+        $events = $this->appEvents;
438
+        $events->trigger(ApplicationEvent::EVENT_APPLICATION_POST_CREATE, $this, ['application' => $application]);
439 439
 
440 440
         $model = new ViewModel(
441 441
             array(
Please login to merge, or discard this patch.