ApiApplyController::indexAction() - Code Metrics - Inspection of "Merge pull request #588: application api" - cross-solution/YAWIK - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0913ed...15a2b1 )

by Mathias

created 2020-07-24 16:42 UTC

ApiApplyController::indexAction() A

↳ Parent: ApiApplyController

Complexity

Conditions	4
Paths	4

Size

Total Lines	54
Code Lines	32

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
eloc	32
c	2
b	0
f	1
dl	0
loc	54
ccs	0
cts	41
cp	0
rs	9.408
cc	4
nc	4
nop	0
crap	20

How to fix Long Method

<?php

/**
 * YAWIK
 *
 * @filesource
 * @copyright 2020 CROSS Solution <https://www.cross-solution.de>
 * @license MIT
 */

declare(strict_types=1);

namespace Applications\Controller;

use Applications\Entity\Contact;
use Applications\Entity\Hydrator\ApiApplicationHydrator;
use Applications\Repository\Application as ApplicationsRepository;
use Auth\Entity\AnonymousUser;
use Jobs\Repository\Job as JobsRepository;
use Laminas\Mvc\Controller\AbstractActionController;
use Laminas\View\Model\JsonModel;

/**
 * TODO: description
 *
 * @author Mathias Gelhausen <[email protected]>
 * TODO: write tests
 */
class ApiApplyController extends AbstractActionController
{
    private $appRepository;
    private $jobRepository;
    private $formContainer;
    private $hydrator;

    public function __construct(
        ApplicationsRepository $appRepository,
        JobsRepository $jobRepository,
        $formContainer,
        ApiApplicationHydrator $hydrator
    ) {
        $this->appRepository = $appRepository;
        $this->jobRepository = $jobRepository;
        $this->formContainer = $formContainer;
        $this->hydrator = $hydrator;
    }

    public function indexAction()
    {
        /** @var \Laminas\Http\PhpEnvironment\Request $request */
        $request = $this->getRequest();
        if (!$request->isPost()) {
            return $this->noPostRequestModel();
        }

        $applyId = $this->params()->fromQuery('applyId');
        $job = $this->jobRepository->findOneBy(['applyId' => $applyId]);

        if (!$job) {

            return $this->noJobFoundModel($applyId);
        }

        $data = array_merge_recursive(
            $request->getPost()->toArray(),
            $request->getFiles()->toArray()
        );


        $application = $this->appRepository->create();
        $application->setJob($job);
        $user = $this->auth()->getUser();
        $user = $this->auth()->/** @scrutinizer ignore-call */ getUser();
        $application->setUser($user);
        $application->setContact(new Contact());

        $hydrator = $this->hydrator;
        $hydrator->hydrate($data, $application);
        //$application->getContact()->setFirstName($data['contact']['firstName']);


        $this->appRepository->store($application);

        $result = [
            'status' => 'OK',
            'id' => $application->getId(),
            'entity' => $hydrator->extract($application)
        ];

        if ($user instanceof AnonymousUser) {
            $result['track'] =
                $this->url()->fromRoute(
                    'lang/applications/detail',
                    ['id' => $application->getId()],
                    ['force_canonical' => true],
                    true
                )
                . '?token=' . $user->getToken()
            ;
        }

        $model = new JsonModel($result);
        return $model;
    }

    private function noPostRequestModel()
    {
        /** @var \Laminas\Http\PhpEnvironment\Response $response */
        $response = $this->getResponse();
        $response->setStatusCode($response::STATUS_CODE_405);

        return new JsonModel([
            'status' => 'error',
            'message' => 'Invalid request method. Only POST allowed.'
        ]);
    }

    private function invalidDataModel($e)

    {
        /** @var \Laminas\Http\PhpEnvironment\Response $response */
        $response = $this->getResponse();
        $response->setStatusCode($response::STATUS_CODE_405);

        return new JsonModel([
            'status' => 'error',
            'message' => 'Invalid json data: ' . $e->getMessage()
        ]);
    }

    private function noJobFoundModel($applyId)
    {
        /** @var \Laminas\Http\PhpEnvironment\Response $response */
        $response = $this->getResponse();
        $response->setStatusCode($response::STATUS_CODE_400);

        return new JsonModel([
            'status' => 'error',
            'message' => 'No job found with apply id "' . $applyId . '"',
        ]);
    }

    private function invalidApplicationDataModel()

    {
        /** @var \Laminas\Http\PhpEnvironment\Response $response */
        $response = $this->getResponse();
        $response->setStatusCode($response::STATUS_CODE_400);

        return new JsonModel([
            'status' => 'error',
            'message' => 'Invalid application data.',
            'errrors' => $this->formContainer->getMessages()
        ]);
    }
}


cross-solution / YAWIK

Push — master ( 0913ed...15a2b1 )

ApiApplyController::indexAction() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like