Inspection of "Queue jobs use new MongoJob::create method" - cross-solution/YAWIK - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 0de0ee...1049f6 )

by Mathias

created 2019-02-13 10:48 UTC

Status

Indentation +43 added lines, -43 removed lines patch added patch discarded remove patch

@@ -129,62 +129,62 @@  discard block
 block discarded – undo
                 ->will($this->returnValue('<html />'));
 
         $this->viewPhpRendererStrategy = $this->getMockBuilder('\Zend\View\Strategy\PhpRendererStrategy')
-                          ->disableOriginalConstructor()
-                          ->getMock();
+                            ->disableOriginalConstructor()
+                            ->getMock();
 
         $this->viewPhpRendererStrategy->expects($this->once())
-                          ->method('getRenderer')
-                          ->will($this->returnValue($this->renderer));
+                            ->method('getRenderer')
+                            ->will($this->returnValue($this->renderer));
 
         $this->response = $this->getMockBuilder('\Zend\Http\Response')
-                                              ->disableOriginalConstructor()
-                                              ->getMock();
+                                                ->disableOriginalConstructor()
+                                                ->getMock();
 
         $this->jobEvent = $this->getMockBuilder('\Jobs\Listener\Events\JobEvent')
-                               ->disableOriginalConstructor()
-                               ->getMock();
+                                ->disableOriginalConstructor()
+                                ->getMock();
 
         $this->job = $this->getMockBuilder('\Jobs\Entity\Job')
-                          ->disableOriginalConstructor()
-                          ->getMock();
+                            ->disableOriginalConstructor()
+                            ->getMock();
 
         $this->publisher = $this->getMockBuilder('\Jobs\Entity\Publisher')
-                          ->disableOriginalConstructor()
-                          ->getMock();
+                            ->disableOriginalConstructor()
+                            ->getMock();
 
         $this->publisher->expects($this->at(0))
-                           ->method('__get')
-                           ->with('externalId')
-                           ->will($this->returnValue('externalId32'));
+                            ->method('__get')
+                            ->with('externalId')
+                            ->will($this->returnValue('externalId32'));
 
         $this->publisher->expects($this->at(1))
-                           ->method('__get')
-                           ->with('reference')
-                           ->will($this->returnValue('reference32'));
+                            ->method('__get')
+                            ->with('reference')
+                            ->will($this->returnValue('reference32'));
 
         $this->publisher->expects($this->any())
-                              ->method('__set')
-                              ->will($this->returnCallback($staticClassPrefix . 'publisherSetter'));
+                                ->method('__set')
+                                ->will($this->returnCallback($staticClassPrefix . 'publisherSetter'));
 
         $this->htmlAbsPathFilter = $this->getMockBuilder('\Core\Filter\HtmlAbsPathFilter')
                                     ->disableOriginalConstructor()
                                     ->getMock();
 
         $this->htmlAbsPathFilter->expects($this->any())
-                              ->method('filter')
-                              ->will($this->returnCallback($staticClassPrefix . 'absPathFilter'));
+                                ->method('filter')
+                                ->will($this->returnCallback($staticClassPrefix . 'absPathFilter'));
 
         $this->filterManager = $this->getMockBuilder('\Zend\ServiceManager\ServiceManager')
-                                     ->disableOriginalConstructor()
-                                     ->getMock();
+                                        ->disableOriginalConstructor()
+                                        ->getMock();
 
         $this->filterManager->expects($this->at(0))
                         ->method('get')
                         ->willReturn($this->htmlAbsPathFilter);
 
         $this->restClient = $this->getMockBuilder('\Core\Service\RestClient')
-                                 ->disableOriginalConstructor()
-                                 ->getMock();
+                                    ->disableOriginalConstructor()
+                                    ->getMock();
 
         //$this->restClient->expects($this->at(0))
         //                   ->method('getHost')
@@ -200,8 +200,8 @@  discard block
 block discarded – undo
             ->will($this->returnValue($this->response));
 
         $this->organization = $this->getMockBuilder('\Organizations\Entity\Organization')
-                                 ->disableOriginalConstructor()
-                                 ->getMock();
+                                    ->disableOriginalConstructor()
+                                    ->getMock();
 
         $this->organization->expects($this->at(0))
                         ->method('__get')
@@ -209,21 +209,21 @@  discard block
 block discarded – undo
                         ->will($this->returnValue('name32'));
 
         $this->provider = $this->getMockBuilder('\Jobs\Options\ProviderOptions')
-                                   ->disableOriginalConstructor()
-                                   ->getMock();
+                                    ->disableOriginalConstructor()
+                                    ->getMock();
 
         $this->providerChannel = $this->getMockBuilder('\Jobs\Options\ChannelOptions')
-                                      ->disableOriginalConstructor()
-                                      ->getMock();
+                                        ->disableOriginalConstructor()
+                                        ->getMock();
 
         $this->providerChannel->expects($this->any())
-                              ->method('__get')
-                              ->will($this->returnCallback($staticClassPrefix . 'providerChannelGetter'));
+                                ->method('__get')
+                                ->will($this->returnCallback($staticClassPrefix . 'providerChannelGetter'));
 
         $this->provider->expects($this->any(0))
-                       ->method('__get')
-                       ->with('channels')
-                       ->willReturn(array('bbb value' => $this->providerChannel));
+                        ->method('__get')
+                        ->with('channels')
+                        ->willReturn(array('bbb value' => $this->providerChannel));
 
         $this->viewModel = $this->getMockBuilder('\Zend\View\Model\ViewModel')
                                 ->disableOriginalConstructor()
@@ -304,12 +304,12 @@  discard block
 block discarded – undo
     protected function setRestReturn($referenceUpdate, $applyIdUpdate)
     {
         $this->response->expects($this->any())
-                       ->method('getBody')
-                       ->will($this->returnValue(json_encode(
-                           array(
-                               'referenceUpdate' => $referenceUpdate,
-                               'applyIdUpdate' => $applyIdUpdate
-                           ))));
+                        ->method('getBody')
+                        ->will($this->returnValue(json_encode(
+                            array(
+                                'referenceUpdate' => $referenceUpdate,
+                                'applyIdUpdate' => $applyIdUpdate
+                            ))));
     }
 
 

Please login to merge, or discard this patch.

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -110,7 +110,7 @@  discard block
 block discarded – undo
         
         $this->target = new Publisher($this->serviceManager);
 
-        $staticClassPrefix = '\\' . __CLASS__ . '::';
+        $staticClassPrefix = '\\'.__CLASS__.'::';
 
         $this->log = $this->getMockBuilder('\Zend\Log\Logger')
             ->disableOriginalConstructor()
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
 
         $this->publisher->expects($this->any())
                               ->method('__set')
-                              ->will($this->returnCallback($staticClassPrefix . 'publisherSetter'));
+                              ->will($this->returnCallback($staticClassPrefix.'publisherSetter'));
 
         $this->htmlAbsPathFilter = $this->getMockBuilder('\Core\Filter\HtmlAbsPathFilter')
                                     ->disableOriginalConstructor()
@@ -172,7 +172,7 @@  discard block
 block discarded – undo
 
         $this->htmlAbsPathFilter->expects($this->any())
                               ->method('filter')
-                              ->will($this->returnCallback($staticClassPrefix . 'absPathFilter'));
+                              ->will($this->returnCallback($staticClassPrefix.'absPathFilter'));
 
         $this->filterManager = $this->getMockBuilder('\Zend\ServiceManager\ServiceManager')
                                      ->disableOriginalConstructor()
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
 
         $this->providerChannel->expects($this->any())
                               ->method('__get')
-                              ->will($this->returnCallback($staticClassPrefix . 'providerChannelGetter'));
+                              ->will($this->returnCallback($staticClassPrefix.'providerChannelGetter'));
 
         $this->provider->expects($this->any(0))
                        ->method('__get')

Please login to merge, or discard this patch.

module/Jobs/test/JobsTest/Listener/GetOrganizationManagersTest.php 2 patches

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -107,7 +107,7 @@
 block discarded – undo
 
         $wf = new WorkflowSettings();
         $wf->setAcceptApplicationByDepartmentManager($flag('acceptApplication'))
-           ->setAssignDepartmentManagersToJobs($flag('assignManagers'));
+            ->setAssignDepartmentManagersToJobs($flag('assignManagers'));
 
         $org->expects($this->once())->method('getWorkflowSettings')->willReturn($wf);
 

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -199,7 +199,7 @@
 block discarded – undo
 
         $actual = $this->target->__invoke($event);
 
-        $this->assertTrue(is_array($actual),'Listener did not return an array!');
+        $this->assertTrue(is_array($actual), 'Listener did not return an array!');
         $this->assertArrayHasKey('status', $actual);
         $this->assertEquals('disabled', $actual['status']);
     }

Please login to merge, or discard this patch.

module/Jobs/test/JobsTest/Acl/WriteAssertionTest.php 1 patch

Spacing +21 added lines, -21 removed lines patch added patch discarded remove patch

@@ -65,19 +65,19 @@  discard block
 block discarded – undo
 
         $privileges = array('new', 'test', 'edit');
 
-        foreach(array($role, $user) as $testObj)
+        foreach (array($role, $user) as $testObj)
         {
             // non user is always false?
-            foreach($privileges as $p)
+            foreach ($privileges as $p)
             {
-                $this->assertFalse((bool)$target->assert($acl, $testObj, null, $p));
+                $this->assertFalse((bool) $target->assert($acl, $testObj, null, $p));
             }
 
             // user and wrong privilege is false?
-            foreach($privileges as $p)
+            foreach ($privileges as $p)
             {
                 // Casting null to false is safe here, 'edit' for pair user-privilege tested after
-                $this->assertFalse((bool)$target->assert($acl, $testObj, $job, $p));
+                $this->assertFalse((bool) $target->assert($acl, $testObj, $job, $p));
             }
         }
 
@@ -117,15 +117,15 @@  discard block
 block discarded – undo
         //$user->setOrganization($organization);
 
         /** Organization without user **/
-        $this->assertFalse( $assertion->checkOrganizationPermissions( $user, $job ) );
+        $this->assertFalse($assertion->checkOrganizationPermissions($user, $job));
     }
 
     /**
      * @dataProvider assertParametersWithoutOrganization
      */
-    public function testAssertWithoutOrganisation($input, $expected){
+    public function testAssertWithoutOrganisation($input, $expected) {
 
-            $method="assert".($expected?"True":"False");
+            $method = "assert".($expected ? "True" : "False");
 
             $this->$method(
                 $this->target->assert(
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
 
     }
 
-    public function assertParametersWithoutOrganization(){
+    public function assertParametersWithoutOrganization() {
 
         $userId = 1234;
         $user = new User();
@@ -163,13 +163,13 @@  discard block
 block discarded – undo
 
 
         return [
-            [[new Acl(), null, null, null] , false ],
-            [[new Acl(), null, null, Permissions::PERMISSION_CHANGE] , false ],
-            [[new Acl(), $user, $jobMock, 'edit'] , true ],
+            [[new Acl(), null, null, null], false],
+            [[new Acl(), null, null, Permissions::PERMISSION_CHANGE], false],
+            [[new Acl(), $user, $jobMock, 'edit'], true],
         ];
     }
 
-    public function testAssertUserIsOrganizationAdmin(){
+    public function testAssertUserIsOrganizationAdmin() {
 
         $userId = 1234;
         $user = new User();
@@ -192,13 +192,13 @@  discard block
 block discarded – undo
         $this->assertTrue(
             $this->target->assert(
                 new Acl(), // acl
-                $user,     // role
-                $jobMock,  // resource
+                $user, // role
+                $jobMock, // resource
                 'edit'     // privilege
             ));
     }
 
-    public function testAssertUserIsOwnerOfTheParentOrganization(){
+    public function testAssertUserIsOwnerOfTheParentOrganization() {
 
         $userId = 1234;
         $user = new User();
@@ -225,13 +225,13 @@  discard block
 block discarded – undo
         $this->assertTrue(
             $this->target->assert(
                 new Acl(), // acl
-                $user,     // role
-                $jobMock,  // resource
+                $user, // role
+                $jobMock, // resource
                 'edit'     // privilege
             ));
     }
 
-    public function testUserIsEmployeeWithJobsChangePermissions(){
+    public function testUserIsEmployeeWithJobsChangePermissions() {
 
         $userId = 1234;
         $user = new User();
@@ -265,8 +265,8 @@  discard block
 block discarded – undo
         $this->assertTrue(
             $this->target->assert(
                 new Acl(), // acl
-                $user,     // role
-                $jobMock,  // resource
+                $user, // role
+                $jobMock, // resource
                 'edit'     // privilege
             ));
     }

Please login to merge, or discard this patch.

module/Jobs/test/TestConfig.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -2,7 +2,7 @@
 block discarded – undo
 $commonModules = include_once __DIR__.'/../../../config/common.modules.php';
 
 return array(
-    'modules' => array_merge($commonModules,array(
+    'modules' => array_merge($commonModules, array(
         'Core',
         'Auth',
         'Jobs',

Please login to merge, or discard this patch.

module/Auth/test/Bootstrap.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -1,6 +1,6 @@
 block discarded – undo
 <?php
 
 /** @var array $testConfig */
-$testConfig = include __DIR__ . '/TestConfig.php';
+$testConfig = include __DIR__.'/TestConfig.php';
 
-require_once __DIR__ . '/../../../test/Bootstrap.php';
+require_once __DIR__.'/../../../test/Bootstrap.php';

Please login to merge, or discard this patch.

module/Auth/test/TestConfig.php 2 patches

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -6,9 +6,9 @@  discard block
 block discarded – undo
     // This should be an array of module namespaces used in the application.
     'modules' => array_merge($commonModules,array(
         'Core',
-	    'Auth',
-	    'Jobs',
-	    'Organizations',
+        'Auth',
+        'Jobs',
+        'Organizations',
     )),
 
     // These are various options for the listeners attached to the ModuleManager
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
     //     ),
     // )
 
-   // Initial configuration with which to seed the ServiceManager.
-   // Should be compatible with Zend\ServiceManager\Config.
-   // 'service_manager' => array(),
+    // Initial configuration with which to seed the ServiceManager.
+    // Should be compatible with Zend\ServiceManager\Config.
+    // 'service_manager' => array(),
 );

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -4,7 +4,7 @@
 block discarded – undo
 
 return array(
     // This should be an array of module namespaces used in the application.
-    'modules' => array_merge($commonModules,array(
+    'modules' => array_merge($commonModules, array(
         'Core',
 	    'Auth',
 	    'Jobs',

Please login to merge, or discard this patch.

Auth/test/AclTest/Assertion/AbstractEventManagerAwareAssertionTest.php 2 patches

Indentation +16 added lines, -16 removed lines patch added patch discarded remove patch

@@ -85,12 +85,12 @@  discard block
 block discarded – undo
         $acl    = new Acl();
 
         $events = $this->getMockBuilder('\Zend\EventManager\EventManager')
-                       ->disableOriginalConstructor()
-                       ->getMock();
+                        ->disableOriginalConstructor()
+                        ->getMock();
 
         $events->expects($this->once())
-               ->method('triggerUntil')
-               ->willReturn(new ResponseCollection());
+                ->method('triggerUntil')
+                ->willReturn(new ResponseCollection());
 
         $target->setEventManager($events);
 
@@ -112,12 +112,12 @@  discard block
 block discarded – undo
         $responseFalse = $this->createResponseMock(false);
 
         $events = $this->getMockBuilder('\Zend\EventManager\EventManager')
-                       ->disableOriginalConstructor()
-                       ->getMock();
+                        ->disableOriginalConstructor()
+                        ->getMock();
 
         $events->expects($this->exactly(5))
-               ->method('triggerUntil')
-               ->will($this->onConsecutiveCalls($responseNull, $responseEmpty, $responseZero, $responseTrue, $responseFalse));
+                ->method('triggerUntil')
+                ->will($this->onConsecutiveCalls($responseNull, $responseEmpty, $responseZero, $responseTrue, $responseFalse));
 
         $target->setEventManager($events);
 
@@ -133,8 +133,8 @@  discard block
 block discarded – undo
     protected function createResponseMock($returnValue)
     {
         $response = $this->getMockBuilder('\Zend\EventManager\ResponseCollection')
-                             ->disableOriginalConstructor()
-                             ->getMock();
+                                ->disableOriginalConstructor()
+                                ->getMock();
         $response->method('last')->willReturn($returnValue);
 
         return $response;
@@ -145,8 +145,8 @@  discard block
 block discarded – undo
         $target = new TargetMock();
 
         $events = $this->getMockBuilder('\Zend\EventManager\EventManager')
-                       ->disableOriginalConstructor()
-                       ->getMock();
+                        ->disableOriginalConstructor()
+                        ->getMock();
 
         $acl = new Acl();
         $role = new GenericRole('testRole');
@@ -155,16 +155,16 @@  discard block
 block discarded – undo
         $self = $this;
 
         $events->expects($this->once())->method('triggerUntil')
-               ->will($this->returnCallback(function ($callback,$eventName,$event) use ($acl, $role, $resource, $privilege, $self) {
-               	    $self->assertTrue(is_callable($callback));
-	                $self->assertEquals('assert',$eventName);
+                ->will($this->returnCallback(function ($callback,$eventName,$event) use ($acl, $role, $resource, $privilege, $self) {
+                        $self->assertTrue(is_callable($callback));
+                    $self->assertEquals('assert',$eventName);
                     $self->assertSame($acl, $event->getAcl());
                     $self->assertSame($role, $event->getRole());
                     $self->assertSame($resource, $event->getResource());
                     $self->assertSame($privilege, $event->getPrivilege());
 
                     return new ResponseCollection();
-               }));
+                }));
 
         $target->setEventManager($events);
         $target->assert($acl, $role, $resource, $privilege);

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -155,9 +155,9 @@
 block discarded – undo
         $self = $this;
 
         $events->expects($this->once())->method('triggerUntil')
-               ->will($this->returnCallback(function ($callback,$eventName,$event) use ($acl, $role, $resource, $privilege, $self) {
+               ->will($this->returnCallback(function($callback, $eventName, $event) use ($acl, $role, $resource, $privilege, $self) {
                	    $self->assertTrue(is_callable($callback));
-	                $self->assertEquals('assert',$eventName);
+	                $self->assertEquals('assert', $eventName);
                     $self->assertSame($acl, $event->getAcl());
                     $self->assertSame($role, $event->getRole());
                     $self->assertSame($resource, $event->getResource());

Please login to merge, or discard this patch.

module/Auth/test/AclTest/Assertion/AssertionManagerFactoryTest.php 2 patches

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -31,11 +31,11 @@  discard block
 block discarded – undo
     public function testCreateServiceReturnsAssertionManager()
     {
         $services = $this->getMockBuilder('\Zend\ServiceManager\ServiceManager')
-                         ->disableOriginalConstructor()
-                         ->getMock();
+                            ->disableOriginalConstructor()
+                            ->getMock();
 
         $services->expects($this->once())->method('get')->with('Config')
-                 ->willReturn(array());
+                    ->willReturn(array());
 
         $target = new AssertionManagerFactory();
         $manager = $target->__invoke($services,AssertionManager::class);
@@ -53,11 +53,11 @@  discard block
 block discarded – undo
     public function testCorrectConfigIsUsedToConfigureTheManager($config, $testName, $testResult)
     {
         $services = $this->getMockBuilder('\Zend\ServiceManager\ServiceManager')
-                         ->disableOriginalConstructor()
-                         ->getMock();
+                            ->disableOriginalConstructor()
+                            ->getMock();
 
         $services->expects($this->once())->method('get')->with('Config')
-                 ->willReturn($config);
+                    ->willReturn($config);
 
         $target = new AssertionManagerFactory();
 

Please login to merge, or discard this patch.

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -38,7 +38,7 @@  discard block
 block discarded – undo
                  ->willReturn(array());
 
         $target = new AssertionManagerFactory();
-        $manager = $target->__invoke($services,AssertionManager::class);
+        $manager = $target->__invoke($services, AssertionManager::class);
 
         $this->assertInstanceOf('\Acl\Assertion\AssertionManager', $manager);
         //$this->assertFalse($manager->shareByDefault(), 'The managers\' shareByDefault value must be set to FALSE by the factory.');
@@ -61,9 +61,9 @@  discard block
 block discarded – undo
 
         $target = new AssertionManagerFactory();
 
-        $manager = $target->__invoke($services,AssertionManager::class);
+        $manager = $target->__invoke($services, AssertionManager::class);
 
-        $this->assertTrue($testResult === $manager->has($testName), 'Expected managers\' has method to return ' . ($testResult ? 'TRUE' : 'FALSE') . ' on ' .$testName);
+        $this->assertTrue($testResult === $manager->has($testName), 'Expected managers\' has method to return '.($testResult ? 'TRUE' : 'FALSE').' on '.$testName);
     }
 
     public function provideConfigArrays()

Please login to merge, or discard this patch.

module/Auth/test/AclTest/Assertion/AssertionManagerTest.php 1 patch

Indentation +26 added lines, -26 removed lines patch added patch discarded remove patch

@@ -68,35 +68,35 @@  discard block
 block discarded – undo
     public function testInjectEventManagerInitializerCallbackGetsEventManagerFromServicesIfNotSetInAssertion()
     {
         $assertion = $this
-	        ->getMockForAbstractClass('\AclTest\Assertion\EventManagerAwareAssertionMock')
+            ->getMockForAbstractClass('\AclTest\Assertion\EventManagerAwareAssertionMock')
         ;
         $services = $this->getMockBuilder('\Zend\ServiceManager\AbstractPluginManager')
-	        ->disableOriginalConstructor()
-	        ->getMock()
+            ->disableOriginalConstructor()
+            ->getMock()
         ;
         $parentServices = $this
-	        ->getMockBuilder('\Zend\ServiceManager\ServiceManager')
-	        ->disableOriginalConstructor()
-	        ->getMock()
+            ->getMockBuilder('\Zend\ServiceManager\ServiceManager')
+            ->disableOriginalConstructor()
+            ->getMock()
         ;
         $events = new EventManager();
-	    $target = new AssertionManager($parentServices);
+        $target = new AssertionManager($parentServices);
         $assertion
-	        ->expects($this->once())
-	        ->method('getEventManager')
-	        ->willReturn(null)
+            ->expects($this->once())
+            ->method('getEventManager')
+            ->willReturn(null)
         ;
         $assertion
-	        ->expects($this->once())
-	        ->method('setEventManager')
-	        ->with($events)
+            ->expects($this->once())
+            ->method('setEventManager')
+            ->with($events)
         ;
 
         $parentServices
-	        ->expects($this->once())
-	        ->method('get')
-	        ->with('EventManager')
-	        ->willReturn($events)
+            ->expects($this->once())
+            ->method('get')
+            ->with('EventManager')
+            ->willReturn($events)
         ;
         /*
          * Wanted to use:
@@ -115,8 +115,8 @@  discard block
 block discarded – undo
         $target = new AssertionManager($this->serviceManager);
         $assertion = $this->getMockForAbstractClass('\AclTest\Assertion\EventManagerAwareAssertionMock');
         $services = $this->getMockBuilder('\Zend\ServiceManager\AbstractPluginManager')
-	        ->disableOriginalConstructor()
-	        ->getMock()
+            ->disableOriginalConstructor()
+            ->getMock()
         ;
         
         $parentServices = $this->getMockBuilder('\Zend\ServiceManager\ServiceManager')->disableOriginalConstructor()->getMock();
@@ -126,15 +126,15 @@  discard block
 block discarded – undo
         //$services->setServiceLocator($parentServices);
 
         $parentServices
-	        ->expects($this->never())
-	        ->method('get')
-	        //->with('SharedEventManager')
-	        //->willReturn($sharedEvents)
+            ->expects($this->never())
+            ->method('get')
+            //->with('SharedEventManager')
+            //->willReturn($sharedEvents)
         ;
         $assertion
-	        ->expects($this->once())
-	        ->method('getEventManager')
-	        ->willReturn($events)
+            ->expects($this->once())
+            ->method('getEventManager')
+            ->willReturn($events)
         ;
 
         $this->assertNull($target->injectEventManager($assertion, $services));

Please login to merge, or discard this patch.

		@@ -129,62 +129,62 @@ discard block
		block discarded – undo
129	129	->will($this->returnValue('<html />'));
130	130
131	131	$this->viewPhpRendererStrategy = $this->getMockBuilder('\Zend\View\Strategy\PhpRendererStrategy')
132		- ->disableOriginalConstructor()
133		- ->getMock();
	132	+ ->disableOriginalConstructor()
	133	+ ->getMock();
134	134
135	135	$this->viewPhpRendererStrategy->expects($this->once())
136		- ->method('getRenderer')
137		- ->will($this->returnValue($this->renderer));
	136	+ ->method('getRenderer')
	137	+ ->will($this->returnValue($this->renderer));
138	138
139	139	$this->response = $this->getMockBuilder('\Zend\Http\Response')
140		- ->disableOriginalConstructor()
141		- ->getMock();
	140	+ ->disableOriginalConstructor()
	141	+ ->getMock();
142	142
143	143	$this->jobEvent = $this->getMockBuilder('\Jobs\Listener\Events\JobEvent')
144		- ->disableOriginalConstructor()
145		- ->getMock();
	144	+ ->disableOriginalConstructor()
	145	+ ->getMock();
146	146
147	147	$this->job = $this->getMockBuilder('\Jobs\Entity\Job')
148		- ->disableOriginalConstructor()
149		- ->getMock();
	148	+ ->disableOriginalConstructor()
	149	+ ->getMock();
150	150
151	151	$this->publisher = $this->getMockBuilder('\Jobs\Entity\Publisher')
152		- ->disableOriginalConstructor()
153		- ->getMock();
	152	+ ->disableOriginalConstructor()
	153	+ ->getMock();
154	154
155	155	$this->publisher->expects($this->at(0))
156		- ->method('__get')
157		- ->with('externalId')
158		- ->will($this->returnValue('externalId32'));
	156	+ ->method('__get')
	157	+ ->with('externalId')
	158	+ ->will($this->returnValue('externalId32'));
159	159
160	160	$this->publisher->expects($this->at(1))
161		- ->method('__get')
162		- ->with('reference')
163		- ->will($this->returnValue('reference32'));
	161	+ ->method('__get')
	162	+ ->with('reference')
	163	+ ->will($this->returnValue('reference32'));
164	164
165	165	$this->publisher->expects($this->any())
166		- ->method('__set')
167		- ->will($this->returnCallback($staticClassPrefix . 'publisherSetter'));
	166	+ ->method('__set')
	167	+ ->will($this->returnCallback($staticClassPrefix . 'publisherSetter'));
168	168
169	169	$this->htmlAbsPathFilter = $this->getMockBuilder('\Core\Filter\HtmlAbsPathFilter')
170	170	->disableOriginalConstructor()
171	171	->getMock();
172	172
173	173	$this->htmlAbsPathFilter->expects($this->any())
174		- ->method('filter')
175		- ->will($this->returnCallback($staticClassPrefix . 'absPathFilter'));
	174	+ ->method('filter')
	175	+ ->will($this->returnCallback($staticClassPrefix . 'absPathFilter'));
176	176
177	177	$this->filterManager = $this->getMockBuilder('\Zend\ServiceManager\ServiceManager')
178		- ->disableOriginalConstructor()
179		- ->getMock();
	178	+ ->disableOriginalConstructor()
	179	+ ->getMock();
180	180
181	181	$this->filterManager->expects($this->at(0))
182	182	->method('get')
183	183	->willReturn($this->htmlAbsPathFilter);
184	184
185	185	$this->restClient = $this->getMockBuilder('\Core\Service\RestClient')
186		- ->disableOriginalConstructor()
187		- ->getMock();
	186	+ ->disableOriginalConstructor()
	187	+ ->getMock();
188	188
189	189	//$this->restClient->expects($this->at(0))
190	190	// ->method('getHost')
		@@ -200,8 +200,8 @@ discard block
		block discarded – undo
200	200	->will($this->returnValue($this->response));
201	201
202	202	$this->organization = $this->getMockBuilder('\Organizations\Entity\Organization')
203		- ->disableOriginalConstructor()
204		- ->getMock();
	203	+ ->disableOriginalConstructor()
	204	+ ->getMock();
205	205
206	206	$this->organization->expects($this->at(0))
207	207	->method('__get')
		@@ -209,21 +209,21 @@ discard block
		block discarded – undo
209	209	->will($this->returnValue('name32'));
210	210
211	211	$this->provider = $this->getMockBuilder('\Jobs\Options\ProviderOptions')
212		- ->disableOriginalConstructor()
213		- ->getMock();
	212	+ ->disableOriginalConstructor()
	213	+ ->getMock();
214	214
215	215	$this->providerChannel = $this->getMockBuilder('\Jobs\Options\ChannelOptions')
216		- ->disableOriginalConstructor()
217		- ->getMock();
	216	+ ->disableOriginalConstructor()
	217	+ ->getMock();
218	218
219	219	$this->providerChannel->expects($this->any())
220		- ->method('__get')
221		- ->will($this->returnCallback($staticClassPrefix . 'providerChannelGetter'));
	220	+ ->method('__get')
	221	+ ->will($this->returnCallback($staticClassPrefix . 'providerChannelGetter'));
222	222
223	223	$this->provider->expects($this->any(0))
224		- ->method('__get')
225		- ->with('channels')
226		- ->willReturn(array('bbb value' => $this->providerChannel));
	224	+ ->method('__get')
	225	+ ->with('channels')
	226	+ ->willReturn(array('bbb value' => $this->providerChannel));
227	227
228	228	$this->viewModel = $this->getMockBuilder('\Zend\View\Model\ViewModel')
229	229	->disableOriginalConstructor()
		@@ -304,12 +304,12 @@ discard block
		block discarded – undo
304	304	protected function setRestReturn($referenceUpdate, $applyIdUpdate)
305	305	{
306	306	$this->response->expects($this->any())
307		- ->method('getBody')
308		- ->will($this->returnValue(json_encode(
309		- array(
310		- 'referenceUpdate' => $referenceUpdate,
311		- 'applyIdUpdate' => $applyIdUpdate
312		- ))));
	307	+ ->method('getBody')
	308	+ ->will($this->returnValue(json_encode(
	309	+ array(
	310	+ 'referenceUpdate' => $referenceUpdate,
	311	+ 'applyIdUpdate' => $applyIdUpdate
	312	+ ))));
313	313	}
314	314
315	315

		@@ -110,7 +110,7 @@ discard block
		block discarded – undo
110	110
111	111	$this->target = new Publisher($this->serviceManager);
112	112
113		- $staticClassPrefix = '\\' . __CLASS__ . '::';
	113	+ $staticClassPrefix = '\\'.__CLASS__.'::';
114	114
115	115	$this->log = $this->getMockBuilder('\Zend\Log\Logger')
116	116	->disableOriginalConstructor()
		@@ -164,7 +164,7 @@ discard block
		block discarded – undo
164	164
165	165	$this->publisher->expects($this->any())
166	166	->method('__set')
167		- ->will($this->returnCallback($staticClassPrefix . 'publisherSetter'));
	167	+ ->will($this->returnCallback($staticClassPrefix.'publisherSetter'));
168	168
169	169	$this->htmlAbsPathFilter = $this->getMockBuilder('\Core\Filter\HtmlAbsPathFilter')
170	170	->disableOriginalConstructor()
		@@ -172,7 +172,7 @@ discard block
		block discarded – undo
172	172
173	173	$this->htmlAbsPathFilter->expects($this->any())
174	174	->method('filter')
175		- ->will($this->returnCallback($staticClassPrefix . 'absPathFilter'));
	175	+ ->will($this->returnCallback($staticClassPrefix.'absPathFilter'));
176	176
177	177	$this->filterManager = $this->getMockBuilder('\Zend\ServiceManager\ServiceManager')
178	178	->disableOriginalConstructor()
		@@ -218,7 +218,7 @@ discard block
		block discarded – undo
218	218
219	219	$this->providerChannel->expects($this->any())
220	220	->method('__get')
221		- ->will($this->returnCallback($staticClassPrefix . 'providerChannelGetter'));
	221	+ ->will($this->returnCallback($staticClassPrefix.'providerChannelGetter'));
222	222
223	223	$this->provider->expects($this->any(0))
224	224	->method('__get')

		@@ -65,19 +65,19 @@ discard block
		block discarded – undo
65	65
66	66	$privileges = array('new', 'test', 'edit');
67	67
68		- foreach(array($role, $user) as $testObj)
	68	+ foreach (array($role, $user) as $testObj)
69	69	{
70	70	// non user is always false?
71		- foreach($privileges as $p)
	71	+ foreach ($privileges as $p)
72	72	{
73		- $this->assertFalse((bool)$target->assert($acl, $testObj, null, $p));
	73	+ $this->assertFalse((bool) $target->assert($acl, $testObj, null, $p));
74	74	}
75	75
76	76	// user and wrong privilege is false?
77		- foreach($privileges as $p)
	77	+ foreach ($privileges as $p)
78	78	{
79	79	// Casting null to false is safe here, 'edit' for pair user-privilege tested after
80		- $this->assertFalse((bool)$target->assert($acl, $testObj, $job, $p));
	80	+ $this->assertFalse((bool) $target->assert($acl, $testObj, $job, $p));
81	81	}
82	82	}
83	83
		@@ -117,15 +117,15 @@ discard block
		block discarded – undo
117	117	//$user->setOrganization($organization);
118	118
119	119	/ Organization without user /
120		- $this->assertFalse( $assertion->checkOrganizationPermissions( $user, $job ) );
	120	+ $this->assertFalse($assertion->checkOrganizationPermissions($user, $job));
121	121	}
122	122
123	123	/**
124	124	* @dataProvider assertParametersWithoutOrganization
125	125	*/
126		- public function testAssertWithoutOrganisation($input, $expected){
	126	+ public function testAssertWithoutOrganisation($input, $expected) {
127	127
128		- $method="assert".($expected?"True":"False");
	128	+ $method = "assert".($expected ? "True" : "False");
129	129
130	130	$this->$method(
131	131	$this->target->assert(
		@@ -138,7 +138,7 @@ discard block
		block discarded – undo
138	138
139	139	}
140	140
141		- public function assertParametersWithoutOrganization(){
	141	+ public function assertParametersWithoutOrganization() {
142	142
143	143	$userId = 1234;
144	144	$user = new User();
		@@ -163,13 +163,13 @@ discard block
		block discarded – undo
163	163
164	164
165	165	return [
166		- [[new Acl(), null, null, null] , false ],
167		- [[new Acl(), null, null, Permissions::PERMISSION_CHANGE] , false ],
168		- [[new Acl(), $user, $jobMock, 'edit'] , true ],
	166	+ [[new Acl(), null, null, null], false],
	167	+ [[new Acl(), null, null, Permissions::PERMISSION_CHANGE], false],
	168	+ [[new Acl(), $user, $jobMock, 'edit'], true],
169	169	];
170	170	}
171	171
172		- public function testAssertUserIsOrganizationAdmin(){
	172	+ public function testAssertUserIsOrganizationAdmin() {
173	173
174	174	$userId = 1234;
175	175	$user = new User();
		@@ -192,13 +192,13 @@ discard block
		block discarded – undo
192	192	$this->assertTrue(
193	193	$this->target->assert(
194	194	new Acl(), // acl
195		- $user, // role
196		- $jobMock, // resource
	195	+ $user, // role
	196	+ $jobMock, // resource
197	197	'edit' // privilege
198	198	));
199	199	}
200	200
201		- public function testAssertUserIsOwnerOfTheParentOrganization(){
	201	+ public function testAssertUserIsOwnerOfTheParentOrganization() {
202	202
203	203	$userId = 1234;
204	204	$user = new User();
		@@ -225,13 +225,13 @@ discard block
		block discarded – undo
225	225	$this->assertTrue(
226	226	$this->target->assert(
227	227	new Acl(), // acl
228		- $user, // role
229		- $jobMock, // resource
	228	+ $user, // role
	229	+ $jobMock, // resource
230	230	'edit' // privilege
231	231	));
232	232	}
233	233
234		- public function testUserIsEmployeeWithJobsChangePermissions(){
	234	+ public function testUserIsEmployeeWithJobsChangePermissions() {
235	235
236	236	$userId = 1234;
237	237	$user = new User();
		@@ -265,8 +265,8 @@ discard block
		block discarded – undo
265	265	$this->assertTrue(
266	266	$this->target->assert(
267	267	new Acl(), // acl
268		- $user, // role
269		- $jobMock, // resource
	268	+ $user, // role
	269	+ $jobMock, // resource
270	270	'edit' // privilege
271	271	));
272	272	}

		@@ -107,7 +107,7 @@
		block discarded – undo
107	107
108	108	$wf = new WorkflowSettings();
109	109	$wf->setAcceptApplicationByDepartmentManager($flag('acceptApplication'))
110		- ->setAssignDepartmentManagersToJobs($flag('assignManagers'));
	110	+ ->setAssignDepartmentManagersToJobs($flag('assignManagers'));
111	111
112	112	$org->expects($this->once())->method('getWorkflowSettings')->willReturn($wf);
113	113

		@@ -199,7 +199,7 @@
		block discarded – undo
199	199
200	200	$actual = $this->target->__invoke($event);
201	201
202		- $this->assertTrue(is_array($actual),'Listener did not return an array!');
	202	+ $this->assertTrue(is_array($actual), 'Listener did not return an array!');
203	203	$this->assertArrayHasKey('status', $actual);
204	204	$this->assertEquals('disabled', $actual['status']);
205	205	}

		@@ -2,7 +2,7 @@
		block discarded – undo
2	2	$commonModules = include_once __DIR__.'/../../../config/common.modules.php';
3	3
4	4	return array(
5		- 'modules' => array_merge($commonModules,array(
	5	+ 'modules' => array_merge($commonModules, array(
6	6	'Core',
7	7	'Auth',
8	8	'Jobs',

		@@ -1,6 +1,6 @@
		block discarded – undo
1	1	<?php
2	2
3	3	/** @var array $testConfig */
4		-$testConfig = include __DIR__ . '/TestConfig.php';
	4	+$testConfig = include __DIR__.'/TestConfig.php';
5	5
6		-require_once __DIR__ . '/../../../test/Bootstrap.php';
	6	+require_once __DIR__.'/../../../test/Bootstrap.php';

		@@ -6,9 +6,9 @@ discard block
		block discarded – undo
6	6	// This should be an array of module namespaces used in the application.
7	7	'modules' => array_merge($commonModules,array(
8	8	'Core',
9		- 'Auth',
10		- 'Jobs',
11		- 'Organizations',
	9	+ 'Auth',
	10	+ 'Jobs',
	11	+ 'Organizations',
12	12	)),
13	13
14	14	// These are various options for the listeners attached to the ModuleManager
		@@ -64,7 +64,7 @@ discard block
		block discarded – undo
64	64	// ),
65	65	// )
66	66
67		- // Initial configuration with which to seed the ServiceManager.
68		- // Should be compatible with Zend\ServiceManager\Config.
69		- // 'service_manager' => array(),
	67	+ // Initial configuration with which to seed the ServiceManager.
	68	+ // Should be compatible with Zend\ServiceManager\Config.
	69	+ // 'service_manager' => array(),
70	70	);

		@@ -4,7 +4,7 @@
		block discarded – undo
4	4
5	5	return array(
6	6	// This should be an array of module namespaces used in the application.
7		- 'modules' => array_merge($commonModules,array(
	7	+ 'modules' => array_merge($commonModules, array(
8	8	'Core',
9	9	'Auth',
10	10	'Jobs',

		@@ -85,12 +85,12 @@ discard block
		block discarded – undo
85	85	$acl = new Acl();
86	86
87	87	$events = $this->getMockBuilder('\Zend\EventManager\EventManager')
88		- ->disableOriginalConstructor()
89		- ->getMock();
	88	+ ->disableOriginalConstructor()
	89	+ ->getMock();
90	90
91	91	$events->expects($this->once())
92		- ->method('triggerUntil')
93		- ->willReturn(new ResponseCollection());
	92	+ ->method('triggerUntil')
	93	+ ->willReturn(new ResponseCollection());
94	94
95	95	$target->setEventManager($events);
96	96
		@@ -112,12 +112,12 @@ discard block
		block discarded – undo
112	112	$responseFalse = $this->createResponseMock(false);
113	113
114	114	$events = $this->getMockBuilder('\Zend\EventManager\EventManager')
115		- ->disableOriginalConstructor()
116		- ->getMock();
	115	+ ->disableOriginalConstructor()
	116	+ ->getMock();
117	117
118	118	$events->expects($this->exactly(5))
119		- ->method('triggerUntil')
120		- ->will($this->onConsecutiveCalls($responseNull, $responseEmpty, $responseZero, $responseTrue, $responseFalse));
	119	+ ->method('triggerUntil')
	120	+ ->will($this->onConsecutiveCalls($responseNull, $responseEmpty, $responseZero, $responseTrue, $responseFalse));
121	121
122	122	$target->setEventManager($events);
123	123
		@@ -133,8 +133,8 @@ discard block
		block discarded – undo
133	133	protected function createResponseMock($returnValue)
134	134	{
135	135	$response = $this->getMockBuilder('\Zend\EventManager\ResponseCollection')
136		- ->disableOriginalConstructor()
137		- ->getMock();
	136	+ ->disableOriginalConstructor()
	137	+ ->getMock();
138	138	$response->method('last')->willReturn($returnValue);
139	139
140	140	return $response;
		@@ -145,8 +145,8 @@ discard block
		block discarded – undo
145	145	$target = new TargetMock();
146	146
147	147	$events = $this->getMockBuilder('\Zend\EventManager\EventManager')
148		- ->disableOriginalConstructor()
149		- ->getMock();
	148	+ ->disableOriginalConstructor()
	149	+ ->getMock();
150	150
151	151	$acl = new Acl();
152	152	$role = new GenericRole('testRole');
		@@ -155,16 +155,16 @@ discard block
		block discarded – undo
155	155	$self = $this;
156	156
157	157	$events->expects($this->once())->method('triggerUntil')
158		- ->will($this->returnCallback(function ($callback,$eventName,$event) use ($acl, $role, $resource, $privilege, $self) {
159		- $self->assertTrue(is_callable($callback));
160		- $self->assertEquals('assert',$eventName);
	158	+ ->will($this->returnCallback(function ($callback,$eventName,$event) use ($acl, $role, $resource, $privilege, $self) {
	159	+ $self->assertTrue(is_callable($callback));
	160	+ $self->assertEquals('assert',$eventName);
161	161	$self->assertSame($acl, $event->getAcl());
162	162	$self->assertSame($role, $event->getRole());
163	163	$self->assertSame($resource, $event->getResource());
164	164	$self->assertSame($privilege, $event->getPrivilege());
165	165
166	166	return new ResponseCollection();
167		- }));
	167	+ }));
168	168
169	169	$target->setEventManager($events);
170	170	$target->assert($acl, $role, $resource, $privilege);

		@@ -155,9 +155,9 @@
		block discarded – undo
155	155	$self = $this;
156	156
157	157	$events->expects($this->once())->method('triggerUntil')
158		- ->will($this->returnCallback(function ($callback,$eventName,$event) use ($acl, $role, $resource, $privilege, $self) {
	158	+ ->will($this->returnCallback(function($callback, $eventName, $event) use ($acl, $role, $resource, $privilege, $self) {
159	159	$self->assertTrue(is_callable($callback));
160		- $self->assertEquals('assert',$eventName);
	160	+ $self->assertEquals('assert', $eventName);
161	161	$self->assertSame($acl, $event->getAcl());
162	162	$self->assertSame($role, $event->getRole());
163	163	$self->assertSame($resource, $event->getResource());

		@@ -31,11 +31,11 @@ discard block
		block discarded – undo
31	31	public function testCreateServiceReturnsAssertionManager()
32	32	{
33	33	$services = $this->getMockBuilder('\Zend\ServiceManager\ServiceManager')
34		- ->disableOriginalConstructor()
35		- ->getMock();
	34	+ ->disableOriginalConstructor()
	35	+ ->getMock();
36	36
37	37	$services->expects($this->once())->method('get')->with('Config')
38		- ->willReturn(array());
	38	+ ->willReturn(array());
39	39
40	40	$target = new AssertionManagerFactory();
41	41	$manager = $target->__invoke($services,AssertionManager::class);
		@@ -53,11 +53,11 @@ discard block
		block discarded – undo
53	53	public function testCorrectConfigIsUsedToConfigureTheManager($config, $testName, $testResult)
54	54	{
55	55	$services = $this->getMockBuilder('\Zend\ServiceManager\ServiceManager')
56		- ->disableOriginalConstructor()
57		- ->getMock();
	56	+ ->disableOriginalConstructor()
	57	+ ->getMock();
58	58
59	59	$services->expects($this->once())->method('get')->with('Config')
60		- ->willReturn($config);
	60	+ ->willReturn($config);
61	61
62	62	$target = new AssertionManagerFactory();
63	63

		@@ -38,7 +38,7 @@ discard block
		block discarded – undo
38	38	->willReturn(array());
39	39
40	40	$target = new AssertionManagerFactory();
41		- $manager = $target->__invoke($services,AssertionManager::class);
	41	+ $manager = $target->__invoke($services, AssertionManager::class);
42	42
43	43	$this->assertInstanceOf('\Acl\Assertion\AssertionManager', $manager);
44	44	//$this->assertFalse($manager->shareByDefault(), 'The managers\' shareByDefault value must be set to FALSE by the factory.');
		@@ -61,9 +61,9 @@ discard block
		block discarded – undo
61	61
62	62	$target = new AssertionManagerFactory();
63	63
64		- $manager = $target->__invoke($services,AssertionManager::class);
	64	+ $manager = $target->__invoke($services, AssertionManager::class);
65	65
66		- $this->assertTrue($testResult === $manager->has($testName), 'Expected managers\' has method to return ' . ($testResult ? 'TRUE' : 'FALSE') . ' on ' .$testName);
	66	+ $this->assertTrue($testResult === $manager->has($testName), 'Expected managers\' has method to return '.($testResult ? 'TRUE' : 'FALSE').' on '.$testName);
67	67	}
68	68
69	69	public function provideConfigArrays()

		@@ -68,35 +68,35 @@ discard block
		block discarded – undo
68	68	public function testInjectEventManagerInitializerCallbackGetsEventManagerFromServicesIfNotSetInAssertion()
69	69	{
70	70	$assertion = $this
71		- ->getMockForAbstractClass('\AclTest\Assertion\EventManagerAwareAssertionMock')
	71	+ ->getMockForAbstractClass('\AclTest\Assertion\EventManagerAwareAssertionMock')
72	72	;
73	73	$services = $this->getMockBuilder('\Zend\ServiceManager\AbstractPluginManager')
74		- ->disableOriginalConstructor()
75		- ->getMock()
	74	+ ->disableOriginalConstructor()
	75	+ ->getMock()
76	76	;
77	77	$parentServices = $this
78		- ->getMockBuilder('\Zend\ServiceManager\ServiceManager')
79		- ->disableOriginalConstructor()
80		- ->getMock()
	78	+ ->getMockBuilder('\Zend\ServiceManager\ServiceManager')
	79	+ ->disableOriginalConstructor()
	80	+ ->getMock()
81	81	;
82	82	$events = new EventManager();
83		- $target = new AssertionManager($parentServices);
	83	+ $target = new AssertionManager($parentServices);
84	84	$assertion
85		- ->expects($this->once())
86		- ->method('getEventManager')
87		- ->willReturn(null)
	85	+ ->expects($this->once())
	86	+ ->method('getEventManager')
	87	+ ->willReturn(null)
88	88	;
89	89	$assertion
90		- ->expects($this->once())
91		- ->method('setEventManager')
92		- ->with($events)
	90	+ ->expects($this->once())
	91	+ ->method('setEventManager')
	92	+ ->with($events)
93	93	;
94	94
95	95	$parentServices
96		- ->expects($this->once())
97		- ->method('get')
98		- ->with('EventManager')
99		- ->willReturn($events)
	96	+ ->expects($this->once())
	97	+ ->method('get')
	98	+ ->with('EventManager')
	99	+ ->willReturn($events)
100	100	;
101	101	/*
102	102	* Wanted to use:
		@@ -115,8 +115,8 @@ discard block
		block discarded – undo
115	115	$target = new AssertionManager($this->serviceManager);
116	116	$assertion = $this->getMockForAbstractClass('\AclTest\Assertion\EventManagerAwareAssertionMock');
117	117	$services = $this->getMockBuilder('\Zend\ServiceManager\AbstractPluginManager')
118		- ->disableOriginalConstructor()
119		- ->getMock()
	118	+ ->disableOriginalConstructor()
	119	+ ->getMock()
120	120	;
121	121
122	122	$parentServices = $this->getMockBuilder('\Zend\ServiceManager\ServiceManager')->disableOriginalConstructor()->getMock();
		@@ -126,15 +126,15 @@ discard block
		block discarded – undo
126	126	//$services->setServiceLocator($parentServices);
127	127
128	128	$parentServices
129		- ->expects($this->never())
130		- ->method('get')
131		- //->with('SharedEventManager')
132		- //->willReturn($sharedEvents)
	129	+ ->expects($this->never())
	130	+ ->method('get')
	131	+ //->with('SharedEventManager')
	132	+ //->willReturn($sharedEvents)
133	133	;
134	134	$assertion
135		- ->expects($this->once())
136		- ->method('getEventManager')
137		- ->willReturn($events)
	135	+ ->expects($this->once())
	136	+ ->method('getEventManager')
	137	+ ->willReturn($events)
138	138	;
139	139
140	140	$this->assertNull($target->injectEventManager($assertion, $services));

cross-solution / YAWIK

Push — develop ( 0de0ee...1049f6 )

Status

Category

Indentation +43 added lines, -43 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +21 added lines, -21 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +16 added lines, -16 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +26 added lines, -26 removed lines patch added patch discarded remove patch