CreateAssertionTest::testPreAssertConditions() - Code Metrics - Inspection of "[Jobs] Adds Job link to the json response used by..." - cross-solution/YAWIK - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( e2b887...c09155 )

unknown

created 2016-01-12 17:29 UTC

CreateAssertionTest::testPreAssertConditions() A

↳ Parent: CreateAssertionTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	19
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	19
rs	9.4286
cc	1
eloc	9
nc	1
nop	0

<?php
/**
 * YAWIK
 *
 * @filesource
 * @license MIT
 * @copyright  2013 - 2015 Cross Solution <http://cross-solution.de>
 */
  
/** */
namespace JobsTest\Acl;

use Auth\Entity\User;
use Jobs\Acl\CreateAssertion;
use Zend\Permissions\Acl\Acl;
use Zend\Permissions\Acl\Resource\ResourceInterface;
use Zend\Permissions\Acl\Role\GenericRole;
use Zend\Permissions\Acl\Role\RoleInterface;

/**
 * Test of Jobs\Acl\CreateAssertion
 *
 * @covers \Jobs\Acl\CreateAssertion
 * @author Mathias Gelhausen <[email protected]>
 * @group Jobs
 * @group Jobs.Acl
 */
class CreateAssertionTest extends \PHPUnit_Framework_TestCase
{

    /**
     * @coversNothing
     */
    public function testExtendsBaseClass()
    {
        $target = new CreateAssertion();

        $this->assertInstanceOf('\Acl\Assertion\AbstractEventManagerAwareAssertion', $target);
    }

    /**
     * @coversNothing
     */
    public function testProvidesDefaultEventManagerIdentifiers()
    {
        $target = new CreateAssertion();
        $expected = array(
            'Jobs/Acl/Assertions',
            'Jobs/Acl/Assertion/Create',
        );

        $this->assertAttributeEquals($expected, 'identifiers', $target);
    }

    public function testPreAssertConditions()
    {
        $target = new CreateAssertionMock();

        $acl = new Acl();
        $role = new GenericRole('test');

        // non user is always false?
        $this->assertFalse($target->assert($acl, $role, null, 'test'));
        $this->assertFalse($target->assert($acl, $role, null, 'new'));

        // user and wrong privilege is false?
        $role = new User();
        $this->assertFalse($target->assert($acl, $role, null, 'test'));

        // user and right privilege is null (meaning triggering event will be done)?
        $this->assertNull($target->assert($acl, $role, null, 'new'));

    }
}

class CreateAssertionMock extends CreateAssertion

{
    public function assert(Acl $acl,
                           RoleInterface $role = null,
                           ResourceInterface $resource = null,
                           $privilege = null
    ) {
        return parent::preAssert($acl, $role, $resource, $privilege);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }
}

1			<?php
2			/**
3			* YAWIK
4			*
5			* @filesource
6			* @license MIT
7			* @copyright 2013 - 2015 Cross Solution <http://cross-solution.de>
8			*/
9
10			/** */
11			namespace JobsTest\Acl;
12
13			use Auth\Entity\User;
14			use Jobs\Acl\CreateAssertion;
15			use Zend\Permissions\Acl\Acl;
16			use Zend\Permissions\Acl\Resource\ResourceInterface;
17			use Zend\Permissions\Acl\Role\GenericRole;
18			use Zend\Permissions\Acl\Role\RoleInterface;
19
20			/**
21			* Test of Jobs\Acl\CreateAssertion
22			*
23			* @covers \Jobs\Acl\CreateAssertion
24			* @author Mathias Gelhausen <[email protected]>
25			* @group Jobs
26			* @group Jobs.Acl
27			*/
28			class CreateAssertionTest extends \PHPUnit_Framework_TestCase
29			{
30
31			/**
32			* @coversNothing
33			*/
34			public function testExtendsBaseClass()
35			{
36			$target = new CreateAssertion();
37
38			$this->assertInstanceOf('\Acl\Assertion\AbstractEventManagerAwareAssertion', $target);
39			}
40
41			/**
42			* @coversNothing
43			*/
44			public function testProvidesDefaultEventManagerIdentifiers()
45			{
46			$target = new CreateAssertion();
47			$expected = array(
48			'Jobs/Acl/Assertions',
49			'Jobs/Acl/Assertion/Create',
50			);
51
52			$this->assertAttributeEquals($expected, 'identifiers', $target);
53			}
54
55			public function testPreAssertConditions()
56			{
57			$target = new CreateAssertionMock();
58
59			$acl = new Acl();
60			$role = new GenericRole('test');
61
62			// non user is always false?
63			$this->assertFalse($target->assert($acl, $role, null, 'test'));
64			$this->assertFalse($target->assert($acl, $role, null, 'new'));
65
66			// user and wrong privilege is false?
67			$role = new User();
68			$this->assertFalse($target->assert($acl, $role, null, 'test'));
69
70			// user and right privilege is null (meaning triggering event will be done)?
71			$this->assertNull($target->assert($acl, $role, null, 'new'));
72
73			}
74			}
75
76			class CreateAssertionMock extends CreateAssertion
			0 ignored issues – show Coding Style Compatibility introduced 2016-01-12 17:40 UTC by Report Bug Copy Issue Report PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history...
77			{
78			public function assert(Acl $acl,
79			RoleInterface $role = null,
80			ResourceInterface $resource = null,
81			$privilege = null
82			) {
83			return parent::preAssert($acl, $role, $resource, $privilege);
			0 ignored issues – show Comprehensibility Bug introduced 2016-01-12 17:40 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`preAssert()` instead of `assert()`). Are you sure this is correct? If so, you might want to change this to `$this->preAssert()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
84			}
85			}

cross-solution / YAWIK

Push — develop ( e2b887...c09155 )

CreateAssertionTest::testPreAssertConditions() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like