FormElement::render() - Code Metrics - Inspection of "Fix: FormElement view helper causes endless loop i..." - cross-solution/YAWIK - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( c74260...f7afa8 )

unknown

created 2017-01-20 16:10 UTC

FormElement::render() C

↳ Parent: FormElement

Complexity

Conditions	7
Paths	7

Size

Total Lines	26
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	26
rs	6.7272
c	0
b	0
f	0
cc	7
eloc	15
nc	7
nop	2

<?php
/**

 */

namespace Core\Form\View\Helper;

use Core\Form\ViewPartialProviderInterface;
use Zend\Form\View\Helper\FormElement as ZendFormElement;
use Zend\Form\Element;
use Zend\Form\ElementInterface;
use Core\Form\Element\ViewHelperProviderInterface as CoreElementInterface;
use Zend\View\Helper\HelperInterface;

class FormElement extends ZendFormElement
{

    /**
     * @param ElementInterface $element
     *
     * @return string
     */
    public function render(ElementInterface $element, $ignoreViewPartial = false)
    {
        $renderer = $this->getView();
        if (!method_exists($renderer, 'plugin')) {
            // Bail early if renderer is not pluggable
            return '';
        }

        if ($element instanceof ViewPartialProviderInterface && !$ignoreViewPartial) {
            $partial = $element->getViewPartial();
            return $renderer->partial($partial, ['element' => $element]);
        }

        if ($element instanceof CoreElementInterface) {
            $helper = $element->getViewHelper();
            if (is_string($helper)) {
                $helper = $renderer->plugin($helper);
            }
            if ($helper instanceof HelperInterface) {
                $helper->setView($renderer);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
            }
            return $helper($element);
        }

        return parent::render($element);
    }
}


1			<?php
2			/**
3
4			*/
5
6			namespace Core\Form\View\Helper;
7
8			use Core\Form\ViewPartialProviderInterface;
9			use Zend\Form\View\Helper\FormElement as ZendFormElement;
10			use Zend\Form\Element;
11			use Zend\Form\ElementInterface;
12			use Core\Form\Element\ViewHelperProviderInterface as CoreElementInterface;
13			use Zend\View\Helper\HelperInterface;
14
15			class FormElement extends ZendFormElement
16			{
17
18			/**
19			* @param ElementInterface $element
20			*
21			* @return string
22			*/
23			public function render(ElementInterface $element, $ignoreViewPartial = false)
24			{
25			$renderer = $this->getView();
26			if (!method_exists($renderer, 'plugin')) {
27			// Bail early if renderer is not pluggable
28			return '';
29			}
30
31			if ($element instanceof ViewPartialProviderInterface && !$ignoreViewPartial) {
32			$partial = $element->getViewPartial();
33			return $renderer->partial($partial, ['element' => $element]);
34			}
35
36			if ($element instanceof CoreElementInterface) {
37			$helper = $element->getViewHelper();
38			if (is_string($helper)) {
39			$helper = $renderer->plugin($helper);
40			}
41			if ($helper instanceof HelperInterface) {
42			$helper->setView($renderer);
			0 ignored issues – show Bug introduced 2016-08-02 14:40 UTC by Report Bug Copy Issue Report It seems like `$renderer` defined by `$this->getView()` on line `25` can be `null`; however, `Zend\View\Helper\HelperInterface::setView()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
43			}
44			return $helper($element);
45			}
46
47			return parent::render($element);
48			}
49			}
50

cross-solution / YAWIK

Push — develop ( c74260...f7afa8 )

FormElement::render() C

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like