Manager::factory() - Code Metrics - Inspection of "[Solr] Solr Server integration ref #234" - cross-solution/YAWIK - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#241)

by ANTHONIUS

created 2016-07-02 07:12 UTC

Manager::factory() A

↳ Parent: Manager

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	6
rs	9.4285
cc	1
eloc	3
nc	1
nop	1

<?php
/**
 * YAWIK
 *
 * @filesource
 * @copyright (c) 2013 - 2016 Cross Solution (http://cross-solution.de)
 * @license   MIT
 */

namespace Solr\Bridge;


use Solr\Exception\ServerException;
use Solr\Options\ModuleOptions;
use Zend\ServiceManager\ServiceLocatorInterface;

/**
 * Manage connection with the SolrServer
 *
 * @author  Anthonius Munthi <[email protected]>
 * @since   0.27
 * @package Solr\Bridge
 */
class Manager
{
    const SOLR_DATE_FORMAT  = 'Y-m-d\TH:i:s\Z';
    const SORT_ASCENDING    = 0;
    const SORT_DESCENDING   = 1;

    /**
     * @var ModuleOptions
     */
    protected $connectOption;

    /**
     * Manager constructor.
     * @param ModuleOptions $connectOption
     */
    public function __construct(ModuleOptions $connectOption)
    {
        $this->connectOption = $connectOption;
    }

    /**
     * Get \SolrClient with custom path option
     *
     * @param string $path
     * @return \SolrClient
     */
    public function getClient($path='/solr')
    {
        $connectOption = $this->connectOption;
        $options = [
            'secure' => $connectOption->isSecure(),
            'hostname' => $connectOption->getHostname(),
            'port' => $connectOption->getPort(),
            'path' => $path,
            'login' => $connectOption->getUsername(),
            'password' => $connectOption->getPassword(),
        ];

        return new \SolrClient($options);
    }

    /**
     * Add new document into Solr server
     *
     * @param \SolrInputDocument $document
     * @param string $path
     * @throws ServerException When failed adding document to server
     */
    public function addDocument(\SolrInputDocument $document,$path='/solr')
    {
        $client = $this->getClient($path);
        try{
            $client->addDocument($document);
            $client->commit();
            $client->optimize();
        }catch (\Exception $e){
            throw new ServerException('Can not add document to server!',$e->getCode(),$e);
        }
    }

    /**
     * Create new instance for Solr\Manager
     * @param ServiceLocatorInterface $sl
     * @return Manager
     */
    static public function factory(ServiceLocatorInterface $sl)

    {
        return new self(
            $sl->get('Solr/Options/Module')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );
    }
}

1			<?php
2			/**
3			* YAWIK
4			*
5			* @filesource
6			* @copyright (c) 2013 - 2016 Cross Solution (http://cross-solution.de)
7			* @license MIT
8			*/
9
10			namespace Solr\Bridge;
11
12
13			use Solr\Exception\ServerException;
14			use Solr\Options\ModuleOptions;
15			use Zend\ServiceManager\ServiceLocatorInterface;
16
17			/**
18			* Manage connection with the SolrServer
19			*
20			* @author Anthonius Munthi <[email protected]>
21			* @since 0.27
22			* @package Solr\Bridge
23			*/
24			class Manager
25			{
26			const SOLR_DATE_FORMAT = 'Y-m-d\TH:i:s\Z';
27			const SORT_ASCENDING = 0;
28			const SORT_DESCENDING = 1;
29
30			/**
31			* @var ModuleOptions
32			*/
33			protected $connectOption;
34
35			/**
36			* Manager constructor.
37			* @param ModuleOptions $connectOption
38			*/
39			public function __construct(ModuleOptions $connectOption)
40			{
41			$this->connectOption = $connectOption;
42			}
43
44			/**
45			* Get \SolrClient with custom path option
46			*
47			* @param string $path
48			* @return \SolrClient
49			*/
50			public function getClient($path='/solr')
51			{
52			$connectOption = $this->connectOption;
53			$options = [
54			'secure' => $connectOption->isSecure(),
55			'hostname' => $connectOption->getHostname(),
56			'port' => $connectOption->getPort(),
57			'path' => $path,
58			'login' => $connectOption->getUsername(),
59			'password' => $connectOption->getPassword(),
60			];
61
62			return new \SolrClient($options);
63			}
64
65			/**
66			* Add new document into Solr server
67			*
68			* @param \SolrInputDocument $document
69			* @param string $path
70			* @throws ServerException When failed adding document to server
71			*/
72			public function addDocument(\SolrInputDocument $document,$path='/solr')
73			{
74			$client = $this->getClient($path);
75			try{
76			$client->addDocument($document);
77			$client->commit();
78			$client->optimize();
79			}catch (\Exception $e){
80			throw new ServerException('Can not add document to server!',$e->getCode(),$e);
81			}
82			}
83
84			/**
85			* Create new instance for Solr\Manager
86			* @param ServiceLocatorInterface $sl
87			* @return Manager
88			*/
89			static public function factory(ServiceLocatorInterface $sl)
			0 ignored issues – show Coding Style introduced 2016-07-01 06:20 UTC by Report Bug Copy Issue Report As per PSR2, the `static` declaration should come after the visibility declaration. Loading history...
90			{
91			return new self(
92			$sl->get('Solr/Options/Module')
			0 ignored issues – show Documentation introduced 2016-07-02 07:19 UTC by Report Bug Copy Issue Report `$sl->get('Solr/Options/Module')` is of type `object\|array`, but the function expects a `object<Solr\Options\ModuleOptions>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
93			);
94			}
95			}

cross-solution / YAWIK

Pull Request — develop (#241)

Manager::factory() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like