Solr\Filter\AbstractPaginationQuery

Complexity

Total Complexity

8

Size/Duplication

Total Lines	107
Duplicated Lines	6.54 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	4
Bugs	0	Features	1

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	filter()	0	6	1
A	filterSort()	7	20	4
A	getPropertiesMap()	0	4	1
A	factory()	0	5	1
	getEntityClass()	0	1	?
	createQuery()	0	1	?

<?php
/**
 * YAWIK
 *
 * @filesource
 * @copyright (c) 2013 - 2016 Cross Solution (http://cross-solution.de)
 * @license   MIT
 */

namespace Solr\Filter;


use Solr\Bridge\Manager;
use Zend\Filter\Exception;
use Zend\Filter\FilterInterface;
use Zend\ServiceManager\ServiceLocatorInterface;

/**
 * Class AbstractPaginationQuery
 *
 * @author  Anthonius Munthi <me@itstoni.com>
 * @since   0.27
 * @package Solr\Filter
 */
abstract class AbstractPaginationQuery implements FilterInterface
{
    /**
     * @var array
     */
    protected $sortPropertiesMap = array();

    /**
     * Store property name and converter to be used
     * during result conversion
     *
     * @var array
     */
    protected $propertiesMap = [];

    /**
     * @var Manager
     */
    protected $manager = null;

    /**
     * AbstractPaginationQuery constructor.
     * 
     * @param Manager $manager
     */
    public function __construct(Manager $manager)
    {
        $this->manager = $manager;
    }

    /**
     * Filter query based on given value
     *
     * @param mixed $value
     * @return \SolrQuery
     */
    public function filter($value)
    {
        $query = new \SolrQuery();
        
        return $this->createQuery($value,$query);
    }

    /**
     * Returns sort parameter to be used for query
     *
     * @param $sort
     * @return array
     */
    protected function filterSort($sort)
    {
        if ('-' == $sort{0}) {
            $sortProp = substr($sort, 1);
            $sortDir  = Manager::SORT_DESCENDING;
        } else {
            $sortProp = $sort;
            $sortDir = Manager::SORT_ASCENDING;
        }

        if (isset($this->sortPropertiesMap[$sortProp])) {

This code seems to be duplicated across your project.

            $sortProp = $this->sortPropertiesMap[$sortProp];

            if (is_array($sortProp)) {
                return array_fill_keys($sortProp, $sortDir);
            }
        }

        return array($sortProp => $sortDir);
    }

    /**
     * Returs an array key => value for this pagination filter
     * to define custom solr result handler
     * @return array
     * @codeCoverageIgnore
     */
    public function getPropertiesMap()
    {
        return $this->propertiesMap;
    }

    /**
     * Creates new instance for this filter
     *
     * @param ServiceLocatorInterface $sl
     * @return static
     */
    static public function factory(ServiceLocatorInterface $sl)

As per PSR2, the static declaration should come after the visibility declaration.

    {
        $manager = $sl->getServiceLocator()->get('Solr/Manager');

It seems like you code against a concrete implementation and not the interface Zend\ServiceManager\ServiceLocatorInterface as the method getServiceLocator() does only exist in the following implementations of said interface: Acl\Assertion\AssertionManager, Core\Mail\MailService, Core\Paginator\PaginatorService, Zend\Barcode\ObjectPluginManager, Zend\Barcode\RendererPluginManager, Zend\Cache\PatternPluginManager, Zend\Cache\Storage\AdapterPluginManager, Zend\Cache\Storage\PluginManager, Zend\Config\ReaderPluginManager, Zend\Config\WriterPluginManager, Zend\Feed\Reader\ExtensionPluginManager, Zend\Feed\Writer\ExtensionPluginManager, Zend\File\Transfer\Adapter\FilterPluginManager, Zend\File\Transfer\Adapter\ValidatorPluginManager, Zend\Filter\FilterPluginManager, Zend\Form\FormElementManager\FormElementManagerV2Polyfill, Zend\Form\FormElementManager\FormElementManagerV3Polyfill, Zend\Hydrator\HydratorPluginManager, Zend\I18n\Translator\LoaderPluginManager, Zend\InputFilter\InputFilterPluginManager, Zend\Log\FilterPluginManager, Zend\Log\FormatterPluginManager, Zend\Log\ProcessorPluginManager, Zend\Log\WriterPluginManager, Zend\Log\Writer\FilterPluginManager, Zend\Log\Writer\FormatterPluginManager, Zend\Mail\Protocol\SmtpPluginManager, Zend\Mvc\Controller\ControllerManager, Zend\Mvc\Controller\PluginManager, Zend\Mvc\Router\RoutePluginManager, Zend\Paginator\AdapterPluginManager, Zend\Paginator\ScrollingStylePluginManager, Zend\Serializer\AdapterPluginManager, Zend\ServiceManager\AbstractPluginManager, Zend\Tag\Cloud\DecoratorPluginManager, Zend\Text\Table\DecoratorManager, Zend\Validator\ValidatorPluginManager, Zend\View\HelperPluginManager, Zend\View\Helper\Navigation\PluginManager.

        return new static($manager);
    }

    /**
     * Returns class to be used for entity object creation
     *
     * @return string
     */
    abstract public function getEntityClass();

    /**
     * @param   array $params
     * @param   \SolrQuery $query
     * @return  \SolrQuery
     */
    abstract public function createQuery(array $params,$query);
}