Completed
Pull Request — develop (#359)
by Mathias
23:51
created
module/Applications/src/Applications/Entity/ApplicationInterface.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -240,7 +240,7 @@  discard block
 block discarded – undo
240 240
     /**
241 241
      * Gets all comments for the application.
242 242
      *
243
-     * @return ArrayCollection;
243
+     * @return Collection
244 244
 
245 245
      */
246 246
     public function getComments();
@@ -271,7 +271,7 @@  discard block
 block discarded – undo
271 271
     /**
272 272
      * Gets all attributes for an application.
273 273
      *
274
-     * @return ArrayCollection;
274
+     * @return Attributes
275 275
 
276 276
      */
277 277
     public function getAttributes();
Please login to merge, or discard this patch.
Indentation   -2 removed lines patch added patch discarded remove patch
@@ -241,7 +241,6 @@  discard block
 block discarded – undo
241 241
      * Gets all comments for the application.
242 242
      *
243 243
      * @return ArrayCollection;
244
-
245 244
      */
246 245
     public function getComments();
247 246
     
@@ -272,7 +271,6 @@  discard block
 block discarded – undo
272 271
      * Gets all attributes for an application.
273 272
      *
274 273
      * @return ArrayCollection;
275
-
276 274
      */
277 275
     public function getAttributes();
278 276
 
Please login to merge, or discard this patch.
module/Core/src/Core/View/Helper/Period.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
      * returns the number of years of the education or work experience
19 19
      *
20 20
      * @param array $array
21
-     * @return string
21
+     * @return double
22 22
      */
23 23
     public function __invoke($array)
24 24
     {
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -25,13 +25,13 @@
 block discarded – undo
25 25
         // calculate EndDate - StartDate = X Years.
26 26
         // eg. 4.2 Years
27 27
         
28
-        $days=0;
28
+        $days = 0;
29 29
         foreach ($array as $obj) {
30 30
             $date1 = new \DateTime($obj->getEndDate());
31 31
             $date2 = new \DateTime($obj->getStartDate());
32 32
             $interval = $date1->diff($date2);
33
-            $days+=abs($interval->format('%R%a'));
33
+            $days += abs($interval->format('%R%a'));
34 34
         }
35
-        return round($days/365, 1);
35
+        return round($days / 365, 1);
36 36
     }
37 37
 }
Please login to merge, or discard this patch.
module/Core/src/Core/Repository/Filter/PropertyToKeywords.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
             $entity = $value;
24 24
             $value = array();
25 25
             foreach ($entity->getSearchableProperties() as $name) {
26
-                $result = $entity->{'get' .$name}();
26
+                $result = $entity->{'get'.$name}();
27 27
                 if (is_array($result)) {
28 28
                     $value = array_merge($value, $result);
29 29
                 } else {
@@ -48,8 +48,8 @@  discard block
 block discarded – undo
48 48
         $innerPattern = StringUtils::hasPcreUnicodeSupport()
49 49
                       ? '[^\p{L}]'
50 50
                       : '[^a-z0-9ßäöü ]';
51
-        $pattern      = '~' . $innerPattern . '~isu';
52
-        $stripPattern = '~^' . $innerPattern . '+|' . $innerPattern . '+$~isu';
51
+        $pattern      = '~'.$innerPattern.'~isu';
52
+        $stripPattern = '~^'.$innerPattern.'+|'.$innerPattern.'+$~isu';
53 53
         $parts     = array();
54 54
         $textParts = explode(' ', $string);
55 55
         foreach ($textParts as $part) {
Please login to merge, or discard this patch.
module/Core/src/Core/Form/RatingFieldset.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -49,11 +49,11 @@
 block discarded – undo
49 49
         $properties = $refl->getProperties();
50 50
         
51 51
         foreach ($properties as $property) {
52
-            $name  = $property->getName();
52
+            $name = $property->getName();
53 53
             if ('_' == $name{0}) {
54 54
                 continue;
55 55
             }
56
-            $value = $rating->{'get' . $name}();
56
+            $value = $rating->{'get'.$name}();
57 57
             $input = array(
58 58
                 'type' => 'Core/Rating',
59 59
                 'name' => $name,
Please login to merge, or discard this patch.
src/Jobs/Form/Hydrator/Strategy/JobDescriptionQualificationsStrategy.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
     {
19 19
         /* @var \Jobs\Entity\Job $value */
20 20
         $result = null;
21
-        if (method_exists($value,'getTemplateValues')) {
21
+        if (method_exists($value, 'getTemplateValues')) {
22 22
             $result = $value->getTemplateValues()->getQualifications();
23 23
         }
24 24
         return $result;
Please login to merge, or discard this patch.
module/Jobs/src/Jobs/Form/Hydrator/Strategy/JobDescriptionTitleStrategy.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@
 block discarded – undo
17 17
     public function extract($value)
18 18
     {
19 19
         $result = null;
20
-        if (method_exists($value,'templateValues')) {
20
+        if (method_exists($value, 'templateValues')) {
21 21
             $result = $value->getTemplateValues()->getTitle();
22 22
         }
23 23
         return $result;
Please login to merge, or discard this patch.
module/Applications/src/Applications/Repository/Application.php 2 patches
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -102,9 +102,9 @@  discard block
 block discarded – undo
102 102
     {
103 103
         $qb = $this->getPaginationQueryBuilder($params);
104 104
         $cursor = $qb->hydrate(false)
105
-                     ->select('_id')
106
-                     ->getQuery()
107
-                     ->execute();
105
+                        ->select('_id')
106
+                        ->getQuery()
107
+                        ->execute();
108 108
         
109 109
         $list = new PaginationList(array_keys(ArrayUtils::iteratorToArray($cursor)));
110 110
         return $list;
@@ -133,8 +133,8 @@  discard block
 block discarded – undo
133 133
     {
134 134
         $auth=$this->getService('AuthenticationService');
135 135
         $qb=$this->createQueryBuilder()
136
-                  ->field("readBy")->notIn(array($auth->getUser()->getId()))
137
-                  ->field("job")->equals(new \MongoId($job->getId()));
136
+                    ->field("readBy")->notIn(array($auth->getUser()->getId()))
137
+                    ->field("job")->equals(new \MongoId($job->getId()));
138 138
         return $qb->getQuery()->execute();
139 139
     }
140 140
 
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -131,8 +131,8 @@
 block discarded – undo
131 131
      */
132 132
     public function loadUnreadApplicationsForJob($job)
133 133
     {
134
-        $auth=$this->getService('AuthenticationService');
135
-        $qb=$this->createQueryBuilder()
134
+        $auth = $this->getService('AuthenticationService');
135
+        $qb = $this->createQueryBuilder()
136 136
                   ->field("readBy")->notIn(array($auth->getUser()->getId()))
137 137
                   ->field("job")->equals(new \MongoId($job->getId()));
138 138
         return $qb->getQuery()->execute();
Please login to merge, or discard this patch.
module/Applications/src/Applications/Controller/CommentController.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -105,7 +105,7 @@
 block discarded – undo
105 105
                     $application->getComments()->add($comment);
106 106
                     $application->changeStatus($application->getStatus(), sprintf(
107 107
                                     /* @translate */ 'Application was rated by %s',
108
-                                     $this->auth()->getUser()->getInfo()->getDisplayName())
108
+                                        $this->auth()->getUser()->getInfo()->getDisplayName())
109 109
                         );
110 110
                 }
111 111
                 $viewModel->setVariable('isSaved', true);
Please login to merge, or discard this patch.
src/Organizations/Entity/Hydrator/Strategy/OrganizationNameStrategy.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
     public function extract($value)
35 35
     {
36 36
         $name = '';
37
-        if (method_exists($value,"getName")) {
37
+        if (method_exists($value, "getName")) {
38 38
             $name = $value->getName();
39 39
         }
40 40
         return $name;
Please login to merge, or discard this patch.