ClonePropertiesTrait::cloneProperties() - Code Metrics - Inspection of "[Core] fixes unitest." - cross-solution/YAWIK - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( ddc457...b629d8 )

unknown

created 2017-02-17 10:43 UTC

ClonePropertiesTrait::cloneProperties() C

↳ Parent: ClonePropertiesTrait

Complexity

Conditions	11
Paths	56

Size

Total Lines	38
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	38
rs	5.2653
c	0
b	0
f	0
cc	11
eloc	23
nc	56
nop	1

How to fix Complexity

<?php
/**
 * YAWIK
 *
 * @filesource
 * @license MIT
 * @copyright  2013 - 2017 Cross Solution <http://cross-solution.de>
 */
  
/** */
namespace Core\Entity;

use Core\Entity\Collection\ArrayCollection;
use Doctrine\Common\Collections\Collection;

/**
 * ${CARET}
 * 
 * @author Mathias Gelhausen <[email protected]>
 * @todo write test 
 */
trait ClonePropertiesTrait
{
    public function __clone()
    {
        $this->cloneProperties();
    }

    private function cloneProperties(array $properties = null)
    {
        if (null === $properties) {
            $properties = isset($this->cloneProperties) ? $this->cloneProperties : [];
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }

        foreach ($properties as $property) {
            if (0 === strpos($property, '!')) {
                $property = substr($property, 1);
                $loop = false;
            } else {
                $loop = true;
            }

            $value = $this->{$property};
            if ($value instanceOf Collection && $loop) {
                $collection = new ArrayCollection();
                foreach ($value as $item) {
                    $collection->add(clone $item);
                }
                $value = $collection;
            } elseif(null === $value) {


            } else {
                $value = clone $value;
            }

            $this->{$property} = $value;
        }

        if ($this instanceOf IdentifiableEntityInterface) {
            $this->setId(null);
        }

        if (is_callable('parent::__clone')) {
            parent::__clone();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        }
    }
}

1			<?php
2			/**
3			* YAWIK
4			*
5			* @filesource
6			* @license MIT
7			* @copyright 2013 - 2017 Cross Solution <http://cross-solution.de>
8			*/
9
10			/** */
11			namespace Core\Entity;
12
13			use Core\Entity\Collection\ArrayCollection;
14			use Doctrine\Common\Collections\Collection;
15
16			/**
17			* ${CARET}
18			*
19			* @author Mathias Gelhausen <[email protected]>
20			* @todo write test
21			*/
22			trait ClonePropertiesTrait
23			{
24			public function __clone()
25			{
26			$this->cloneProperties();
27			}
28
29			private function cloneProperties(array $properties = null)
30			{
31			if (null === $properties) {
32			$properties = isset($this->cloneProperties) ? $this->cloneProperties : [];
			0 ignored issues – show Bug introduced 2017-02-16 16:50 UTC by Report Bug Copy Issue Report The property `cloneProperties` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
33			}
34
35			foreach ($properties as $property) {
36			if (0 === strpos($property, '!')) {
37			$property = substr($property, 1);
38			$loop = false;
39			} else {
40			$loop = true;
41			}
42
43			$value = $this->{$property};
44			if ($value instanceOf Collection && $loop) {
45			$collection = new ArrayCollection();
46			foreach ($value as $item) {
47			$collection->add(clone $item);
48			}
49			$value = $collection;
50			} elseif(null === $value) {
			0 ignored issues – show Unused Code introduced 2017-02-17 10:49 UTC by Report Bug Copy Issue Report This `elseif` statement is empty, and could be removed. This check looks for the bodies of `elseif` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `elseif` bodies can be removed. If you have an empty elseif but statements in the `else` branch, consider inverting the condition. Loading history...
51
52			} else {
53			$value = clone $value;
54			}
55
56			$this->{$property} = $value;
57			}
58
59			if ($this instanceOf IdentifiableEntityInterface) {
60			$this->setId(null);
61			}
62
63			if (is_callable('parent::__clone')) {
64			parent::__clone();
			0 ignored issues – show Comprehensibility Bug introduced 2017-02-16 16:50 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`__clone()` instead of `cloneProperties()`). Are you sure this is correct? If so, you might want to change this to `$this->__clone()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
65			}
66			}
67			}

cross-solution / YAWIK

Push — develop ( ddc457...b629d8 )

ClonePropertiesTrait::cloneProperties() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like