Auth\Controller\UsersController

Complexity

Total Complexity

12

Size/Duplication

Total Lines	123
Duplicated Lines	8.94 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes	5
Bugs	1	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	listAction()	0	21	1
C	editAction()	11	74	10

<?php
/**
 * YAWIK
 *
 * @filesource
 * @copyright (c) 2013 - 2016 Cross Solution (http://cross-solution.de)
 * @license   MIT
 */

/** Auth controller */
namespace Auth\Controller;

use Zend\Mvc\Controller\AbstractActionController;
use Zend\View\Model\ViewModel;
use Zend\View\Model\JsonModel;
use Auth\Repository\User as UserRepository;
use Core\Form\SummaryFormInterface;

/**
 * List registered users
 */
class UsersController extends AbstractActionController
{

    /**
     * @var UserRepository
     */
    protected $userRepository;

    /**
     * @param UserRepository $userRepository
     */
    public function __construct(UserRepository $userRepository)
    {
        $this->userRepository = $userRepository;
    }
    
    /**
     * Login with username and password
     *
     * @return \Zend\Http\Response|ViewModel

Should the return type not be array?

     */
    public function listAction()
    {
        /* @var \Zend\Http\Request $request */
        $request          = $this->getRequest();
        $params           = $request->getQuery();

        $paginator = $this->paginator('Auth/User', $params);

The method paginator does not exist on object<Auth\Controller\UsersController>? Since you implemented __call, maybe consider adding a @method annotation.

        $form = $this->getServiceLocator()->get('forms')
                ->get('Core/TextSearch', [
                                           'placeholder' => /*@translate*/ 'Type name, email address, role, or login name',
                                           'button_element' => 'text'
                                       ]);

        $return = array(
            'by' => $params['by'],
            'users' => $paginator,
            'form' => $form,
        );

        return $return;
    }

    /**
     * Edit user
     *
     * @return \Zend\Http\Response|ViewModel

Should the return type not be array|JsonModel?

     */
    public function editAction()
    {
        /* @var $user \Auth\Entity\User */
        $user = $this->userRepository->find($this->params('id'), \Doctrine\ODM\MongoDB\LockMode::NONE, null, ['allowDeactivated' => true]);
        
        // check if user is not found
        if (!$user) {
            return $this->notFoundAction();
        }
        
        $params = $this->params();
        $serviceLocator = $this->getServiceLocator();
        $forms = $serviceLocator->get('forms');
        /* @var $infoContainer \Auth\Form\UserProfileContainer */
        $infoContainer = $forms->get('Auth/userprofilecontainer');
        $infoContainer->setEntity($user);
        $statusContainer = $forms->get('Auth/UserStatusContainer');
        $statusContainer->setEntity($user);
        
        // set selected user to image strategy
        $imageStrategy = $infoContainer->getForm('info.image')

The method getHydrator does only exist in Zend\Form\FormInterface, but not in Core\Form\Container.

            ->getHydrator()
            ->getStrategy('image');
		$fileEntity = $imageStrategy->getFileEntity();
		$fileEntity->setUser($user);
		$imageStrategy->setFileEntity($fileEntity);
        
        if ($this->request->isPost()) {

It seems like you code against a concrete implementation and not the interface Zend\Stdlib\RequestInterface as the method isPost() does only exist in the following implementations of said interface: Zend\Http\PhpEnvironment\Request, Zend\Http\Request.

            $formName = $params->fromQuery('form');
            $container = $formName === 'status' ? $statusContainer : $infoContainer;
            $form = $container->getForm($formName);
        
            if ($form) {
                $postData  = $form->getOption('use_post_array') ? $params->fromPost() : [];
                $filesData = $form->getOption('use_files_array') ? $params->fromFiles() : [];
                $form->setData(array_merge($postData, $filesData));
        
                if (!$form->isValid()) {
                    return new JsonModel(
                        array(
                            'valid' => false,
                            'errors' => $form->getMessages(),
                        )
                    );
                }
                
                $serviceLocator->get('repositories')->store($user);
        
                if ('file-uri' === $params->fromPost('return')) {

This code seems to be duplicated across your project.

                    $content = $form->getHydrator()->getLastUploadedFile()->getUri();
                } else {
                    if ($form instanceof SummaryFormInterface) {
                        $form->setRenderMode(SummaryFormInterface::RENDER_SUMMARY);
                        $viewHelper = 'summaryform';
                    } else {
                        $viewHelper = 'form';
                    }
                    $content = $serviceLocator->get('ViewHelperManager')->get($viewHelper)->__invoke($form);
                }
        
                return new JsonModel(
                    array(
                        'valid' => $form->isValid(),
                        'content' => $content,
                    )
                );
            }
        }
        
        return [
            'infoContainer' => $infoContainer,
            'statusContainer' => $statusContainer
        ];
    }
}