cross-solution / YAWIK

module/Behat/src/CoreContext.php

Spacing +7 added lines, -7 removed lines

@@ -29,7 +29,7 @@ 
 
     private $config;
 
-    public function __construct($config=null)
+    public function __construct($config = null)
     {
         if (is_null($config)) {
             $config = __DIR__.'/../../../config/config.php';
@@ -180,7 +180,7 @@ 
     public function iSetMainWindowName()
     {
         $window_name = 'main_window';
-        $script = 'window.name = "' . $window_name . '"';
+        $script = 'window.name = "'.$window_name.'"';
         $this->getSession()->executeScript($script);
     }
     
@@ -239,14 +239,14 @@ 
                 break;
             
             default:
-                throw new \Exception(__METHOD__ . ' Couldn\'t find selector: ' . $selector . ' - Allowed selectors: #id, .className, //xpath');
+                throw new \Exception(__METHOD__.' Couldn\'t find selector: '.$selector.' - Allowed selectors: #id, .className, //xpath');
                 break;
         }
         
         try {
             $this->getSession()->executeScript($function);
         } catch (\Exception $e) {
-            throw new \Exception(__METHOD__ . ' failed'. ' Message: for this locator:"'.$selector.'"');
+            throw new \Exception(__METHOD__.' failed'.' Message: for this locator:"'.$selector.'"');
         }
     }
     
@@ -266,7 +266,7 @@ 
      *
      * @return \Behat\Mink\Element\NodeElement|mixed|null
      */
-    public function getElement($locator, $selector='css')
+    public function getElement($locator, $selector = 'css')
     {
         $page = $this->minkContext->getSession()->getPage();
         $element = $page->find('css', $locator);
@@ -300,12 +300,12 @@ 
         $session = $this->getSession();
         $element = $session->getPage()->find(
             'xpath',
-            $session->getSelectorsHandler()->selectorToXpath('xpath', '*//*[text()="'. $text .'"]')
+            $session->getSelectorsHandler()->selectorToXpath('xpath', '*//*[text()="'.$text.'"]')
         );
         if (null === $element) {
             $element = $session->getPage()->find(
                 'named',
-                array('id',$text)
+                array('id', $text)
             );
         }
         if (null === $element) {

Doc Comments +2 added lines, -2 removed lines

@@ -104,7 +104,6 @@ 
     
     /**
      * @param $name
-     * @param array $params
      *
      * @return string
      */
@@ -115,6 +114,7 @@ 
 
     /**
      * @When /^I hover over the element "([^"]*)"$/
+     * @param string $locator
      */
     public function iHoverOverTheElement($locator)
     {
@@ -259,7 +259,7 @@ 
     }
     
     /**
-     * @param $locator
+     * @param string $locator
      * @param string $selector
      *
      * @return \Behat\Mink\Element\NodeElement|mixed|null

module/Behat/src/UserContext.php

Spacing +15 added lines, -15 removed lines

@@ -63,7 +63,7 @@ 
      */
     protected $currentUser;
     
-    public function __construct($parameters=[])
+    public function __construct($parameters = [])
     {
         $defaultLoginInfo = [
             'facebook' => [
@@ -75,7 +75,7 @@ 
                 'session_password-login' => getenv('LINKEDIN_USER_PASSWORD')
             ],
         ];
-        $socialLoginConfig = isset($parameters['social_login_info']) ? $parameters['social_login_info']:[];
+        $socialLoginConfig = isset($parameters['social_login_info']) ? $parameters['social_login_info'] : [];
         $this->socialLoginInfo = array_merge($defaultLoginInfo, $socialLoginConfig);
     }
 
@@ -142,7 +142,7 @@ 
      * @Given I am logged in as a recruiter
      * @Given I am logged in as a recruiter with :organization as organization
      */
-    public function iAmLoggedInAsARecruiter($organization=null)
+    public function iAmLoggedInAsARecruiter($organization = null)
     {
         $user = $this->thereIsAUserIdentifiedBy(
             'test@recruiter.com',
@@ -174,7 +174,7 @@ 
     public function iDonTHaveUser($login)
     {
         $repo = $this->getUserRepository();
-        $user=$repo->findByLogin($login);
+        $user = $repo->findByLogin($login);
         if ($user instanceof UserInterface) {
             $repo->remove($user, true);
         }
@@ -222,7 +222,7 @@ 
     private function startLogin(UserInterface $user, $password)
     {
         $currentUser = $this->currentUser;
-        if (!is_object($currentUser) || $user->getId()!=$currentUser->getId()) {
+        if (!is_object($currentUser) || $user->getId() != $currentUser->getId()) {
             $this->iWantToLogIn();
             $this->iSpecifyTheUsernameAs($user->getLogin());
             $this->iSpecifyThePasswordAs($password);
@@ -242,10 +242,10 @@ 
     /**
      * @Given there is a user :email identified by :password
      */
-    public function thereIsAUserIdentifiedBy($email, $password, $role=User::ROLE_RECRUITER, $fullname="Test Recruiter", $organization=null)
+    public function thereIsAUserIdentifiedBy($email, $password, $role = User::ROLE_RECRUITER, $fullname = "Test Recruiter", $organization = null)
     {
         $repo = $this->getUserRepository();
-        if (!is_object($user=$repo->findByEmail($email))) {
+        if (!is_object($user = $repo->findByEmail($email))) {
             $user = $this->createUser($email, $password, $role, $fullname, $organization);
         }
         
@@ -266,7 +266,7 @@ 
      *
      * @return \Auth\Entity\UserInterface
      */
-    public function createUser($email, $password, $role=User::ROLE_RECRUITER, $fullname="Test Recruiter")
+    public function createUser($email, $password, $role = User::ROLE_RECRUITER, $fullname = "Test Recruiter")
     {
         /* @var Register $service */
         /* @var User $user */
@@ -280,7 +280,7 @@ 
         $expFullName = explode(' ', $fullname);
         $info = $user->getInfo();
         $info->setFirstName(array_shift($expFullName));
-        $info->setLastName(count($expFullName)>0 ? implode(' ', $expFullName):'');
+        $info->setLastName(count($expFullName) > 0 ? implode(' ', $expFullName) : '');
         $info->setEmail($email);
         $info->setEmailVerified(true);
         $repo->store($user);
@@ -310,7 +310,7 @@ 
         /* @var $repoOrganization OrganizationRepository */
         $repoOrganization = $this->coreContext->getRepositories()->get('Organizations/Organization');
         $result = $repoOrganization->findByName($orgName);
-        $organization = count($result) > 0 ? $result[0]:null;
+        $organization = count($result) > 0 ? $result[0] : null;
         if (!$organization instanceof Organization) {
             $organization = new Organization();
             $organizationName = new OrganizationName($orgName);
@@ -426,12 +426,12 @@ 
     {
         $repo = $this->getUserRepository();
         $data = $table->getRowsHash();
-        $email = isset($data['email']) ? $data['email']:'test@example.com';
-        $password = isset($data['password']) ? $data['password']:'test';
-        $fullname = isset($data['fullname']) ? $data['fullname']:'Test User';
-        $role = isset($data['role']) ? $data['role']:User::ROLE_RECRUITER;
+        $email = isset($data['email']) ? $data['email'] : 'test@example.com';
+        $password = isset($data['password']) ? $data['password'] : 'test';
+        $fullname = isset($data['fullname']) ? $data['fullname'] : 'Test User';
+        $role = isset($data['role']) ? $data['role'] : User::ROLE_RECRUITER;
         
-        if (!is_object($user=$repo->findByLogin($email))) {
+        if (!is_object($user = $repo->findByLogin($email))) {
             $user = $this->createUser($email, $password, $role, $fullname);
         }
         $this->currentUser = $user;

Doc Comments +3 added lines

@@ -219,6 +219,9 @@
         $this->startLogin($user, 'test');
     }
     
+    /**
+     * @param string $password
+     */
     private function startLogin(UserInterface $user, $password)
     {
         $currentUser = $this->currentUser;

module/Install/config/module.config.php

Spacing +6 added lines, -6 removed lines

@@ -25,7 +25,7 @@ 
 	    'factories' => [
 		    'mvctranslator' => \Zend\Mvc\I18n\TranslatorFactory::class,
 		    'FilterManager' => \Zend\Filter\FilterPluginManagerFactory::class,
-            'Tracy' => [\Core\Service\Tracy::class,'factory'],
+            'Tracy' => [\Core\Service\Tracy::class, 'factory'],
             'Core/Options' => 'Core\Factory\ModuleOptionsFactory',
         ],
         'abstract_factories' => [
@@ -95,12 +95,12 @@ 
         'exception_template' => 'error/index',
         // Map template to files. Speeds up the lookup through the template stack.
         'template_map' => [
-            'layout/layout' => __DIR__ . '/../view/layout/layout.phtml',
-            'error/index' => __DIR__ . '/../view/error/index.phtml',
+            'layout/layout' => __DIR__.'/../view/layout/layout.phtml',
+            'error/index' => __DIR__.'/../view/error/index.phtml',
         ],
         // Where to look for view templates not mapped above
         'template_path_stack' => [
-            __DIR__ . '/../view',
+            __DIR__.'/../view',
         ],
     ],
 
@@ -114,13 +114,13 @@ 
         'translation_file_patterns' => [
             [
                 'type' => 'gettext',
-                'base_dir' => __DIR__ . '/../language',
+                'base_dir' => __DIR__.'/../language',
                 'pattern' => '%s.mo',
                 'text_domain' => 'Install',
             ],
             [
                 'type'     => 'phparray',
-                'base_dir' => __DIR__ . '/../../Core/language',
+                'base_dir' => __DIR__.'/../../Core/language',
                 'pattern' => 'Zend_Validate.%s.php',
                 'text_domain' => 'default',
             ],

Indentation +15 added lines, -15 removed lines

@@ -8,15 +8,15 @@ 
  */
 
 return [
-	'tracy' => [
-		'enabled' => true, // flag whether to load tracy at all
-		'mode' => true, // true = production|false = development|null = autodetect|IP address(es) csv/array
-		'bar' => false, // bool = enabled|Toggle nette diagnostics bar.
-		'strict' => true, // bool = cause immediate death|int = matched against error severity
-		'log' => __DIR__.'/../../../var/log/tracy', // path to log directory (this directory keeps error.log, snoozing mailsent file & html exception trace files)
-		'email' => null, // in production mode notifies the recipient
-		'email_snooze' => 900 // interval for sending email in seconds
-	],
+    'tracy' => [
+        'enabled' => true, // flag whether to load tracy at all
+        'mode' => true, // true = production|false = development|null = autodetect|IP address(es) csv/array
+        'bar' => false, // bool = enabled|Toggle nette diagnostics bar.
+        'strict' => true, // bool = cause immediate death|int = matched against error severity
+        'log' => __DIR__.'/../../../var/log/tracy', // path to log directory (this directory keeps error.log, snoozing mailsent file & html exception trace files)
+        'email' => null, // in production mode notifies the recipient
+        'email_snooze' => 900 // interval for sending email in seconds
+    ],
 
     'doctrine' => [
         'driver' => [
@@ -35,9 +35,9 @@ 
         'invokables' => [
             'Install/Listener/LanguageSetter' => 'Install\Listener\LanguageSetter',
         ],
-	    'factories' => [
-		    'mvctranslator' => \Zend\Mvc\I18n\TranslatorFactory::class,
-		    'FilterManager' => \Zend\Filter\FilterPluginManagerFactory::class,
+        'factories' => [
+            'mvctranslator' => \Zend\Mvc\I18n\TranslatorFactory::class,
+            'FilterManager' => \Zend\Filter\FilterPluginManagerFactory::class,
             'Tracy' => [\Core\Service\Tracy::class,'factory'],
             'Core/Options' => 'Core\Factory\ModuleOptionsFactory',
         ],
@@ -63,9 +63,9 @@ 
     ],
 
     'controllers' => [
-	    'abstract_factories' => [
-	    	\Install\Factory\Controller\LazyControllerFactory::class
-	    ],
+        'abstract_factories' => [
+            \Install\Factory\Controller\LazyControllerFactory::class
+        ],
     ],
 
     'controller_plugins' => [

module/Core/src/View/Helper/ContactLink.php

Spacing +1 added lines, -1 removed lines

@@ -69,7 +69,7 @@
         $attr       = array();
         
         foreach ($attributes as $name => $value) {
-            $attr[] = $escape($name) . (strlen($value) ? ('="' . $escapeAttr($value) . '"') : '');
+            $attr[] = $escape($name).(strlen($value) ? ('="'.$escapeAttr($value).'"') : '');
         }
         
         return implode(' ', $attr);

module/Auth/src/Auth/Controller/Plugin/UserSwitcher.php

Doc Comments +2 added lines, -2 removed lines

@@ -119,7 +119,7 @@ 
     /**
      * Switch to another user.
      *
-     * @param string|UserInterface $id user id of the user to switch to.
+     * @param string $id user id of the user to switch to.
      * @param array $params Additional parameters to store in the session container.
      *
      * @return bool
@@ -222,7 +222,7 @@ 
     /**
      * Gets the session container.
      *
-     * @return Container
+     * @return string
      */
     private function getSessionContainer()
     {

module/Auth/src/Auth/Service/Register.php

Doc Comments +2 added lines, -2 removed lines

@@ -154,7 +154,7 @@ 
     }
 
     /**
-     * @param $user
+     * @param \Auth\Entity\UserInterface $user
      * @return $this
      */
     protected function setUser($user)
@@ -247,7 +247,7 @@ 
     /**
      * Email-Address
      * @param $email string
-     * @return mixed
+     * @return Register
      */
     protected function setEmail($email)
     {

module/Core/src/Application.php

Doc Comments +2 added lines, -2 removed lines

@@ -36,7 +36,7 @@ 
     /**
      * Get required modules for Yawik
      *
-     * @return array
+     * @return string[]
      */
     public static function getRequiredModules()
     {
@@ -172,7 +172,7 @@ 
 
     /**
      * Setup php server
-     * @return bool
+     * @return null|boolean
      * @codeCoverageIgnore
      */
     private static function setupCliServerEnv()

Spacing +12 added lines, -12 removed lines

@@ -69,7 +69,7 @@ 
      * @param array $loadModules
      * @return array
      */
-    public static function generateModuleConfiguration($loadModules=[])
+    public static function generateModuleConfiguration($loadModules = [])
     {
         $modules = ArrayUtils::merge(
             static::getRequiredModules(),
@@ -152,12 +152,12 @@ 
     {
         $modules = [];
         $configDir = static::getConfigDir();
-        foreach (glob($configDir. '/autoload/*.module.php') as $moduleFile) {
+        foreach (glob($configDir.'/autoload/*.module.php') as $moduleFile) {
             $addModules = require $moduleFile;
             foreach ($addModules as $addModule) {
                 if (strpos($addModule, '-') === 0) {
                     $remove = substr($addModule, 1);
-                    $modules = array_filter($modules, function ($elem) use ($remove) {
+                    $modules = array_filter($modules, function($elem) use ($remove) {
                         return strcasecmp($elem, $remove);
                     });
                 } else {
@@ -178,15 +178,15 @@ 
     private static function setupCliServerEnv()
     {
         $parseUrl = parse_url(substr($_SERVER["REQUEST_URI"], 1));
-        $route = isset($parseUrl['path']) ? $parseUrl['path']:null;
-        if (is_file(__DIR__ . '/' . $route)) {
+        $route = isset($parseUrl['path']) ? $parseUrl['path'] : null;
+        if (is_file(__DIR__.'/'.$route)) {
             if (substr($route, -4) == ".php") {
-                require __DIR__ . '/' . $route;     // Include requested script files
+                require __DIR__.'/'.$route; // Include requested script files
                 exit;
             }
-            return false;           // Serve file as is
+            return false; // Serve file as is
         } else {                    // Fallback to index.php
-            $_GET["q"] = $route;    // Try to emulate the behaviour of a .htaccess here.
+            $_GET["q"] = $route; // Try to emulate the behaviour of a .htaccess here.
         }
         return true;
     }
@@ -196,7 +196,7 @@ 
      */
     public static function loadDotEnv()
     {
-        static $isLoaded=false;
+        static $isLoaded = false;
         if ($isLoaded) {
             return;
         }
@@ -211,9 +211,9 @@ 
         }
 
         //@TODO: should move this version loading to somewhere else
-        $isVendor = strpos(__FILE__, 'modules')!==false || strpos(__FILE__, 'vendor') !== false;
-        $version = getenv('TRAVIS') || $isVendor ? "undefined":exec('git describe');
-        $branch = getenv('TRAVIS') || $isVendor ? "undefined":exec('git rev-parse --abbrev-ref HEAD', $output, $retVal);
+        $isVendor = strpos(__FILE__, 'modules') !== false || strpos(__FILE__, 'vendor') !== false;
+        $version = getenv('TRAVIS') || $isVendor ? "undefined" : exec('git describe');
+        $branch = getenv('TRAVIS') || $isVendor ? "undefined" : exec('git rev-parse --abbrev-ref HEAD', $output, $retVal);
         static::$VERSION = $version.'['.$branch.']';
 
 

module/Core/src/Entity/Hydrator/FileCollectionUploadHydrator.php

Doc Comments +2 added lines, -2 removed lines

@@ -21,8 +21,8 @@
     protected $elementName;
 
     /**
-     * @param $name
-     * @param $strategy
+     * @param string $name
+     * @param Strategy\FileUploadStrategy $strategy
      */
     public function __construct($name, $strategy)
     {

module/Core/src/Entity/Hydrator/JsonEntityHydrator.php

Doc Comments +3 added lines

@@ -29,6 +29,9 @@
     {
     }
 
+    /**
+     * @param EntityHydrator $hydrator
+     */
     public function injectHydrator($hydrator)
     {
         if (empty($hydrator) || !$hydrator instanceof AbstractHydrator) {