Completed
Pull Request — develop (#509)
by ANTHONIUS
21:03
created
module/Jobs/src/Entity/JobInterface.php 2 patches
Doc Comments   +10 added lines patch added patch discarded remove patch
@@ -38,6 +38,7 @@  discard block
 block discarded – undo
38 38
      * Gets the unique key used by applications to reference a job posting
39 39
      *
40 40
      * @param string $applyId
41
+     * @return JobInterface|null
41 42
      */
42 43
     public function setApplyId($applyId);
43 44
 
@@ -93,6 +94,7 @@  discard block
 block discarded – undo
93 94
      * Sets an URI for a job posting
94 95
      *
95 96
      * @param string $link
97
+     * @return Job
96 98
      */
97 99
     public function setLink($link);
98 100
     
@@ -139,6 +141,7 @@  discard block
 block discarded – undo
139 141
      * Sets the title of a job posting
140 142
      *
141 143
      * @param string $title
144
+     * @return JobInterface
142 145
      */
143 146
     public function setTitle($title);
144 147
 
@@ -240,6 +243,7 @@  discard block
 block discarded – undo
240 243
      * Sets the language of a job posting
241 244
      *
242 245
      * @param string $language
246
+     * @return Job
243 247
      */
244 248
     public function setLanguage($language);
245 249
 
@@ -255,6 +259,7 @@  discard block
 block discarded – undo
255 259
      * Sets the location of a job posting
256 260
      *
257 261
      * @param string $location
262
+     * @return Job
258 263
      */
259 264
     public function setLocation($location);
260 265
 
@@ -269,6 +274,7 @@  discard block
 block discarded – undo
269 274
      * Sets locations of a job posting
270 275
      *
271 276
      * @param string $locations
277
+     * @return Job
272 278
      */
273 279
     public function setLocations($locations);
274 280
 
@@ -283,6 +289,7 @@  discard block
 block discarded – undo
283 289
      * Sets applications for a job posting
284 290
      *
285 291
      * @param Collection $applications
292
+     * @return Job|null
286 293
      */
287 294
     public function setApplications(Collection $applications);
288 295
     
@@ -297,6 +304,7 @@  discard block
 block discarded – undo
297 304
      * Sets Status of a job posting
298 305
      *
299 306
      * @param string $status
307
+     * @return void
300 308
      */
301 309
     public function setStatus($status);
302 310
 
@@ -342,6 +350,7 @@  discard block
 block discarded – undo
342 350
      * organisation offering the job.
343 351
      *
344 352
      * @param string $reference
353
+     * @return Job
345 354
      */
346 355
     public function setReference($reference);
347 356
     
@@ -357,6 +366,7 @@  discard block
 block discarded – undo
357 366
      * Sets the list of channels where a job opening should be published
358 367
      *
359 368
      * @param Array $portals
369
+     * @return Job|null
360 370
      */
361 371
     public function setPortals(array $portals);
362 372
 
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -198,7 +198,7 @@
 block discarded – undo
198 198
      *
199 199
      * @return UserInterface $user
200 200
      */
201
-    public function getUser() ;
201
+    public function getUser();
202 202
 
203 203
     /**
204 204
      * Gets the link to the application form
Please login to merge, or discard this patch.
module/Jobs/src/Factory/Form/MultipostingSelectFactory.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
      * @param  string             $requestedName
31 31
      * @param  null|array         $options
32 32
      *
33
-     * @return object
33
+     * @return MultipostingSelect
34 34
      * @throws ServiceNotFoundException if unable to resolve the service.
35 35
      * @throws ServiceNotCreatedException if an exception is raised when
36 36
      *     creating a service.
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
         $router = $container->get('Router');
47 47
         $select  = new MultipostingSelect();
48 48
         $helpers = $container->get('ViewHelperManager');
49
-        $currencyFormat  = $helpers->get('currencyFormat');
49
+        $currencyFormat = $helpers->get('currencyFormat');
50 50
 
51 51
         $channels = $container->get('Jobs/Options/Provider');
52 52
 
@@ -67,11 +67,11 @@  discard block
 block discarded – undo
67 67
 
68 68
             $link = $router->assemble($channel->getParams(), array('name' => $channel->getRoute()));
69 69
             $groups[$category]['options'][$channel->getKey()] =
70
-                $channel->getLabel() . '|'
71
-                . $channel->getHeadLine() . '|'
72
-                . $channel->getDescription() . '|'
73
-                . $channel->getLinkText() . '|'
74
-                . $link . '|' . $channel->getPublishDuration() . '|'
70
+                $channel->getLabel().'|'
71
+                . $channel->getHeadLine().'|'
72
+                . $channel->getDescription().'|'
73
+                . $channel->getLinkText().'|'
74
+                . $link.'|'.$channel->getPublishDuration().'|'
75 75
                 . $channel->getLogo();
76 76
         }
77 77
 
Please login to merge, or discard this patch.
module/Jobs/src/Factory/Repository/Filter/PaginationAdminQueryFactory.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@
 block discarded – undo
25 25
      * @param  string             $requestedName
26 26
      * @param  null|array         $options
27 27
      *
28
-     * @return object
28
+     * @return PaginationAdminQuery
29 29
      * @throws ServiceNotFoundException if unable to resolve the service.
30 30
      * @throws ServiceNotCreatedException if an exception is raised when
31 31
      *     creating a service.
Please login to merge, or discard this patch.
module/Jobs/src/Filter/ViewModelTemplateFilterAbstract.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -111,7 +111,7 @@
 block discarded – undo
111 111
 
112 112
     /**
113 113
      * @param mixed $value
114
-     * @return mixed|ViewModel
114
+     * @return ViewModel
115 115
      * @throws \InvalidArgumentException
116 116
      */
117 117
     public function filter($value)
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
      */
121 121
     public function setImageFileCacheHelper($imageFileCacheHelper)
122 122
     {
123
-        $this->imageFileCacheHelper=$imageFileCacheHelper;
123
+        $this->imageFileCacheHelper = $imageFileCacheHelper;
124 124
         return;
125 125
     }
126 126
 
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
         if (!isset($this->job)) {
147 147
             throw new \InvalidArgumentException('cannot create a viewModel for Templates without an $job');
148 148
         }
149
-        $model->setTemplate('templates/' . $this->job->getTemplate() . '/index');
149
+        $model->setTemplate('templates/'.$this->job->getTemplate().'/index');
150 150
         return $model;
151 151
     }
152 152
 
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
             throw new \InvalidArgumentException('cannot create a viewModel for Templates without aa $job');
207 207
         }
208 208
         $location = $this->job->getLocation();
209
-        $this->container['location'] = isset($location)?$location:'';
209
+        $this->container['location'] = isset($location) ? $location : '';
210 210
         return $this;
211 211
     }
212 212
 
@@ -227,7 +227,7 @@  discard block
 block discarded – undo
227 227
         }
228 228
         $description = $this->job->getTemplateValues()->getDescription();
229 229
 
230
-        $this->container['description'] = isset($description)?$description:'';
230
+        $this->container['description'] = isset($description) ? $description : '';
231 231
         return $this;
232 232
     }
233 233
 
@@ -291,9 +291,9 @@  discard block
 block discarded – undo
291 291
         if (!isset($this->job)) {
292 292
             throw new \InvalidArgumentException('cannot create a viewModel for Templates without a $job');
293 293
         }
294
-        $labelQualifications='';
295
-        $labelBenefits='';
296
-        $labelRequirements='';
294
+        $labelQualifications = '';
295
+        $labelBenefits = '';
296
+        $labelRequirements = '';
297 297
 
298 298
         $organization = $this->job->getOrganization();
299 299
         if (isset($organization)) {
Please login to merge, or discard this patch.
module/Jobs/src/Form/Hydrator/Strategy/JobManagerStrategy.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,6 @@
 block discarded – undo
46 46
      * Converts the given value so that it can be hydrated by the hydrator.
47 47
      *
48 48
      * @param mixed $value The original value.
49
-     * @param array $data  (optional) The original data for context.
50 49
      *
51 50
      * @return mixed Returns the value that should be hydrated.
52 51
      */
Please login to merge, or discard this patch.
module/Jobs/src/Options/ChannelOptions.php 2 patches
Doc Comments   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
     /**
155 155
      * Gets the unique key of a channel
156 156
      *
157
-     * @return string
157
+     * @return integer
158 158
      */
159 159
     public function getKey()
160 160
     {
@@ -176,7 +176,7 @@  discard block
 block discarded – undo
176 176
     /**
177 177
      * Gets the unique key of a channel
178 178
      *
179
-     * @return string
179
+     * @return integer
180 180
      */
181 181
     public function getExternalkey()
182 182
     {
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
     /**
260 260
      * Gets the tax for a price
261 261
      *
262
-     * @return string
262
+     * @return integer
263 263
      */
264 264
     public function getTax()
265 265
     {
@@ -352,7 +352,7 @@  discard block
 block discarded – undo
352 352
     /**
353 353
      * Gets the headline of the channel
354 354
      *
355
-     * @return mixed
355
+     * @return string
356 356
      */
357 357
     public function getHeadLine()
358 358
     {
@@ -390,7 +390,7 @@  discard block
 block discarded – undo
390 390
     }
391 391
 
392 392
     /**
393
-     * @return mixed
393
+     * @return string
394 394
      */
395 395
     public function getLinkText()
396 396
     {
@@ -408,7 +408,7 @@  discard block
 block discarded – undo
408 408
     }
409 409
 
410 410
     /**
411
-     * @return mixed
411
+     * @return string
412 412
      */
413 413
     public function getRoute()
414 414
     {
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
      *
82 82
      * @var int $publishDuration
83 83
      */
84
-    protected $publishDuration=30;
84
+    protected $publishDuration = 30;
85 85
 
86 86
     /**
87 87
      * Category for this channel
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
      */
141 141
     public function setKey($key)
142 142
     {
143
-        $this->key=$key;
143
+        $this->key = $key;
144 144
         return $this;
145 145
     }
146 146
 
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
      */
163 163
     public function setExternalkey($key)
164 164
     {
165
-        $this->externalkey=$key;
165
+        $this->externalkey = $key;
166 166
         return $this;
167 167
     }
168 168
 
Please login to merge, or discard this patch.
module/Organizations/src/Controller/IndexController.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -250,6 +250,9 @@
 block discarded – undo
250 250
         return $container;
251 251
     }
252 252
 
253
+    /**
254
+     * @param string $script
255
+     */
253 256
     protected function getErrorViewModel($script)
254 257
     {
255 258
         $this->getResponse()->setStatusCode(Response::STATUS_CODE_500);
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
         try {
125 125
             /* @var $handler \Organizations\Controller\Plugin\GetOrganizationHandler */
126 126
             $handler = $this->plugin('Organizations/GetOrganizationHandler');
127
-            $org  = $handler->process($this->params(), true);
127
+            $org = $handler->process($this->params(), true);
128 128
         } catch (MissingParentOrganizationException $e) {
129 129
             return $this->getErrorViewModel('no-parent');
130 130
         } catch (NotFoundException $e) {
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
             ];
136 136
         }
137 137
 
138
-        $container       = $this->getFormular($org);
138
+        $container = $this->getFormular($org);
139 139
 
140 140
         if (isset($formIdentifier) && $request->isPost()) {
141 141
             /* @var $form \Zend\Form\FormInterface */
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
             $form = $container->get($formIdentifier);
161 161
             $form->setData(array_merge($postData, $filesData));
162 162
             if (!isset($form)) {
163
-                throw new \RuntimeException('No form found for "' . $formIdentifier . '"');
163
+                throw new \RuntimeException('No form found for "'.$formIdentifier.'"');
164 164
             }
165 165
             $isValid = $form->isValid();
166 166
 
Please login to merge, or discard this patch.
module/Organizations/src/Controller/ProfileController.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -169,6 +169,9 @@
 block discarded – undo
169 169
         return new ViewModel($result);
170 170
     }
171 171
 
172
+    /**
173
+     * @param Organization $organization
174
+     */
172 175
     private function disabledProfileViewModel($organization)
173 176
     {
174 177
         $model = new ViewModel([
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
     public function indexAction()
80 80
     {
81 81
         $result = $this->pagination([
82
-            'params' => ['Organizations_Profile',[
82
+            'params' => ['Organizations_Profile', [
83 83
                     'q',
84 84
                     'count' => $this->options['count'],
85 85
                     'page' => 1,
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
 
136 136
         $result = $this->pagination([
137 137
             'params' => [
138
-                'Organization_Jobs',[
138
+                'Organization_Jobs', [
139 139
                     'q',
140 140
                     'organization_id' => $id,
141 141
                     'count' => $this->options['count'],
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
             /* @var \Zend\Paginator\Paginator $paginator */
155 155
             $paginator = $result['jobs'];
156 156
             $count = $paginator->getTotalItemCount();
157
-            if (0===$count) {
157
+            if (0 === $count) {
158 158
                 return $this->disabledProfileViewModel($organization);
159 159
             }
160 160
         }
Please login to merge, or discard this patch.
module/Organizations/src/Entity/Hydrator/Strategy/HttploadStrategy.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,6 @@
 block discarded – undo
32 32
     }
33 33
 
34 34
     /**
35
-     * @param mixed $value$organizationImageEntity
36 35
      *
37 36
      * @return mixed
38 37
      */
Please login to merge, or discard this patch.