cross-solution / YAWIK

module/Core/src/View/Helper/Services.php

Doc Comments -1 removed lines

@@ -86,7 +86,6 @@
     }
     
     /**
-     * @param HelperPluginManager $helperPluginManager
      * @return Services
      */
     public static function factory($sm)

module/Cv/src/Controller/ManageController.php

Doc Comments +3 added lines

@@ -173,6 +173,9 @@
         return $this->redirect()->refresh();
     }
 
+    /**
+     * @param \Cv\Repository\Cv $repository
+     */
     private function getCv($repository, $user)
     {
         $id =

module/Cv/src/Entity/Cv.php

Doc Comments +8 added lines, -5 removed lines

@@ -186,7 +186,7 @@ 
     }
     
     /**
-     * @return ArrayCollection
+     * @return IdentityWrapper
      */
     public function getEducationsIndexedById()
     {
@@ -215,7 +215,7 @@ 
     }
     
     /**
-     * @return ArrayCollection
+     * @return IdentityWrapper
      */
     public function getEmploymentsIndexedById()
     {
@@ -244,7 +244,7 @@ 
     }
     
     /**
-     * @return ArrayCollection
+     * @return IdentityWrapper
      */
     public function getSkillsIndexedById()
     {
@@ -322,7 +322,7 @@ 
     }
 
     /**
-     * @return ArrayCollection
+     * @return IdentityWrapper
      */
     public function getLanguageSkillsIndexedById()
     {
@@ -360,7 +360,7 @@ 
     }
     
     /**
-     * @param Status|string $status
+     * @param string $status
      */
     public function setStatus($status)
     {
@@ -407,6 +407,9 @@ 
         }
     }
 
+    /**
+     * @param UserInterface $oldUser
+     */
     private function updatePermissions($oldUser = null)
     {
         $hasPermissions = (bool) $this->permissions;

Indentation +5 added lines, -5 removed lines

@@ -60,11 +60,11 @@
     protected $skills;
 
     /**
-    * Skills
-    *
-    * @var ArrayCollection
-    * @ODM\EmbedMany(targetDocument="\Cv\Entity\Language")
-    */
+     * Skills
+     *
+     * @var ArrayCollection
+     * @ODM\EmbedMany(targetDocument="\Cv\Entity\Language")
+     */
     protected $languageSkills;
 
     /**

Spacing +3 added lines, -3 removed lines

@@ -82,7 +82,7 @@ 
      * @var array
      * @ODM\Field(type="collection")
      */
-    protected $nativeLanguages=[];
+    protected $nativeLanguages = [];
 
 
     /**
@@ -267,7 +267,7 @@ 
      */
     public function setIsDraft($isDraft)
     {
-        $this->isDraft=$isDraft;
+        $this->isDraft = $isDraft;
         return $this;
     }
 
@@ -337,7 +337,7 @@ 
      */
     public function setNativeLanguages($nativeLanguages)
     {
-        $this->nativeLanguages=$nativeLanguages;
+        $this->nativeLanguages = $nativeLanguages;
         return $this;
     }
 

module/Cv/src/Options/ModuleOptions.php

Doc Comments +1 added lines, -1 removed lines

@@ -93,7 +93,7 @@
     /**
      * Gets the the maximum number of allowed attachments
      *
-     * @return string
+     * @return integer
      */
     public function getAttachmentsCount()
     {

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
      *
      * @var array $attachmentsMimeType
      */
-    protected $attachmentsMimeType = array('image','applications/pdf',
+    protected $attachmentsMimeType = array('image', 'applications/pdf',
         'application/x-pdf',
         'application/acrobat',
         'applications/vnd.pdf',

module/Cv/src/Repository/Cv.php

Doc Comments +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
      * Look for an drafted Document of a given user
      *
      * @param $user
-     * @return CvEntity|null
+     * @return \MongoCursor
      */
     public function findDraft($user)
     {

module/Geo/src/Service/AbstractClient.php

Doc Comments +6 added lines

@@ -38,6 +38,9 @@ 
     protected $country;
 
 
+    /**
+     * @param string $uri
+     */
     public function __construct($uri, $country="DE", $cache = false)
     {
         $this->country = $country;
@@ -92,6 +95,9 @@ 
         return isset($result[0]) ? $result[0] : false;
     }
 
+    /**
+     * @param string $result
+     */
     protected function processResult($result)
     {
         return $result;

Spacing +2 added lines, -2 removed lines

@@ -38,7 +38,7 @@ 
     protected $country;
 
 
-    public function __construct($uri, $country="DE", $cache = false)
+    public function __construct($uri, $country = "DE", $cache = false)
     {
         $this->country = $country;
         $this->client = $this->setupClient($uri);
@@ -72,7 +72,7 @@ 
 
         $response = $this->client->send();
         if ($response->getStatusCode() !== 200) {
-            throw new \RuntimeException('Query failed, because ' . $response->getReasonPhrase());
+            throw new \RuntimeException('Query failed, because '.$response->getReasonPhrase());
         }
 
         $result = $response->getBody();

module/Jobs/src/Controller/ManageController.php

Doc Comments +3 added lines, -4 removed lines

@@ -165,7 +165,6 @@ 
      *
      * parameter are arbitrary elements for defaults or programming flow
      *
-     * @param array $parameter
      * @return null|ViewModel
      * @throws \RuntimeException
      */
@@ -388,7 +387,7 @@ 
 
     /**
      * @param  $job \Jobs\Entity\Job
-     * @return mixed
+     * @return \Jobs\Form\Job
      */
     protected function getFormular($job)
     {
@@ -411,7 +410,7 @@ 
     }
 
     /**
-     * @param $form
+     * @param \Jobs\Form\Job $form
      * @param array $params
      * @return ViewModel
      */
@@ -604,7 +603,7 @@ 
     }
 
     /**
-     * @param $script
+     * @param string $script
      * @param array $parameter
      * @return ViewModel
      */

Indentation +47 added lines, -47 removed lines

@@ -66,16 +66,16 @@ 
      */
     protected $translator;
 	
-	/**
-	 * @var FilterPluginManager
-	 */
+    /**
+     * @var FilterPluginManager
+     */
     protected $filterManager;
     
     protected $jobFormEvents;
 	
-	/**
-	 * @var
-	 */
+    /**
+     * @var
+     */
     protected $formManager;
     
     protected $options;
@@ -88,35 +88,35 @@ 
     
     protected $jobEvent;
 	
-	/**
-	 * ManageController constructor.
-	 *
-	 * @TODO: [ZF3] make this controller more thin, looks like so much things to do
-	 *
-	 * @param AuthenticationService $auth
-	 * @param RepositoryService $repositoryService
-	 * @param TranslatorInterface $translator
-	 * @param FilterPluginManager $filterManager
-	 * @param EventManagerInterface $jobFormEvents
-	 * @param $formManager
-	 * @param $options
-	 * @param HelperPluginManager $viewHelper
-	 * @param ValidatorPluginManager $validatorManager
-	 * @param EventManagerInterface $jobEvents
-	 * @param EventInterface $jobEvent
-	 */
+    /**
+     * ManageController constructor.
+     *
+     * @TODO: [ZF3] make this controller more thin, looks like so much things to do
+     *
+     * @param AuthenticationService $auth
+     * @param RepositoryService $repositoryService
+     * @param TranslatorInterface $translator
+     * @param FilterPluginManager $filterManager
+     * @param EventManagerInterface $jobFormEvents
+     * @param $formManager
+     * @param $options
+     * @param HelperPluginManager $viewHelper
+     * @param ValidatorPluginManager $validatorManager
+     * @param EventManagerInterface $jobEvents
+     * @param EventInterface $jobEvent
+     */
     public function __construct(
-    	AuthenticationService $auth,
-	    RepositoryService $repositoryService,
-	    TranslatorInterface $translator,
-		FilterPluginManager $filterManager,
-		EventManagerInterface $jobFormEvents,
-		$formManager,
-		$options,
-		HelperPluginManager $viewHelper,
-		ValidatorPluginManager $validatorManager,
-		EventManagerInterface $jobEvents,
-		EventInterface $jobEvent
+        AuthenticationService $auth,
+        RepositoryService $repositoryService,
+        TranslatorInterface $translator,
+        FilterPluginManager $filterManager,
+        EventManagerInterface $jobFormEvents,
+        $formManager,
+        $options,
+        HelperPluginManager $viewHelper,
+        ValidatorPluginManager $validatorManager,
+        EventManagerInterface $jobEvents,
+        EventInterface $jobEvent
     )
     {
         $this->auth = $auth;
@@ -157,7 +157,7 @@ 
         }
         $routeMatch = $e->getRouteMatch();
         $action = $routeMatch->getParam('action');
-	    $services = $e->getApplication()->getServiceManager();
+        $services = $e->getApplication()->getServiceManager();
         if (in_array($action, array('edit', 'approval', 'completion'))) {
             $jobEvents = $services->get('Jobs/Events');
             $mailSender = $services->get('Jobs/Listener/MailSender');
@@ -202,12 +202,12 @@ 
         $jobEntity = $this->initializeJob()->get($this->params(), true);
 
         $model = new ViewModel([
-                                   'portals' => $jobEntity->getPortals(),
-                                   'channels' => $channels,
-                                   'defaultCurrencyCode' => $options->defaultCurrencyCode,
-                                   'defaultTaxRate' =>  $options->defaultTaxRate,
-                                   'jobId' => $jobEntity->getId()
-                               ]);
+                                    'portals' => $jobEntity->getPortals(),
+                                    'channels' => $channels,
+                                    'defaultCurrencyCode' => $options->defaultCurrencyCode,
+                                    'defaultTaxRate' =>  $options->defaultTaxRate,
+                                    'jobId' => $jobEntity->getId()
+                                ]);
         $model->setTemplate('jobs/partials/channel-list')->setTerminal(true);
         return $model;
     }
@@ -225,7 +225,7 @@ 
      */
     protected function save()
     {
-		$formEvents = $this->jobFormEvents;
+        $formEvents = $this->jobFormEvents;
         $user               = $this->auth->getUser();
         if (empty($user->getInfo()->getEmail())) {
             return $this->getErrorViewModel('no-parent', array('cause' => 'noEmail'));
@@ -584,7 +584,7 @@ 
             'lang/jobs/view',
             array(),
             array('query' => $query
-                      )
+                        )
         );
 
         $approvalLink = $this->url()->fromRoute(
@@ -600,10 +600,10 @@ 
         );
 
         return array('job' => $jobEntity,
-                     'diffSnapshot' => $diff,
-                     'viewLink' => $viewLink,
-                     'approvalLink' => $approvalLink,
-                     'declineLink' => $declineLink);
+                        'diffSnapshot' => $diff,
+                        'viewLink' => $viewLink,
+                        'approvalLink' => $approvalLink,
+                        'declineLink' => $declineLink);
     }
 
     /**

Spacing +16 added lines, -16 removed lines

@@ -227,11 +227,11 @@ 
     protected function save()
     {
 		$formEvents = $this->jobFormEvents;
-        $user               = $this->auth->getUser();
+        $user = $this->auth->getUser();
         if (empty($user->getInfo()->getEmail())) {
             return $this->getErrorViewModel('no-parent', array('cause' => 'noEmail'));
         }
-        $userOrg            = $user->getOrganization();
+        $userOrg = $user->getOrganization();
         if (!$userOrg->hasAssociation() || $userOrg->getOrganization()->isDraft()) {
             return $this->getErrorViewModel('no-parent', array('cause' => 'noCompany'));
         }
@@ -261,7 +261,7 @@ 
         }
 
 
-        $viewModel          = null;
+        $viewModel = null;
         $this->acl($jobEntity, 'edit');
         if ($status = $params->fromQuery('status')) {
             $this->changeStatus($jobEntity, $status);
@@ -273,11 +273,11 @@ 
         $instanceForm       = null;
         $formErrorMessages = array();
 
-        if (isset($formIdentifier) &&  $request->isPost()) {
+        if (isset($formIdentifier) && $request->isPost()) {
             // at this point the form get instantiated and immediately accumulated
             $instanceForm = $form->getForm($formIdentifier);
             if (!isset($instanceForm)) {
-                throw new \RuntimeException('No form found for "' . $formIdentifier . '"');
+                throw new \RuntimeException('No form found for "'.$formIdentifier.'"');
             }
             // the id may be part of the postData, but it never should be altered
             $postData = $request->getPost();
@@ -331,20 +331,20 @@ 
             $jobValid = false;
             $errorMessage[] = $this->translator->translate('Accept the Terms');
         }
-        $result = $formEvents->trigger('ValidateJob', $this, [ 'form' => $form ]);
+        $result = $formEvents->trigger('ValidateJob', $this, ['form' => $form]);
         foreach ($result as $messages) {
             if (!$messages) {
                 continue;
             }
             if (!is_array($messages)) {
-                $messages = [ $messages ];
+                $messages = [$messages];
             }
 
             $errorMessage = array_merge($errorMessage, $messages);
             $jobValid = false;
         }
 
-        $errorMessage = '<br />' . implode('<br />', $errorMessage);
+        $errorMessage = '<br />'.implode('<br />', $errorMessage);
         if ($isAjax) {
             if ($instanceForm instanceof SummaryForm) {
                 $instanceForm->setRenderMode(SummaryForm::RENDER_SUMMARY);
@@ -352,7 +352,7 @@ 
             } else {
                 $viewHelper = 'form';
             }
-            $viewHelperManager  = $this->viewHelper;
+            $viewHelperManager = $this->viewHelper;
             $content = $viewHelperManager->get($viewHelper)->__invoke($instanceForm);
             $viewModel = new JsonModel(
                 array(
@@ -376,7 +376,7 @@ 
                     }
                 }
             } else {
-                $formEvents->trigger('DisableElements', $this, [ 'form' => $form, 'job'=>$jobEntity ]);
+                $formEvents->trigger('DisableElements', $this, ['form' => $form, 'job'=>$jobEntity]);
                 // Job is deployed, some changes are now disabled
                 $form->enableAll();
             }
@@ -384,7 +384,7 @@ 
 
             $completionLink = $this->url()->fromRoute(
                 'lang/jobs/completion',
-                [ 'id' => $jobEntity->getId()]
+                ['id' => $jobEntity->getId()]
             );
 
             $viewModel = $this->getViewModel($form);
@@ -450,7 +450,7 @@ 
     protected function getFormular($job)
     {
         /* @var $forms \Zend\Form\FormElementManager\FormElementManagerV3Polyfill */
-        $forms    = $this->formManager;
+        $forms = $this->formManager;
         /* @var $container \Jobs\Form\Job */
 
         $container = $forms->get(
@@ -552,15 +552,15 @@ 
         $jobEvent->setJobEntity($jobEntity);
         $jobEvent->addPortal('XingVendorApi');
         $jobEvent->setTarget($this);
-        $jobEvents      = $this->jobEvents;
+        $jobEvents = $this->jobEvents;
         // array with differences between the last snapshot and the actual entity
         // is remains Null if there is no snapshot
         // it will be an empty array if the snapshot and the actual entity do not differ
-        $diff           = null;
+        $diff = null;
 
 
         if ($params == 'declined') {
-            if ($jobEntity instanceOf JobSnapshot)  {
+            if ($jobEntity instanceOf JobSnapshot) {
                 $jobEntity->getOriginalEntity()->changeStatus(
                     Status::ACTIVE,
                     sprintf(
@@ -638,7 +638,7 @@ 
      */
     public function deactivateAction()
     {
-        $user           = $this->auth->getUser();
+        $user = $this->auth->getUser();
 
         $jobEntity = $this->initializeJob()->get($this->params());
 

module/Jobs/src/Entity/Decorator/JsonLdProvider.php

Doc Comments +1 added lines

@@ -82,6 +82,7 @@
      * Generates a location array
      *
      * @param Collection $locations,
+     * @param string $locations
      *
      * @return array
      */

Spacing +4 added lines, -4 removed lines

@@ -58,7 +58,7 @@ 
             $dateEnd->add(new \DateInterval("P180D"));
             $dateEnd = $dateEnd->format('Y-m-d H:i:s');
         }
-        $array=[
+        $array = [
             '@context'=>'http://schema.org/',
             '@type' => 'JobPosting',
             'title' => $this->job->getTitle(),
@@ -93,7 +93,7 @@ 
      */
     private function getLocations($locations)
     {
-        $array=[];
+        $array = [];
         foreach ($locations as $location) { /* @var \Core\Entity\LocationInterface $location */
             array_push(
                 $array,
@@ -101,7 +101,7 @@ 
                     '@type' => 'Place',
                     'address' => [
                         '@type' => 'PostalAddress',
-                        'streetAddress' => $location->getStreetname() .' '.$location->getStreetnumber(),
+                        'streetAddress' => $location->getStreetname().' '.$location->getStreetnumber(),
                         'postalCode' => $location->getPostalCode(),
                         'addressLocality' => $location->getCity(),
                         'addressCountry' => $location->getCountry(),
@@ -122,7 +122,7 @@ 
      */
     private function getDescription(TemplateValuesInterface $values)
     {
-        $description=sprintf(
+        $description = sprintf(
             "<p>%s</p>".
             "<h1>%s</h1>".
             "<h3>Requirements</h3><p>%s</p>".

module/Jobs/src/Entity/History.php

Doc Comments +3 added lines

@@ -41,6 +41,9 @@
      */
     protected $message;
     
+    /**
+     * @param StatusInterface|null $status
+     */
     public function __construct($status, $message = '[System]')
     {
         if (!$status instanceof StatusInterface) {