Completed
Push — develop ( fd8298...e653e2 )
by Carsten
14s
created
module/Geo/src/Geo/Service/AbstractClient.php 2 patches
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -36,6 +36,9 @@  discard block
 block discarded – undo
36 36
     protected $cache;
37 37
 
38 38
 
39
+    /**
40
+     * @param string $uri
41
+     */
39 42
     public function __construct($uri, $cache = false)
40 43
     {
41 44
         $this->client = $this->setupClient($uri);
@@ -90,6 +93,9 @@  discard block
 block discarded – undo
90 93
         return isset($result[0]) ? $result[0] : false;
91 94
     }
92 95
 
96
+    /**
97
+     * @param string $result
98
+     */
93 99
     protected function processResult($result)
94 100
     {
95 101
         return $result;
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@
 block discarded – undo
69 69
 
70 70
         $response = $this->client->send();
71 71
         if ($response->getStatusCode() !== 200) {
72
-            throw new \RuntimeException('Query failed, because ' . $response->getReasonPhrase());
72
+            throw new \RuntimeException('Query failed, because '.$response->getReasonPhrase());
73 73
         }
74 74
 
75 75
         $result = $response->getBody();
Please login to merge, or discard this patch.
module/Core/src/Core/Form/SearchForm.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -167,7 +167,7 @@
 block discarded – undo
167 167
                     'label' => $label,
168 168
                 ],
169 169
                 'attributes' => [
170
-                    'class' => 'btn btn-' . ('submit' == $type ? 'primary' : 'default'),
170
+                    'class' => 'btn btn-'.('submit' == $type ? 'primary' : 'default'),
171 171
                     'type'  => $type,
172 172
                 ],
173 173
             ]
Please login to merge, or discard this patch.
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -47,6 +47,9 @@  discard block
 block discarded – undo
47 47
         $this->buttonsIterator->isLIFO(false);
48 48
     }
49 49
 
50
+    /**
51
+     * @param string $name
52
+     */
50 53
     public function setButtonElement($name)
51 54
     {
52 55
         return $this->setOption('button_element', $name);
@@ -182,6 +185,9 @@  discard block
 block discarded – undo
182 185
         return $this->buttonsIterator;
183 186
     }
184 187
 
188
+    /**
189
+     * @param string $name
190
+     */
185 191
     public function addButton($name, $priority = 0, $type = 'button')
186 192
     {
187 193
         if (is_array($name)) {
Please login to merge, or discard this patch.
module/Core/src/Core/Entity/Snapshot.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@
 block discarded – undo
23 23
 {
24 24
     /**
25 25
      * @param $data
26
-     * @return mixed
26
+     * @return Snapshot
27 27
      * @ODM\PreUpdate
28 28
      */
29 29
     public function __invoke($data)
Please login to merge, or discard this patch.
module/Core/src/Core/Repository/AbstractRepository.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
     }
37 37
 
38 38
     /**
39
-     * @param $name
39
+     * @param string $name
40 40
      *
41 41
      * @return mixed
42 42
      */
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
     /**
60 60
      * @param array $data
61 61
      *
62
-     * @return mixed
62
+     * @return EntityInterface
63 63
      */
64 64
     public function create(array $data = null, $persist = false)
65 65
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -130,7 +130,7 @@
 block discarded – undo
130 130
 
131 131
     protected function checkEntityType($entity)
132 132
     {
133
-        if ( !($entity instanceOf $this->entityPrototype) ) {
133
+        if (!($entity instanceOf $this->entityPrototype)) {
134 134
             throw new \InvalidArgumentException(sprintf(
135 135
                                                     'Entity must be of type %s but recieved %s instead',
136 136
                                                     get_class($this->entityPrototype),
Please login to merge, or discard this patch.
module/Core/src/Core/Repository/DoctrineMongoODM/PersistenceListener.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,6 @@
 block discarded – undo
26 26
      * Attach to an event manager
27 27
      *
28 28
      * @param  EventManagerInterface $events
29
-     * @param  integer $priority
30 29
      */
31 30
     public function attach(EventManagerInterface $events)
32 31
     {
Please login to merge, or discard this patch.
module/Organizations/src/Organizations/Controller/IndexController.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -250,6 +250,9 @@
 block discarded – undo
250 250
         return $container;
251 251
     }
252 252
 
253
+    /**
254
+     * @param string $script
255
+     */
253 256
     protected function getErrorViewModel($script)
254 257
     {
255 258
         $this->getResponse()->setStatusCode(Response::STATUS_CODE_500);
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
         try {
125 125
             /* @var $handler \Organizations\Controller\Plugin\GetOrganizationHandler */
126 126
             $handler = $this->plugin('Organizations/GetOrganizationHandler');
127
-            $org  = $handler->process($this->params(), true);
127
+            $org = $handler->process($this->params(), true);
128 128
         } catch (MissingParentOrganizationException $e) {
129 129
             return $this->getErrorViewModel('no-parent');
130 130
         } catch (NotFoundException $e) {
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
             ];
136 136
         }
137 137
 
138
-        $container       = $this->getFormular($org);
138
+        $container = $this->getFormular($org);
139 139
 
140 140
         if (isset($formIdentifier) && $request->isPost()) {
141 141
             /* @var $form \Zend\Form\FormInterface */
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
             $form = $container->get($formIdentifier);
161 161
             $form->setData(array_merge($postData, $filesData));
162 162
             if (!isset($form)) {
163
-                throw new \RuntimeException('No form found for "' . $formIdentifier . '"');
163
+                throw new \RuntimeException('No form found for "'.$formIdentifier.'"');
164 164
             }
165 165
             $isValid = $form->isValid();
166 166
 
Please login to merge, or discard this patch.
src/Organizations/Controller/Plugin/GetOrganizationHandler.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@
 block discarded – undo
59 59
      * @param Params $params
60 60
      * @param bool   $allowDraft
61 61
      *
62
-     * @return object|\Organizations\Entity\Organization
62
+     * @return \Organizations\Entity\OrganizationInterface
63 63
      * @throws UnauthorizedAccessException
64 64
      * @throws \Doctrine\ODM\MongoDB\LockException
65 65
      * @throws NotFoundException
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -44,10 +44,10 @@  discard block
 block discarded – undo
44 44
      */
45 45
     protected $acl;
46 46
 
47
-    public function __construct(RepositoryService $repositoryService,AuthenticationService $auth, Acl $acl) {
48
-        $this->repositoryService=$repositoryService;
49
-        $this->auth=$auth;
50
-        $this->acl=$acl;
47
+    public function __construct(RepositoryService $repositoryService, AuthenticationService $auth, Acl $acl) {
48
+        $this->repositoryService = $repositoryService;
49
+        $this->auth = $auth;
50
+        $this->acl = $acl;
51 51
     }
52 52
 
53 53
     public function __invoke()
@@ -64,9 +64,9 @@  discard block
 block discarded – undo
64 64
      * @throws \Doctrine\ODM\MongoDB\LockException
65 65
      * @throws NotFoundException
66 66
      */
67
-    public function process(Params $params,$allowDraft = true)
67
+    public function process(Params $params, $allowDraft = true)
68 68
     {
69
-        $repositories   = $this->repositoryService;
69
+        $repositories = $this->repositoryService;
70 70
         /* @var \Organizations\Repository\Organization $organizationRepository */
71 71
         $organizationRepository = $this->repositoryService->get('Organizations/Organization');
72 72
 
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
         $user = $this->auth->getUser(); /* @var $user \Auth\Entity\UserInterface */
76 76
 
77 77
         /* @var $organizationId string */
78
-        $organizationId = empty($idFromRoute)?$idFromSubForm:$idFromRoute;
78
+        $organizationId = empty($idFromRoute) ? $idFromSubForm : $idFromRoute;
79 79
 
80 80
         $editOwnOrganization = '__my__' === $organizationId;
81 81
 
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
             return $organization;
111 111
         }
112 112
 
113
-        $organization      = $organizationRepository->find($organizationId);
113
+        $organization = $organizationRepository->find($organizationId);
114 114
         if (!$organization) {
115 115
             throw new NotFoundException($organizationId);
116 116
         }
Please login to merge, or discard this patch.
module/Settings/src/Settings/Form/FormAbstract.php 1 patch
Doc Comments   +8 added lines patch added patch discarded remove patch
@@ -31,6 +31,11 @@  discard block
 block discarded – undo
31 31
         return $this->hydrator;
32 32
     }
33 33
     
34
+    /**
35
+     * @param string $name
36
+     *
37
+     * @return callable
38
+     */
34 39
     protected function getPlugin($name)
35 40
     {
36 41
         $plugin = null;
@@ -69,6 +74,9 @@  discard block
 block discarded – undo
69 74
         $this->add($this->formManager->get('DefaultButtonsFieldset'));
70 75
     }
71 76
     
77
+    /**
78
+     * @return string
79
+     */
72 80
     abstract public function getCoreFieldset();
73 81
     
74 82
     /**
Please login to merge, or discard this patch.
module/Core/src/Core/Controller/AdminControllerEvent.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@
 block discarded – undo
61 61
      *
62 62
      * @return self
63 63
      */
64
-    public function addViewModel($name, $model, $priority=0)
64
+    public function addViewModel($name, $model, $priority = 0)
65 65
     {
66 66
         $this->models->insert($name, $model, $priority);
67 67
 
Please login to merge, or discard this patch.