IndexController - Code Metrics - Inspection of "Merge branch 'feature/workflow-settings' into deve..." - cross-solution/YAWIK - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( e649e8...88dc2a )

unknown

created 2016-05-02 17:07 UTC

IndexController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	34
Duplicated Lines	76.47 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	4
Bugs	0	Features	2

Metric	Value
wmc	3
c	4
b	0
f	2
lcom	1
cbo	4
dl	26
loc	34
rs	10

1 Method

Rating	Name	Duplication	Size	Complexity
B	dashboardAction()	26	26	3

How to fix Duplicated Code

<?php
/**
 * YAWIK
 *
 * @filesource
 * @copyright (c) 2013 - 2016 Cross Solution (http://cross-solution.de)
 * @license   MIT
 */

/** Applications controller */
namespace Applications\Controller;


use Zend\Http\Request;
use Zend\Mvc\Controller\AbstractActionController;
use Zend\View\Model\ViewModel;
use Zend\View\Model\JsonModel;


/**
 * Main Action Controller for Applications module.
 *
 * @method \Core\Controller\Plugin\CreatePaginator paginator()
 * @method \Acl\Controller\Plugin\Acl acl()
 */
class IndexController extends AbstractActionController
{
    /**
     * Handles dashboard listings of applications
     *
     * @return array
     */
    public function dashboardAction()

    {
        /* @var Request $request */
        $request = $this->getRequest();
        $params = $request->getQuery();
        $isRecruiter = $this->acl()->isRole('recruiter');
        if ($isRecruiter) {
            $params->set('by', 'me');
        }

         //default sorting
        if (!isset($params['sort'])) {
            $params['sort']="-date";
        }
        $params->count = 5;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $params->pageRange=5;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        $this->paginationParams()->setParams('Applications\Index', $params);


        $paginator = $this->paginator('Applications', $params->toArray());

     
        return array(
            'script' => 'applications/index/dashboard',
            'applications' => $paginator
        );
    }
}


Push — develop ( e649e8...88dc2a )

IndexController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

1		<?php
2		/**
3		* YAWIK
4		*
5		* @filesource
6		* @copyright (c) 2013 - 2016 Cross Solution (http://cross-solution.de)
7		* @license MIT
8		*/
9
10		/** Applications controller */
11		namespace Applications\Controller;
12
13
14		use Zend\Http\Request;
15		use Zend\Mvc\Controller\AbstractActionController;
16		use Zend\View\Model\ViewModel;
17		use Zend\View\Model\JsonModel;
18
19
20		/**
21		* Main Action Controller for Applications module.
22		*
23		* @method \Core\Controller\Plugin\CreatePaginator paginator()
24		* @method \Acl\Controller\Plugin\Acl acl()
25		*/
26		class IndexController extends AbstractActionController
27		{
28		/**
29		* Handles dashboard listings of applications
30		*
31		* @return array
32		*/
33	View Code Duplication	public function dashboardAction()
		0 ignored issues – show Duplication introduced 2015-11-30 11:54 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
34		{
35		/* @var Request $request */
36		$request = $this->getRequest();
37		$params = $request->getQuery();
38		$isRecruiter = $this->acl()->isRole('recruiter');
39		if ($isRecruiter) {
40		$params->set('by', 'me');
41		}
42
43		//default sorting
44		if (!isset($params['sort'])) {
45		$params['sort']="-date";
46		}
47		$params->count = 5;
		0 ignored issues – show Bug introduced 2016-05-02 17:15 UTC by Report Bug Copy Issue Report Accessing `count` on the interface `Zend\Stdlib\ParametersInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
48		$params->pageRange=5;
		0 ignored issues – show Bug introduced 2016-05-02 17:15 UTC by Report Bug Copy Issue Report Accessing `pageRange` on the interface `Zend\Stdlib\ParametersInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
49
50		$this->paginationParams()->setParams('Applications\Index', $params);
		0 ignored issues – show Bug introduced 2015-11-30 11:54 UTC by Report Bug Copy Issue Report The method `paginationParams()` does not exist on `Applications\Controller\IndexController`. Did you maybe mean `params()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
51
52		$paginator = $this->paginator('Applications', $params->toArray());
		0 ignored issues – show Unused Code introduced 2016-03-01 09:01 UTC by Report Bug Copy Issue Report The call to `IndexController::paginator()` has too many arguments starting with `'Applications'`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
53
54		return array(
55		'script' => 'applications/index/dashboard',
56		'applications' => $paginator
57		);
58		}
59		}
60

cross-solution / YAWIK

Push — develop ( e649e8...88dc2a )

IndexController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like