Completed
Pull Request — develop (#235)
by ANTHONIUS
08:47
created
module/Core/src/Core/Form/View/Helper/FormCollectionContainer.php 3 patches
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
         $translator = $this->getTranslator();
56 56
         $formContainerHelper = $view->formContainer();
57 57
         $formsMarkup = '';
58
-		$formTemplateWrapper = '<div class="form-collection-container-form">
58
+        $formTemplateWrapper = '<div class="form-collection-container-form">
59 59
             <button type="button" class="btn btn-sm btn-danger pull-right form-collection-container-remove-button">' . $translator->translate('Remove') . '</button>
60 60
             %s
61 61
         </div>';
@@ -66,16 +66,16 @@  discard block
 block discarded – undo
66 66
         }
67 67
         
68 68
         $templateForm = $container->getTemplateForm();
69
-		$templateMarkup = sprintf(
69
+        $templateMarkup = sprintf(
70 70
             $view->formCollection()->getTemplateWrapper(),
71 71
             $view->escapeHtmlAttr(sprintf($formTemplateWrapper, $formContainerHelper->renderElement($templateForm, $layout, $parameter)))
72 72
         );
73 73
         
74
-		return sprintf('<div class="form-collection-container" data-new-entry-key="%s" data-remove-action="%s" data-remove-question="%s">
74
+        return sprintf('<div class="form-collection-container" data-new-entry-key="%s" data-remove-action="%s" data-remove-question="%s">
75 75
                 <h3>%s</h3>
76 76
                 %s%s%s
77 77
             </div>',
78
-		    CollectionContainer::NEW_ENTRY,
78
+            CollectionContainer::NEW_ENTRY,
79 79
             $container->formatAction('remove'),
80 80
             $translator->translate('Really remove?'),
81 81
             $container->getLabel(),
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
         $formContainerHelper = $view->formContainer();
57 57
         $formsMarkup = '';
58 58
 		$formTemplateWrapper = '<div class="form-collection-container-form">
59
-            <button type="button" class="btn btn-sm btn-danger pull-right form-collection-container-remove-button">' . $translator->translate('Remove') . '</button>
59
+            <button type="button" class="btn btn-sm btn-danger pull-right form-collection-container-remove-button">' . $translator->translate('Remove').'</button>
60 60
             %s
61 61
         </div>';
62 62
         
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
             $container->getLabel(),
82 82
             $formsMarkup,
83 83
             $templateMarkup,
84
-            '<div class="form-collection-container-add-wrapper"><button type="button" class="btn btn-success form-collection-container-add-button">' . sprintf($translator->translate('Add %s'), $container->getLabel()) . '</button></div>'
84
+            '<div class="form-collection-container-add-wrapper"><button type="button" class="btn btn-success form-collection-container-add-button">'.sprintf($translator->translate('Add %s'), $container->getLabel()).'</button></div>'
85 85
         );
86 86
     }
87 87
 }
Please login to merge, or discard this patch.
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -60,10 +60,12 @@
 block discarded – undo
60 60
             %s
61 61
         </div>';
62 62
         
63
-        foreach ($container as $form) /* @var $form \Zend\Form\Form */
63
+        foreach ($container as $form) {
64
+            /* @var $form \Zend\Form\Form */
64 65
         {
65 66
             $formsMarkup .= sprintf($formTemplateWrapper, $formContainerHelper->renderElement($form, $layout, $parameter));
66 67
         }
68
+        }
67 69
         
68 70
         $templateForm = $container->getTemplateForm();
69 71
 		$templateMarkup = sprintf(
Please login to merge, or discard this patch.
module/Cv/src/Cv/Form/SkillCollectionFactory.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,6 +16,6 @@
 block discarded – undo
16 16
         $container = new \Core\Form\CollectionContainer('CvEmploymentForm', new \Cv\Entity\Employment());
17 17
         $container->setLabel(/*@translate */ 'Employment history');
18 18
         
19
-		return $container;
19
+        return $container;
20 20
     }
21 21
 }
Please login to merge, or discard this patch.
module/Cv/src/Cv/Form/LanguageSkillCollectionFactory.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,6 +16,6 @@
 block discarded – undo
16 16
         $container = new \Core\Form\CollectionContainer('CvEmploymentForm', new \Cv\Entity\Employment());
17 17
         $container->setLabel(/*@translate */ 'Employment history');
18 18
         
19
-		return $container;
19
+        return $container;
20 20
     }
21 21
 }
Please login to merge, or discard this patch.
module/Cv/src/Cv/Form/PreferredJobFieldset.php 1 patch
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -32,9 +32,9 @@
 block discarded – undo
32 32
     public function init()
33 33
     {
34 34
         $this->setName('preferredJob')
35
-             ->setHydrator(new EntityHydrator())
36
-             ->setObject(new PreferredJob())
37
-             ->setLabel('Desired Employment');
35
+                ->setHydrator(new EntityHydrator())
36
+                ->setObject(new PreferredJob())
37
+                ->setLabel('Desired Employment');
38 38
 
39 39
         $this->add(
40 40
             array(
Please login to merge, or discard this patch.
module/Cv/src/Cv/Form/PreferredJobForm.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -11,7 +11,7 @@
 block discarded – undo
11 11
 
12 12
     public function init()
13 13
     {
14
-      //  $this->setDescription(/*@translate*/' Where do you want to work tomorrow. This heading gives an immediate overview of your desired next job.');
14
+        //  $this->setDescription(/*@translate*/' Where do you want to work tomorrow. This heading gives an immediate overview of your desired next job.');
15 15
         $this->setIsDescriptionsEnabled(true);
16 16
         parent::init();
17 17
     }
Please login to merge, or discard this patch.
module/Cv/src/Cv/Form/NativeLanguageFieldset.php 1 patch
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -124,9 +124,9 @@
 block discarded – undo
124 124
     public function init()
125 125
     {
126 126
         $this->setName('nativeLanguages')
127
-             ->setHydrator(new EntityHydrator())
128
-             ->setObject(new NativeLanguageEntity())
129
-             ->setLabel('Native Language');
127
+                ->setHydrator(new EntityHydrator())
128
+                ->setObject(new NativeLanguageEntity())
129
+                ->setLabel('Native Language');
130 130
 
131 131
 
132 132
         $this->add(
Please login to merge, or discard this patch.
module/Cv/src/Cv/Entity/Cv.php 3 patches
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -60,11 +60,11 @@
 block discarded – undo
60 60
     protected $skills;
61 61
 
62 62
     /**
63
-    * Skills
64
-    *
65
-    * @var ArrayCollection
66
-    * @ODM\EmbedMany(targetDocument="\Cv\Entity\Language")
67
-    */
63
+     * Skills
64
+     *
65
+     * @var ArrayCollection
66
+     * @ODM\EmbedMany(targetDocument="\Cv\Entity\Language")
67
+     */
68 68
     protected $languageSkills;
69 69
 
70 70
     /**
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
      * @var array
72 72
      * @ODM\Collection
73 73
      */
74
-    protected $nativeLanguages=[];
74
+    protected $nativeLanguages = [];
75 75
 
76 76
 
77 77
     /**
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
 
217 217
     public function setIsDraft($isDraft)
218 218
     {
219
-        $this->isDraft=$isDraft;
219
+        $this->isDraft = $isDraft;
220 220
         return $this;
221 221
     }
222 222
 
@@ -284,7 +284,7 @@  discard block
 block discarded – undo
284 284
      */
285 285
     public function setNativeLanguages($nativeLanguages)
286 286
     {
287
-        $this->nativeLanguages=$nativeLanguages;
287
+        $this->nativeLanguages = $nativeLanguages;
288 288
         return $this;
289 289
     }
290 290
 
Please login to merge, or discard this patch.
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
     }
140 140
     
141 141
     /**
142
-     * @return ArrayCollection
142
+     * @return IdentityWrapper
143 143
      */
144 144
     public function getEducationsIndexedById()
145 145
     {
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
     }
169 169
     
170 170
     /**
171
-     * @return ArrayCollection
171
+     * @return IdentityWrapper
172 172
      */
173 173
     public function getEmploymentsIndexedById()
174 174
     {
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
     }
198 198
     
199 199
     /**
200
-     * @return ArrayCollection
200
+     * @return IdentityWrapper
201 201
      */
202 202
     public function getSkillsIndexedById()
203 203
     {
@@ -275,7 +275,7 @@  discard block
 block discarded – undo
275 275
     }
276 276
 
277 277
     /**
278
-     * @return ArrayCollection
278
+     * @return IdentityWrapper
279 279
      */
280 280
     public function getLanguageSkillsIndexedById()
281 281
     {
Please login to merge, or discard this patch.
module/Cv/src/Cv/Form/LanguageSkillFieldset.php 1 patch
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -11,9 +11,9 @@
 block discarded – undo
11 11
     public function init()
12 12
     {
13 13
         $this->setName('language')
14
-             ->setHydrator(new EntityHydrator())
15
-             ->setObject(new LanguageEntity())
16
-             ->setLabel('Language');
14
+                ->setHydrator(new EntityHydrator())
15
+                ->setObject(new LanguageEntity())
16
+                ->setLabel('Language');
17 17
         
18 18
         $this->add(
19 19
             array(
Please login to merge, or discard this patch.
module/Core/src/Core/Entity/LocationInterface.php 1 patch
Doc Comments   +7 added lines, -6 removed lines patch added patch discarded remove patch
@@ -20,14 +20,14 @@  discard block
 block discarded – undo
20 20
      * Sets the Postal Code of a location
21 21
      *
22 22
      * @param   string $postalCode
23
-     * @return mixed
23
+     * @return AbstractLocation
24 24
      */
25 25
     public function setPostalCode($postalCode);
26 26
 
27 27
     /**
28 28
      * Gets the Postal Code of a location
29 29
      *
30
-     * @return mixed
30
+     * @return string
31 31
      */
32 32
     public function getPostalCode();
33 33
 
@@ -44,6 +44,7 @@  discard block
 block discarded – undo
44 44
      *
45 45
      * @param GeoJson $coordinates
46 46
      * @internal param $point
47
+     * @return AbstractLocation
47 48
      */
48 49
     public function setCoordinates(GeoJson $coordinates);
49 50
 
@@ -51,7 +52,7 @@  discard block
 block discarded – undo
51 52
      * Sets the city name of a Location
52 53
      *
53 54
      * @param $city
54
-     * @return mixed
55
+     * @return AbstractLocation
55 56
      */
56 57
     public function setCity($city);
57 58
 
@@ -66,14 +67,14 @@  discard block
 block discarded – undo
66 67
      * Sets the country of a location
67 68
      *
68 69
      * @param $country
69
-     * @return mixed
70
+     * @return AbstractLocation
70 71
      */
71 72
     public function setCountry($country);
72 73
 
73 74
     /**
74 75
      * Gets the country of a location
75 76
      *
76
-     * @return mixed
77
+     * @return string
77 78
      */
78 79
     public function getCountry();
79 80
 
@@ -81,7 +82,7 @@  discard block
 block discarded – undo
81 82
      * Sets the region of a location. Eg. "Hessen" is a region in "Germany"
82 83
      *
83 84
      * @param $region
84
-     * @return mixed
85
+     * @return AbstractLocation
85 86
      */
86 87
     public function setRegion($region);
87 88
 
Please login to merge, or discard this patch.