StatusSelectFactory::__invoke() - Code Metrics - Inspection of "Merge #379" - cross-solution/YAWIK - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 8cb156...27be84 )

unknown

created 2017-06-02 11:31 UTC

StatusSelectFactory::__invoke() A

↳ Parent: StatusSelectFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	14
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	14
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	9
nc	1
nop	3

<?php
/**
 * YAWIK
 *
 * @filesource
 * @license MIT
 * @copyright  2013 - 2017 Cross Solution <http://cross-solution.de>
 */
  
/** */
namespace Applications\Factory\Form;

use \Zend\Form\Element\Select;
use Interop\Container\ContainerInterface;
use Zend\ServiceManager\AbstractPluginManager;
use Zend\ServiceManager\FactoryInterface;
use Zend\ServiceManager\ServiceLocatorInterface; 

/**
 * Factory for the state select element.
 * 
 * @author Mathias Gelhausen <[email protected]>
 * @since 0.29.2
 */
class StatusSelectFactory implements FactoryInterface
{
    /**
     *
     *
     * @param ContainerInterface $container
     * @param string             $requestedName
     * @param array              $options

     *
     * @return Select
     */
    public function __invoke(ContainerInterface $container, $requestedName, array $options = null)
    {
        /* @var \Applications\Repository\Application $applications */
        $repositories = $container->get('repositories');
        $applications = $repositories->get('Applications');
        $states       = $applications->getStates();
        array_unshift($states, '');
        $valueOptions = array_combine($states, $states);
        $select       = new Select();

        $select->setValueOptions($valueOptions);

        return $select;
    }

    /**
     * @param ServiceLocatorInterface|AbstractPluginManager $serviceLocator
     *
     * @return Select
     */
    public function createService(ServiceLocatorInterface $serviceLocator)
    {
        return $this($serviceLocator->getServiceLocator(), Select::class);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }
}


1			<?php
2			/**
3			* YAWIK
4			*
5			* @filesource
6			* @license MIT
7			* @copyright 2013 - 2017 Cross Solution <http://cross-solution.de>
8			*/
9
10			/** */
11			namespace Applications\Factory\Form;
12
13			use \Zend\Form\Element\Select;
14			use Interop\Container\ContainerInterface;
15			use Zend\ServiceManager\AbstractPluginManager;
16			use Zend\ServiceManager\FactoryInterface;
17			use Zend\ServiceManager\ServiceLocatorInterface;
18
19			/**
20			* Factory for the state select element.
21			*
22			* @author Mathias Gelhausen <[email protected]>
23			* @since 0.29.2
24			*/
25			class StatusSelectFactory implements FactoryInterface
26			{
27			/**
28			*
29			*
30			* @param ContainerInterface $container
31			* @param string $requestedName
32			* @param array $options
			0 ignored issues – show Documentation introduced 2017-03-10 16:18 UTC by Report Bug Copy Issue Report Should the type for parameter `$options` not be `null\|array`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
33			*
34			* @return Select
35			*/
36			public function __invoke(ContainerInterface $container, $requestedName, array $options = null)
37			{
38			/* @var \Applications\Repository\Application $applications */
39			$repositories = $container->get('repositories');
40			$applications = $repositories->get('Applications');
41			$states = $applications->getStates();
42			array_unshift($states, '');
43			$valueOptions = array_combine($states, $states);
44			$select = new Select();
45
46			$select->setValueOptions($valueOptions);
47
48			return $select;
49			}
50
51			/**
52			* @param ServiceLocatorInterface\|AbstractPluginManager $serviceLocator
53			*
54			* @return Select
55			*/
56			public function createService(ServiceLocatorInterface $serviceLocator)
57			{
58			return $this($serviceLocator->getServiceLocator(), Select::class);
			0 ignored issues – show Bug introduced 2017-03-02 20:05 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Zend\ServiceManager\ServiceLocatorInterface` as the method `getServiceLocator()` does only exist in the following implementations of said interface: `Acl\Assertion\AssertionManager`, `Core\Mail\MailService`, `Core\Paginator\PaginatorService`, `Zend\Barcode\ObjectPluginManager`, `Zend\Barcode\RendererPluginManager`, `Zend\Cache\PatternPluginManager`, `Zend\Cache\Storage\AdapterPluginManager`, `Zend\Cache\Storage\PluginManager`, `Zend\Config\ReaderPluginManager`, `Zend\Config\WriterPluginManager`, `Zend\Feed\Reader\ExtensionPluginManager`, `Zend\Feed\Writer\ExtensionPluginManager`, `Zend\File\Transfer\Adapter\FilterPluginManager`, `Zend\File\Transfer\Adapter\ValidatorPluginManager`, `Zend\Filter\FilterPluginManager`, `Zend\Form\FormElementMan...lementManagerV2Polyfill`, `Zend\Form\FormElementMan...lementManagerV3Polyfill`, `Zend\Hydrator\HydratorPluginManager`, `Zend\I18n\Translator\LoaderPluginManager`, `Zend\InputFilter\InputFilterPluginManager`, `Zend\Log\FilterPluginManager`, `Zend\Log\FormatterPluginManager`, `Zend\Log\ProcessorPluginManager`, `Zend\Log\WriterPluginManager`, `Zend\Log\Writer\FilterPluginManager`, `Zend\Log\Writer\FormatterPluginManager`, `Zend\Mail\Protocol\SmtpPluginManager`, `Zend\Mvc\Controller\ControllerManager`, `Zend\Mvc\Controller\PluginManager`, `Zend\Mvc\Router\RoutePluginManager`, `Zend\Paginator\AdapterPluginManager`, `Zend\Paginator\ScrollingStylePluginManager`, `Zend\Serializer\AdapterPluginManager`, `Zend\ServiceManager\AbstractPluginManager`, `Zend\Stdlib\Hydrator\HydratorPluginManager`, `Zend\Tag\Cloud\DecoratorPluginManager`, `Zend\Text\Table\DecoratorManager`, `Zend\Validator\ValidatorPluginManager`, `Zend\View\HelperPluginManager`, `Zend\View\Helper\Navigation\PluginManager`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
59			}
60			}
61

cross-solution / YAWIK

Push — develop ( 8cb156...27be84 )

StatusSelectFactory::__invoke() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like