Completed
Push — develop ( 60c2a6...7c4b2f )
by Carsten
61:42 queued 47:32
created
module/Organizations/src/Organizations/Controller/IndexController.php 3 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -301,6 +301,9 @@
 block discarded – undo
301 301
         return $organization;
302 302
     }
303 303
 
304
+    /**
305
+     * @param string $script
306
+     */
304 307
     protected function getErrorViewModel($script)
305 308
     {
306 309
         $this->getResponse()->setStatusCode(500);
Please login to merge, or discard this patch.
Indentation   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -1,11 +1,11 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * YAWIK
4
- *
5
- * @filesource
6
- * @copyright (c) 2013-2015 Cross Solution (http://cross-solution.de)
7
- * @license   GPLv3
8
- */
3
+     * YAWIK
4
+     *
5
+     * @filesource
6
+     * @copyright (c) 2013-2015 Cross Solution (http://cross-solution.de)
7
+     * @license   GPLv3
8
+     */
9 9
 
10 10
 /** ActionController of Organizations */
11 11
 namespace Organizations\Controller;
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
         if ($isRecruiter) {
96 96
             $params->set('by', 'me');
97 97
         }
98
-         //default sorting
98
+            //default sorting
99 99
         if (!isset($params['sort'])) {
100 100
             $params->set('sort', "-name");
101 101
         }
@@ -237,7 +237,7 @@  discard block
 block discarded – undo
237 237
             $container->disableForm('employeesManagement');
238 238
         } else {
239 239
             $container->disableForm('organizationLogo')
240
-                      ->disableForm('descriptionForm');
240
+                        ->disableForm('descriptionForm');
241 241
         }
242 242
         return $container;
243 243
     }
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -124,11 +124,11 @@  discard block
 block discarded – undo
124 124
         $params          = $this->params();
125 125
         $formIdentifier  = $params->fromQuery('form');
126 126
         try {
127
-            $org             = $this->getOrganization(true);
127
+            $org = $this->getOrganization(true);
128 128
         } catch (\RuntimeException $e) {
129 129
             return $this->getErrorViewModel('no-parent');
130 130
         }
131
-        $container       = $this->getFormular($org);
131
+        $container = $this->getFormular($org);
132 132
 
133 133
         if (isset($formIdentifier) && $request->isPost()) {
134 134
             /* @var $form \Zend\Form\FormInterface */
@@ -261,7 +261,7 @@  discard block
 block discarded – undo
261 261
         $user = $this->auth()->getUser(); /* @var $user \Auth\Entity\UserInterface */
262 262
 
263 263
         /* @var $organizationId string */
264
-        $organizationId = empty($id_fromRoute)?$id_fromSubForm:$id_fromRoute;
264
+        $organizationId = empty($id_fromRoute) ? $id_fromSubForm : $id_fromRoute;
265 265
         $editOwnOrganization = '__my__' === $organizationId;
266 266
         if ($editOwnOrganization) {
267 267
             /* @var $userOrg \Organizations\Entity\OrganizationReference */
@@ -294,7 +294,7 @@  discard block
 block discarded – undo
294 294
             return $organization;
295 295
         }
296 296
 
297
-        $organization      = $this->repository->find($organizationId);
297
+        $organization = $this->repository->find($organizationId);
298 298
         if (!$organization) {
299 299
             throw new \RuntimeException('No Organization found with id "' . $organizationId . '"');
300 300
         }
Please login to merge, or discard this patch.
module/Organizations/src/Organizations/Entity/OrganizationReference.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -150,7 +150,7 @@
 block discarded – undo
150 150
      *   $this->proxy($method[, $arg1[, $arg2[, ...]]]);
151 151
      * </pre>
152 152
      *
153
-     * @param $method
153
+     * @param string $method
154 154
      *
155 155
      * @return self|mixed
156 156
      */
Please login to merge, or discard this patch.
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -1,11 +1,11 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * YAWIK
4
- *
5
- * @filesource
6
- * @license MIT
7
- * @copyright  2013 - 2015 Cross Solution <http://cross-solution.de>
8
- */
3
+     * YAWIK
4
+     *
5
+     * @filesource
6
+     * @license MIT
7
+     * @copyright  2013 - 2015 Cross Solution <http://cross-solution.de>
8
+     */
9 9
   
10 10
 /** */
11 11
 namespace Organizations\Repository\Event;
Please login to merge, or discard this patch.
src/Organizations/Repository/Filter/PaginationQueryFactory.php 3 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
      *
28 28
      * @see \Zend\ServiceManager\FactoryInterface::createService()
29 29
      * @param ServiceLocatorInterface $serviceLocator
30
-     * @return \Organizations\Repository\Filter\PaginationQuery|mixed
30
+     * @return PaginationQuery
31 31
      */
32 32
     public function createService(ServiceLocatorInterface $serviceLocator)
33 33
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@
 block discarded – undo
31 31
      */
32 32
     public function createService(ServiceLocatorInterface $serviceLocator)
33 33
     {
34
-        $auth  = $serviceLocator->getServiceLocator()->get('AuthenticationService');
34
+        $auth = $serviceLocator->getServiceLocator()->get('AuthenticationService');
35 35
         $filter = new PaginationQuery($auth);
36 36
         return $filter;
37 37
     }
Please login to merge, or discard this patch.
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -1,11 +1,11 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * YAWIK
4
- *
5
- * @filesource
6
- * @copyright (c) 2013-2015 Cross Solution (http://cross-solution.de)
7
- * @license   MIT
8
- */
3
+     * YAWIK
4
+     *
5
+     * @filesource
6
+     * @copyright (c) 2013-2015 Cross Solution (http://cross-solution.de)
7
+     * @license   MIT
8
+     */
9 9
 
10 10
 /** SettingsEntityResolverFactory.php */
11 11
 namespace Settings\Repository;
Please login to merge, or discard this patch.
module/Organizations/src/Organizations/Repository/Organization.php 3 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
     /**
107 107
      * Finds the main organization of an user.
108 108
      *
109
-     * @param string|UserInterface $userOrId
109
+     * @param string $userOrId
110 110
      *
111 111
      * @return null|OrganizationInterface
112 112
      */
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
     /**
143 143
      * Finds the organization, an user is employed by.
144 144
      *
145
-     * @param string|UserInterface $userOrId
145
+     * @param string $userOrId
146 146
      *
147 147
      * @return null|OrganizationInterface
148 148
      */
@@ -270,7 +270,7 @@  discard block
 block discarded – undo
270 270
     /**
271 271
      * Look for an drafted Document of a given user
272 272
      *
273
-     * @param $user
273
+     * @param UserInterface $user
274 274
      * @return \Organizations\Entity\Organization|null
275 275
      */
276 276
     public function findDraft($user)
Please login to merge, or discard this patch.
Indentation   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -1,10 +1,10 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * YAWIK
4
- *
5
- * @copyright (c) 2013-2015 Cross Solution (http://cross-solution.de)
6
- * @license   GPLv3
7
- */
3
+     * YAWIK
4
+     *
5
+     * @copyright (c) 2013-2015 Cross Solution (http://cross-solution.de)
6
+     * @license   GPLv3
7
+     */
8 8
 
9 9
 namespace Organizations\Repository;
10 10
 
@@ -128,10 +128,10 @@  discard block
 block discarded – undo
128 128
 //           )
129 129
 //        );
130 130
         $qb->addAnd($qb->expr()->field('user')->equals($userId))
131
-           ->addAnd(
132
-               $qb->expr()->addOr($qb->expr()->field('parent')->exists(false))
133
-                               ->addOr($qb->expr()->field('parent')->equals(null))
134
-           );
131
+            ->addAnd(
132
+                $qb->expr()->addOr($qb->expr()->field('parent')->exists(false))
133
+                                ->addOr($qb->expr()->field('parent')->equals(null))
134
+            );
135 135
 
136 136
         $q      = $qb->getQuery();
137 137
         $entity = $q->getSingleResult();
@@ -252,7 +252,7 @@  discard block
 block discarded – undo
252 252
         if ($userOrg->hasAssociation()) {
253 253
             $qb->addAnd(
254 254
                 $qb->expr()->addOr($qb->expr()->field('parent')->equals($userOrg->getId()))
255
-                           ->addOr($qb->expr()->field('_id')->equals($userOrg->getId()))
255
+                            ->addOr($qb->expr()->field('_id')->equals($userOrg->getId()))
256 256
             );
257 257
         }
258 258
 
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -260,7 +260,7 @@
 block discarded – undo
260 260
 
261 261
         foreach ($result as $id => $item) {
262 262
             $organizations[$id] = $item;
263
-            $organizationNameId = (string)$organizations[$id]['organizationName'];
263
+            $organizationNameId = (string) $organizations[$id]['organizationName'];
264 264
             $organizations[$id]['organizationName'] = $organizationNames[$organizationNameId];
265 265
         }
266 266
 
Please login to merge, or discard this patch.
module/Organizations/src/Organizations/Repository/OrganizationName.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -14,6 +14,9 @@
 block discarded – undo
14 14
 
15 15
 class OrganizationName extends AbstractRepository
16 16
 {
17
+    /**
18
+     * @param string $name
19
+     */
17 20
     public function findbyName($name, $create = true)
18 21
     {
19 22
         $entity = $this->findOneBy(array('name' => $name));
Please login to merge, or discard this patch.
module/Pdf/Module.php 3 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
     /**
165 165
      * give a summary of all inserted Files,
166 166
      * this is for having access to those files in the post-process
167
-     * @param \Core\View\Helper\InsertFile\FileEvent|\Zend\View\ViewEvent $e
167
+     * @param FileEvent $e
168 168
      * @return NULL
169 169
      */
170 170
     public function collectFiles(FileEvent $e)
@@ -313,7 +313,7 @@  discard block
 block discarded – undo
313 313
      *
314 314
      * @param string $name
315 315
      * @param \Zend\View\Renderer\RendererInterface $renderer
316
-     * @return string|boolean
316
+     * @return string|false
317 317
      */
318 318
     public function resolve($name, Renderer $renderer = null)
319 319
     {
Please login to merge, or discard this patch.
Indentation   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -1,11 +1,11 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * YAWIK
4
- * Auth Module Bootstrap
5
- *
6
- * @copyright (c) 2013-2015 Cross Solution (http://cross-solution.de)
7
- * @license   MIT
8
- */
3
+     * YAWIK
4
+     * Auth Module Bootstrap
5
+     *
6
+     * @copyright (c) 2013-2015 Cross Solution (http://cross-solution.de)
7
+     * @license   MIT
8
+     */
9 9
 
10 10
 namespace Pdf;
11 11
 
@@ -42,11 +42,11 @@  discard block
 block discarded – undo
42 42
     protected $appendImage = array();
43 43
     
44 44
     
45
-     /**
46
-     * Loads module specific configuration.
47
-     *
48
-     * @return array
49
-     */
45
+        /**
46
+         * Loads module specific configuration.
47
+         *
48
+         * @return array
49
+         */
50 50
     public function getConfig()
51 51
     {
52 52
         return ModuleConfigLoader::load(__DIR__ . '/config');
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
         $eventManager->getSharedManager()->attach(
65 65
             'Applications',
66 66
             'application.detail.actionbuttons',
67
-            function ($event) {
67
+            function($event) {
68 68
                 return 'pdf/application/details/button';
69 69
             }
70 70
         );
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
246 246
         
247 247
         // the handles are for temporary files
248 248
         error_reporting(0);
249
-        foreach (array(self::RENDER_FULL, self::RENDER_WITHOUT_PDF, self::RENDER_WITHOUT_ATTACHMENTS ) as $render) {
249
+        foreach (array(self::RENDER_FULL, self::RENDER_WITHOUT_PDF, self::RENDER_WITHOUT_ATTACHMENTS) as $render) {
250 250
             $handles = array();
251 251
             try {
252 252
                 $pdf = new extern\mPDFderive();
Please login to merge, or discard this patch.
module/Settings/src/Settings/Entity/SettingsContainer.php 2 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -138,7 +138,6 @@
 block discarded – undo
138 138
      * If the property is an array, the check will return, if this
139 139
      * array has items or not.
140 140
      *
141
-     * @param string $name
142 141
      * @return boolean
143 142
      */
144 143
     public function __isset($property)
Please login to merge, or discard this patch.
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -1,11 +1,11 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * YAWIK
4
- *
5
- * @filesource
6
- * @copyright (c) 2013-2015 Cross Solution (http://cross-solution.de)
7
- * @license   MIT
8
- */
3
+     * YAWIK
4
+     *
5
+     * @filesource
6
+     * @copyright (c) 2013-2015 Cross Solution (http://cross-solution.de)
7
+     * @license   MIT
8
+     */
9 9
 
10 10
 /** SettingsEntityResolverFactory.php */
11 11
 namespace Settings\Repository;
Please login to merge, or discard this patch.
module/Settings/src/Settings/Form/FormAbstract.php 1 patch
Doc Comments   +8 added lines patch added patch discarded remove patch
@@ -50,6 +50,11 @@  discard block
 block discarded – undo
50 50
         return $this->hydrator;
51 51
     }
52 52
     
53
+    /**
54
+     * @param string $name
55
+     *
56
+     * @return callable
57
+     */
53 58
     protected function getPlugin($name)
54 59
     {
55 60
         $plugin = null;
@@ -88,5 +93,8 @@  discard block
 block discarded – undo
88 93
         $this->add($this->forms->get('DefaultButtonsFieldset'));
89 94
     }
90 95
     
96
+    /**
97
+     * @return string
98
+     */
91 99
     abstract public function getCoreFieldset();
92 100
 }
Please login to merge, or discard this patch.
module/Settings/src/Settings/Repository/Settings.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,6 @@
 block discarded – undo
44 44
     
45 45
     /**
46 46
      * the $id for an entity 'setting' is the same as for the entity 'user'
47
-     * @param type $id
48 47
      */
49 48
     public function getSettingsByUser($user)
50 49
     {
Please login to merge, or discard this patch.