Completed
Push — develop ( 60c2a6...7c4b2f )
by Carsten
61:42 queued 47:32
created
module/Jobs/src/Jobs/Controller/ManageController.php 3 patches
Doc Comments   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
 {
33 33
 
34 34
     /**
35
-     * @return $this|void
35
+     * @return ManageController
36 36
      */
37 37
     public function attachDefaultListeners()
38 38
     {
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
     /**
102 102
      * @TODO edit-Action and save-Action are doing the same, one of them has to quit
103 103
      *
104
-     * @return null|ViewModel
104
+     * @return ViewModel
105 105
      */
106 106
     public function editAction()
107 107
     {
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
     }
116 116
 
117 117
     /**
118
-     * @return null|ViewModel
118
+     * @return ViewModel
119 119
      */
120 120
     public function saveAction()
121 121
     {
@@ -130,7 +130,7 @@  discard block
 block discarded – undo
130 130
      * parameter are arbitrary elements for defaults or programming flow
131 131
      *
132 132
      * @param array $parameter
133
-     * @return null|ViewModel
133
+     * @return ViewModel
134 134
      * @throws \RuntimeException
135 135
      */
136 136
     protected function save($parameter = array())
@@ -511,7 +511,7 @@  discard block
 block discarded – undo
511 511
     }
512 512
 
513 513
     /**
514
-     * @return null|ViewModel
514
+     * @return ViewModel
515 515
      */
516 516
     public function deactivateAction()
517 517
     {
@@ -552,7 +552,7 @@  discard block
 block discarded – undo
552 552
     }
553 553
 
554 554
     /**
555
-     * @param $script
555
+     * @param string $script
556 556
      * @param array $parameter
557 557
      * @return ViewModel
558 558
      */
Please login to merge, or discard this patch.
Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -409,8 +409,8 @@  discard block
 block discarded – undo
409 409
         if (empty($reference)) {
410 410
             // create an unique job-reference
411 411
             $repository = $this->getServiceLocator()
412
-                               ->get('repositories')
413
-                               ->get('Jobs/Job');
412
+                                ->get('repositories')
413
+                                ->get('Jobs/Job');
414 414
             $jobEntity->setReference($repository->getUniqueReference());
415 415
         }
416 416
         $jobEntity->changeStatus(Status::CREATED, "job was created");
@@ -457,9 +457,9 @@  discard block
 block discarded – undo
457 457
             // we want just some Values to be compared
458 458
             $diff = null;
459 459
             foreach (array('title', 'organization', 'location',
460
-                         'templateValues.qualifications', 'templateValues.requirements', 'templateValues.benefits', 'templateValues.title',
461
-                         'templateValues._freeValues.description',
462
-                     ) as $prelKey) {
460
+                            'templateValues.qualifications', 'templateValues.requirements', 'templateValues.benefits', 'templateValues.title',
461
+                            'templateValues._freeValues.description',
462
+                        ) as $prelKey) {
463 463
                 if (array_key_exists($prelKey, $prelDiff)) {
464 464
                     $diff[$prelKey] = $prelDiff[$prelKey];
465 465
                 }
@@ -486,28 +486,28 @@  discard block
 block discarded – undo
486 486
             'lang/jobs/view',
487 487
             array(),
488 488
             array('query' =>
489
-                      array( 'id' => $jobEntity->id))
489
+                        array( 'id' => $jobEntity->id))
490 490
         );
491 491
 
492 492
         $approvalLink = $this->url()->fromRoute(
493 493
             'lang/jobs/approval',
494 494
             array('state' => 'approved'),
495 495
             array('query' =>
496
-                      array( 'id' => $jobEntity->id))
496
+                        array( 'id' => $jobEntity->id))
497 497
         );
498 498
 
499 499
         $declineLink = $this->url()->fromRoute(
500 500
             'lang/jobs/approval',
501 501
             array('state' => 'declined'),
502 502
             array('query' =>
503
-                      array( 'id' => $jobEntity->id))
503
+                        array( 'id' => $jobEntity->id))
504 504
         );
505 505
 
506 506
         return array('job' => $jobEntity,
507
-                     'diffSnapshot' => $diff,
508
-                     'viewLink' => $viewLink,
509
-                     'approvalLink' => $approvalLink,
510
-                     'declineLink' => $declineLink);
507
+                        'diffSnapshot' => $diff,
508
+                        'viewLink' => $viewLink,
509
+                        'approvalLink' => $approvalLink,
510
+                        'declineLink' => $declineLink);
511 511
     }
512 512
 
513 513
     /**
Please login to merge, or discard this patch.
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
         if (empty($user->info->email)) {
141 141
             return $this->getErrorViewModel('no-parent', array('cause' => 'noEmail'));
142 142
         }
143
-        $userOrg            = $user->getOrganization();
143
+        $userOrg = $user->getOrganization();
144 144
         if (!$userOrg->hasAssociation()) {
145 145
             return $this->getErrorViewModel('no-parent', array('cause' => 'noCompany'));
146 146
         }
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
         $request            = $this->getRequest();
155 155
         $params             = $this->params();
156 156
         $formIdentifier     = $params->fromQuery('form');
157
-        $pageIdentifier     = (int) $params->fromQuery('page', array_key_exists('page', $parameter)?$parameter['page']:0);
157
+        $pageIdentifier     = (int) $params->fromQuery('page', array_key_exists('page', $parameter) ? $parameter['page'] : 0);
158 158
         $jobEntity          = $this->getJob();
159 159
         $viewModel          = null;
160 160
         $this->acl($jobEntity, 'edit');
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
165 165
         $instanceForm       = null;
166 166
         $viewHelperManager  = $serviceLocator->get('ViewHelperManager');
167 167
         $formErrorMessages = array();
168
-        if (isset($formIdentifier) &&  $request->isPost()) {
168
+        if (isset($formIdentifier) && $request->isPost()) {
169 169
             // at this point the form get instantiated and immediately accumulated
170 170
             $instanceForm = $form->getForm($formIdentifier);
171 171
             if (!isset($instanceForm)) {
@@ -353,7 +353,7 @@  discard block
 block discarded – undo
353 353
         $id_fromQuery   = $this->params()->fromQuery('id', 0);
354 354
         $id_fromSubForm = $this->params()->fromPost('job', 0);
355 355
         $user           = $this->auth()->getUser();
356
-        $id             = empty($id_fromRoute)? (empty($id_fromQuery)?$id_fromSubForm:$id_fromQuery) : $id_fromRoute;
356
+        $id             = empty($id_fromRoute) ? (empty($id_fromQuery) ? $id_fromSubForm : $id_fromQuery) : $id_fromRoute;
357 357
 
358 358
         if (empty($id) && $allowDraft) {
359 359
             $this->acl('Jobs/Manage', 'new');
@@ -368,7 +368,7 @@  discard block
 block discarded – undo
368 368
             return $job;
369 369
         }
370 370
 
371
-        $jobEntity      = $repository->find($id);
371
+        $jobEntity = $repository->find($id);
372 372
         if (!$jobEntity) {
373 373
             throw new \RuntimeException('No job found with id "' . $id . '"');
374 374
         }
@@ -450,7 +450,7 @@  discard block
 block discarded – undo
450 450
         // array with differences between the last snapshot and the actual entity
451 451
         // is remains Null if there is no snapshot
452 452
         // it will be an empty array if the snapshot and the actual entity do not differ
453
-        $diff           = null;
453
+        $diff = null;
454 454
         // preliminary difference, contain all differences
455 455
         $prelDiff = $this->entitySnapshot()->diff($jobEntity);
456 456
         if (isset($prelDiff)) {
@@ -486,21 +486,21 @@  discard block
 block discarded – undo
486 486
             'lang/jobs/view',
487 487
             array(),
488 488
             array('query' =>
489
-                      array( 'id' => $jobEntity->id))
489
+                      array('id' => $jobEntity->id))
490 490
         );
491 491
 
492 492
         $approvalLink = $this->url()->fromRoute(
493 493
             'lang/jobs/approval',
494 494
             array('state' => 'approved'),
495 495
             array('query' =>
496
-                      array( 'id' => $jobEntity->id))
496
+                      array('id' => $jobEntity->id))
497 497
         );
498 498
 
499 499
         $declineLink = $this->url()->fromRoute(
500 500
             'lang/jobs/approval',
501 501
             array('state' => 'declined'),
502 502
             array('query' =>
503
-                      array( 'id' => $jobEntity->id))
503
+                      array('id' => $jobEntity->id))
504 504
         );
505 505
 
506 506
         return array('job' => $jobEntity,
@@ -535,7 +535,7 @@  discard block
 block discarded – undo
535 535
     public function templateAction()
536 536
     {
537 537
         $serviceLocator          = $this->getServiceLocator();
538
-        $translator          = $serviceLocator->get('translator');
538
+        $translator = $serviceLocator->get('translator');
539 539
         try {
540 540
             $jobEntity           = $this->getJob();
541 541
             $template            = $this->params('template', 'default');
Please login to merge, or discard this patch.
module/Jobs/src/Jobs/Entity/History.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -41,6 +41,9 @@
 block discarded – undo
41 41
      */
42 42
     protected $message;
43 43
     
44
+    /**
45
+     * @param Status $status
46
+     */
44 47
     public function __construct($status, $message = '[System]')
45 48
     {
46 49
         if (!$status instanceof StatusInterface) {
Please login to merge, or discard this patch.
module/Jobs/src/Jobs/Entity/JobSnapshot.php 3 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -673,7 +673,7 @@  discard block
 block discarded – undo
673 673
     /**
674 674
      * Gets locations of a job posting
675 675
      *
676
-     * @return string
676
+     * @return Collection
677 677
      */
678 678
     public function getLocations()
679 679
     {
@@ -715,7 +715,7 @@  discard block
 block discarded – undo
715 715
     /**
716 716
      * Gets applications for a job posting
717 717
      *
718
-     * @return string
718
+     * @return Status
719 719
      */
720 720
     public function getStatus()
721 721
     {
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -303,14 +303,14 @@
 block discarded – undo
303 303
     {
304 304
         $methods = array_filter(
305 305
             get_class_methods($source),
306
-            function ($v) {
306
+            function($v) {
307 307
                 return 3 < strlen($v) && strpos($v, 'get') === 0;
308 308
             }
309 309
         );
310 310
         // these attributes don't need to get copied
311 311
         $methods = array_diff($methods, array('getId', 'getHydrator', 'getHiringOrganizations'));
312 312
         $methods = array_map(
313
-            function ($v) {
313
+            function($v) {
314 314
                 return lcfirst(substr($v, 3));
315 315
             },
316 316
             $methods
Please login to merge, or discard this patch.
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -1,12 +1,12 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * YAWIK
4
- *
5
- * @filesource
6
- * @copyright (c) 2013-2015 Cross Solution (http://cross-solution.de)
7
- * @license   MIT
8
- * @author    [email protected]
9
- */
3
+     * YAWIK
4
+     *
5
+     * @filesource
6
+     * @copyright (c) 2013-2015 Cross Solution (http://cross-solution.de)
7
+     * @license   MIT
8
+     * @author    [email protected]
9
+     */
10 10
 
11 11
 namespace Organizations\Form;
12 12
 
Please login to merge, or discard this patch.
module/Jobs/src/Jobs/Factory/Listener/MailSenderFactory.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
      *
28 28
      * @param ServiceLocatorInterface $serviceLocator
29 29
      *
30
-     * @return NewJobMailSender
30
+     * @return MailSender
31 31
      */
32 32
     public function createService(ServiceLocatorInterface $serviceLocator)
33 33
     {
Please login to merge, or discard this patch.
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -1,11 +1,11 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * YAWIK
4
- *
5
- * @filesource
6
- * @license MIT
7
- * @copyright  2013 - 2015 Cross Solution <http://cross-solution.de>
8
- */
3
+     * YAWIK
4
+     *
5
+     * @filesource
6
+     * @license MIT
7
+     * @copyright  2013 - 2015 Cross Solution <http://cross-solution.de>
8
+     */
9 9
   
10 10
 /** */
11 11
 namespace Organizations\Repository\Event;
Please login to merge, or discard this patch.
module/Jobs/src/Jobs/Form/PreviewLink.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
     }
35 35
 
36 36
     /**
37
-     * @return string|\Zend\View\Helper\HelperInterface
37
+     * @return string
38 38
      */
39 39
     public function getViewHelper()
40 40
     {
Please login to merge, or discard this patch.
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -1,12 +1,12 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * YAWIK
4
- *
5
- * @filesource
6
- * @copyright (c) 2013-2015 Cross Solution (http://cross-solution.de)
7
- * @license   MIT
8
- * @author    [email protected]
9
- */
3
+     * YAWIK
4
+     *
5
+     * @filesource
6
+     * @copyright (c) 2013-2015 Cross Solution (http://cross-solution.de)
7
+     * @license   MIT
8
+     * @author    [email protected]
9
+     */
10 10
 
11 11
 namespace Organizations\Form;
12 12
 
Please login to merge, or discard this patch.
module/Jobs/src/Jobs/Listener/Events/JobEvent.php 3 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@
 block discarded – undo
64 64
      * Sets the job entity
65 65
      *
66 66
      * @param  Job $jobEntity
67
-     * @return MvcEvent
67
+     * @return JobEvent
68 68
      */
69 69
     public function setJobEntity(Job $jobEntity)
70 70
     {
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -34,24 +34,24 @@
 block discarded – undo
34 34
      * Event is fired when a users has created a new job opening and accepted the
35 35
      * terms and conditions
36 36
      */
37
-    const EVENT_JOB_CREATED   = 'job.created';
37
+    const EVENT_JOB_CREATED = 'job.created';
38 38
 
39 39
     /**
40 40
      * Event is fired when the owner of the YAWIK installation has accepted the job
41 41
      * opening
42 42
      */
43
-    const EVENT_JOB_ACCEPTED   = 'job.accepted';
43
+    const EVENT_JOB_ACCEPTED = 'job.accepted';
44 44
 
45 45
     /**
46 46
      * Event is fired, when the owner of the YAWIK installation has rejected the job
47 47
      * opening
48 48
      */
49
-    const EVENT_JOB_REJECTED   = 'job.rejected';
49
+    const EVENT_JOB_REJECTED = 'job.rejected';
50 50
 
51 51
     /**
52 52
      * get all available names for publishing
53 53
      */
54
-    const PORTAL_AVAIL_NAME    = 'portal.availname';
54
+    const PORTAL_AVAIL_NAME = 'portal.availname';
55 55
 
56 56
     /**
57 57
      * @var portals to be published
Please login to merge, or discard this patch.
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -1,12 +1,12 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * YAWIK
4
- *
5
- * @filesource
6
- * @copyright (c) 2013-2015 Cross Solution (http://cross-solution.de)
7
- * @license   MIT
8
- * @author    [email protected]
9
- */
3
+     * YAWIK
4
+     *
5
+     * @filesource
6
+     * @copyright (c) 2013-2015 Cross Solution (http://cross-solution.de)
7
+     * @license   MIT
8
+     * @author    [email protected]
9
+     */
10 10
 
11 11
 namespace Organizations\Form;
12 12
 
Please login to merge, or discard this patch.
module/Jobs/src/Jobs/Listener/Publisher.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
     }
47 47
 
48 48
     /**
49
-     * @return mixed
49
+     * @return ServiceManager
50 50
      */
51 51
     public function getServiceManager()
52 52
     {
Please login to merge, or discard this patch.
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -1,12 +1,12 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * YAWIK
4
- *
5
- * @filesource
6
- * @copyright (c) 2013-2015 Cross Solution (http://cross-solution.de)
7
- * @license   MIT
8
- * @author    [email protected]
9
- */
3
+     * YAWIK
4
+     *
5
+     * @filesource
6
+     * @copyright (c) 2013-2015 Cross Solution (http://cross-solution.de)
7
+     * @license   MIT
8
+     * @author    [email protected]
9
+     */
10 10
 
11 11
 namespace Organizations\Form;
12 12
 
Please login to merge, or discard this patch.
module/Jobs/src/Jobs/Options/ChannelOptions.php 3 patches
Doc Comments   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
     /**
148 148
      * Gets the unique key of a channel
149 149
      *
150
-     * @return string
150
+     * @return integer
151 151
      */
152 152
     public function getKey()
153 153
     {
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
     /**
170 170
      * Gets the unique key of a channel
171 171
      *
172
-     * @return string
172
+     * @return integer
173 173
      */
174 174
     public function getExternalkey()
175 175
     {
@@ -252,7 +252,7 @@  discard block
 block discarded – undo
252 252
     /**
253 253
      * Gets the tax for a price
254 254
      *
255
-     * @return string
255
+     * @return integer
256 256
      */
257 257
     public function getTax()
258 258
     {
@@ -345,7 +345,7 @@  discard block
 block discarded – undo
345 345
     /**
346 346
      * Gets the headline of the channel
347 347
      *
348
-     * @return mixed
348
+     * @return string
349 349
      */
350 350
     public function getHeadLine()
351 351
     {
@@ -383,7 +383,7 @@  discard block
 block discarded – undo
383 383
     }
384 384
 
385 385
     /**
386
-     * @return mixed
386
+     * @return string
387 387
      */
388 388
     public function getLinkText()
389 389
     {
@@ -401,7 +401,7 @@  discard block
 block discarded – undo
401 401
     }
402 402
 
403 403
     /**
404
-     * @return mixed
404
+     * @return string
405 405
      */
406 406
     public function getRoute()
407 407
     {
@@ -439,7 +439,7 @@  discard block
 block discarded – undo
439 439
     /**
440 440
      * Gets the logo of a channel (Jobboard)
441 441
      *
442
-     * @return string|null
442
+     * @return string
443 443
      */
444 444
     public function getLogo()
445 445
     {
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
      *
82 82
      * @var int $publishDuration
83 83
      */
84
-    protected $publishDuration=30;
84
+    protected $publishDuration = 30;
85 85
 
86 86
     /**
87 87
      * Category for this channel
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
      */
141 141
     public function setKey($key)
142 142
     {
143
-        $this->key=$key;
143
+        $this->key = $key;
144 144
         return $this;
145 145
     }
146 146
 
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
      */
163 163
     public function setExternalkey($key)
164 164
     {
165
-        $this->externalkey=$key;
165
+        $this->externalkey = $key;
166 166
         return $this;
167 167
     }
168 168
 
Please login to merge, or discard this patch.
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -1,12 +1,12 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * YAWIK
4
- *
5
- * @filesource
6
- * @copyright (c) 2013-2015 Cross Solution (http://cross-solution.de)
7
- * @author cbleek
8
- * @license   MIT
9
- */
3
+     * YAWIK
4
+     *
5
+     * @filesource
6
+     * @copyright (c) 2013-2015 Cross Solution (http://cross-solution.de)
7
+     * @author cbleek
8
+     * @license   MIT
9
+     */
10 10
 
11 11
 namespace Jobs\Options;
12 12
 
Please login to merge, or discard this patch.
module/Jobs/src/Jobs/Repository/Filter/PaginationAdminQueryFactory.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
 {
19 19
     /**
20 20
      * @param ServiceLocatorInterface $serviceLocator
21
-     * @return PaginationQuery|mixed
21
+     * @return PaginationAdminQuery
22 22
      */
23 23
     public function createService(ServiceLocatorInterface $serviceLocator)
24 24
     {
Please login to merge, or discard this patch.
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -1,12 +1,12 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * YAWIK
4
- *
5
- * @filesource
6
- * @copyright (c) 2013-2015 Cross Solution (http://cross-solution.de)
7
- * @license   MIT
8
- * @author    [email protected]
9
- */
3
+     * YAWIK
4
+     *
5
+     * @filesource
6
+     * @copyright (c) 2013-2015 Cross Solution (http://cross-solution.de)
7
+     * @license   MIT
8
+     * @author    [email protected]
9
+     */
10 10
 
11 11
 namespace Organizations\Form;
12 12
 
Please login to merge, or discard this patch.