Completed
Pull Request — develop (#323)
by Mathias
15:36
created
module/Jobs/src/Jobs/Form/AdminSearchFormElementsFieldset.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -25,8 +25,8 @@
 block discarded – undo
25 25
     public function init()
26 26
     {
27 27
         $this->addTextElement(
28
-             'Search',
29
-             /*@translate*/ 'search for position or company'
28
+                'Search',
29
+                /*@translate*/ 'search for position or company'
30 30
         );
31 31
 
32 32
 
Please login to merge, or discard this patch.
module/Jobs/src/Jobs/Controller/TemplateController.php 2 patches
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@
 block discarded – undo
71 71
             $this->auth()->isAdmin()
72 72
         ) {
73 73
             $applicationViewModel->setTemplate('iframe/iFrameInjection');
74
-        }elseif(Status::EXPIRED == $job->getStatus() or  Status::INACTIVE == $job->getStatus()) {
74
+        } elseif(Status::EXPIRED == $job->getStatus() or  Status::INACTIVE == $job->getStatus()) {
75 75
             $this->response->setStatusCode(Response::STATUS_CODE_410);
76 76
             $model->setTemplate('jobs/error/expired');
77 77
             $model->setVariables(
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
     public function viewAction()
57 57
     {
58 58
         $id = $this->params()->fromQuery('id');
59
-        $channel = $this->params()->fromRoute('channel','default');
59
+        $channel = $this->params()->fromRoute('channel', 'default');
60 60
         $response = $this->getResponse();
61 61
         /* @var \Jobs\Entity\Job $job */
62 62
         $job = $this->jobRepository->find($id);
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
             $this->auth()->isAdmin()
84 84
         ) {
85 85
             $applicationViewModel->setTemplate('iframe/iFrameInjection');
86
-        }elseif(Status::EXPIRED == $job->getStatus() or  Status::INACTIVE == $job->getStatus()) {
86
+        }elseif (Status::EXPIRED == $job->getStatus() or Status::INACTIVE == $job->getStatus()) {
87 87
             $response->setStatusCode(Response::STATUS_CODE_410);
88 88
             $model->setTemplate('jobs/error/expired');
89 89
             $model->setVariables(
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
     protected function editTemplateAction()
112 112
     {
113 113
         $id = $this->params('id');
114
-        $formIdentifier=$this->params()->fromQuery('form');
114
+        $formIdentifier = $this->params()->fromQuery('form');
115 115
         $job = $this->jobRepository->find($id);
116 116
         $this->acl($job, 'edit');
117 117
 
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
 
143 143
             $instanceForm = $formTemplate->get($formIdentifier);
144 144
             if (!isset($instanceForm)) {
145
-                throw new \RuntimeException('No form found for "' . $formIdentifier . '"');
145
+                throw new \RuntimeException('No form found for "'.$formIdentifier.'"');
146 146
             }
147 147
 
148 148
             // the id is part of the postData, but it never should be altered
Please login to merge, or discard this patch.
module/Jobs/config/module.config.php 1 patch
Spacing   +33 added lines, -33 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@  discard block
 block discarded – undo
15 15
                  * for multiple paths.
16 16
                  * example https://github.com/doctrine/DoctrineORMModule
17 17
                  */
18
-                'paths' => array( __DIR__ . '/../src/Jobs/Entity'),
18
+                'paths' => array(__DIR__.'/../src/Jobs/Entity'),
19 19
             ),
20 20
         ),
21 21
         'eventmanager' => array(
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
             'translation_file_patterns' => array(
47 47
                     array(
48 48
                             'type'     => 'gettext',
49
-                            'base_dir' => __DIR__ . '/../language',
49
+                            'base_dir' => __DIR__.'/../language',
50 50
                             'pattern'  => '%s.mo',
51 51
                     ),
52 52
             ),
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
                 'allow' => array(
85 85
                     'Jobboard',
86 86
                     'Jobs/Jobboard',
87
-                    'Jobs/Template' => [ 'view', 'edittemplate' ],
87
+                    'Jobs/Template' => ['view', 'edittemplate'],
88 88
                     'Jobs/Manage' => array(
89 89
                         'template',
90 90
                     ),
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
     ),
214 214
 
215 215
     'event_manager' => [
216
-        'Core/AdminController/Events' => [ 'listeners' => [
216
+        'Core/AdminController/Events' => ['listeners' => [
217 217
             'Jobs/Listener/AdminWidgetProvider' => \Core\Controller\AdminControllerEvent::EVENT_DASHBOARD,
218 218
         ]],
219 219
 
@@ -266,39 +266,39 @@  discard block
 block discarded – undo
266 266
     'view_manager' => array(
267 267
         // Map template to files. Speeds up the lookup through the template stack.
268 268
         'template_map' => array(
269
-            'jobs/form/list-filter' => __DIR__ . '/../view/form/list-filter.phtml',
270
-            'jobs/form/apply-identifier' => __DIR__ . '/../view/form/apply-identifier.phtml',
271
-            'jobs/form/hiring-organization-select' => __DIR__ . '/../view/form/hiring-organization-select.phtml',
272
-            'jobs/form/multiposting-select' => __DIR__ . '/../view/form/multiposting-select.phtml',
273
-            'jobs/form/multiposting-checkboxes' => __DIR__ . '/../view/form/multiposting-checkboxes.phtml',
274
-            'jobs/form/ats-mode.view' => __DIR__ . '/../view/form/ats-mode.view.phtml',
275
-            'jobs/form/ats-mode.form' => __DIR__ . '/../view/form/ats-mode.form.phtml',
276
-            'jobs/form/preview' => __DIR__ . '/../view/form/preview.phtml',
277
-            'jobs/partials/channel-list' => __DIR__ . '/../view/partials/channel-list.phtml',
278
-            'jobs/assign-user' => __DIR__ . '/../view/jobs/manage/assign-user.phtml',
279
-            'jobs/snapshot_or_preview' => __DIR__ . '/../view/partials/snapshot_or_preview.phtml',
280
-            'jobs/history' => __DIR__ . '/../view/partials/history.phtml',
281
-            'jobs/portalsummary' => __DIR__ . '/../view/partials/portalsummary.phtml',
282
-            'content/jobs-publish-on-yawik' => __DIR__ . '/../view/modals/yawik.phtml',
283
-            'content/jobs-publish-on-jobsintown' => __DIR__ . '/../view/modals/jobsintown.phtml',
284
-            'content/jobs-publish-on-homepage' => __DIR__ . '/../view/modals/homepage.phtml',
285
-            'content/jobs-publish-on-fazjob' => __DIR__ . '/../view/modals/fazjob.phtml',
286
-            'content/jobs-terms-and-conditions' => __DIR__ . '/../view/jobs/index/terms.phtml',
287
-            'mail/job-created' => __DIR__ . '/../view/mails/job-created.phtml',
288
-            'mail/job-pending' => __DIR__ . '/../view/mails/job-pending.phtml',
289
-            'mail/job-accepted' => __DIR__ . '/../view/mails/job-accepted.phtml',
290
-            'mail/job-rejected' => __DIR__ . '/../view/mails/job-rejected.phtml',
291
-            'mail/job-created.en' => __DIR__ . '/../view/mails/job-created.en.phtml',
292
-            'mail/job-pending.en' => __DIR__ . '/../view/mails/job-pending.en.phtml',
293
-            'mail/job-accepted.en' => __DIR__ . '/../view/mails/job-accepted.en.phtml',
294
-            'mail/job-rejected.en' => __DIR__ . '/../view/mails/job-rejected.en.phtml',
295
-            'jobs/error/no-parent' => __DIR__ . '/../view/error/no-parent.phtml',
296
-            'jobs/error/expired' => __DIR__ . '/../view/error/expired.phtml',
269
+            'jobs/form/list-filter' => __DIR__.'/../view/form/list-filter.phtml',
270
+            'jobs/form/apply-identifier' => __DIR__.'/../view/form/apply-identifier.phtml',
271
+            'jobs/form/hiring-organization-select' => __DIR__.'/../view/form/hiring-organization-select.phtml',
272
+            'jobs/form/multiposting-select' => __DIR__.'/../view/form/multiposting-select.phtml',
273
+            'jobs/form/multiposting-checkboxes' => __DIR__.'/../view/form/multiposting-checkboxes.phtml',
274
+            'jobs/form/ats-mode.view' => __DIR__.'/../view/form/ats-mode.view.phtml',
275
+            'jobs/form/ats-mode.form' => __DIR__.'/../view/form/ats-mode.form.phtml',
276
+            'jobs/form/preview' => __DIR__.'/../view/form/preview.phtml',
277
+            'jobs/partials/channel-list' => __DIR__.'/../view/partials/channel-list.phtml',
278
+            'jobs/assign-user' => __DIR__.'/../view/jobs/manage/assign-user.phtml',
279
+            'jobs/snapshot_or_preview' => __DIR__.'/../view/partials/snapshot_or_preview.phtml',
280
+            'jobs/history' => __DIR__.'/../view/partials/history.phtml',
281
+            'jobs/portalsummary' => __DIR__.'/../view/partials/portalsummary.phtml',
282
+            'content/jobs-publish-on-yawik' => __DIR__.'/../view/modals/yawik.phtml',
283
+            'content/jobs-publish-on-jobsintown' => __DIR__.'/../view/modals/jobsintown.phtml',
284
+            'content/jobs-publish-on-homepage' => __DIR__.'/../view/modals/homepage.phtml',
285
+            'content/jobs-publish-on-fazjob' => __DIR__.'/../view/modals/fazjob.phtml',
286
+            'content/jobs-terms-and-conditions' => __DIR__.'/../view/jobs/index/terms.phtml',
287
+            'mail/job-created' => __DIR__.'/../view/mails/job-created.phtml',
288
+            'mail/job-pending' => __DIR__.'/../view/mails/job-pending.phtml',
289
+            'mail/job-accepted' => __DIR__.'/../view/mails/job-accepted.phtml',
290
+            'mail/job-rejected' => __DIR__.'/../view/mails/job-rejected.phtml',
291
+            'mail/job-created.en' => __DIR__.'/../view/mails/job-created.en.phtml',
292
+            'mail/job-pending.en' => __DIR__.'/../view/mails/job-pending.en.phtml',
293
+            'mail/job-accepted.en' => __DIR__.'/../view/mails/job-accepted.en.phtml',
294
+            'mail/job-rejected.en' => __DIR__.'/../view/mails/job-rejected.en.phtml',
295
+            'jobs/error/no-parent' => __DIR__.'/../view/error/no-parent.phtml',
296
+            'jobs/error/expired' => __DIR__.'/../view/error/expired.phtml',
297 297
         ),
298 298
 
299 299
         // Where to look for view templates not mapped above
300 300
         'template_path_stack' => array(
301
-            __DIR__ . '/../view',
301
+            __DIR__.'/../view',
302 302
         ),
303 303
     ),
304 304
 
Please login to merge, or discard this patch.
module/Core/src/Core/Listener/LanguageRouteListener.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -215,8 +215,8 @@
 block discarded – undo
215 215
     }
216 216
 
217 217
     /**
218
-     * @param $response
219
-     * @param $uri
218
+     * @param \Zend\Stdlib\ResponseInterface $response
219
+     * @param string $uri
220 220
      *
221 221
      * @return mixed
222 222
      */
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -97,10 +97,10 @@  discard block
 block discarded – undo
97 97
         }
98 98
         
99 99
         $router = $e->getRouter();
100
-        $basePath=$router->getBaseUrl();
100
+        $basePath = $router->getBaseUrl();
101 101
         $match = [];
102 102
         
103
-        if (preg_match('~^' . $basePath . '/([a-z]{2})(?:/|$)~', $e->getRequest()->getRequestUri(), $match)) {
103
+        if (preg_match('~^'.$basePath.'/([a-z]{2})(?:/|$)~', $e->getRequest()->getRequestUri(), $match)) {
104 104
             /* It seems we have already a language in the URI
105 105
              * Now there are two possibilities:
106 106
              *
@@ -182,8 +182,8 @@  discard block
 block discarded – undo
182 182
         setlocale(
183 183
             LC_ALL,
184 184
             array(
185
-            $locale . ".utf8",
186
-            $locale . ".iso88591",
185
+            $locale.".utf8",
186
+            $locale.".iso88591",
187 187
             $locale,
188 188
             substr($locale, 0, 2),
189 189
             'de_DE.utf8',
Please login to merge, or discard this patch.
module/Core/src/Core/Controller/Plugin/Service/NotificationFactory.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
         $notificationListener = $serviceLocator->getServiceLocator()->get('Core/Listener/Notification');
25 25
         $translator = $services->get('translator');
26 26
 
27
-        $notification   = new Notification($flashMessenger);
27
+        $notification = new Notification($flashMessenger);
28 28
         $notification->setListener($notificationListener);
29 29
         $notification->setTranslator($translator);
30 30
 
Please login to merge, or discard this patch.
module/Jobs/src/Jobs/Factory/Form/HiringOrganizationSelectFactory.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@
 block discarded – undo
41 41
             $organizations = $organizationReference->getHiringOrganizations()->toArray();
42 42
             $organization = $organizationReference->getOrganization();
43 43
             if (!$organization->isDraft()) {
44
-    			array_unshift($organizations, $organization);
44
+                array_unshift($organizations, $organization);
45 45
             }
46 46
             $select->setSelectableOrganizations($organizations, /* addEmptyOption */
47 47
                                                 false
Please login to merge, or discard this patch.
module/Applications/src/Applications/Listener/EventApplicationCreated.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
                         [
77 77
                             'job' => $job,
78 78
                             'user' => $employee->getUser(),
79
-                            'bcc' => $adminSettings->getMailBCC() ? [ $admin ] : null,
79
+                            'bcc' => $adminSettings->getMailBCC() ? [$admin] : null,
80 80
                         ]
81 81
                     );
82 82
                 }
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
                 [
95 95
                     'job'   => $this->application->getJob(),
96 96
                     'user'  => $recruiter,
97
-                    'bcc' => $adminSettings->getMailBCC() ? [ $admin ] : null,
97
+                    'bcc' => $adminSettings->getMailBCC() ? [$admin] : null,
98 98
                 ]
99 99
             );
100 100
         }
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
                     [
112 112
                         'application' => $this->application,
113 113
                         'body'        => $ackBody,
114
-                        'bcc'         => $adminSettings->getMailBCC() ? [ $admin ] : null,
114
+                        'bcc'         => $adminSettings->getMailBCC() ? [$admin] : null,
115 115
                     ]
116 116
                 );
117 117
 
Please login to merge, or discard this patch.
Settings/src/Settings/Form/DisableElementsCapableFormSettingsFieldset.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -109,7 +109,7 @@
 block discarded – undo
109 109
     
110 110
     /**
111 111
      * @param ServiceLocatorInterface $formManager
112
-     * @return AbstractSettingsForm
112
+     * @return DisableElementsCapableFormSettingsFieldset
113 113
      */
114 114
     public static function factory(ServiceLocatorInterface $formManager)
115 115
     {
Please login to merge, or discard this patch.
module/Core/src/Core/Mail/MailServiceFactory.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@
 block discarded – undo
39 39
 
40 40
         $config = new MailServiceConfig($configArray);
41 41
 
42
-        $service   = new MailService($serviceLocator, $config);
42
+        $service = new MailService($serviceLocator, $config);
43 43
 
44 44
         return $service;
45 45
 
Please login to merge, or discard this patch.