Completed
Pull Request — develop (#223)
by ANTHONIUS
08:52
created
module/Auth/src/Auth/Factory/Form/RoleSelectFactory.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@
 block discarded – undo
39 39
                           || array_key_exists('user', $config['acl']['roles'])
40 40
                           ? array(User::ROLE_USER)
41 41
                           : array('none')
42
-                         );
42
+                            );
43 43
         
44 44
         $valueOptions = array();
45 45
         foreach ($publicRoles as $role) {
Please login to merge, or discard this patch.
module/Core/src/Core/Entity/EntityTrait.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -22,6 +22,9 @@
 block discarded – undo
22 22
  */
23 23
 trait EntityTrait
24 24
 {
25
+    /**
26
+     * @param string $property
27
+     */
25 28
     public function notEmpty($property, array $args=[])
26 29
     {
27 30
         $method = "get$property";
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -20,16 +20,16 @@
 block discarded – undo
20 20
  */
21 21
 trait EntityTrait
22 22
 {
23
-    public function notEmpty($property, array $args=[])
23
+    public function notEmpty($property, array $args = [])
24 24
     {
25 25
         $method = "get$property";
26 26
 
27 27
         if (!method_exists($this, $method)) {
28
-            throw new OutOfBoundsException("'$property' is not a valid property of '" . get_class($this) . "'");
28
+            throw new OutOfBoundsException("'$property' is not a valid property of '".get_class($this)."'");
29 29
         }
30 30
 
31 31
         $value = count($args)
32
-            ? call_user_func_array([ $this, $method ], $args)
32
+            ? call_user_func_array([$this, $method], $args)
33 33
             : $this->$method();
34 34
 
35 35
         if (null === $value) { // is_scalar does not consider 'null' to be scalar value.
Please login to merge, or discard this patch.
module/Core/src/Core/Form/View/Helper/FormContainer.php 3 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -73,6 +73,9 @@
 block discarded – undo
73 73
 
74 74
     }
75 75
 
76
+    /**
77
+     * @param string $layout
78
+     */
76 79
     public function renderElement($element, $layout, $parameter)
77 80
     {
78 81
         $parameterPartial = $parameter;
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -96,9 +96,9 @@
 block discarded – undo
96 96
         } elseif ($element instanceof SummaryForm) {
97 97
             $content .= $this->getView()->summaryForm($element);
98 98
         } elseif ($element instanceof Container) {
99
-            $content.= $this->render($element, $layout, $parameter);
99
+            $content .= $this->render($element, $layout, $parameter);
100 100
         } else {
101
-            $content.= $this->getView()->form($element, $layout, $parameter);
101
+            $content .= $this->getView()->form($element, $layout, $parameter);
102 102
         }
103 103
 
104 104
         return $content;
Please login to merge, or discard this patch.
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -83,8 +83,8 @@
 block discarded – undo
83 83
         if ($element instanceof ViewPartialProviderInterface) {
84 84
             $parameterPartial = array_merge(array('element' => $element, 'layout' => $layout), $parameterPartial);
85 85
             $content .= $this->getView()->partial(
86
-                             $element->getViewPartial(),
87
-                             $parameterPartial
86
+                                $element->getViewPartial(),
87
+                                $parameterPartial
88 88
             );
89 89
 
90 90
         } elseif ($element instanceof ViewHelperProviderInterface) {
Please login to merge, or discard this patch.
module/Orders/src/Entity/OrderInterface.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -79,7 +79,6 @@
 block discarded – undo
79 79
     /**
80 80
      * Sets the invoice address.
81 81
      *
82
-     * @param InvoiceAddressInterface $invoice
83 82
      *
84 83
      * @return self
85 84
      */
Please login to merge, or discard this patch.
module/Orders/src/Factory/Form/JobInvoiceAddressFactory.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@
 block discarded – undo
36 36
      *
37 37
      * @param ServiceLocatorInterface $serviceLocator
38 38
      *
39
-     * @return mixed
39
+     * @return InvoiceAddress
40 40
      */
41 41
     public function createService(ServiceLocatorInterface $serviceLocator)
42 42
     {
Please login to merge, or discard this patch.
module/Core/src/Core/Factory/EventManager/EventManagerAbstractFactory.php 4 patches
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -54,8 +54,7 @@
 block discarded – undo
54 54
         if (method_exists($events, 'setEventPrototype')) {
55 55
             $event = $serviceLocator->has($config['event']) ? $serviceLocator->get($config['event']) : new $config['event']();
56 56
             $events->setEventPrototype($event);
57
-        }
58
-        else {
57
+        } else {
59 58
             $events->setEventClass($config['event']);
60 59
         }
61 60
 
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -293,7 +293,7 @@
 block discarded – undo
293 293
      * @param string|array $options String is either event name or aggregate name (when name is int).
294 294
      *                              Array are the options from config. [ [event,..], method, priority, lazy]
295 295
      *
296
-     * @return array
296
+     * @return \Zend\EventManager\EventManagerInterface
297 297
      */
298 298
     protected function normalizeListenerOptions($name, $options)
299 299
     {
Please login to merge, or discard this patch.
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -278,7 +278,7 @@
 block discarded – undo
278 278
             /* @var \Core\Listener\DeferredListenerAggregate $aggregate */
279 279
             $aggregate = $services->get('Core/Listener/DeferredListenerAggregate');
280 280
             $aggregate->setListeners($lazyListeners)
281
-                      ->attach($eventManager);
281
+                        ->attach($eventManager);
282 282
         }
283 283
     }
284 284
 
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
         $defaults = [
149 149
             'service' => 'EventManager',
150 150
             'configure' => true,
151
-            'identifiers' => [ $name ],
151
+            'identifiers' => [$name],
152 152
             'event' => '\Zend\EventManager\Event',
153 153
             'listeners' => [],
154 154
         ];
@@ -239,7 +239,7 @@  discard block
 block discarded – undo
239 239
         foreach ($listeners as $name => $options) {
240 240
             $options = $this->normalizeListenerOptions($name, $options);
241 241
 
242
-            if ($options['lazy'] && null !== $options['attach'] ) {
242
+            if ($options['lazy'] && null !== $options['attach']) {
243 243
                 foreach ($options['attach'] as $spec) {
244 244
                     $lazyListeners[] = [
245 245
                         'service' => $options['service'],
@@ -269,7 +269,7 @@  discard block
 block discarded – undo
269 269
             }
270 270
 
271 271
             foreach ($options['attach'] as $spec) {
272
-                $callback = $spec['method'] ? [ $listener, $spec['method'] ] : $listener;
272
+                $callback = $spec['method'] ? [$listener, $spec['method']] : $listener;
273 273
                 $eventManager->attach($spec['events'], $callback, $spec['priority']);
274 274
             }
275 275
         }
@@ -340,7 +340,7 @@  discard block
 block discarded – undo
340 340
 
341 341
         if (is_string($options)) {
342 342
             /* Only an event name is provided in config */
343
-            $normalized['attach'] = [ [ 'events' => [ $options ], 'method' => null, 'priority' => 0 ] ];
343
+            $normalized['attach'] = [['events' => [$options], 'method' => null, 'priority' => 0]];
344 344
             return $normalized;
345 345
 
346 346
         }
@@ -369,7 +369,7 @@  discard block
 block discarded – undo
369 369
             } else if (is_string($opt)) {
370 370
                 if (null === $event) {
371 371
                     /* first string found is assumed to be the event name */
372
-                    $event = [ $opt ];
372
+                    $event = [$opt];
373 373
                 } else {
374 374
                     /* second string found must be a method name. */
375 375
                     $method = $opt;
@@ -385,7 +385,7 @@  discard block
 block discarded – undo
385 385
             }
386 386
         }
387 387
 
388
-        $normalized['attach'] = [ [ 'events' => $event, 'method' => $method, 'priority' => $priority ] ];
388
+        $normalized['attach'] = [['events' => $event, 'method' => $method, 'priority' => $priority]];
389 389
         $normalized['lazy']   = $lazy;
390 390
 
391 391
         return $normalized;
@@ -394,7 +394,7 @@  discard block
 block discarded – undo
394 394
     protected function normalizeEventsSpec($options)
395 395
     {
396 396
         $listenerPriority = isset($options['priority']) ? $options['priority'] : 0;
397
-        $listenerMethod   = isset($options['method'])   ? $options['method']   : '__none__';
397
+        $listenerMethod   = isset($options['method']) ? $options['method'] : '__none__';
398 398
         $events = [];
399 399
 
400 400
         foreach ($options['events'] as $event => $spec) {
@@ -414,7 +414,7 @@  discard block
 block discarded – undo
414 414
             } else if (is_array($spec)) {
415 415
                 if (isset($spec['method'])) {
416 416
                     if (!is_array($spec['method'])) {
417
-                        $spec['method'] = [ $spec['method'] ];
417
+                        $spec['method'] = [$spec['method']];
418 418
                     }
419 419
 
420 420
                     foreach ($spec['method'] as $method => $methodPriority) {
Please login to merge, or discard this patch.
module/Orders/config/router.config.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -6,7 +6,7 @@
 block discarded – undo
6 6
  * @license MIT
7 7
  * @copyright  2013 - 2016 Cross Solution <http://cross-solution.de>
8 8
  */
9
-return [ 'router' => [ 'routes' => [ 'lang' => [ 'child_routes' => [
9
+return ['router' => ['routes' => ['lang' => ['child_routes' => [
10 10
 
11 11
     'orders' => [
12 12
         'type' => 'Segment',
Please login to merge, or discard this patch.
module/Orders/config/module.config.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -60,4 +60,4 @@
 block discarded – undo
60 60
         ],
61 61
     ],
62 62
 ];
63
-  
64 63
\ No newline at end of file
64
+    
65 65
\ No newline at end of file
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
                  * for multiple paths.
24 24
                  * example https://github.com/doctrine/DoctrineORMModule
25 25
                  */
26
-                'paths' => array( __DIR__ . '/../src/Entity'),
26
+                'paths' => array(__DIR__.'/../src/Entity'),
27 27
             ),
28 28
         ],
29 29
     ],
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
         'translation_file_patterns' => array(
34 34
             array(
35 35
                 'type'     => 'gettext',
36
-                'base_dir' => __DIR__ . '/../language',
36
+                'base_dir' => __DIR__.'/../language',
37 37
                 'pattern'  => '%s.mo',
38 38
             ),
39 39
         ),
@@ -42,11 +42,11 @@  discard block
 block discarded – undo
42 42
 
43 43
     'event_manager' => [
44 44
 
45
-        'Jobs/Events' => [ 'listeners' => [
46
-            'Orders/Listener/CreateJobOrder' => [ \Jobs\Listener\Events\JobEvent::EVENT_JOB_CREATED, true ],
45
+        'Jobs/Events' => ['listeners' => [
46
+            'Orders/Listener/CreateJobOrder' => [\Jobs\Listener\Events\JobEvent::EVENT_JOB_CREATED, true],
47 47
         ]],
48 48
 
49
-        'Jobs/JobContainer/Events' => [ 'listeners' => [
49
+        'Jobs/JobContainer/Events' => ['listeners' => [
50 50
             '\Orders\Form\Listener\DisableJobInvoiceAddress' => 'DisableElements',
51 51
             'Orders\Form\Listener\InjectInvoiceAddressInJobContainer' => \Core\Form\Event\FormEvent::EVENT_INIT,
52 52
             '\Orders\Form\Listener\ValidateJobInvoiceAddress' => 'ValidateJob',
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
             ],
60 60
         ],
61 61
 
62
-        'Core/AdminController/Events' => [ 'listeners' => [
62
+        'Core/AdminController/Events' => ['listeners' => [
63 63
             'Orders/Listener/AdminWidgetProvider' => \Core\Controller\AdminControllerEvent::EVENT_DASHBOARD,
64 64
         ]],
65 65
     ],
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
     'view_helper_config' => [
83 83
         'headscript' => [
84 84
             'lang/orders' => [
85
-                [ \Zend\View\Helper\HeadScript::FILE, 'Orders/js/list.index.js', 'PREPEND' ],
85
+                [\Zend\View\Helper\HeadScript::FILE, 'Orders/js/list.index.js', 'PREPEND'],
86 86
                 'js/bootstrap-dialog.min.js'
87 87
             ],
88 88
         ],
Please login to merge, or discard this patch.
module/Orders/config/acl.config.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -7,7 +7,7 @@
 block discarded – undo
7 7
  * @copyright  2013 - 2016 Cross Solution <http://cross-solution.de>
8 8
  */
9 9
 
10
-return [ 'acl' => [
10
+return ['acl' => [
11 11
 
12 12
     'rules' => [
13 13
         'admin' => [
Please login to merge, or discard this patch.