Completed
Pull Request — develop (#223)
by ANTHONIUS
08:52
created
module/Auth/src/Auth/Factory/Listener/MailForgotPasswordFactory.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
      * Creates an instance of MailForgotPassword
23 23
      *
24 24
      * @param ServiceLocatorInterface $serviceLocator
25
-     * @return \Auth\View\Helper\Auth
25
+     * @return MailForgotPassword
26 26
      * @see \Zend\ServiceManager\FactoryInterface::createService()
27 27
      */
28 28
     public function createService(ServiceLocatorInterface $serviceLocator)
Please login to merge, or discard this patch.
module/Geo/src/Geo/Controller/Plugin/Photon.php 3 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@
 block discarded – undo
17 17
     /**
18 18
      * @param string $par Query Parameter
19 19
      * @param string $geoCoderUrl Url of the geo location service
20
-     * @param string $land language
20
+     * @param string $lang language
21 21
      *
22 22
      * @return array|mixed|string
23 23
      */
Please login to merge, or discard this patch.
Indentation   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -51,16 +51,16 @@
 block discarded – undo
51 51
         $r=[];
52 52
         foreach ($result as $key => $val) {
53 53
             $row=['name' => (property_exists($val->properties, 'name') ? $val->properties->name:''),
54
-                  'postcode' => (property_exists($val->properties, 'postcode') ? $val->properties->postcode:''),
55
-                  'city' =>(property_exists($val->properties, 'city') ? $val->properties->city:''),
56
-                  'street' => (property_exists($val->properties, 'street') ? $val->properties->street : ''),
57
-                  'state' => (property_exists($val->properties, 'state') ? $val->properties->state : ''),
58
-                  'country' => (property_exists($val->properties, 'country') ? $val->properties->country : ''),
59
-                  'coordinates' => implode(":", $val->geometry->coordinates),
60
-                  'osm_key' => (property_exists($val->properties, 'osm_key') ? $val->properties->osm_key : ''),
61
-                  'osm_value' => (property_exists($val->properties, 'osm_value') ? $val->properties->osm_value : ''),
62
-                  'osm_id' => (property_exists($val->properties, 'osm_id') ? $val->properties->osm_id : ''),
63
-                  'data' => json_encode($val),
54
+                    'postcode' => (property_exists($val->properties, 'postcode') ? $val->properties->postcode:''),
55
+                    'city' =>(property_exists($val->properties, 'city') ? $val->properties->city:''),
56
+                    'street' => (property_exists($val->properties, 'street') ? $val->properties->street : ''),
57
+                    'state' => (property_exists($val->properties, 'state') ? $val->properties->state : ''),
58
+                    'country' => (property_exists($val->properties, 'country') ? $val->properties->country : ''),
59
+                    'coordinates' => implode(":", $val->geometry->coordinates),
60
+                    'osm_key' => (property_exists($val->properties, 'osm_key') ? $val->properties->osm_key : ''),
61
+                    'osm_value' => (property_exists($val->properties, 'osm_value') ? $val->properties->osm_value : ''),
62
+                    'osm_id' => (property_exists($val->properties, 'osm_id') ? $val->properties->osm_id : ''),
63
+                    'data' => json_encode($val),
64 64
             ];
65 65
             $r[]=$row;
66 66
         }
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -27,11 +27,11 @@  discard block
 block discarded – undo
27 27
         $client->setMethod('GET');
28 28
 
29 29
         $osmTags = [
30
-            'tourism','aeroway','railway', 'amenity', 'historic', 'tunnel', 'mountain_pass',
30
+            'tourism', 'aeroway', 'railway', 'amenity', 'historic', 'tunnel', 'mountain_pass',
31 31
             'leisure', 'natural', 'bridge', 'waterway'
32 32
         ];
33 33
 
34
-        $osmTags = array_map(function($i) { return urlencode('!' . $i); }, $osmTags);
34
+        $osmTags = array_map(function($i) { return urlencode('!'.$i); }, $osmTags);
35 35
 
36 36
         $uri = sprintf(
37 37
             '%s?q=%s&lang=%s&osm_tag=%s',
@@ -48,11 +48,11 @@  discard block
 block discarded – undo
48 48
         $result = $response->getBody();
49 49
         $result = json_decode($result);
50 50
         $result = $result->features;
51
-        $r=[];
51
+        $r = [];
52 52
         foreach ($result as $key => $val) {
53
-            $row=['name' => (property_exists($val->properties, 'name') ? $val->properties->name:''),
54
-                  'postcode' => (property_exists($val->properties, 'postcode') ? $val->properties->postcode:''),
55
-                  'city' =>(property_exists($val->properties, 'city') ? $val->properties->city:''),
53
+            $row = ['name' => (property_exists($val->properties, 'name') ? $val->properties->name : ''),
54
+                  'postcode' => (property_exists($val->properties, 'postcode') ? $val->properties->postcode : ''),
55
+                  'city' =>(property_exists($val->properties, 'city') ? $val->properties->city : ''),
56 56
                   'street' => (property_exists($val->properties, 'street') ? $val->properties->street : ''),
57 57
                   'state' => (property_exists($val->properties, 'state') ? $val->properties->state : ''),
58 58
                   'country' => (property_exists($val->properties, 'country') ? $val->properties->country : ''),
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
                   'osm_id' => (property_exists($val->properties, 'osm_id') ? $val->properties->osm_id : ''),
63 63
                   'data' => json_encode($val),
64 64
             ];
65
-            $r[]=$row;
65
+            $r[] = $row;
66 66
         }
67 67
         return $r;
68 68
     }
Please login to merge, or discard this patch.
Jobs/src/Jobs/Factory/Repository/Filter/PaginationAdminQueryFactory.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@
 block discarded – undo
19 19
 {
20 20
     /**
21 21
      * @param ServiceLocatorInterface $serviceLocator
22
-     * @return PaginationAdminQuery|mixed
22
+     * @return PaginationAdminQuery
23 23
      */
24 24
     public function createService(ServiceLocatorInterface $serviceLocator)
25 25
     {
Please login to merge, or discard this patch.
module/Jobs/src/Jobs/Factory/Repository/Filter/PaginationQueryFactory.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@
 block discarded – undo
14 14
 {
15 15
     /**
16 16
      * @param ServiceLocatorInterface $serviceLocator
17
-     * @return PaginationQuery|mixed
17
+     * @return PaginationQuery
18 18
      */
19 19
     public function createService(ServiceLocatorInterface $serviceLocator)
20 20
     {
Please login to merge, or discard this patch.
module/Organizations/src/Organizations/Mail/EmployeeInvitationFactory.php 1 patch
Indentation   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -81,12 +81,12 @@  discard block
 block discarded – undo
81 81
         $url = $router->assemble(
82 82
             array('action' => 'accept'),
83 83
             array(
84
-                                     'name'  => 'lang/organizations/invite',
85
-                                     'query' => array(
86
-                                         'token'        => $this->options['token'],
87
-                                         'organization' => $org->getId()
88
-                                     )
89
-                                 )
84
+                                        'name'  => 'lang/organizations/invite',
85
+                                        'query' => array(
86
+                                            'token'        => $this->options['token'],
87
+                                            'organization' => $org->getId()
88
+                                        )
89
+                                    )
90 90
         );
91 91
 
92 92
         $variables = array(
@@ -107,14 +107,14 @@  discard block
 block discarded – undo
107 107
 
108 108
         $mail = $serviceLocator->get('htmltemplate');
109 109
         $mail->setTemplate($this->options['template'])
110
-             ->setVariables($variables)
111
-             ->setSubject(
112
-                 sprintf(
113
-                     /* @translate */ 'Invitation to join the team of %s',
114
-                     $orgName
115
-                 )
116
-             )
117
-             ->addTo($user->getEmail());
110
+                ->setVariables($variables)
111
+                ->setSubject(
112
+                    sprintf(
113
+                        /* @translate */ 'Invitation to join the team of %s',
114
+                        $orgName
115
+                    )
116
+                )
117
+                ->addTo($user->getEmail());
118 118
 
119 119
         return $mail;
120 120
     }
Please login to merge, or discard this patch.
module/Core/src/Core/Mail/TranslatorAwareMessage.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -108,6 +108,9 @@
 block discarded – undo
108 108
         return parent::setSubject($subject);
109 109
     }
110 110
 
111
+    /**
112
+     * @param string $formatString
113
+     */
111 114
     public function setFormattedSubject($formatString)
112 115
     {
113 116
         $args       = func_get_args();
Please login to merge, or discard this patch.
module/Core/src/Core/Controller/Plugin/CreatePaginatorService.php 3 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
      * @param array $defaultParams
31 31
      * @param bool  $usePostParams
32 32
      *
33
-     * @return mixed
33
+     * @return ZendPaginator
34 34
      */
35 35
     public function __invoke($paginatorName, $defaultParams = array(), $usePostParams = false)
36 36
     {
Please login to merge, or discard this patch.
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@
 block discarded – undo
42 42
         $this->filterSortParam($params);
43 43
         $paginator = $this->createPaginator($repository, $params);
44 44
         $paginator->setCurrentPageNumber($params->get('page', 1))
45
-                  ->setItemCountPerPage($params->get('count', 10));
45
+                    ->setItemCountPerPage($params->get('count', 10));
46 46
         
47 47
         return $paginator;
48 48
         
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -61,11 +61,11 @@
 block discarded – undo
61 61
         $paginatorManager = $this->serviceManager->get('Core/PaginatorService');
62 62
         $paginator = $paginatorManager->get($paginatorName);
63 63
         if (!isset($paginator) || !$paginator instanceof ZendPaginator) {
64
-            throw new \RuntimeException('Could not create paginator ' . $paginatorName);
64
+            throw new \RuntimeException('Could not create paginator '.$paginatorName);
65 65
         }
66 66
         $adapter = $paginator->getAdapter();
67 67
         if (!isset($adapter) || !$adapter instanceof AdapterInterface) {
68
-            throw new \RuntimeException('Paginator ' . $paginatorName . ' has no Adapter');
68
+            throw new \RuntimeException('Paginator '.$paginatorName.' has no Adapter');
69 69
         }
70 70
 
71 71
         $params     = $usePostParams
Please login to merge, or discard this patch.
module/Jobs/src/Jobs/Controller/ImportController.php 2 patches
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -179,9 +179,9 @@  discard block
 block discarded – undo
179 179
                                 $location = new Location();
180 180
                                 $coords = array_map(function($i) { return (float) $i; }, $locData['coordinates']);
181 181
                                 $location->setCountry($locData['country'])
182
-                                         ->setRegion($locData['region'])
183
-                                         ->setCity($locData['city'])
184
-                                         ->setCoordinates(new Point($coords));
182
+                                            ->setRegion($locData['region'])
183
+                                            ->setCity($locData['city'])
184
+                                            ->setCoordinates(new Point($coords));
185 185
 
186 186
                                 $jobLocations->add($location);
187 187
                             }
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
212 212
                                 /* @var $jobEvents \Zend\EventManager\EventManager */
213 213
                                 $jobEvents = $services->get('Jobs/Events');
214 214
                                 $jobEvent->setName(JobEvent::EVENT_JOB_ACCEPTED)
215
-                                         ->setTarget($this);
215
+                                            ->setTarget($this);
216 216
                                 $responses = $jobEvents->trigger($jobEvent);
217 217
                                 foreach ($responses as $response) {
218 218
                                     // responses from the portals
Please login to merge, or discard this patch.
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
                 'atsEnabled' => '1',
72 72
                 'uriApply' => 'http://mw2.yawik.org/de/apply/129145',
73 73
                 'logoRef' => 'http://anzeigen.jobsintown.de/companies/logo/image-id/3263',
74
-                'publisher' => 'http://anzeigen.jobsintown.de/feedbackJobPublish/' . '2130010128',
74
+                'publisher' => 'http://anzeigen.jobsintown.de/feedbackJobPublish/'.'2130010128',
75 75
                 'imageUrl' => 'http://th07.deviantart.net/fs71/PRE/i/2014/230/5/8/a_battle_with_the_elements_by_lordljcornellphotos-d7vns0p.jpg',
76 76
                 'locations' => '[{"country":"Deutschland","city":null,"region":"Mecklenburg-Vorpommern","coordinates":["13.2555","53.5476"]}]',
77 77
 
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
                         $entity = $repositoriesJob->findOneBy(array("applyId" => (string) $applyId));
106 106
                         if (!isset($entity)) {
107 107
                             // new Job (the more likely branch)
108
-                            $entity =$repositoriesJob->create(array("applyId" => (string) $applyId));
108
+                            $entity = $repositoriesJob->create(array("applyId" => (string) $applyId));
109 109
                         } else {
110 110
                             $createdJob = false;
111 111
                         }
@@ -142,10 +142,10 @@  discard block
 block discarded – undo
142 142
                             $entity->getPermissions()->grant($group, PermissionsInterface::PERMISSION_VIEW);
143 143
                         }
144 144
                         $result['isSaved'] = true;
145
-                        $log->info('Jobs/manage/saveJob [user: ' . $user->login . ']:' . var_export($p, true));
145
+                        $log->info('Jobs/manage/saveJob [user: '.$user->login.']:'.var_export($p, true));
146 146
 
147 147
                         if (!empty($params->companyId)) {
148
-                            $companyId                = $params->companyId . $loginSuffix;
148
+                            $companyId                = $params->companyId.$loginSuffix;
149 149
                             $repOrganization          = $repositories->get('Organizations/Organization');
150 150
                             $hydratorManager          = $services->get('hydratorManager');
151 151
                             $hydrator                 = $hydratorManager->get('Hydrator/Organization');
@@ -194,7 +194,7 @@  discard block
 block discarded – undo
194 194
                             $jobLocations->clear();
195 195
                             foreach ($locations as $locData) {
196 196
                                 $location = new Location();
197
-                                $coords = array_map(function ($i) { return (float) $i; }, $locData['coordinates']);
197
+                                $coords = array_map(function($i) { return (float) $i; }, $locData['coordinates']);
198 198
                                 $location->setCountry($locData['country'])
199 199
                                          ->setRegion($locData['region'])
200 200
                                          ->setCity($locData['city'])
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
                                                     break;
260 260
                                             }
261 261
                                             if (array_key_exists($portal, $result['portals'])) {
262
-                                                throw new \RuntimeException('Publisher-Events (internal error): There are two publisher registered for ' . $portal);
262
+                                                throw new \RuntimeException('Publisher-Events (internal error): There are two publisher registered for '.$portal);
263 263
                                             }
264 264
                                             $result['portals'][$portal] = $status;
265 265
                                         } else {
@@ -272,16 +272,16 @@  discard block
 block discarded – undo
272 272
                             }
273 273
                         }
274 274
                     } else {
275
-                        $log->info('Jobs/manage/saveJob [error: ' . $form->getMessages() . ']:' . var_export($p, true));
275
+                        $log->info('Jobs/manage/saveJob [error: '.$form->getMessages().']:'.var_export($p, true));
276 276
                         $result['valid Error'] = $form->getMessages();
277 277
                     }
278 278
                 }
279 279
             } else {
280
-                $log->info('Jobs/manage/saveJob [error: session lost]:' . var_export($p, true));
280
+                $log->info('Jobs/manage/saveJob [error: session lost]:'.var_export($p, true));
281 281
                 $result['message'] = 'session_id is lost';
282 282
             }
283 283
         } catch (\Exception $e) {
284
-            $result['message'] = 'exception occured: ' . $e->getMessage();
284
+            $result['message'] = 'exception occured: '.$e->getMessage();
285 285
         }
286 286
         //$services->get('Core/Log')->info('Jobs/manage/saveJob result:' . PHP_EOL . var_export($p, True));
287 287
         return new JsonModel($result);
Please login to merge, or discard this patch.
module/Core/src/Core/Form/Form.php 2 patches
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -77,6 +77,7 @@  discard block
 block discarded – undo
77 77
 
78 78
     /**
79 79
      * @param string $description
80
+     * @param double[] $params
80 81
      *
81 82
      * @return $this
82 83
      */
@@ -258,7 +259,7 @@  discard block
 block discarded – undo
258 259
     }
259 260
 
260 261
     /**
261
-     * @param $spec
262
+     * @param string $spec
262 263
      *
263 264
      * @return $this
264 265
      */
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
      *
81 81
      * @return $this
82 82
      */
83
-    public function setDescription($description,$params = null)
83
+    public function setDescription($description, $params = null)
84 84
     {
85 85
         $this->options['description'] = $description;
86 86
         $this->options['description_params'] = $params;
@@ -350,9 +350,9 @@  discard block
 block discarded – undo
350 350
                 if (!$inputExists && $required) {
351 351
                     $fieldsetName = '';
352 352
                     if ($fieldset->hasAttribute('name')) {
353
-                        $fieldsetName = 'in Fieldset "' . $fieldset->getAttribute('name') . '" ';
353
+                        $fieldsetName = 'in Fieldset "'.$fieldset->getAttribute('name').'" ';
354 354
                     }
355
-                    throw new \RuntimeException('input for "' . $name . '" ' . $fieldsetName . 'is required but a input-field with this name is not defined');
355
+                    throw new \RuntimeException('input for "'.$name.'" '.$fieldsetName.'is required but a input-field with this name is not defined');
356 356
                 }
357 357
             }
358 358
         }
Please login to merge, or discard this patch.