Completed
Pull Request — develop (#459)
by ANTHONIUS
06:44
created
module/Jobs/src/Jobs/Controller/ManageController.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -227,11 +227,11 @@  discard block
 block discarded – undo
227 227
     protected function save()
228 228
     {
229 229
 		$formEvents = $this->jobFormEvents;
230
-        $user               = $this->auth->getUser();
230
+        $user = $this->auth->getUser();
231 231
         if (empty($user->getInfo()->getEmail())) {
232 232
             return $this->getErrorViewModel('no-parent', array('cause' => 'noEmail'));
233 233
         }
234
-        $userOrg            = $user->getOrganization();
234
+        $userOrg = $user->getOrganization();
235 235
         if (!$userOrg->hasAssociation() || $userOrg->getOrganization()->isDraft()) {
236 236
             return $this->getErrorViewModel('no-parent', array('cause' => 'noCompany'));
237 237
         }
@@ -261,7 +261,7 @@  discard block
 block discarded – undo
261 261
         }
262 262
 
263 263
 
264
-        $viewModel          = null;
264
+        $viewModel = null;
265 265
         $this->acl($jobEntity, 'edit');
266 266
         if ($status = $params->fromQuery('status')) {
267 267
             $this->changeStatus($jobEntity, $status);
@@ -273,11 +273,11 @@  discard block
 block discarded – undo
273 273
         $instanceForm       = null;
274 274
         $formErrorMessages = array();
275 275
 
276
-        if (isset($formIdentifier) &&  $request->isPost()) {
276
+        if (isset($formIdentifier) && $request->isPost()) {
277 277
             // at this point the form get instantiated and immediately accumulated
278 278
             $instanceForm = $form->getForm($formIdentifier);
279 279
             if (!isset($instanceForm)) {
280
-                throw new \RuntimeException('No form found for "' . $formIdentifier . '"');
280
+                throw new \RuntimeException('No form found for "'.$formIdentifier.'"');
281 281
             }
282 282
             // the id may be part of the postData, but it never should be altered
283 283
             $postData = $request->getPost();
@@ -331,20 +331,20 @@  discard block
 block discarded – undo
331 331
             $jobValid = false;
332 332
             $errorMessage[] = $this->translator->translate('Accept the Terms');
333 333
         }
334
-        $result = $formEvents->trigger('ValidateJob', $this, [ 'form' => $form ]);
334
+        $result = $formEvents->trigger('ValidateJob', $this, ['form' => $form]);
335 335
         foreach ($result as $messages) {
336 336
             if (!$messages) {
337 337
                 continue;
338 338
             }
339 339
             if (!is_array($messages)) {
340
-                $messages = [ $messages ];
340
+                $messages = [$messages];
341 341
             }
342 342
 
343 343
             $errorMessage = array_merge($errorMessage, $messages);
344 344
             $jobValid = false;
345 345
         }
346 346
 
347
-        $errorMessage = '<br />' . implode('<br />', $errorMessage);
347
+        $errorMessage = '<br />'.implode('<br />', $errorMessage);
348 348
         if ($isAjax) {
349 349
             if ($instanceForm instanceof SummaryForm) {
350 350
                 $instanceForm->setRenderMode(SummaryForm::RENDER_SUMMARY);
@@ -352,7 +352,7 @@  discard block
 block discarded – undo
352 352
             } else {
353 353
                 $viewHelper = 'form';
354 354
             }
355
-            $viewHelperManager  = $this->viewHelper;
355
+            $viewHelperManager = $this->viewHelper;
356 356
             $content = $viewHelperManager->get($viewHelper)->__invoke($instanceForm);
357 357
             $viewModel = new JsonModel(
358 358
                 array(
@@ -376,7 +376,7 @@  discard block
 block discarded – undo
376 376
                     }
377 377
                 }
378 378
             } else {
379
-                $formEvents->trigger('DisableElements', $this, [ 'form' => $form, 'job'=>$jobEntity ]);
379
+                $formEvents->trigger('DisableElements', $this, ['form' => $form, 'job'=>$jobEntity]);
380 380
                 // Job is deployed, some changes are now disabled
381 381
                 $form->enableAll();
382 382
             }
@@ -384,7 +384,7 @@  discard block
 block discarded – undo
384 384
 
385 385
             $completionLink = $this->url()->fromRoute(
386 386
                 'lang/jobs/completion',
387
-                [ 'id' => $jobEntity->getId()]
387
+                ['id' => $jobEntity->getId()]
388 388
             );
389 389
 
390 390
             $viewModel = $this->getViewModel($form);
@@ -450,7 +450,7 @@  discard block
 block discarded – undo
450 450
     protected function getFormular($job)
451 451
     {
452 452
         /* @var $forms \Zend\Form\FormElementManager\FormElementManagerV3Polyfill */
453
-        $forms    = $this->formManager;
453
+        $forms = $this->formManager;
454 454
         /* @var $container \Jobs\Form\Job */
455 455
 
456 456
         $container = $forms->get(
@@ -555,11 +555,11 @@  discard block
 block discarded – undo
555 555
         // array with differences between the last snapshot and the actual entity
556 556
         // is remains Null if there is no snapshot
557 557
         // it will be an empty array if the snapshot and the actual entity do not differ
558
-        $diff           = null;
558
+        $diff = null;
559 559
 
560 560
 
561 561
         if ($params == 'declined') {
562
-            if ($jobEntity instanceOf JobSnapshot)  {
562
+            if ($jobEntity instanceOf JobSnapshot) {
563 563
                 $jobEntity->getOriginalEntity()->changeStatus(
564 564
                     Status::ACTIVE,
565 565
                     sprintf(
@@ -634,7 +634,7 @@  discard block
 block discarded – undo
634 634
      */
635 635
     public function deactivateAction()
636 636
     {
637
-        $user           = $this->auth->getUser();
637
+        $user = $this->auth->getUser();
638 638
 
639 639
         $jobEntity = $this->initializeJob()->get($this->params());
640 640
 
Please login to merge, or discard this patch.
module/Cv/src/Cv/Factory/Form/LanguageSkillCollectionFactory.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@
 block discarded – undo
19 19
 	 * @return \Core\Form\CollectionContainer
20 20
 	 */
21 21
     public function __invoke(ContainerInterface $container, $requestedName, array $options = null) {
22
-	    $collectionContainer = new CollectionContainer( 'Cv/LanguageSkillForm', new Language() );
22
+	    $collectionContainer = new CollectionContainer('Cv/LanguageSkillForm', new Language());
23 23
 	    $collectionContainer->setLabel(/*@translate */ 'Additional Language Skills' );
24 24
 	
25 25
 	    return $collectionContainer;
Please login to merge, or discard this patch.
module/Behat/src/SummaryFormContext.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -39,8 +39,8 @@  discard block
 block discarded – undo
39 39
 		$name = Inflector::camelize($name);
40 40
 		$type = $this->elementMap[$name];
41 41
 		$locator = $type.' .sf-summary .sf-controls button';
42
-		$element = $this->minkContext->getSession()->getPage()->find('css',$locator);
43
-		if(!$element){
42
+		$element = $this->minkContext->getSession()->getPage()->find('css', $locator);
43
+		if (!$element) {
44 44
 			throw new \Exception('No element found with this locator: "'.$locator.'"');
45 45
 		}
46 46
 		$element->click();
@@ -70,12 +70,12 @@  discard block
 block discarded – undo
70 70
 	{
71 71
 		$type = Inflector::camelize($type);
72 72
 		$method = 'iSave'.$type;
73
-		if(method_exists($this,$method)){
74
-			call_user_func([$this,$method]);
75
-		}else{
73
+		if (method_exists($this, $method)) {
74
+			call_user_func([$this, $method]);
75
+		} else {
76 76
 			$locator = $this->elementMap[$type].'-buttons-submit';
77 77
 			$this->coreContext->scrollIntoView($locator);
78
-			$element = $this->minkContext->getSession()->getPage()->find('css',$locator);
78
+			$element = $this->minkContext->getSession()->getPage()->find('css', $locator);
79 79
 			$element->click();
80 80
 		}
81 81
 	}
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 	{
85 85
 		$locator = '#nameForm-buttons-submit';
86 86
 		$this->coreContext->scrollIntoView($locator);
87
-		$element = $this->minkContext->getSession()->getPage()->find('css',$locator);
87
+		$element = $this->minkContext->getSession()->getPage()->find('css', $locator);
88 88
 		$element->click();
89 89
 	}
90 90
 	
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
 	public function iSaveWorkflow()
95 95
 	{
96 96
 		$locator = '#workflowSettings-buttons-submit';
97
-		$element = $this->minkContext->getSession()->getPage()->find('css',$locator);
97
+		$element = $this->minkContext->getSession()->getPage()->find('css', $locator);
98 98
 		$element->click();
99 99
 	}
100 100
 	
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
 	{
103 103
 		$locator = '#locationForm-buttons-submit';
104 104
 		$this->coreContext->scrollIntoView($locator);
105
-		$element = $this->minkContext->getSession()->getPage()->find('css',$locator);
105
+		$element = $this->minkContext->getSession()->getPage()->find('css', $locator);
106 106
 		$element->click();
107 107
 	}
108 108
 	
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
 	{
112 112
 		$locator = '#general-classifications-buttons-submit';
113 113
 		$this->coreContext->scrollIntoView($locator);
114
-		$element = $this->minkContext->getSession()->getPage()->find('css',$locator);
114
+		$element = $this->minkContext->getSession()->getPage()->find('css', $locator);
115 115
 		$element->click();
116 116
 	}
117 117
 	
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
 	{
120 120
 		$locator = '#general-customerNote-buttons-submit';
121 121
 		$this->coreContext->scrollIntoView('#sf-general-customerNote');
122
-		$element = $this->minkContext->getSession()->getPage()->find('css',$locator);
122
+		$element = $this->minkContext->getSession()->getPage()->find('css', $locator);
123 123
 		$element->click();
124 124
 	}
125 125
 	
Please login to merge, or discard this patch.
module/Behat/src/CoreContext.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -39,11 +39,11 @@  discard block
 block discarded – undo
39 39
 	public function gatherContexts(BeforeScenarioScope $scope)
40 40
 	{
41 41
 		$this->minkContext = $scope->getEnvironment()->getContext(MinkContext::class);
42
-		if(false === static::$jobCategoryChecked){
42
+		if (false === static::$jobCategoryChecked) {
43 43
 			/* @var Categories $catRepo */
44 44
 			$catRepo = $this->getRepositories()->get('Jobs/Category');
45 45
 			$all = $catRepo->findAll();
46
-			if(count($all) <= 1){
46
+			if (count($all) <= 1) {
47 47
 				$catRepo->createDefaultCategory('professions');
48 48
 				$catRepo->createDefaultCategory('industries');
49 49
 				$catRepo->createDefaultCategory('employmentTypes');
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
 	 */
58 58
 	public function getApplication()
59 59
 	{
60
-		if(!is_object(static::$application)){
60
+		if (!is_object(static::$application)) {
61 61
 			$configFile = realpath(__DIR__.'/../../../config/config.php');
62 62
 			$config = include($configFile);
63 63
 			static::$application = Application::init($config);
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
 	public function iSubmitTheFormWithId($arg)
142 142
 	{
143 143
 		$node = $this->minkContext->getSession()->getPage()->find('css', $arg);
144
-		if($node) {
144
+		if ($node) {
145 145
 			$this->minkContext->getSession()->executeScript("jQuery('$arg').submit();");
146 146
 		} else {
147 147
 			throw new \Exception('Element not found');
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
165 165
 	public function iSetMainWindowName()
166 166
 	{
167 167
 		$window_name = 'main_window';
168
-		$script = 'window.name = "' . $window_name . '"';
168
+		$script = 'window.name = "'.$window_name.'"';
169 169
 		$this->getSession()->executeScript($script);
170 170
 	}
171 171
 	
@@ -224,14 +224,14 @@  discard block
 block discarded – undo
224 224
 				break;
225 225
 			
226 226
 			default:
227
-				throw new \Exception(__METHOD__ . ' Couldn\'t find selector: ' . $selector . ' - Allowed selectors: #id, .className, //xpath');
227
+				throw new \Exception(__METHOD__.' Couldn\'t find selector: '.$selector.' - Allowed selectors: #id, .className, //xpath');
228 228
 				break;
229 229
 		}
230 230
 		
231 231
 		try {
232 232
 			$this->getSession()->executeScript($function);
233 233
 		} catch (\Exception $e) {
234
-			throw new \Exception(__METHOD__ . ' failed'. ' Message: for this locator:"'.$selector.'"');
234
+			throw new \Exception(__METHOD__.' failed'.' Message: for this locator:"'.$selector.'"');
235 235
 		}
236 236
 	}
237 237
 	
@@ -252,10 +252,10 @@  discard block
 block discarded – undo
252 252
 	 *
253 253
 	 * @return \Behat\Mink\Element\NodeElement|mixed|null
254 254
 	 */
255
-	public function getElement($locator,$selector='css')
255
+	public function getElement($locator, $selector = 'css')
256 256
 	{
257 257
 		$page = $this->minkContext->getSession()->getPage();
258
-		$element = $page->find('css',$locator);
258
+		$element = $page->find('css', $locator);
259 259
 		return $element;
260 260
 	}
261 261
 	
@@ -287,12 +287,12 @@  discard block
 block discarded – undo
287 287
 		$session = $this->getSession();
288 288
 		$element = $session->getPage()->find(
289 289
 			'xpath',
290
-			$session->getSelectorsHandler()->selectorToXpath('xpath', '*//*[text()="'. $text .'"]')
290
+			$session->getSelectorsHandler()->selectorToXpath('xpath', '*//*[text()="'.$text.'"]')
291 291
 		);
292
-		if(null === $element){
292
+		if (null === $element) {
293 293
 			$element = $session->getPage()->find(
294 294
 				'named',
295
-				array('id',$text)
295
+				array('id', $text)
296 296
 			);
297 297
 		}
298 298
 		if (null === $element) {
Please login to merge, or discard this patch.
public/index.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -11,23 +11,23 @@  discard block
 block discarded – undo
11 11
 
12 12
 date_default_timezone_set('Europe/Berlin');
13 13
 
14
-if(!version_compare(PHP_VERSION, '5.6.0', 'ge')){
15
-    echo sprintf('<p>Sorry, YAWIK requires at least PHP 5.6.0 to run, but this server currently provides PHP %s</p>',PHP_VERSION);
14
+if (!version_compare(PHP_VERSION, '5.6.0', 'ge')) {
15
+    echo sprintf('<p>Sorry, YAWIK requires at least PHP 5.6.0 to run, but this server currently provides PHP %s</p>', PHP_VERSION);
16 16
     echo '<p>Please ask your servers\' administrator to install the proper PHP version.</p>';
17 17
     exit;
18 18
 }
19 19
 
20 20
 if (php_sapi_name() == 'cli-server') {
21 21
     $parseUrl = parse_url(substr($_SERVER["REQUEST_URI"], 1));
22
-    $route = isset($parseUrl['path']) ? $parseUrl['path']:null;
23
-    if (is_file(__DIR__ . '/' . $route)) {
24
-        if(substr($route, -4) == ".php"){
25
-            require __DIR__ . '/' . $route;     // Include requested script files
22
+    $route = isset($parseUrl['path']) ? $parseUrl['path'] : null;
23
+    if (is_file(__DIR__.'/'.$route)) {
24
+        if (substr($route, -4) == ".php") {
25
+            require __DIR__.'/'.$route; // Include requested script files
26 26
             exit;
27 27
         }
28
-        return false;           // Serve file as is
28
+        return false; // Serve file as is
29 29
     } else {                    // Fallback to index.php
30
-        $_GET["q"] = $route;    // Try to emulate the behaviour of a .htaccess here.
30
+        $_GET["q"] = $route; // Try to emulate the behaviour of a .htaccess here.
31 31
     }
32 32
 }
33 33
 
@@ -47,8 +47,8 @@  discard block
 block discarded – undo
47 47
 } else {
48 48
     echo '<p>Could not initialize autoloading. This happens, if the dependencies are not installed yet.</p>';
49 49
     echo '<p>Please try to install the dependencies via: </p>';
50
-    echo '<code>cd '. realpath('.') .'<br>./install.sh</code>';
51
-    echo '<p>exit at ' . __FILE__ . ' in line ' . __LINE__ .'</p>';
50
+    echo '<code>cd '.realpath('.').'<br>./install.sh</code>';
51
+    echo '<p>exit at '.__FILE__.' in line '.__LINE__.'</p>';
52 52
     exit;
53 53
 }
54 54
 
Please login to merge, or discard this patch.
module/Behat/src/ApplicationContext.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -35,13 +35,13 @@
 block discarded – undo
35 35
 		/* @var $repo JobRepository */
36 36
 		$repo = $this->getRepository('Jobs/Job');
37 37
 		$job = $repo->findOneBy(['title' => $title]);
38
-		if(!$job instanceof Job){
38
+		if (!$job instanceof Job) {
39 39
 			throw new \Exception('There is no job titled: "'.$title.'"');
40 40
 		}
41 41
 		$job->setApplyId($job->getId());
42 42
 		$repo->store($job);
43 43
 
44
-		$url = $this->generateUrl('lang/apply',[
44
+		$url = $this->generateUrl('lang/apply', [
45 45
 		    'applyId' => $job->getApplyId()
46 46
         ]);
47 47
 		$this->visit($url);
Please login to merge, or discard this patch.
module/Behat/src/InstallContext.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -31,8 +31,8 @@  discard block
 block discarded – undo
31 31
 
32 32
     public function __construct()
33 33
     {
34
-        static::$configFile = getcwd() . '/config/autoload/install.module.php';
35
-        static::$yawikGlobalConfig = getcwd() . '/config/autoload/yawik.config.global.php';
34
+        static::$configFile = getcwd().'/config/autoload/install.module.php';
35
+        static::$yawikGlobalConfig = getcwd().'/config/autoload/yawik.config.global.php';
36 36
         static::$yawikBackupConfig = str_replace('yawik.config.global.php', 'yawik.backup', static::$yawikGlobalConfig);
37 37
     }
38 38
 
@@ -42,18 +42,18 @@  discard block
 block discarded – undo
42 42
     public function iHaveInstallModuleActivated()
43 43
     {
44 44
         $target = static::$configFile;
45
-        if(!file_exists($target)){
45
+        if (!file_exists($target)) {
46 46
             $source = __DIR__.'/../resources/install.module.php';
47
-            copy($source,$target);
48
-            chmod($target,0777);
47
+            copy($source, $target);
48
+            chmod($target, 0777);
49 49
         }
50 50
 
51 51
         // backup existing file
52 52
         $yawikBackupConfig = static::$yawikBackupConfig;
53 53
         $yawikGlobalConfig = static::$yawikGlobalConfig;
54 54
 
55
-        if(is_file($yawikGlobalConfig)){
56
-            rename($yawikGlobalConfig,$yawikBackupConfig);
55
+        if (is_file($yawikGlobalConfig)) {
56
+            rename($yawikGlobalConfig, $yawikBackupConfig);
57 57
         }
58 58
     }
59 59
 
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
 
93 93
     static public function restoreConfig()
94 94
     {
95
-        if(is_file($file = static::$configFile)){
95
+        if (is_file($file = static::$configFile)) {
96 96
             unlink($file);
97 97
         }
98 98
 
@@ -100,8 +100,8 @@  discard block
 block discarded – undo
100 100
         $yawikBackupConfig = static::$yawikBackupConfig;
101 101
         $yawikGlobalConfig = static::$yawikGlobalConfig;
102 102
 
103
-        if(is_file($yawikBackupConfig)){
104
-            rename($yawikBackupConfig,$yawikGlobalConfig);
103
+        if (is_file($yawikBackupConfig)) {
104
+            rename($yawikBackupConfig, $yawikGlobalConfig);
105 105
         }
106 106
     }
107 107
 
@@ -112,6 +112,6 @@  discard block
 block discarded – undo
112 112
     {
113 113
         $config = $this->getService('config');
114 114
         $connection = $config['doctrine']['connection']['odm_default']['connectionString'];
115
-        $this->minkContext->fillField('db_conn',$connection);
115
+        $this->minkContext->fillField('db_conn', $connection);
116 116
     }
117 117
 }
Please login to merge, or discard this patch.
module/Behat/src/CommonContextTrait.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -51,16 +51,16 @@
 block discarded – undo
51 51
 		$this->summaryFormContext = $scope->getEnvironment()->getContext(SummaryFormContext::class);
52 52
 	}
53 53
 	
54
-	public function generateUrl($name,array $params=array(),array $options=array())
54
+	public function generateUrl($name, array $params = array(), array $options = array())
55 55
 	{
56 56
 	    $defaults = ['lang'=>'en'];
57
-	    $params = array_merge($defaults,$params);
57
+	    $params = array_merge($defaults, $params);
58 58
         /* @var Url $urlHelper */
59 59
         $urlHelper = $this
60 60
             ->getService('ViewHelperManager')
61 61
             ->get('url')
62 62
         ;
63
-        $url = $urlHelper($name,$params,$options);
63
+        $url = $urlHelper($name, $params, $options);
64 64
 
65 65
         return $this->coreContext->generateUrl($url);
66 66
 	}
Please login to merge, or discard this patch.
module/Behat/src/SettingsContext.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@
 block discarded – undo
31 31
 	 */
32 32
 	public function iGoToEmailTemplatePage()
33 33
 	{
34
-	    $url = $this->generateUrl('lang/settings',[
34
+	    $url = $this->generateUrl('lang/settings', [
35 35
 	        'module' => 'Applications'
36 36
         ]);
37 37
 		$this->visit($url);
Please login to merge, or discard this patch.