Completed
Push — develop ( cc6530...59407f )
by Mathias
08:03
created
module/Organizations/src/Organizations/Controller/IndexController.php 3 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -250,6 +250,9 @@
 block discarded – undo
250 250
         return $container;
251 251
     }
252 252
 
253
+    /**
254
+     * @param string $script
255
+     */
253 256
     protected function getErrorViewModel($script)
254 257
     {
255 258
         $this->getResponse()->setStatusCode(Response::STATUS_CODE_500);
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
         try {
125 125
             /* @var $handler \Organizations\Controller\Plugin\GetOrganizationHandler */
126 126
             $handler = $this->plugin('Organizations/GetOrganizationHandler');
127
-            $org  = $handler->process($this->params(), true);
127
+            $org = $handler->process($this->params(), true);
128 128
         } catch (MissingParentOrganizationException $e) {
129 129
             return $this->getErrorViewModel('no-parent');
130 130
         } catch (NotFoundException $e) {
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
             ];
136 136
         }
137 137
 
138
-        $container       = $this->getFormular($org);
138
+        $container = $this->getFormular($org);
139 139
 
140 140
         if (isset($formIdentifier) && $request->isPost()) {
141 141
             /* @var $form \Zend\Form\FormInterface */
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
             $form = $container->get($formIdentifier);
161 161
             $form->setData(array_merge($postData, $filesData));
162 162
             if (!isset($form)) {
163
-                throw new \RuntimeException('No form found for "' . $formIdentifier . '"');
163
+                throw new \RuntimeException('No form found for "'.$formIdentifier.'"');
164 164
             }
165 165
             $isValid = $form->isValid();
166 166
 
Please login to merge, or discard this patch.
Indentation   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -56,33 +56,33 @@
 block discarded – undo
56 56
      */
57 57
     private $repository;
58 58
 	
59
-	/**
60
-	 * @var FormElementManagerV3Polyfill
61
-	 */
59
+    /**
60
+     * @var FormElementManagerV3Polyfill
61
+     */
62 62
     private $formManager;
63 63
     
64 64
     private $viewHelper;
65 65
 	
66
-	/**
67
-	 * @var TranslatorInterface
68
-	 */
66
+    /**
67
+     * @var TranslatorInterface
68
+     */
69 69
     private $translator;
70 70
 	
71
-	/**
72
-	 * Create new controller instance
73
-	 *
74
-	 * @param Form\Organizations $form
75
-	 * @param Repository\Organization $repository
76
-	 * @param TranslatorInterface $translator
77
-	 * @param $formManager
78
-	 * @param $viewHelper
79
-	 */
71
+    /**
72
+     * Create new controller instance
73
+     *
74
+     * @param Form\Organizations $form
75
+     * @param Repository\Organization $repository
76
+     * @param TranslatorInterface $translator
77
+     * @param $formManager
78
+     * @param $viewHelper
79
+     */
80 80
     public function __construct(
81
-    	Form\Organizations $form,
82
-	    Repository\Organization $repository,
83
-		TranslatorInterface $translator,
84
-		$formManager,
85
-		$viewHelper
81
+        Form\Organizations $form,
82
+        Repository\Organization $repository,
83
+        TranslatorInterface $translator,
84
+        $formManager,
85
+        $viewHelper
86 86
     )
87 87
     {
88 88
         $this->repository = $repository;
Please login to merge, or discard this patch.
module/Settings/src/Settings/Form/FormAbstract.php 1 patch
Doc Comments   +8 added lines patch added patch discarded remove patch
@@ -31,6 +31,11 @@  discard block
 block discarded – undo
31 31
         return $this->hydrator;
32 32
     }
33 33
     
34
+    /**
35
+     * @param string $name
36
+     *
37
+     * @return callable
38
+     */
34 39
     protected function getPlugin($name)
35 40
     {
36 41
         $plugin = null;
@@ -69,6 +74,9 @@  discard block
 block discarded – undo
69 74
         $this->add($this->formManager->get('DefaultButtonsFieldset'));
70 75
     }
71 76
     
77
+    /**
78
+     * @return string
79
+     */
72 80
     abstract public function getCoreFieldset();
73 81
     
74 82
     /**
Please login to merge, or discard this patch.
module/Core/src/Core/Controller/AdminControllerEvent.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@
 block discarded – undo
61 61
      *
62 62
      * @return self
63 63
      */
64
-    public function addViewModel($name, $model, $priority=0)
64
+    public function addViewModel($name, $model, $priority = 0)
65 65
     {
66 66
         $this->models->insert($name, $model, $priority);
67 67
 
Please login to merge, or discard this patch.
module/Core/src/Core/Form/View/Helper/FormElement.php 1 patch
Indentation   -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,5 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
-
4 3
  */
5 4
 
6 5
 namespace Core\Form\View\Helper;
Please login to merge, or discard this patch.
module/Core/src/Core/Form/View/Helper/ToggleButton.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
             if (null === $buttonContent) {
27 27
                 throw new Exception\DomainException(
28 28
                     sprintf(
29
-                        '%s expects either button content as the second argument, ' .
29
+                        '%s expects either button content as the second argument, '.
30 30
                         'or that the element provided has a label value; neither found',
31 31
                         __METHOD__
32 32
                     )
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
         $checkedBoole   = ($value == 1 || $value == 'on');
47 47
         
48 48
 
49
-        $checkedClass   = $checkedBoole?'active"':'';
49
+        $checkedClass   = $checkedBoole ? 'active"' : '';
50 50
 
51 51
         $hiddenElement = '';
52 52
         if ($element->useHiddenElement()) {
@@ -63,11 +63,11 @@  discard block
 block discarded – undo
63 63
             $element->setUseHiddenElement(false);
64 64
         }
65 65
 
66
-        $buttonContent = $hiddenElement . PHP_EOL
67
-                . '<div class="btn-group" data-toggle="buttons">' . PHP_EOL
68
-                . '<label class="btn btn-default ' . $checkedClass . '">' . PHP_EOL
69
-                . parent::render($element) . $buttonContent . PHP_EOL . '</label>' . PHP_EOL
70
-                . '</div>' . PHP_EOL;
66
+        $buttonContent = $hiddenElement.PHP_EOL
67
+                . '<div class="btn-group" data-toggle="buttons">'.PHP_EOL
68
+                . '<label class="btn btn-default '.$checkedClass.'">'.PHP_EOL
69
+                . parent::render($element).$buttonContent.PHP_EOL.'</label>'.PHP_EOL
70
+                . '</div>'.PHP_EOL;
71 71
 
72 72
         return $buttonContent;
73 73
     }
Please login to merge, or discard this patch.
module/Core/src/Core/Entity/EntityInterface.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@
 block discarded – undo
72 72
      * @throws \Core\Entity\Exception\OutOfBoundsException if the property does not exists.
73 73
      * @since 0.25
74 74
      */
75
-    public function notEmpty($property, array $args=[]);
75
+    public function notEmpty($property, array $args = []);
76 76
 
77 77
     /**
78 78
      * Checks, if this entity has a property.
Please login to merge, or discard this patch.
module/Settings/Module.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
      */
29 29
     public function getConfig()
30 30
     {
31
-        return include __DIR__ . '/config/module.config.php';
31
+        return include __DIR__.'/config/module.config.php';
32 32
     }
33 33
 
34 34
     /**
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
         return array(
43 43
             'Zend\Loader\StandardAutoloader' => array(
44 44
                 'namespaces' => array(
45
-                    __NAMESPACE__ => __DIR__ . '/src/' . __NAMESPACE__,
45
+                    __NAMESPACE__ => __DIR__.'/src/'.__NAMESPACE__,
46 46
                 ),
47 47
             ),
48 48
         );
Please login to merge, or discard this patch.
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
      */
30 30
     public function onBootstrap(MvcEvent $e)
31 31
     {
32
-    	// we attach with wildcard events name
32
+        // we attach with wildcard events name
33 33
         $events = $e->getApplication()->getEventManager();
34 34
         $events->attach(
35 35
             MvcEvent::EVENT_RENDER,
Please login to merge, or discard this patch.
module/Jobs/src/Jobs/Controller/TemplateController.php 3 patches
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@
 block discarded – undo
83 83
             $this->auth()->isAdmin()
84 84
         ) {
85 85
             $applicationViewModel->setTemplate('iframe/iFrameInjection');
86
-        }elseif(Status::EXPIRED == $job->getStatus() or  Status::INACTIVE == $job->getStatus()) {
86
+        } elseif(Status::EXPIRED == $job->getStatus() or  Status::INACTIVE == $job->getStatus()) {
87 87
             $response->setStatusCode(Response::STATUS_CODE_410);
88 88
             $model->setTemplate('jobs/error/expired');
89 89
             $model->setVariables(
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
     public function viewAction()
59 59
     {
60 60
         $id = $this->params()->fromQuery('id');
61
-        $channel = $this->params()->fromRoute('channel','default');
61
+        $channel = $this->params()->fromRoute('channel', 'default');
62 62
         $response = $this->getResponse();
63 63
         /* @var \Jobs\Entity\Job $job */
64 64
         try {
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
             $this->auth()->isAdmin()
88 88
         ) {
89 89
             $applicationViewModel->setTemplate('iframe/iFrameInjection');
90
-        }elseif(Status::EXPIRED == $job->getStatus() or  Status::INACTIVE == $job->getStatus()) {
90
+        }elseif (Status::EXPIRED == $job->getStatus() or Status::INACTIVE == $job->getStatus()) {
91 91
             $response->setStatusCode(Response::STATUS_CODE_410);
92 92
             $model->setTemplate('jobs/error/expired');
93 93
             $model->setVariables(
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
     protected function editTemplateAction()
116 116
     {
117 117
         $id = $this->params('id');
118
-        $formIdentifier=$this->params()->fromQuery('form');
118
+        $formIdentifier = $this->params()->fromQuery('form');
119 119
         //$job = $this->jobRepository->find($id);
120 120
         $job = $this->initializeJob()->get($this->params(), true, true); /* @var \Jobs\Entity\Job $job */
121 121
         $this->acl($job, 'edit');
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
 
140 140
         $formTemplate->setParam('id', $job->getId());
141 141
         $formTemplate->setParam('applyId', $job->getApplyId());
142
-        $formTemplate->setParam('snapshot', $job instanceOf JobSnapshot ? $job->getSnapshotId() : '' );
142
+        $formTemplate->setParam('snapshot', $job instanceOf JobSnapshot ? $job->getSnapshotId() : '');
143 143
 
144 144
         $formTemplate->setEntity($job);
145 145
 
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
 
149 149
             $instanceForm = $formTemplate->get($formIdentifier);
150 150
             if (!isset($instanceForm)) {
151
-                throw new \RuntimeException('No form found for "' . $formIdentifier . '"');
151
+                throw new \RuntimeException('No form found for "'.$formIdentifier.'"');
152 152
             }
153 153
 
154 154
             // the id is part of the postData, but it never should be altered
Please login to merge, or discard this patch.
Indentation   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -52,16 +52,16 @@
 block discarded – undo
52 52
     protected $formManager;
53 53
 
54 54
     public function __construct(
55
-    	Repository\Job $jobRepository,
56
-	    $viewModelTemplateFilter,
57
-	    $translator,
58
-	    AbstractOptions $config,
59
-	    $viewHelper,
60
-		$formManager
55
+        Repository\Job $jobRepository,
56
+        $viewModelTemplateFilter,
57
+        $translator,
58
+        AbstractOptions $config,
59
+        $viewHelper,
60
+        $formManager
61 61
     )
62 62
     {
63
-    	$this->viewModelTemplateFilter = $viewModelTemplateFilter;
64
-    	$this->translator = $translator;
63
+        $this->viewModelTemplateFilter = $viewModelTemplateFilter;
64
+        $this->translator = $translator;
65 65
         $this->jobRepository = $jobRepository;
66 66
         $this->config = $config;
67 67
         $this->formManager = $formManager;
Please login to merge, or discard this patch.
module/Jobs/src/Jobs/Filter/ViewModelTemplateFilterForm.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@
 block discarded – undo
48 48
             'lang/jobs/view',
49 49
             [],
50 50
             [
51
-                'query' => [ 'id' => $job->getId() ],
51
+                'query' => ['id' => $job->getId()],
52 52
                 'force_canonical' => true
53 53
             ]
54 54
         );
Please login to merge, or discard this patch.