Completed
Push — develop ( cc6530...59407f )
by Mathias
08:03
created
module/Auth/src/Acl/Controller/Plugin/Acl.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
 
130 130
     /**
131 131
      * @param $resource
132
-     * @param null $privilege
132
+     * @param null|string $privilege
133 133
      * @throws \Auth\Exception\UnauthorizedImageAccessException
134 134
      * @throws \Auth\Exception\UnauthorizedAccessException
135 135
      */
@@ -155,8 +155,8 @@  discard block
 block discarded – undo
155 155
     }
156 156
 
157 157
     /**
158
-     * @param null $resource
159
-     * @param null $privilege
158
+     * @param null|string $resource
159
+     * @param null|string $privilege
160 160
      * @param string $mode
161 161
      * @return $this|bool
162 162
      */
Please login to merge, or discard this patch.
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -138,14 +138,14 @@
 block discarded – undo
138 138
         if (!$this->test($resource, $privilege)) {
139 139
             $msg = null === $privilege
140 140
                  ? sprintf(
141
-                     'You are not allowed to access resource "%s"',
142
-                     is_object($resource) ? $resource->getResourceId() : $resource
143
-                 )
141
+                        'You are not allowed to access resource "%s"',
142
+                        is_object($resource) ? $resource->getResourceId() : $resource
143
+                    )
144 144
                  : sprintf(
145
-                     'You are not allowed to execute operation "%s" on resource "%s"',
146
-                     $privilege,
147
-                     is_object($resource) ? $resource->getResourceId() : $resource
148
-                 );
145
+                        'You are not allowed to execute operation "%s" on resource "%s"',
146
+                        $privilege,
147
+                        is_object($resource) ? $resource->getResourceId() : $resource
148
+                    );
149 149
             
150 150
             if ($resource instanceof FileInterface && 0 == strpos($resource->getType(), 'image/')) {
151 151
                 throw new UnauthorizedImageAccessException(str_replace('resource', 'image', $msg));
Please login to merge, or discard this patch.
module/Cv/src/Cv/Options/ModuleOptions.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
      *
35 35
      * @var array $attachmentsMimeType
36 36
      */
37
-    protected $attachmentsMimeType = array('image','applications/pdf',
37
+    protected $attachmentsMimeType = array('image', 'applications/pdf',
38 38
         'application/x-pdf',
39 39
         'application/acrobat',
40 40
         'applications/vnd.pdf',
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -93,7 +93,7 @@
 block discarded – undo
93 93
     /**
94 94
      * Gets the the maximum number of allowed attachments
95 95
      *
96
-     * @return string
96
+     * @return integer
97 97
      */
98 98
     public function getAttachmentsCount()
99 99
     {
Please login to merge, or discard this patch.
module/Auth/src/Auth/Listener/UnauthorizedAccessListener.php 2 patches
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -57,9 +57,9 @@  discard block
 block discarded – undo
57 57
         if ($exception instanceof UnauthorizedImageAccessException) {
58 58
             $image = __DIR__ . '/../../../../../public/images/unauthorized-access.png';
59 59
             $response->setStatusCode(Response::STATUS_CODE_403)
60
-                     ->setContent(file_get_contents($image))
61
-                     ->getHeaders()
62
-                     ->addHeaderLine('Content-Type', 'image/png');
60
+                        ->setContent(file_get_contents($image))
61
+                        ->getHeaders()
62
+                        ->addHeaderLine('Content-Type', 'image/png');
63 63
             $e->stopPropagation();
64 64
             $response->sendHeaders();
65 65
             //echo file_get_contents($image);
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
         }
71 71
         
72 72
         $application = $e->getApplication();
73
-		$auth = $application->getServiceManager()->get('AuthenticationService');
73
+        $auth = $application->getServiceManager()->get('AuthenticationService');
74 74
         
75 75
         if (!$auth->hasIdentity()) {
76 76
             $routeMatch = $e->getRouteMatch();
@@ -102,9 +102,9 @@  discard block
 block discarded – undo
102 102
         $model->setTemplate($this->getExceptionTemplate());
103 103
         $e->setResult($model);
104 104
 
105
-       // $statusCode = $response->getStatusCode();
106
-       // if ($statusCode === 200) {
105
+        // $statusCode = $response->getStatusCode();
106
+        // if ($statusCode === 200) {
107 107
             $response->setStatusCode(Response::STATUS_CODE_403);
108
-       // }
108
+        // }
109 109
     }
110 110
 }
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
          * Return an image, if an image was requested.
56 56
          */
57 57
         if ($exception instanceof UnauthorizedImageAccessException) {
58
-            $image = __DIR__ . '/../../../../../public/images/unauthorized-access.png';
58
+            $image = __DIR__.'/../../../../../public/images/unauthorized-access.png';
59 59
             $response->setStatusCode(Response::STATUS_CODE_403)
60 60
                      ->setContent(file_get_contents($image))
61 61
                      ->getHeaders()
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
             $routeMatch->setParam('action', 'index');
79 79
             $query = $e->getRequest()->getQuery();
80 80
             $ref = $e->getRequest()->getRequestUri();
81
-            $ref = preg_replace('~^' . preg_quote($e->getRouter()->getBaseUrl()) . '~', '', $ref);
81
+            $ref = preg_replace('~^'.preg_quote($e->getRouter()->getBaseUrl()).'~', '', $ref);
82 82
             $query->set('ref', $ref);
83 83
             $query->set('req', 1);
84 84
             $response->setStatusCode(Response::STATUS_CODE_401);
Please login to merge, or discard this patch.
module/Cv/src/Cv/Controller/ManageController.php 3 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -173,6 +173,9 @@
 block discarded – undo
173 173
         return $this->redirect()->refresh();
174 174
     }
175 175
 
176
+    /**
177
+     * @param \Cv\Repository\Cv $repository
178
+     */
176 179
     private function getCv($repository, $user)
177 180
     {
178 181
         $id =
Please login to merge, or discard this patch.
Indentation   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -28,27 +28,27 @@
 block discarded – undo
28 28
  */
29 29
 class ManageController extends AbstractActionController
30 30
 {
31
-	private $repositories;
31
+    private $repositories;
32 32
 	
33
-	private $formElements;
33
+    private $formElements;
34 34
 	
35
-	private $viewHelper;
35
+    private $viewHelper;
36 36
 	
37
-	static public function factory(ContainerInterface $container)
38
-	{
39
-		$controller = new static();
40
-		$controller->init($container);
41
-		return $controller;
42
-	}
37
+    static public function factory(ContainerInterface $container)
38
+    {
39
+        $controller = new static();
40
+        $controller->init($container);
41
+        return $controller;
42
+    }
43 43
 	
44
-	public function init(ContainerInterface $container)
45
-	{
46
-		$this->repositories = $container->get('repositories');
47
-		$this->formElements = $container->get('FormElementManager');
48
-		$this->viewHelper = $container->get('ViewHelperManager');
49
-	}
44
+    public function init(ContainerInterface $container)
45
+    {
46
+        $this->repositories = $container->get('repositories');
47
+        $this->formElements = $container->get('FormElementManager');
48
+        $this->viewHelper = $container->get('ViewHelperManager');
49
+    }
50 50
 	
51
-	public function formAction()
51
+    public function formAction()
52 52
     {
53 53
         $repositories = $this->repositories;
54 54
         /* @var $cvRepository \Cv\Repository\Cv */
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -119,8 +119,7 @@
 block discarded – undo
119 119
                 if ('file-uri' === $params->fromPost('return')) {
120 120
                     $content = $viewHelperManager->get('basepath')
121 121
                         ->__invoke($form->getHydrator()->getLastUploadedFile()->getUri());
122
-                }
123
-                else {
122
+                } else {
124 123
                     if ($form instanceof SummaryFormInterface) {
125 124
                         $form->setRenderMode(SummaryFormInterface::RENDER_SUMMARY);
126 125
                         $viewHelper = 'summaryForm';
Please login to merge, or discard this patch.
module/Cv/src/Cv/Repository/Cv.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
      * Look for an drafted Document of a given user
23 23
      *
24 24
      * @param $user
25
-     * @return CvEntity|null
25
+     * @return \MongoCursor
26 26
      */
27 27
     public function findDraft($user)
28 28
     {
Please login to merge, or discard this patch.
module/Cv/src/Cv/Entity/CvInterface.php 1 patch
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -10,10 +10,10 @@
 block discarded – undo
10 10
 use Core\Entity\IdentifiableEntityInterface;
11 11
 
12 12
 interface CvInterface extends EntityInterface,
13
-                              IdentifiableEntityInterface,
14
-                              DraftableEntityInterface,
15
-                              PermissionsAwareInterface,
16
-                              ModificationDateAwareEntityInterface
13
+                                IdentifiableEntityInterface,
14
+                                DraftableEntityInterface,
15
+                                PermissionsAwareInterface,
16
+                                ModificationDateAwareEntityInterface
17 17
 {
18 18
     
19 19
     /**
Please login to merge, or discard this patch.
module/Core/src/Core/Entity/AbstractStatusEntity.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
             $name = $this->default;
83 83
         }
84 84
 
85
-        if (!isset(static::$orderMap[ $name ])) {
85
+        if (!isset(static::$orderMap[$name])) {
86 86
             throw new \InvalidArgumentException(sprintf(
87 87
                 'Unknown status name "%s" for "%s"',
88 88
                 $name, static::class
@@ -90,6 +90,6 @@  discard block
 block discarded – undo
90 90
         }
91 91
 
92 92
         $this->name  = $name;
93
-        $this->order = static::$orderMap[ $name ];
93
+        $this->order = static::$orderMap[$name];
94 94
     }
95 95
 }
96 96
\ No newline at end of file
Please login to merge, or discard this patch.
module/Cv/src/Cv/Repository/Event/UpdateFilesPermissionsSubscriber.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
 {
25 25
     protected $targetDocument = Cv::class;
26 26
 
27
-    protected $filesProperties = [ 'attachments' ];
27
+    protected $filesProperties = ['attachments'];
28 28
 
29 29
     /**
30 30
      *
Please login to merge, or discard this patch.
DoctrineMongoODM/Event/AbstractUpdateFilesPermissionsSubscriber.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@
 block discarded – undo
49 49
 
50 50
     public function getSubscribedEvents()
51 51
     {
52
-        return [ Events::onFlush ];
52
+        return [Events::onFlush];
53 53
     }
54 54
 
55 55
     /**
Please login to merge, or discard this patch.