Completed
Push — master ( dc4dd2...16100a )
by Mathias
08:39
created
Applications/test/ApplicationsTest/Acl/ApplicationAccessAssertionTest.php 2 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -70,13 +70,13 @@
 block discarded – undo
70 70
         $app  = new Application();
71 71
         $app2 = new Application();
72 72
         $app2->getPermissions()->grant($user, PermissionsInterface::PERMISSION_VIEW)
73
-                               ->grant($user2, PermissionsInterface::PERMISSION_CHANGE);
73
+                                ->grant($user2, PermissionsInterface::PERMISSION_CHANGE);
74 74
 
75 75
         $app3 = new Application();
76 76
         $app3->setIsDraft(true);
77 77
         //$app3->setUser($user);
78 78
         $app3->getPermissions()->grant($user, PermissionsInterface::PERMISSION_VIEW)
79
-                               ->grant($user2, PermissionsInterface::PERMISSION_CHANGE);
79
+                                ->grant($user2, PermissionsInterface::PERMISSION_CHANGE);
80 80
 
81 81
         return array(
82 82
             'nouser-noapp'     => array($role, $resource, null, false),
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -89,8 +89,8 @@
 block discarded – undo
89 89
             'change-not-granted2' => array($user, $app2, 'change', false),
90 90
             'subsequentAttachmentUpload-not-granted' => array($user, $app, Application::PERMISSION_SUBSEQUENT_ATTACHMENT_UPLOAD, false),
91 91
             'subsequentAttachmentUpload-granted' => array($user, $app2, Application::PERMISSION_SUBSEQUENT_ATTACHMENT_UPLOAD, true),
92
-            'allow-draft-view' => [ $user2, $app3, 'change', true ],
93
-            'disallow-draft-view' => [ $user, $app3, 'change', false ],
92
+            'allow-draft-view' => [$user2, $app3, 'change', true],
93
+            'disallow-draft-view' => [$user, $app3, 'change', false],
94 94
 
95 95
         );
96 96
     }
Please login to merge, or discard this patch.
module/Applications/test/TestConfig.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@
 block discarded – undo
60 60
     //     ),
61 61
     // )
62 62
 
63
-   // Initial configuration with which to seed the ServiceManager.
64
-   // Should be compatible with Zend\ServiceManager\Config.
65
-   // 'service_manager' => array(),
63
+    // Initial configuration with which to seed the ServiceManager.
64
+    // Should be compatible with Zend\ServiceManager\Config.
65
+    // 'service_manager' => array(),
66 66
 );
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -5,8 +5,8 @@
 block discarded – undo
5 5
     // This should be an array of module namespaces used in the application.
6 6
 
7 7
 use PHPUnit\Framework\TestCase;
8
-    'modules' => array_merge($commonModules,array(
9
-        'Core', 'Auth', 'Jobs', 'Organizations',  'Applications', 'Cv', 'Settings'
8
+    'modules' => array_merge($commonModules, array(
9
+        'Core', 'Auth', 'Jobs', 'Organizations', 'Applications', 'Cv', 'Settings'
10 10
     )),
11 11
 
12 12
     // These are various options for the listeners attached to the ModuleManager
Please login to merge, or discard this patch.
test/OrganizationsTest/Factory/Form/EmployeesFieldsetFactoryTest.php 2 patches
Indentation   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -44,15 +44,15 @@  discard block
 block discarded – undo
44 44
 
45 45
         $headscript = $this->getMockBuilder('\Zend\View\Helper\HeadScript')->disableOriginalConstructor()->getMock();
46 46
         $headscript->expects($this->once())
47
-                   ->method('__call')
48
-                   ->with('appendFile', array('modules/Organizations/js/organizations.employees.js'))
49
-                   ->willReturn(null);
47
+                    ->method('__call')
48
+                    ->with('appendFile', array('modules/Organizations/js/organizations.employees.js'))
49
+                    ->willReturn(null);
50 50
 
51 51
         $basepath   = $this->getMockBuilder('\Zend\View\Helper\BasePath')->disableOriginalConstructor()->getMock();
52 52
         $basepath->expects($this->once())
53
-                 ->method('__invoke')
54
-                 ->with('modules/Organizations/js/organizations.employees.js')
55
-                 ->will($this->returnArgument(0));
53
+                    ->method('__invoke')
54
+                    ->with('modules/Organizations/js/organizations.employees.js')
55
+                    ->will($this->returnArgument(0));
56 56
 
57 57
         $helpers = $this->getMockBuilder('\Zend\View\HelperPluginManager')->disableOriginalConstructor()->getMock();
58 58
         $helpers->expects($this->exactly(2))
@@ -64,12 +64,12 @@  discard block
 block discarded – undo
64 64
                 ->will($this->onConsecutiveCalls($headscript, $basepath));
65 65
 
66 66
         $services = $this->getMockBuilder('\Zend\ServiceManager\ServiceManager')->disableOriginalConstructor()
67
-                         ->getMock();
67
+                            ->getMock();
68 68
 
69 69
         $services->expects($this->once())
70
-                 ->method('get')
71
-                 ->with('ViewHelperManager')
72
-                 ->willReturn($helpers);
70
+                    ->method('get')
71
+                    ->with('ViewHelperManager')
72
+                    ->willReturn($helpers);
73 73
 
74 74
         $fieldset = $target->__invoke($services, 'irrelevant');
75 75
 
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@
 block discarded – undo
48 48
                    ->with('appendFile', array('modules/Organizations/js/organizations.employees.js'))
49 49
                    ->willReturn(null);
50 50
 
51
-        $basepath   = $this->getMockBuilder('\Zend\View\Helper\BasePath')->disableOriginalConstructor()->getMock();
51
+        $basepath = $this->getMockBuilder('\Zend\View\Helper\BasePath')->disableOriginalConstructor()->getMock();
52 52
         $basepath->expects($this->once())
53 53
                  ->method('__invoke')
54 54
                  ->with('modules/Organizations/js/organizations.employees.js')
Please login to merge, or discard this patch.
Organizations/test/OrganizationsTest/Controller/ProfileControllerTest.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
         $pluginManager->expects($this->any())
104 104
             ->method('get')
105 105
             ->willReturnMap([
106
-                ['params',null,$params]
106
+                ['params', null, $params]
107 107
             ])
108 108
         ;
109 109
 
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
         $plugins->expects($this->any())
127 127
             ->method('get')
128 128
             ->willReturnMap([
129
-                ['params',null,$params]
129
+                ['params', null, $params]
130 130
             ])
131 131
         ;
132 132
 
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
         $plugins->expects($this->any())
151 151
             ->method('get')
152 152
             ->willReturnMap([
153
-                ['params',null,$params]
153
+                ['params', null, $params]
154 154
             ])
155 155
         ;
156 156
 
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
         $pluginManager->expects($this->any())
183 183
             ->method('get')
184 184
             ->willReturnMap([
185
-                ['params',null,$params]
185
+                ['params', null, $params]
186 186
             ])
187 187
         ;
188 188
 
@@ -217,7 +217,7 @@  discard block
 block discarded – undo
217 217
         $pluginManager->expects($this->any())
218 218
             ->method('get')
219 219
             ->willReturnMap([
220
-                ['params',null,$params]
220
+                ['params', null, $params]
221 221
             ])
222 222
         ;
223 223
 
Please login to merge, or discard this patch.
test/OrganizationsTest/Controller/Plugin/InvitationHandlerTest.php 2 patches
Indentation   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -61,11 +61,11 @@  discard block
 block discarded – undo
61 61
         }
62 62
         if (in_array('userTokenGenerator', $mocks)) {
63 63
             $this->userTokenGeneratorMock = $this->getMockBuilder('\Auth\Service\UserUniqueTokenGenerator')
64
-                                             ->disableOriginalConstructor()->getMock();
64
+                                                ->disableOriginalConstructor()->getMock();
65 65
         }
66 66
         if (in_array('mailerPlugin', $mocks)) {
67 67
             $this->mailerPluginMock   = $this->getMockBuilder('\Core\Controller\Plugin\Mailer')
68
-                                         ->disableOriginalConstructor()->getMock();
68
+                                            ->disableOriginalConstructor()->getMock();
69 69
         }
70 70
 
71 71
         if ($inject) {
@@ -133,9 +133,9 @@  discard block
 block discarded – undo
133 133
         $email = 'invalidEmailAddress';
134 134
         $message = 'Email address is invalid.';
135 135
         $this->translatorMock->expects($this->exactly(5))
136
-                             ->method('translate')
137
-                             ->with($message)
138
-                             ->will($this->returnArgument(0));
136
+                                ->method('translate')
137
+                                ->with($message)
138
+                                ->will($this->returnArgument(0));
139 139
 
140 140
         $expected = array(
141 141
             'ok' => false,
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
         $user->getInfo()->setEmail($email);
161 161
 
162 162
         $this->userRepositoryMock->expects($this->once())->method('findByEmail')->with($email, null)
163
-                                 ->willReturn($user);
163
+                                    ->willReturn($user);
164 164
         $this->userRepositoryMock->expects($this->never())->method('create');
165 165
         $this->userTokenGeneratorMock->expects($this->once())->method('generate')->with($user, 7)->willReturn('testToken');
166 166
 
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
192 192
         $user->getInfo()->setEmail($email);
193 193
 
194 194
         $this->userRepositoryMock->expects($this->once())->method('findByEmail')->with($email, null)
195
-                                 ->willReturn(null);
195
+                                    ->willReturn(null);
196 196
         $this->userRepositoryMock->expects($this->once())->method('create')->willReturn($user);
197 197
         $this->userTokenGeneratorMock->expects($this->once())->method('generate')->with($user, 7)->willReturn('testToken');
198 198
 
@@ -227,12 +227,12 @@  discard block
 block discarded – undo
227 227
 
228 228
         $message = 'Sending invitation mail failed.';
229 229
         $this->translatorMock->expects($this->once())
230
-                             ->method('translate')
231
-                             ->with($message)
232
-                             ->will($this->returnArgument(0));
230
+                                ->method('translate')
231
+                                ->with($message)
232
+                                ->will($this->returnArgument(0));
233 233
 
234 234
         $this->userRepositoryMock->expects($this->once())->method('findByEmail')->with($email, null)
235
-                                 ->willReturn($user);
235
+                                    ->willReturn($user);
236 236
         $this->userRepositoryMock->expects($this->never())->method('create');
237 237
         $this->userTokenGeneratorMock->expects($this->once())->method('generate')->with($user, 7)->willReturn('testToken');
238 238
 
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -65,14 +65,14 @@  discard block
 block discarded – undo
65 65
                                              ->disableOriginalConstructor()->getMock();
66 66
         }
67 67
         if (in_array('mailerPlugin', $mocks)) {
68
-            $this->mailerPluginMock   = $this->getMockBuilder('\Core\Controller\Plugin\Mailer')
68
+            $this->mailerPluginMock = $this->getMockBuilder('\Core\Controller\Plugin\Mailer')
69 69
                                          ->disableOriginalConstructor()->getMock();
70 70
         }
71 71
 
72 72
         if ($inject) {
73 73
             foreach ($mocks as $key) {
74
-                $setter = 'set' . $key;
75
-                $this->target->$setter($this->{$key . 'Mock'});
74
+                $setter = 'set'.$key;
75
+                $this->target->$setter($this->{$key.'Mock'});
76 76
             }
77 77
         }
78 78
     }
@@ -107,9 +107,9 @@  discard block
 block discarded – undo
107 107
     {
108 108
         $this->setupMocks($mockKey);
109 109
 
110
-        $setter = 'set' . ucfirst($mockKey);
111
-        $getter = 'get' . ucfirst($mockKey);
112
-        $value  = $this->{$mockKey . 'Mock'};
110
+        $setter = 'set'.ucfirst($mockKey);
111
+        $getter = 'get'.ucfirst($mockKey);
112
+        $value  = $this->{$mockKey.'Mock'};
113 113
 
114 114
         $this->assertSame($this->target, $this->target->$setter($value), 'Fluent interface broken!');
115 115
         $this->assertSame($value, $this->target->$getter());
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
      */
124 124
     public function testGetterThrowExceptionIfDependencyMissing($getterName)
125 125
     {
126
-        $getter = "get" . $getterName;
126
+        $getter = "get".$getterName;
127 127
 
128 128
         $this->target->$getter();
129 129
     }
Please login to merge, or discard this patch.
test/OrganizationsTest/Controller/Plugin/AcceptInvitationHandlerTest.php 2 patches
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
 
48 48
         $this->authMock = $this->getMockBuilder('\Auth\AuthenticationService')->disableOriginalConstructor()->getMock();
49 49
         $this->organizationRepositoryMock = $this->getMockBuilder('Organizations\Repository\Organization')
50
-                                                 ->disableOriginalConstructor()->getMock();
50
+                                                    ->disableOriginalConstructor()->getMock();
51 51
         $this->userRepositoryMock = $this->getMockBuilder('\Auth\Repository\User')->disableOriginalConstructor()->getMock();
52 52
 
53 53
         if (false !== strpos($this->getName(false), 'Setter')) {
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
         $employee->expects($this->once())->method('setStatus')->with(Employee::STATUS_ASSIGNED);
77 77
 
78 78
         $this->organizationMock->expects($this->once())->method('getEmployee')->with($this->userMock->getId())
79
-                               ->willReturn($employee);
79
+                                ->willReturn($employee);
80 80
 
81 81
         $this->organizationMock->expects($this->any())->method('getId')->willReturn('testOrgId');
82 82
         $this->userRepositoryMock->expects($this->once())->method('findByToken')->with('testToken')->willReturn($this->userMock);
@@ -103,9 +103,9 @@  discard block
 block discarded – undo
103 103
                                 ->willReturn($unassignedEmp);
104 104
 
105 105
         $this->organizationRepositoryMock->expects($this->once())
106
-                                         ->method('findPendingOrganizationsByEmployee')
107
-                                         ->with($this->userMock->getId())
108
-                                         ->willReturn(array($sameOrganization, $assignedEmpOrganization, $unassignedEmpOrganization));
106
+                                            ->method('findPendingOrganizationsByEmployee')
107
+                                            ->with($this->userMock->getId())
108
+                                            ->willReturn(array($sameOrganization, $assignedEmpOrganization, $unassignedEmpOrganization));
109 109
 
110 110
         $storageMock = $this->getMockForAbstractClass('\Zend\Authentication\Storage\StorageInterface');
111 111
         $storageMock->expects($this->once())->method('write')->with($this->userMock->getId());
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
         $orgRef = $this->getMockBuilder('\Organizations\Entity\OrganizationReference')->disableOriginalConstructor()->getMock();
178 178
         $orgRef->expects($this->once())->method('hasAssociation')->willReturn(true);
179 179
         $orgRef->expects($this->once())->method('getEmployee')->with($this->userMock->getId())
180
-               ->willReturn($empMock);
180
+                ->willReturn($empMock);
181 181
 
182 182
         $this->userMock->setOrganization($orgRef);
183 183
 
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -134,7 +134,7 @@
 block discarded – undo
134 134
                 continue;
135 135
             }
136 136
 
137
-            $this->fail('Expected exception was not thrown for "' . $method . '"');
137
+            $this->fail('Expected exception was not thrown for "'.$method.'"');
138 138
         }
139 139
     }
140 140
 
Please login to merge, or discard this patch.
test/OrganizationsTest/Controller/InviteEmployeeControllerTest.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
         return isset($this->pluginsMockMap[$name]) ? $this->pluginsMockMap[$name] : null;
95 95
     }
96 96
 
97
-    public function retrieveQueryParam($name, $default=null)
97
+    public function retrieveQueryParam($name, $default = null)
98 98
     {
99 99
         return isset($this->queryParams[$name]) ? $this->queryParams[$name] : $default;
100 100
     }
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
 
128 128
     private function setupOrganizationEntityRetrievalMocks($name)
129 129
     {
130
-        $id = $name. "Id";
130
+        $id = $name."Id";
131 131
         $organization = new Organization();
132 132
         $organization->setOrganizationName(new OrganizationName($name));
133 133
 
Please login to merge, or discard this patch.
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -74,8 +74,8 @@
 block discarded – undo
74 74
         $this->target->setPluginManager($plugins);
75 75
 
76 76
         $params = $this->getMockBuilder('\Zend\Mvc\Controller\Plugin\Params')
77
-                       ->disableOriginalConstructor()
78
-                       ->getMock()
77
+                        ->disableOriginalConstructor()
78
+                        ->getMock()
79 79
         ;
80 80
         $params
81 81
             ->expects($this->any())
Please login to merge, or discard this patch.
Repository/Event/InjectOrganizationReferenceListenerTest.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@
 block discarded – undo
79 79
         $rep = $this->getMockBuilder('\Organizations\Repository\Organization')->disableOriginalConstructor()->getMock();
80 80
 
81 81
         $dm->expects($this->once())->method('getRepository')->with('Organizations\Entity\Organization')
82
-           ->willReturn($rep);
82
+            ->willReturn($rep);
83 83
 
84 84
         $doc->setId('test1234');
85 85
 
Please login to merge, or discard this patch.
Organizations/test/OrganizationsTest/Entity/OrganizationReferenceTest.php 2 patches
Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -41,8 +41,8 @@  discard block
 block discarded – undo
41 41
     public function testOrganizationReferenceImplementsInterfaces()
42 42
     {
43 43
         $target = $this->getMockBuilder('\Organizations\Entity\OrganizationReference')
44
-                       ->disableOriginalConstructor()
45
-                       ->getMock();
44
+                        ->disableOriginalConstructor()
45
+                        ->getMock();
46 46
 
47 47
         $this->assertInstanceOf('\Organizations\Entity\OrganizationReferenceInterface', $target);
48 48
         $this->assertInstanceOf('\Organizations\Entity\OrganizationInterface', $target);
@@ -59,21 +59,21 @@  discard block
 block discarded – undo
59 59
             $organization = new Organization();
60 60
 
61 61
             $repository = $this->getMockBuilder('\Organizations\Repository\Organization')
62
-                               ->disableOriginalConstructor()->getMock();
62
+                                ->disableOriginalConstructor()->getMock();
63 63
 
64 64
             $repository->expects($this->once())
65
-                       ->method('findByUser')
66
-                       ->with('1234')
67
-                       ->willReturn('owner' == $type ? $organization : null);
65
+                        ->method('findByUser')
66
+                        ->with('1234')
67
+                        ->willReturn('owner' == $type ? $organization : null);
68 68
 
69 69
             if ('owner' == $type) {
70 70
                 $repository->expects($this->never())
71
-                           ->method('findByEmployee');
71
+                            ->method('findByEmployee');
72 72
             } else {
73 73
                 $repository->expects($this->once())
74
-                           ->method('findByEmployee')
75
-                           ->with('1234')
76
-                           ->willReturn('employee' == $type ? $organization : null);
74
+                            ->method('findByEmployee')
75
+                            ->with('1234')
76
+                            ->willReturn('employee' == $type ? $organization : null);
77 77
             }
78 78
 
79 79
             $target = new OrganizationReference('1234', $repository);
@@ -196,8 +196,8 @@  discard block
 block discarded – undo
196 196
             [['setEmployees', 'getEmployees'], [[$emps], []], ['__self__', $emps]],
197 197
             ['getEmployee', ['4321'], null],
198 198
             [['setUser', 'getUser', 'getPermissionsUserIds'],
199
-                  [[$user], [], []],
200
-                  ['__self__', $user, [PermissionsInterface::PERMISSION_ALL => [$user->getId()]]]
199
+                    [[$user], [], []],
200
+                    ['__self__', $user, [PermissionsInterface::PERMISSION_ALL => [$user->getId()]]]
201 201
             ],
202 202
             ['getJobs', [], null],
203 203
             [['setPermissions', 'getPermissions'], [[$perms], []], ['__self__', $perms]],
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
             $args = array($args);
116 116
         }
117 117
 
118
-        for ($i=0,$c=count($func); $i<$c; $i+=1) {
118
+        for ($i = 0, $c = count($func); $i < $c; $i += 1) {
119 119
             $f = $func[$i];
120 120
             $a = $args[$i];
121 121
 
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
             $expected = array($expected);
145 145
         }
146 146
 
147
-        for ($i=0, $c=count($func); $i<$c; $i+=1) {
147
+        for ($i = 0, $c = count($func); $i < $c; $i += 1) {
148 148
             $f = $func[$i];
149 149
             $a = $args[$i];
150 150
             $e = $expected[$i];
@@ -176,7 +176,7 @@  discard block
 block discarded – undo
176 176
         $perms = new Permissions();
177 177
         $contact = new OrganizationContact();
178 178
         $image = new OrganizationImage();
179
-        $externalId='myReference';
179
+        $externalId = 'myReference';
180 180
         $template = new Template();
181 181
         $template->setLabelBenefits('These are your Benefits');
182 182
         $workflowSettings = new WorkflowSettings();
Please login to merge, or discard this patch.