ActiveOrganizationSelectFactory::__invoke() - Code Metrics - Inspection of "[Jobs] Fix #271: Implement remote loading of activ..." - cross-solution/YAWIK - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 4092da...af8557 )

unknown

created 2017-05-30 15:42 UTC

ActiveOrganizationSelectFactory::__invoke() B

↳ Parent: ActiveOrganizationSelectFactory

Complexity

Conditions	2
Paths	2

Size

Total Lines	26
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	26
rs	8.8571
c	0
b	0
f	0
cc	2
eloc	14
nc	2
nop	3

<?php
/**
 * YAWIK
 *
 * @filesource
 * @license    MIT
 * @copyright  2013 - 2016 Cross Solution <http://cross-solution.de>
 */

/** */
namespace Jobs\Factory\Form;

use Interop\Container\ContainerInterface;
use Jobs\Form\OrganizationSelect;
use Zend\ServiceManager\AbstractPluginManager;
use Zend\ServiceManager\FactoryInterface;
use Zend\ServiceManager\ServiceLocatorInterface;

/**
 * Factory for the ActiveOrganization select box
 *
 * This creates an {@link \Jobs\Form\OrganizationSelect} with all organizations that are
 * currently associated to at least one "active" job entity.
 *
 * @author Mathias Gelhausen <[email protected]>
 * @since 0.23
 * @since 0.30 - refactored to implement lazy loading organization list.
 */
class ActiveOrganizationSelectFactory implements FactoryInterface
{
    /**
     * Create an object
     *
     * @param  ContainerInterface $container
     * @param  string             $requestedName
     * @param  null|array         $options
     *
     * @return object
     * @throws ServiceNotFoundException if unable to resolve the service.
     * @throws ServiceNotCreatedException if an exception is raised when
     *     creating a service.
     * @throws ContainerException if any other error occurs
     */
    public function __invoke(ContainerInterface $container, $requestedName, array $options = null)
    {
        /* @var \Zend\Http\PhpEnvironment\Request $request */
        $request = $container->get('Request');
        $query   = $request->getQuery();
        $initialId = $query->get('companyId');

        $organizations = [];

        if ($initialId) {
            /* @var $serviceLocator \Zend\ServiceManager\AbstractPluginManager
             * @var $repository \Organizations\Repository\Organization */
            $repositories   = $container->get('repositories');
            $repository = $repositories->get('Organizations');
            $organization  = $repository->find($initialId);
            $organizations[] = $organization;
        }

        $select         = new OrganizationSelect();

        $select->setSelectableOrganizations($organizations);
        $select->setAttribute('data-ajax', '?ajax=jobs.admin.activeorganizations');

        return $select;

    }

    /**
     * Creates the organization select box.
     *
     * @param ServiceLocatorInterface|AbstractPluginManager $serviceLocator
     */
    public function createService(ServiceLocatorInterface $serviceLocator)
    {
        return $this($serviceLocator->getServiceLocator(), OrganizationSelect::class);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }
}


1			<?php
2			/**
3			* YAWIK
4			*
5			* @filesource
6			* @license MIT
7			* @copyright 2013 - 2016 Cross Solution <http://cross-solution.de>
8			*/
9
10			/** */
11			namespace Jobs\Factory\Form;
12
13			use Interop\Container\ContainerInterface;
14			use Jobs\Form\OrganizationSelect;
15			use Zend\ServiceManager\AbstractPluginManager;
16			use Zend\ServiceManager\FactoryInterface;
17			use Zend\ServiceManager\ServiceLocatorInterface;
18
19			/**
20			* Factory for the ActiveOrganization select box
21			*
22			* This creates an {@link \Jobs\Form\OrganizationSelect} with all organizations that are
23			* currently associated to at least one "active" job entity.
24			*
25			* @author Mathias Gelhausen <[email protected]>
26			* @since 0.23
27			* @since 0.30 - refactored to implement lazy loading organization list.
28			*/
29			class ActiveOrganizationSelectFactory implements FactoryInterface
30			{
31			/**
32			* Create an object
33			*
34			* @param ContainerInterface $container
35			* @param string $requestedName
36			* @param null\|array $options
37			*
38			* @return object
39			* @throws ServiceNotFoundException if unable to resolve the service.
40			* @throws ServiceNotCreatedException if an exception is raised when
41			* creating a service.
42			* @throws ContainerException if any other error occurs
43			*/
44			public function __invoke(ContainerInterface $container, $requestedName, array $options = null)
45			{
46			/* @var \Zend\Http\PhpEnvironment\Request $request */
47			$request = $container->get('Request');
48			$query = $request->getQuery();
49			$initialId = $query->get('companyId');
50
51			$organizations = [];
52
53			if ($initialId) {
54			/* @var $serviceLocator \Zend\ServiceManager\AbstractPluginManager
55			* @var $repository \Organizations\Repository\Organization */
56			$repositories = $container->get('repositories');
57			$repository = $repositories->get('Organizations');
58			$organization = $repository->find($initialId);
59			$organizations[] = $organization;
60			}
61
62			$select = new OrganizationSelect();
63
64			$select->setSelectableOrganizations($organizations);
65			$select->setAttribute('data-ajax', '?ajax=jobs.admin.activeorganizations');
66
67			return $select;
68
69			}
70
71			/**
72			* Creates the organization select box.
73			*
74			* @param ServiceLocatorInterface\|AbstractPluginManager $serviceLocator
75			*/
76			public function createService(ServiceLocatorInterface $serviceLocator)
77			{
78			return $this($serviceLocator->getServiceLocator(), OrganizationSelect::class);
			0 ignored issues – show Bug introduced 2017-03-01 19:16 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Zend\ServiceManager\ServiceLocatorInterface` as the method `getServiceLocator()` does only exist in the following implementations of said interface: `Acl\Assertion\AssertionManager`, `Core\Mail\MailService`, `Core\Paginator\PaginatorService`, `Zend\Barcode\ObjectPluginManager`, `Zend\Barcode\RendererPluginManager`, `Zend\Cache\PatternPluginManager`, `Zend\Cache\Storage\AdapterPluginManager`, `Zend\Cache\Storage\PluginManager`, `Zend\Config\ReaderPluginManager`, `Zend\Config\WriterPluginManager`, `Zend\Feed\Reader\ExtensionPluginManager`, `Zend\Feed\Writer\ExtensionPluginManager`, `Zend\File\Transfer\Adapter\FilterPluginManager`, `Zend\File\Transfer\Adapter\ValidatorPluginManager`, `Zend\Filter\FilterPluginManager`, `Zend\Form\FormElementMan...lementManagerV2Polyfill`, `Zend\Form\FormElementMan...lementManagerV3Polyfill`, `Zend\Hydrator\HydratorPluginManager`, `Zend\I18n\Translator\LoaderPluginManager`, `Zend\InputFilter\InputFilterPluginManager`, `Zend\Log\FilterPluginManager`, `Zend\Log\FormatterPluginManager`, `Zend\Log\ProcessorPluginManager`, `Zend\Log\WriterPluginManager`, `Zend\Log\Writer\FilterPluginManager`, `Zend\Log\Writer\FormatterPluginManager`, `Zend\Mail\Protocol\SmtpPluginManager`, `Zend\Mvc\Controller\ControllerManager`, `Zend\Mvc\Controller\PluginManager`, `Zend\Mvc\Router\RoutePluginManager`, `Zend\Paginator\AdapterPluginManager`, `Zend\Paginator\ScrollingStylePluginManager`, `Zend\Serializer\AdapterPluginManager`, `Zend\ServiceManager\AbstractPluginManager`, `Zend\Stdlib\Hydrator\HydratorPluginManager`, `Zend\Tag\Cloud\DecoratorPluginManager`, `Zend\Text\Table\DecoratorManager`, `Zend\Validator\ValidatorPluginManager`, `Zend\View\HelperPluginManager`, `Zend\View\Helper\Navigation\PluginManager`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
79			}
80			}
81

cross-solution / YAWIK

Push — develop ( 4092da...af8557 )

ActiveOrganizationSelectFactory::__invoke() B

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like