Completed
Push — develop ( a5396a...45a0ea )
by Mathias
05:23
created
module/Applications/src/Applications/Listener/EventApplicationCreated.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
                         [
89 89
                             'application' => $this->application,
90 90
                             'user' => $employee->getUser(),
91
-                            'bcc' => $adminSettings->getMailBCC() ? [ $admin ] : null,
91
+                            'bcc' => $adminSettings->getMailBCC() ? [$admin] : null,
92 92
                         ]
93 93
                     );
94 94
                 }
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
                 [
107 107
                     'job'   => $this->application->getJob(),
108 108
                     'user'  => $recruiter,
109
-                    'bcc' => $adminSettings->getMailBCC() ? [ $admin ] : null,
109
+                    'bcc' => $adminSettings->getMailBCC() ? [$admin] : null,
110 110
                 ]
111 111
             );
112 112
         }
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
                     [
124 124
                         'application' => $this->application,
125 125
                         'body'        => $ackBody,
126
-                        'bcc'         => $adminSettings->getMailBCC() ? [ $admin ] : null,
126
+                        'bcc'         => $adminSettings->getMailBCC() ? [$admin] : null,
127 127
                     ]
128 128
                 );
129 129
 
Please login to merge, or discard this patch.
module/Jobs/src/Jobs/Form/CategoriesContainer.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
                         'options' => [
39 39
                             'enable_descriptions' => true,
40 40
                             'description' => /*@translate*/ 'Manage the professions you want to assign to jobs.' .
41
-                                             /*@translate*/ 'The order of categories can be modified by drag&drop.',
41
+                                                /*@translate*/ 'The order of categories can be modified by drag&drop.',
42 42
                             'display_mode' => SummaryForm::DISPLAY_SUMMARY,
43 43
                         ],
44 44
                     ],
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
                         'options' => [
58 58
                             'enable_descriptions' => true,
59 59
                             'description' => /*@translate*/ 'Manage the industries you want to assign to jobs.' .
60
-                                             /*@translate*/ 'The order of categories can be modified by drag&drop.',
60
+                                                /*@translate*/ 'The order of categories can be modified by drag&drop.',
61 61
                             'display_mode' => SummaryForm::DISPLAY_SUMMARY,
62 62
                         ],
63 63
                     ],
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
                         'options' => [
77 77
                             'enable_descriptions' => true,
78 78
                             'description' => /*@translate*/ 'Manage the employment types you want to assign to jobs.'.
79
-                                             /*@translate*/ 'The order of categories can be modified by drag&drop.',
79
+                                                /*@translate*/ 'The order of categories can be modified by drag&drop.',
80 80
                             'display_mode' => SummaryForm::DISPLAY_SUMMARY,
81 81
                         ],
82 82
                     ],
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
                         'property' => true,
38 38
                         'options' => [
39 39
                             'enable_descriptions' => true,
40
-                            'description' => /*@translate*/ 'Manage the professions you want to assign to jobs.' .
40
+                            'description' => /*@translate*/ 'Manage the professions you want to assign to jobs.'.
41 41
                                              /*@translate*/ 'The order of categories can be modified by drag&drop.',
42 42
                             'display_mode' => SummaryForm::DISPLAY_SUMMARY,
43 43
                         ],
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
                         'property' => true,
57 57
                         'options' => [
58 58
                             'enable_descriptions' => true,
59
-                            'description' => /*@translate*/ 'Manage the industries you want to assign to jobs.' .
59
+                            'description' => /*@translate*/ 'Manage the industries you want to assign to jobs.'.
60 60
                                              /*@translate*/ 'The order of categories can be modified by drag&drop.',
61 61
                             'display_mode' => SummaryForm::DISPLAY_SUMMARY,
62 62
                         ],
Please login to merge, or discard this patch.
module/Auth/src/Auth/Controller/Plugin/SocialProfiles.php 3 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -69,6 +69,9 @@
 block discarded – undo
69 69
         return $this;
70 70
     }
71 71
     
72
+    /**
73
+     * @param string $network
74
+     */
72 75
     public function getAdapter($network)
73 76
     {
74 77
         if (isset($this->adapters[$network])) {
Please login to merge, or discard this patch.
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
 
17 17
 class SocialProfiles extends AbstractPlugin
18 18
 {
19
-	protected $hybridAuth;
19
+    protected $hybridAuth;
20 20
 	
21 21
     protected $adapterMap = array(
22 22
         'facebook' => '\\Auth\\Controller\\Plugin\\SocialProfiles\\Facebook',
@@ -25,9 +25,9 @@  discard block
 block discarded – undo
25 25
             
26 26
     );
27 27
 	
28
-	/**
29
-	 * @var RequestInterface
30
-	 */
28
+    /**
29
+     * @var RequestInterface
30
+     */
31 31
     protected $request;
32 32
     
33 33
     public function __construct($hybridAuth,RequestInterface $request,array $adapters = array())
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
 	 */
31 31
     protected $request;
32 32
     
33
-    public function __construct($hybridAuth,RequestInterface $request,array $adapters = array())
33
+    public function __construct($hybridAuth, RequestInterface $request, array $adapters = array())
34 34
     {
35 35
         $this->hybridAuth = $hybridAuth;
36 36
         $this->request = $request;
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
             throw new \InvalidArgumentException(
71 71
                 sprintf(
72 72
                     'Adapter must be either a string or an instance of \Auth\Controller\Plugin\SocialProfiles\AbstractAdapter, but received %s',
73
-                    is_object($adapter) ? get_class($adapter) : '(' . gettype($adapter) . ')'
73
+                    is_object($adapter) ? get_class($adapter) : '('.gettype($adapter).')'
74 74
                 )
75 75
             );
76 76
         }
Please login to merge, or discard this patch.
module/Auth/src/Auth/Controller/Plugin/SocialProfiles/AbstractAdapter.php 2 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,6 @@
 block discarded – undo
29 29
     {}
30 30
     
31 31
     /**
32
-     * @param string $network
33 32
      * @return \Auth\Entity\SocialProfiles\ProfileInterface|bool
34 33
      */
35 34
     public function fetch($api)
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
      */
35 35
     public function fetch($api)
36 36
     {
37
-        $result  = $this->queryApi($api);
37
+        $result = $this->queryApi($api);
38 38
         if (!$result) {
39 39
             return false;
40 40
         }
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
         $class = get_class($this);
61 61
         $class = explode('\\', $class);
62 62
         $class = array_pop($class);
63
-        $class = '\\Auth\\Entity\\SocialProfiles\\' . $class;
63
+        $class = '\\Auth\\Entity\\SocialProfiles\\'.$class;
64 64
         
65 65
         return $class;
66 66
     }
Please login to merge, or discard this patch.
module/Cv/src/Cv/Form/SearchForm.php 2 patches
Indentation   +34 added lines, -34 removed lines patch added patch discarded remove patch
@@ -34,44 +34,44 @@
 block discarded – undo
34 34
     {
35 35
 
36 36
         $this->add(
37
-             [
38
-                 'name' => 'l',
39
-                 'type' => 'LocationSelect',
40
-                 'options' => [
41
-                     'label' => /*@translate*/ 'Location',
42
-                     'span' => 3,
43
-                     'location_entity' => Location::class,
44
-                 ],
45
-                 'attributes' => [
46
-                     'data-width' => '100%',
47
-                 ],
48
-             ]
37
+                [
38
+                    'name' => 'l',
39
+                    'type' => 'LocationSelect',
40
+                    'options' => [
41
+                        'label' => /*@translate*/ 'Location',
42
+                        'span' => 3,
43
+                        'location_entity' => Location::class,
44
+                    ],
45
+                    'attributes' => [
46
+                        'data-width' => '100%',
47
+                    ],
48
+                ]
49 49
         );
50 50
 
51 51
         $this->add(
52
-             [
53
-                 'name' => 'd',
54
-                 'type' => 'Zend\Form\Element\Select',
55
-                 'options' => [
56
-                     'label' => /*@translate*/ 'Distance',
57
-                     'value_options' => [
58
-                         '5' => '5 km',
59
-                         '10' => '10 km',
60
-                         '20' => '20 km',
61
-                         '50' => '50 km',
62
-                         '100' => '100 km'
63
-                     ],
64
-                     'span' => 4,
52
+                [
53
+                    'name' => 'd',
54
+                    'type' => 'Zend\Form\Element\Select',
55
+                    'options' => [
56
+                        'label' => /*@translate*/ 'Distance',
57
+                        'value_options' => [
58
+                            '5' => '5 km',
59
+                            '10' => '10 km',
60
+                            '20' => '20 km',
61
+                            '50' => '50 km',
62
+                            '100' => '100 km'
63
+                        ],
64
+                        'span' => 4,
65 65
 
66
-                 ],
67
-                 'attributes' => [
68
-                     'value' => '10', // default distance
69
-                     'data-searchbox' => -1,  // hide the search box
70
-                     'data-allowclear' => 'false', // allow to clear a selected value
71
-                     'data-placeholder' => /*@translate*/ 'Distance',
72
-                     'data-width' => '100%',
73
-                 ]
74
-             ]
66
+                    ],
67
+                    'attributes' => [
68
+                        'value' => '10', // default distance
69
+                        'data-searchbox' => -1,  // hide the search box
70
+                        'data-allowclear' => 'false', // allow to clear a selected value
71
+                        'data-placeholder' => /*@translate*/ 'Distance',
72
+                        'data-width' => '100%',
73
+                    ]
74
+                ]
75 75
         );
76 76
     }
77 77
 }
78 78
\ No newline at end of file
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@
 block discarded – undo
66 66
                  ],
67 67
                  'attributes' => [
68 68
                      'value' => '10', // default distance
69
-                     'data-searchbox' => -1,  // hide the search box
69
+                     'data-searchbox' => -1, // hide the search box
70 70
                      'data-allowclear' => 'false', // allow to clear a selected value
71 71
                      'data-placeholder' => /*@translate*/ 'Distance',
72 72
                      'data-width' => '100%',
Please login to merge, or discard this patch.
module/Core/src/Core/Listener/XmlRenderListener.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -89,8 +89,8 @@  discard block
 block discarded – undo
89 89
     {
90 90
         if (!($routeMatch = $e->getRouteMatch())) { return; };
91 91
 
92
-        $format = $e->getRouteMatch()->getParam('format',"html");
93
-        $channel = $e->getRouteMatch()->getParam('channel',"default");
92
+        $format = $e->getRouteMatch()->getParam('format', "html");
93
+        $channel = $e->getRouteMatch()->getParam('channel', "default");
94 94
 
95 95
         if ('xml' == $format) {
96 96
             $viewModel = $e->getResult();
@@ -99,8 +99,8 @@  discard block
 block discarded – undo
99 99
             }
100 100
             $resolver = $e->getApplication()->getServiceManager()->get('ViewResolver');
101 101
 
102
-            $templateDefault = $viewModel->getTemplate() . '.xml.phtml';
103
-            $templateChannel = $viewModel->getTemplate() . '.' . $channel . '.xml.phtml';
102
+            $templateDefault = $viewModel->getTemplate().'.xml.phtml';
103
+            $templateChannel = $viewModel->getTemplate().'.'.$channel.'.xml.phtml';
104 104
 
105 105
 
106 106
             if ($channel != 'default' && $resolver->resolve($templateChannel)) {
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
 
118 118
             /* @var Response $response */
119 119
             $response = $e->getResponse();
120
-            $response->getHeaders()->addHeaderLine('Content-Type','application/xml');
120
+            $response->getHeaders()->addHeaderLine('Content-Type', 'application/xml');
121 121
         }
122 122
                 
123 123
     }
Please login to merge, or discard this patch.
module/Geo/src/Geo/Service/AbstractClient.php 3 patches
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -38,6 +38,9 @@  discard block
 block discarded – undo
38 38
     protected $country;
39 39
 
40 40
 
41
+    /**
42
+     * @param string $uri
43
+     */
41 44
     public function __construct($uri, $country="DE", $cache = false)
42 45
     {
43 46
         $this->country = $country;
@@ -92,6 +95,9 @@  discard block
 block discarded – undo
92 95
         return isset($result[0]) ? $result[0] : false;
93 96
     }
94 97
 
98
+    /**
99
+     * @param string $result
100
+     */
95 101
     protected function processResult($result)
96 102
     {
97 103
         return $result;
Please login to merge, or discard this patch.
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -62,10 +62,10 @@
 block discarded – undo
62 62
 
63 63
     public function query($term, array $params = [])
64 64
     {
65
-    	/* @TODO: [ZF3] overriding $term value because it always returns null */
66
-    	if(is_null($term)){
67
-		    $term = $_REQUEST['q'];
68
-	    }
65
+        /* @TODO: [ZF3] overriding $term value because it always returns null */
66
+        if(is_null($term)){
67
+            $term = $_REQUEST['q'];
68
+        }
69 69
         $cacheId = md5($term);
70 70
 
71 71
         if ($this->cache && ($result = $this->cache->getItem($cacheId))) {
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
     protected $country;
39 39
 
40 40
 
41
-    public function __construct($uri, $country="DE", $cache = false)
41
+    public function __construct($uri, $country = "DE", $cache = false)
42 42
     {
43 43
         $this->country = $country;
44 44
         $this->client = $this->setupClient($uri);
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
     public function query($term, array $params = [])
64 64
     {
65 65
     	/* @TODO: [ZF3] overriding $term value because it always returns null */
66
-    	if(is_null($term)){
66
+    	if (is_null($term)) {
67 67
 		    $term = $_REQUEST['q'];
68 68
 	    }
69 69
         $cacheId = md5($term);
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
 
77 77
         $response = $this->client->send();
78 78
         if ($response->getStatusCode() !== 200) {
79
-            throw new \RuntimeException('Query failed, because ' . $response->getReasonPhrase());
79
+            throw new \RuntimeException('Query failed, because '.$response->getReasonPhrase());
80 80
         }
81 81
 
82 82
         $result = $response->getBody();
Please login to merge, or discard this patch.
module/Auth/src/Auth/Adapter/ExternalApplication.php 2 patches
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
         }
116 116
                 
117 117
         $identity      = $this->getIdentity();
118
-        $applicationId = '@' . $this->getApplicationIdentifier();
118
+        $applicationId = '@'.$this->getApplicationIdentifier();
119 119
         $applicationIdIndex = strrpos($identity, $applicationId);
120 120
         //$login         = (0 < $applicationIdIndex &&  strlen($identity) - strlen($applicationId) == $applicationIdIndex)?substr($identity, 0, $applicationIdIndex):$identity;
121 121
         $login         = $identity;
@@ -128,8 +128,8 @@  discard block
 block discarded – undo
128 128
         $loginSuccess = false;
129 129
         $loginResult = array();
130 130
         
131
-        if (0 < $applicationIdIndex &&  strlen($identity) - strlen($applicationId) == $applicationIdIndex) {
132
-            $this->serviceManager->get('Core/Log')->debug('User ' . $login . ', login with correct suffix: ');
131
+        if (0 < $applicationIdIndex && strlen($identity) - strlen($applicationId) == $applicationIdIndex) {
132
+            $this->serviceManager->get('Core/Log')->debug('User '.$login.', login with correct suffix: ');
133 133
             // the login ends with the applicationID, therefore use the secret key
134 134
             // the external login must be the form 'xxxxx@yyyy' where yyyy is the matching suffix to the external application key
135 135
             if (isset($user)) {
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
                     $loginSuccess = true;
138 138
                 } else {
139 139
                     $loginSuccess = false;
140
-                    $this->serviceManager->get('Core/Log')->info('User ' . $login . ', secret: ' . $user->getSecret() . ' != loginPassword: ' . $filter->filter($credential) . ' (' . $credential . ')');
140
+                    $this->serviceManager->get('Core/Log')->info('User '.$login.', secret: '.$user->getSecret().' != loginPassword: '.$filter->filter($credential).' ('.$credential.')');
141 141
                 }
142 142
             } else {
143 143
                 $user = $users->create(
@@ -153,17 +153,17 @@  discard block
 block discarded – undo
153 153
                 $loginResult = array('firstLogin' => true);
154 154
             }
155 155
         } elseif (isset($user)) {
156
-            $this->serviceManager->get('Core/Log')->debug('User ' . $login . ', login with incorrect suffix: ');
156
+            $this->serviceManager->get('Core/Log')->debug('User '.$login.', login with incorrect suffix: ');
157 157
             if ($user->getCredential() == $filter->filter($credential)) {
158
-                $this->serviceManager->get('Core/Log')->debug('User ' . $login . ', credentials are equal');
158
+                $this->serviceManager->get('Core/Log')->debug('User '.$login.', credentials are equal');
159 159
                 $loginSuccess = true;
160 160
             } elseif (!empty($applicationId)) {
161
-                $this->serviceManager->get('Core/Log')->debug('User ' . $login . ', credentials are not equal');
161
+                $this->serviceManager->get('Core/Log')->debug('User '.$login.', credentials are not equal');
162 162
                 // TODO: remove this code as soon as the secret key has been fully established
163 163
                 // basically this does allow an external login with an applicationIndex match against the User-Password
164 164
                 // the way it had been used in the start
165 165
                 if ($user->getCredential() == $filter->filter($credential)) {
166
-                    $this->serviceManager->get('Core/Log')->debug('User ' . $login . ', credentials2 test');
166
+                    $this->serviceManager->get('Core/Log')->debug('User '.$login.', credentials2 test');
167 167
                     $loginSuccess = true;
168 168
                 }
169 169
             }
Please login to merge, or discard this patch.
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -42,9 +42,9 @@
 block discarded – undo
42 42
         $this->setApplicationKey($applicationKey);
43 43
     }
44 44
 	
45
-	/**
46
-	 * @param ContainerInterface $serviceManager
47
-	 */
45
+    /**
46
+     * @param ContainerInterface $serviceManager
47
+     */
48 48
     public function setServiceLocator(ContainerInterface $serviceManager)
49 49
     {
50 50
         $this->serviceManager = $serviceManager;
Please login to merge, or discard this patch.
module/Jobs/src/Jobs/Factory/Form/ActiveOrganizationSelectFactory.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -53,13 +53,13 @@
 block discarded – undo
53 53
         if ($initialId) {
54 54
             /* @var $serviceLocator \Zend\ServiceManager\AbstractPluginManager
55 55
              * @var $repository \Organizations\Repository\Organization */
56
-            $repositories   = $container->get('repositories');
56
+            $repositories = $container->get('repositories');
57 57
             $repository = $repositories->get('Organizations');
58
-            $organization  = $repository->find($initialId);
58
+            $organization = $repository->find($initialId);
59 59
             $organizations[] = $organization;
60 60
         }
61 61
 
62
-        $select         = new OrganizationSelect();
62
+        $select = new OrganizationSelect();
63 63
 
64 64
         $select->setSelectableOrganizations($organizations);
65 65
         $select->setAttribute('data-ajax', '?ajax=jobs.admin.activeorganizations');
Please login to merge, or discard this patch.