cross-solution / YAWIK

module/Applications/src/Entity/ApplicationInterface.php

Doc Comments +2 added lines, -2 removed lines

@@ -240,7 +240,7 @@ 
     /**
      * Gets all comments for the application.
      *
-     * @return ArrayCollection;
+     * @return Collection
 
      */
     public function getComments();
@@ -271,7 +271,7 @@ 
     /**
      * Gets all attributes for an application.
      *
-     * @return ArrayCollection;
+     * @return Attributes
 
      */
     public function getAttributes();

Indentation -2 removed lines

@@ -241,7 +241,6 @@ 
      * Gets all comments for the application.
      *
      * @return ArrayCollection;
-
      */
     public function getComments();
     
@@ -272,7 +271,6 @@ 
      * Gets all attributes for an application.
      *
      * @return ArrayCollection;
-
      */
     public function getAttributes();
 

module/Applications/src/Entity/History.php

Doc Comments +4 added lines, -1 removed lines

@@ -41,6 +41,9 @@ 
      */
     protected $message;
     
+    /**
+     * @param StatusInterface|null $status
+     */
     public function __construct($status, $message = '[System]')
     {
         if (!$status instanceof StatusInterface) {
@@ -116,7 +119,7 @@ 
     /**
      * Sets the history message
      *
-     * @param $message
+     * @param string $message
      *
      * @return $this
      */

module/Applications/src/Listener/Events/ApplicationEvent.php

Doc Comments +2 added lines, -2 removed lines

@@ -168,7 +168,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function getStatus()
     {
@@ -176,7 +176,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return boolean
      */
     public function isPostRequest()
     {

Spacing +3 added lines, -3 removed lines

@@ -28,17 +28,17 @@
     /**
      * Event is fired when a new application is saved.
      */
-    const EVENT_APPLICATION_POST_CREATE   = 'application.post.create';
+    const EVENT_APPLICATION_POST_CREATE = 'application.post.create';
 
     /**
      * Event is fired when a users deleted application
      */
-    const EVENT_APPLICATION_PRE_DELETE   = 'application.pre.delete';
+    const EVENT_APPLICATION_PRE_DELETE = 'application.pre.delete';
 
     /**
      * Event is fired when the status of an application is changed
      */
-    const EVENT_APPLICATION_STATUS_CHANGE   = 'application.status.change';
+    const EVENT_APPLICATION_STATUS_CHANGE = 'application.status.change';
 
     /**
      * @var Application $application

module/Applications/src/Mail/Confirmation.php

Doc Comments +1 added lines, -1 removed lines

@@ -103,7 +103,7 @@
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     protected function getJobTitle()
     {

Spacing +2 added lines, -2 removed lines

@@ -174,11 +174,11 @@
             return '';
         }
 
-        $token = $user instanceof AnonymousUser ? '?token=' . $user->getToken() : '';
+        $token = $user instanceof AnonymousUser ? '?token='.$user->getToken() : '';
         $href  = $router->assemble(
                         ['id' => $this->application->getId()],
                         ['name'=>'lang/applications/detail', 'force_canonical'=>true]
-        ) . $token;
+        ).$token;
 
         return $href;
     }

module/Applications/src/Options/ModuleOptions.php

Doc Comments +2 added lines, -2 removed lines

@@ -121,7 +121,7 @@ 
     /**
      * Gets the the maximum number of allowed attachments
      *
-     * @return string
+     * @return integer
      */
     public function getAttachmentsCount()
     {
@@ -142,7 +142,7 @@ 
     /**
      * Gets the the maximum size of contact images in bytes
      *
-     * @return string
+     * @return integer
      */
     public function getContactImageMaxSize()
     {

Indentation +1 added lines, -1 removed lines

@@ -79,7 +79,7 @@
 
     protected $workflow = [
 
-      'recruiter',
+        'recruiter',
     ];
 
     /**

Spacing +1 added lines, -1 removed lines

@@ -237,7 +237,7 @@
      */
     public function setAllowSubsequentAttachmentUpload($allowSubsequentAttachmentUpload)
     {
-        $this->allowSubsequentAttachmentUpload = (bool)$allowSubsequentAttachmentUpload;
+        $this->allowSubsequentAttachmentUpload = (bool) $allowSubsequentAttachmentUpload;
         
         return $this;
     }

module/Applications/src/Repository/Event/DeleteRemovedAttachmentsSubscriber.php

Doc Comments +2 added lines, -2 removed lines

@@ -35,8 +35,8 @@
     /**
      * Updates fiile permissions on Flush
      *
-     * @param OnFlushEventArgs $eventArgs
-     * @return boolean
+     * @param LifecycleEventArgs $eventArgs
+     * @return boolean|null
      */
     public function postRemoveEntity(LifecycleEventArgs $eventArgs)
     {

Indentation +6 added lines, -6 removed lines

@@ -51,14 +51,14 @@
         $fileId = new \MongoId($file->id);
         
         $dm->createQueryBuilder('Applications\Entity\Application')
-           ->update()->multiple(true)
-           ->field('attachments')->equals($fileId)->pull($fileId)
-           ->getQuery()->execute();
+            ->update()->multiple(true)
+            ->field('attachments')->equals($fileId)->pull($fileId)
+            ->getQuery()->execute();
         
         
         $dm->createQueryBuilder('Applications\Entity\Application')
-           ->update()->multiple(true)
-           ->field('contact.image')->equals($fileId)->set(null)
-           ->getQuery()->execute();
+            ->update()->multiple(true)
+            ->field('contact.image')->equals($fileId)->set(null)
+            ->getQuery()->execute();
     }
 }

module/Applications/src/Repository/Event/UpdateFilesPermissionsSubscriber.php

Doc Comments +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
      * Updates fiile permissions on Flush
      *
      * @param OnFlushEventArgs $eventArgs
-     * @return boolean
+     * @return boolean|null
      */
     public function onFlush(OnFlushEventArgs $eventArgs)
     {

Indentation +4 added lines, -4 removed lines

@@ -56,8 +56,8 @@ 
                
                 foreach ($document->getAttachments() as $attachment) {  /* @var \Applications\Entity\Attachment $attachment */
                     $attachment->getPermissions()
-                               ->clear()
-                               ->inherit($permissions);
+                                ->clear()
+                                ->inherit($permissions);
                     if ($isUpdate) {
                         $uow->computeChangeSet(
                             $dm->getClassMetadata(get_class($attachment)),
@@ -68,8 +68,8 @@ 
                 
                 if ($image = $document->getContact()->getImage()) {
                     $image->getPermissions()
-                          ->clear()
-                          ->inherit($permissions);
+                            ->clear()
+                            ->inherit($permissions);
                     if ($isUpdate) {
                         $uow->computeChangeSet(
                             $dm->getClassMetadata(get_class($image)),

Spacing +1 added lines, -1 removed lines

@@ -42,7 +42,7 @@
         $dm  = $eventArgs->getDocumentManager();
         $uow = $dm->getUnitOfWork();
         
-        $filter = function ($element) {
+        $filter = function($element) {
             return $element instanceof ApplicationInterface
                    && $element->getPermissions()->hasChanged();
         };

module/Behat/src/CoreContext.php

Doc Comments +3 added lines, -3 removed lines

@@ -106,7 +106,6 @@ 
     
     /**
      * @param $name
-     * @param array $params
      *
      * @return string
      */
@@ -117,6 +116,7 @@ 
 
     /**
      * @When /^I hover over the element "([^"]*)"$/
+     * @param string $locator
      */
     public function iHoverOverTheElement($locator)
     {
@@ -261,10 +261,10 @@ 
     }
     
     /**
-     * @param $locator
+     * @param string $locator
      * @param string $selector
      *
-     * @return \Behat\Mink\Element\NodeElement|mixed|null
+     * @return \Behat\Mink\Element\NodeElement|null
      */
     public function getElement($locator, $selector='css')
     {

Spacing +7 added lines, -7 removed lines

@@ -29,7 +29,7 @@ 
 
     private $config;
 
-    public function __construct($config=null)
+    public function __construct($config = null)
     {
         if (is_null($config)) {
             $config = __DIR__.'/../../../config/config.php';
@@ -180,7 +180,7 @@ 
     public function iSetMainWindowName()
     {
         $window_name = 'main_window';
-        $script = 'window.name = "' . $window_name . '"';
+        $script = 'window.name = "'.$window_name.'"';
         $this->getSession()->executeScript($script);
     }
     
@@ -239,14 +239,14 @@ 
                 break;
             
             default:
-                throw new \Exception(__METHOD__ . ' Couldn\'t find selector: ' . $selector . ' - Allowed selectors: #id, .className, //xpath');
+                throw new \Exception(__METHOD__.' Couldn\'t find selector: '.$selector.' - Allowed selectors: #id, .className, //xpath');
                 break;
         }
         
         try {
             $this->getSession()->executeScript($function);
         } catch (\Exception $e) {
-            throw new \Exception(__METHOD__ . ' failed'. ' Message: for this locator:"'.$selector.'"');
+            throw new \Exception(__METHOD__.' failed'.' Message: for this locator:"'.$selector.'"');
         }
     }
     
@@ -266,7 +266,7 @@ 
      *
      * @return \Behat\Mink\Element\NodeElement|mixed|null
      */
-    public function getElement($locator, $selector='css')
+    public function getElement($locator, $selector = 'css')
     {
         $page = $this->minkContext->getSession()->getPage();
         $element = $page->find('css', $locator);
@@ -300,12 +300,12 @@ 
         $session = $this->getSession();
         $element = $session->getPage()->find(
             'xpath',
-            $session->getSelectorsHandler()->selectorToXpath('xpath', '*//*[text()="'. $text .'"]')
+            $session->getSelectorsHandler()->selectorToXpath('xpath', '*//*[text()="'.$text.'"]')
         );
         if (null === $element) {
             $element = $session->getPage()->find(
                 'named',
-                array('id',$text)
+                array('id', $text)
             );
         }
         if (null === $element) {

module/Behat/src/UserContext.php

Doc Comments +4 added lines, -1 removed lines

@@ -219,6 +219,9 @@ 
         $this->startLogin($user, 'test');
     }
     
+    /**
+     * @param string $password
+     */
     private function startLogin(UserInterface $user, $password)
     {
         $currentUser = $this->currentUser;
@@ -264,7 +267,7 @@ 
      * @param string $fullname
      * @param string $role
      *
-     * @return \Auth\Entity\UserInterface
+     * @return \Core\Entity\EntityInterface
      */
     public function createUser($email, $password, $role=User::ROLE_RECRUITER, $fullname="Test Recruiter")
     {

Spacing +15 added lines, -15 removed lines

@@ -63,7 +63,7 @@ 
      */
     protected $currentUser;
     
-    public function __construct($parameters=[])
+    public function __construct($parameters = [])
     {
         $defaultLoginInfo = [
             'facebook' => [
@@ -75,7 +75,7 @@ 
                 'session_password-login' => getenv('LINKEDIN_USER_PASSWORD')
             ],
         ];
-        $socialLoginConfig = isset($parameters['social_login_info']) ? $parameters['social_login_info']:[];
+        $socialLoginConfig = isset($parameters['social_login_info']) ? $parameters['social_login_info'] : [];
         $this->socialLoginInfo = array_merge($defaultLoginInfo, $socialLoginConfig);
     }
 
@@ -142,7 +142,7 @@ 
      * @Given I am logged in as a recruiter
      * @Given I am logged in as a recruiter with :organization as organization
      */
-    public function iAmLoggedInAsARecruiter($organization=null)
+    public function iAmLoggedInAsARecruiter($organization = null)
     {
         $user = $this->thereIsAUserIdentifiedBy(
             'test@recruiter.com',
@@ -174,7 +174,7 @@ 
     public function iDonTHaveUser($login)
     {
         $repo = $this->getUserRepository();
-        $user=$repo->findByLogin($login);
+        $user = $repo->findByLogin($login);
         if ($user instanceof UserInterface) {
             $repo->remove($user, true);
         }
@@ -222,7 +222,7 @@ 
     private function startLogin(UserInterface $user, $password)
     {
         $currentUser = $this->currentUser;
-        if (!is_object($currentUser) || $user->getId()!=$currentUser->getId()) {
+        if (!is_object($currentUser) || $user->getId() != $currentUser->getId()) {
             $this->iWantToLogIn();
             $this->iSpecifyTheUsernameAs($user->getLogin());
             $this->iSpecifyThePasswordAs($password);
@@ -242,10 +242,10 @@ 
     /**
      * @Given there is a user :email identified by :password
      */
-    public function thereIsAUserIdentifiedBy($email, $password, $role=User::ROLE_RECRUITER, $fullname="Test Recruiter", $organization=null)
+    public function thereIsAUserIdentifiedBy($email, $password, $role = User::ROLE_RECRUITER, $fullname = "Test Recruiter", $organization = null)
     {
         $repo = $this->getUserRepository();
-        if (!is_object($user=$repo->findByEmail($email))) {
+        if (!is_object($user = $repo->findByEmail($email))) {
             $user = $this->createUser($email, $password, $role, $fullname, $organization);
         }
         
@@ -266,7 +266,7 @@ 
      *
      * @return \Auth\Entity\UserInterface
      */
-    public function createUser($email, $password, $role=User::ROLE_RECRUITER, $fullname="Test Recruiter")
+    public function createUser($email, $password, $role = User::ROLE_RECRUITER, $fullname = "Test Recruiter")
     {
         /* @var Register $service */
         /* @var User $user */
@@ -280,7 +280,7 @@ 
         $expFullName = explode(' ', $fullname);
         $info = $user->getInfo();
         $info->setFirstName(array_shift($expFullName));
-        $info->setLastName(count($expFullName)>0 ? implode(' ', $expFullName):'');
+        $info->setLastName(count($expFullName) > 0 ? implode(' ', $expFullName) : '');
         $info->setEmail($email);
         $info->setEmailVerified(true);
         $repo->store($user);
@@ -310,7 +310,7 @@ 
         /* @var $repoOrganization OrganizationRepository */
         $repoOrganization = $this->coreContext->getRepositories()->get('Organizations/Organization');
         $result = $repoOrganization->findByName($orgName);
-        $organization = count($result) > 0 ? $result[0]:null;
+        $organization = count($result) > 0 ? $result[0] : null;
         if (!$organization instanceof Organization) {
             $organization = new Organization();
             $organizationName = new OrganizationName($orgName);
@@ -426,12 +426,12 @@ 
     {
         $repo = $this->getUserRepository();
         $data = $table->getRowsHash();
-        $email = isset($data['email']) ? $data['email']:'test@example.com';
-        $password = isset($data['password']) ? $data['password']:'test';
-        $fullname = isset($data['fullname']) ? $data['fullname']:'Test User';
-        $role = isset($data['role']) ? $data['role']:User::ROLE_RECRUITER;
+        $email = isset($data['email']) ? $data['email'] : 'test@example.com';
+        $password = isset($data['password']) ? $data['password'] : 'test';
+        $fullname = isset($data['fullname']) ? $data['fullname'] : 'Test User';
+        $role = isset($data['role']) ? $data['role'] : User::ROLE_RECRUITER;
         
-        if (!is_object($user=$repo->findByLogin($email))) {
+        if (!is_object($user = $repo->findByLogin($email))) {
             $user = $this->createUser($email, $password, $role, $fullname);
         }
         $this->currentUser = $user;