Manager::__construct() - Code Metrics - Inspection of "[Solr] Solr Server integration ref #234" - cross-solution/YAWIK - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#241)

by ANTHONIUS

created 2016-07-01 06:12 UTC

Manager::__construct() A

↳ Parent: Manager

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	1

<?php
/**
 * YAWIK
 *
 * @copyright (c) 2013 - 2016 Cross Solution (http://cross-solution.de)
 * @license   MIT
 */

namespace Solr\Bridge;


use Solr\Exception\ServerException;
use Solr\Options\Connection as ConnectionOption;
use Zend\ServiceManager\ServiceLocatorInterface;

class Manager
{
    const SOLR_DATE_FORMAT  = 'Y-m-d\TH:i:s\Z';
    const SORT_ASCENDING    = 0;
    const SORT_DESCENDING   = 1;

    /**
     * @var ConnectionOption
     */
    protected $connectOption;

    public function __construct(ConnectionOption $connectOption)
    {
        $this->connectOption = $connectOption;
    }

    public function getClient($path='/solr')
    {
        $connectOption = $this->connectOption;
        $options = [
            'secure' => $connectOption->isSecure(),
            'hostname' => $connectOption->getHostname(),
            'port' => $connectOption->getPort(),
            'path' => $path,
            'login' => $connectOption->getUsername(),
            'password' => $connectOption->getPassword(),
        ];

        return new \SolrClient($options);
    }

    /**
     * @param \SolrInputDocument $document
     * @param string $path
     */
    public function addDocument(\SolrInputDocument $document,$path='/solr')
    {
        $client = $this->getClient($path);
        try{
            $client->addDocument($document);
            $client->commit();
            $client->optimize();
        }catch (\Exception $e){
            throw new ServerException('Can not add document to server!',$e->getCode(),$e);
        }
    }
    
    static public function factory(ServiceLocatorInterface $sl)

    {
        return new self(
            $sl->get('Solr/Options/Connection')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );
    }
}

1			<?php
2			/**
3			* YAWIK
4			*
5			* @copyright (c) 2013 - 2016 Cross Solution (http://cross-solution.de)
6			* @license MIT
7			*/
8
9			namespace Solr\Bridge;
10
11
12			use Solr\Exception\ServerException;
13			use Solr\Options\Connection as ConnectionOption;
14			use Zend\ServiceManager\ServiceLocatorInterface;
15
16			class Manager
17			{
18			const SOLR_DATE_FORMAT = 'Y-m-d\TH:i:s\Z';
19			const SORT_ASCENDING = 0;
20			const SORT_DESCENDING = 1;
21
22			/**
23			* @var ConnectionOption
24			*/
25			protected $connectOption;
26
27			public function __construct(ConnectionOption $connectOption)
28			{
29			$this->connectOption = $connectOption;
30			}
31
32			public function getClient($path='/solr')
33			{
34			$connectOption = $this->connectOption;
35			$options = [
36			'secure' => $connectOption->isSecure(),
37			'hostname' => $connectOption->getHostname(),
38			'port' => $connectOption->getPort(),
39			'path' => $path,
40			'login' => $connectOption->getUsername(),
41			'password' => $connectOption->getPassword(),
42			];
43
44			return new \SolrClient($options);
45			}
46
47			/**
48			* @param \SolrInputDocument $document
49			* @param string $path
50			*/
51			public function addDocument(\SolrInputDocument $document,$path='/solr')
52			{
53			$client = $this->getClient($path);
54			try{
55			$client->addDocument($document);
56			$client->commit();
57			$client->optimize();
58			}catch (\Exception $e){
59			throw new ServerException('Can not add document to server!',$e->getCode(),$e);
60			}
61			}
62
63			static public function factory(ServiceLocatorInterface $sl)
			0 ignored issues – show Coding Style introduced 2016-07-01 06:20 UTC by Report Bug Copy Issue Report As per PSR2, the `static` declaration should come after the visibility declaration. Loading history...
64			{
65			return new self(
66			$sl->get('Solr/Options/Connection')
			0 ignored issues – show Documentation introduced 2016-07-01 06:20 UTC by Report Bug Copy Issue Report `$sl->get('Solr/Options/Connection')` is of type `object\|array`, but the function expects a `object<Solr\Options\Connection>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
67			);
68			}
69			}

cross-solution / YAWIK

Pull Request — develop (#241)

Manager::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like