EducationFieldset::init() - Code Metrics - Inspection of "Issue 258" - cross-solution/YAWIK - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#261)

unknown

created 2016-07-26 06:15 UTC

EducationFieldset::init() B

↳ Parent: EducationFieldset

Complexity

Conditions	1
Paths	1

Size

Total Lines	99
Code Lines	60

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
c	2
b	1
f	0
dl	0
loc	99
rs	8.3103
cc	1
eloc	60
nc	1
nop	0

How to fix Long Method

<?php

namespace Cv\Form;

use Zend\Form\Fieldset;
use Cv\Entity\Education as EducationEntity;
use Core\Entity\Hydrator\EntityHydrator;
use Zend\InputFilter\InputFilterProviderInterface;
use Core\Form\ViewPartialProviderInterface;
use Core\Form\ViewPartialProviderTrait;

class EducationFieldset extends Fieldset implements InputFilterProviderInterface, ViewPartialProviderInterface
{
    
    use ViewPartialProviderTrait;
    
    /**
     * View script for rendering
     *
     * @var string
     */
    protected $defaultPartial = 'cv/form/education';
    
    public function init()
    {
        $this->setName('education')
             ->setHydrator(new EntityHydrator())
             ->setObject(new EducationEntity());
        
        $this->add(
            array(
            'type' => 'Core/Datepicker',
            'name' => 'startDate',
            'options' => array(
                'label' => /*@translate*/ 'Start date',
                'data-width' => '50%',
                'class' => 'selectpicker'
            )
            )
        );
        $this->add(
            array(
            'type' => 'Core/Datepicker',
            'name' => 'endDate',
            'options' => array(
                'label' => /*@translate*/ 'End date'
            )
            )
        );
        $this->add(
            array(
                'type' => 'checkbox',
                'name' => 'currentIndicator',
                'options' => array(
                        'label' => /*@translate */ 'ongoing'
                )
            )
        );
        
        $this->add(
            array(
                'name' => 'competencyName',
                'options' => array(
                        'label' => /*@translate */ 'Degree'),
                'attributes' => array(
                        //'id' => 'education-competencyname',

                        'title' =>  /*@translate */ 'please enter the name of your qualification'
                ),
            )
        );
        
        $this->add(
            array(
                'name' => 'organizationName',
                'options' => array(
                        'label' => /*@translate */ 'Organization Name'),
                'attributes' => array(
                        //'id' => 'education-organizationname',

                        'title' =>  /*@translate */ 'please enter the name of the university or school'
                ),
            )
        );

        $this->add(
            array(
                'name' => 'country',
                'options' => array(
                        'label' => /*@translate */ 'Country'),
                'attributes' => array(
                        //'id' => 'education-country',

                        'title' => /*@translate */ 'please select the country'
                ),
            )
        );
        
        $this->add(
            array(
                'name' => 'city',
                'options' => array(
                        'label' => /*@translate */ 'City'),
                'attributes' => array(
                        //'id' => 'education-city',

                        'title' => /*@translate */ 'please enter the name of the city'
                ),
            )
        );
        
        $this->add(
            array(
                'name' => 'description',
                'type' => 'Zend\Form\Element\Textarea',
                'options' => array(
                        'label' => /*@translate */ 'Description',
                ),
                'attributes' => array(
                        //'id' => 'education-description',

                        'title' => /*@translate */ 'please enter a description',
                ),
            )
        );
               
    }

    /**
     *
     * @see \Zend\InputFilter\InputFilterProviderInterface::getInputFilterSpecification()
     */
    public function getInputFilterSpecification()
    {
        return [
            'type' => 'Cv/Education'
        ];
    }

    /**
     *
     * @see \Zend\Form\Form::setData()
     */
    public function populateValues($data)

    {
        if (isset($data['currentIndicator'])
            && isset($data['endDate'])
            && $data['currentIndicator']
        ) {
            // empty & hide endDate if currentIndicator is checked
            $data['endDate'] = '';
            $this->get('endDate')->setOption('rowClass', 'hidden');
        }
        
        return parent::populateValues($data);
    }
}


1		<?php
2
3		namespace Cv\Form;
4
5		use Zend\Form\Fieldset;
6		use Cv\Entity\Education as EducationEntity;
7		use Core\Entity\Hydrator\EntityHydrator;
8		use Zend\InputFilter\InputFilterProviderInterface;
9		use Core\Form\ViewPartialProviderInterface;
10		use Core\Form\ViewPartialProviderTrait;
11
12		class EducationFieldset extends Fieldset implements InputFilterProviderInterface, ViewPartialProviderInterface
13		{
14
15		use ViewPartialProviderTrait;
16
17		/**
18		* View script for rendering
19		*
20		* @var string
21		*/
22		protected $defaultPartial = 'cv/form/education';
23
24		public function init()
25		{
26		$this->setName('education')
27		->setHydrator(new EntityHydrator())
28		->setObject(new EducationEntity());
29
30		$this->add(
31		array(
32		'type' => 'Core/Datepicker',
33		'name' => 'startDate',
34		'options' => array(
35		'label' => /@translate/ 'Start date',
36		'data-width' => '50%',
37		'class' => 'selectpicker'
38		)
39		)
40		);
41		$this->add(
42		array(
43		'type' => 'Core/Datepicker',
44		'name' => 'endDate',
45		'options' => array(
46		'label' => /@translate/ 'End date'
47		)
48		)
49		);
50		$this->add(
51		array(
52		'type' => 'checkbox',
53		'name' => 'currentIndicator',
54		'options' => array(
55		'label' => /@translate / 'ongoing'
56		)
57		)
58		);
59
60		$this->add(
61		array(
62		'name' => 'competencyName',
63		'options' => array(
64		'label' => /@translate / 'Degree'),
65		'attributes' => array(
66		//'id' => 'education-competencyname',
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-02-04 16:54 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
67		'title' => /@translate / 'please enter the name of your qualification'
68		),
69		)
70		);
71
72		$this->add(
73		array(
74		'name' => 'organizationName',
75		'options' => array(
76		'label' => /@translate / 'Organization Name'),
77		'attributes' => array(
78		//'id' => 'education-organizationname',
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-02-04 16:54 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
79		'title' => /@translate / 'please enter the name of the university or school'
80		),
81		)
82		);
83
84		$this->add(
85		array(
86		'name' => 'country',
87		'options' => array(
88		'label' => /@translate / 'Country'),
89		'attributes' => array(
90		//'id' => 'education-country',
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-02-04 16:54 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
91		'title' => /@translate / 'please select the country'
92		),
93		)
94		);
95
96		$this->add(
97		array(
98		'name' => 'city',
99		'options' => array(
100		'label' => /@translate / 'City'),
101		'attributes' => array(
102		//'id' => 'education-city',
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-02-04 16:54 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
103		'title' => /@translate / 'please enter the name of the city'
104		),
105		)
106		);
107
108		$this->add(
109		array(
110		'name' => 'description',
111		'type' => 'Zend\Form\Element\Textarea',
112		'options' => array(
113		'label' => /@translate / 'Description',
114		),
115		'attributes' => array(
116		//'id' => 'education-description',
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-02-04 16:54 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
117		'title' => /@translate / 'please enter a description',
118		),
119		)
120		);
121
122		}
123
124		/**
125		*
126		* @see \Zend\InputFilter\InputFilterProviderInterface::getInputFilterSpecification()
127		*/
128		public function getInputFilterSpecification()
129		{
130		return [
131		'type' => 'Cv/Education'
132		];
133		}
134
135		/**
136		*
137		* @see \Zend\Form\Form::setData()
138		*/
139	View Code Duplication	public function populateValues($data)
		0 ignored issues – show Duplication introduced 2016-07-25 17:25 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
140		{
141		if (isset($data['currentIndicator'])
142		&& isset($data['endDate'])
143		&& $data['currentIndicator']
144		) {
145		// empty & hide endDate if currentIndicator is checked
146		$data['endDate'] = '';
147		$this->get('endDate')->setOption('rowClass', 'hidden');
148		}
149
150		return parent::populateValues($data);
151		}
152		}
153

cross-solution / YAWIK

Pull Request — develop (#261)

EducationFieldset::init() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like