Inspection of "created organizations profile page ref #458" - cross-solution/YAWIK - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#462)

by ANTHONIUS

created 2018-02-09 00:30 UTC

Status

Indentation +30 added lines, -30 removed lines patch added patch discarded remove patch

@@ -49,7 +49,7 @@  discard block
 block discarded – undo
 
     'controllers' => [
         'factories' => [
-	        'Organizations/InviteEmployee' => \Organizations\Factory\Controller\InviteEmployeeControllerFactory::class,
+            'Organizations/InviteEmployee' => \Organizations\Factory\Controller\InviteEmployeeControllerFactory::class,
             'Organizations/Index' => 'Organizations\Factory\Controller\IndexControllerFactory',
             'Organizations/Profile' => 'Organizations\Factory\Controller\ProfileControllerFactory'
         ]
@@ -66,14 +66,14 @@  discard block
 block discarded – undo
     'view_manager' => [
         // Map template to files. Speeds up the lookup through the template stack.
         'template_map' => [
-             'organizations/index/edit' => __DIR__ . '/../view/organizations/index/form.phtml',
-             'organizations/form/employees-fieldset' => __DIR__ . '/../view/form/employees-fieldset.phtml',
-             'organizations/form/employee-fieldset' => __DIR__ .'/../view/form/employee-fieldset.phtml',
-             'organizations/form/invite-employee-bar' => __DIR__ . '/../view/form/invite-employee-bar.phtml',
-             'organizations/error/no-parent' => __DIR__ . '/../view/error/no-parent.phtml',
-             'organizations/error/invite' => __DIR__ . '/../view/error/invite.phtml',
-             'organizations/mail/invite-employee' => __DIR__ . '/../view/mail/invite-employee.phtml',
-             'organizations/form/workflow-fieldset' => __DIR__ . '/../view/form/workflow-fieldset.phtml',
+                'organizations/index/edit' => __DIR__ . '/../view/organizations/index/form.phtml',
+                'organizations/form/employees-fieldset' => __DIR__ . '/../view/form/employees-fieldset.phtml',
+                'organizations/form/employee-fieldset' => __DIR__ .'/../view/form/employee-fieldset.phtml',
+                'organizations/form/invite-employee-bar' => __DIR__ . '/../view/form/invite-employee-bar.phtml',
+                'organizations/error/no-parent' => __DIR__ . '/../view/error/no-parent.phtml',
+                'organizations/error/invite' => __DIR__ . '/../view/error/invite.phtml',
+                'organizations/mail/invite-employee' => __DIR__ . '/../view/mail/invite-employee.phtml',
+                'organizations/form/workflow-fieldset' => __DIR__ . '/../view/form/workflow-fieldset.phtml',
         ],
         // Where to look for view templates not mapped above
         'template_path_stack' => [
@@ -82,24 +82,24 @@  discard block
 block discarded – undo
     ],
     'form_elements' => [
         'invokables' => [
-             'Organizations/Form' => 'Organizations\Form\Organizations',
-             'Organizations/OrganizationsContactForm'     => 'Organizations\Form\OrganizationsContactForm',
-             'Organizations/OrganizationsNameForm'        => 'Organizations\Form\OrganizationsNameForm',
-             'Organizations/OrganizationsDescriptionForm' => 'Organizations\Form\OrganizationsDescriptionForm',
-             'Organizations/OrganizationsContactFieldset' => 'Organizations\Form\OrganizationsContactFieldset',
-             'Organizations/OrganizationsDescriptionFieldset' => 'Organizations\Form\OrganizationsDescriptionFieldset',
-             //'Organizations/OrganizationFieldset'       => 'Organizations\Form\OrganizationFieldset',
-             'Organizations/EmployeesContainer'           => 'Organizations\Form\EmployeesContainer',
-             'Organizations/Employees'                    => 'Organizations\Form\Employees',
-             'Organizations/InviteEmployeeBar'            => 'Organizations\Form\Element\InviteEmployeeBar',
-             'Organizations/Employee'                     => 'Organizations\Form\Element\Employee',
-             'Organizations/WorkflowSettings'             => 'Organizations\Form\WorkflowSettings',
-             'Organizations/WorkflowSettingsFieldset'     => 'Organizations\Form\WorkflowSettingsFieldset',
-             'Organizations/Profile'                      => \Organizations\Form\OrganizationsProfileForm::class,
-             'Organizations/ProfileFieldset'              => \Organizations\Form\OrganizationsProfileFieldset::class
+                'Organizations/Form' => 'Organizations\Form\Organizations',
+                'Organizations/OrganizationsContactForm'     => 'Organizations\Form\OrganizationsContactForm',
+                'Organizations/OrganizationsNameForm'        => 'Organizations\Form\OrganizationsNameForm',
+                'Organizations/OrganizationsDescriptionForm' => 'Organizations\Form\OrganizationsDescriptionForm',
+                'Organizations/OrganizationsContactFieldset' => 'Organizations\Form\OrganizationsContactFieldset',
+                'Organizations/OrganizationsDescriptionFieldset' => 'Organizations\Form\OrganizationsDescriptionFieldset',
+                //'Organizations/OrganizationFieldset'       => 'Organizations\Form\OrganizationFieldset',
+                'Organizations/EmployeesContainer'           => 'Organizations\Form\EmployeesContainer',
+                'Organizations/Employees'                    => 'Organizations\Form\Employees',
+                'Organizations/InviteEmployeeBar'            => 'Organizations\Form\Element\InviteEmployeeBar',
+                'Organizations/Employee'                     => 'Organizations\Form\Element\Employee',
+                'Organizations/WorkflowSettings'             => 'Organizations\Form\WorkflowSettings',
+                'Organizations/WorkflowSettingsFieldset'     => 'Organizations\Form\WorkflowSettingsFieldset',
+                'Organizations/Profile'                      => \Organizations\Form\OrganizationsProfileForm::class,
+                'Organizations/ProfileFieldset'              => \Organizations\Form\OrganizationsProfileFieldset::class
         ],
         'factories' => [
-	        'Organizations/OrganizationsNameFieldset'    => \Organizations\Factory\Form\OrganizationsNameFieldsetFactory::class,
+            'Organizations/OrganizationsNameFieldset'    => \Organizations\Factory\Form\OrganizationsNameFieldsetFactory::class,
             'Organizations/Image'                        => \Organizations\Form\LogoImageFactory::class,
             'Organizations/EmployeesFieldset'            => 'Organizations\Factory\Form\EmployeesFieldsetFactory',
             'Organizations/EmployeeFieldset'             => 'Organizations\Factory\Form\EmployeeFieldsetFactory',
@@ -207,13 +207,13 @@  discard block
 block discarded – undo
 
     'service_manager' => [
         'invokables' => [
-           'Organizations\Auth\Dependency\EmployeeListListener' => 'Organizations\Auth\Dependency\EmployeeListListener'
+            'Organizations\Auth\Dependency\EmployeeListListener' => 'Organizations\Auth\Dependency\EmployeeListListener'
         ],
         'factories' => [
-           'Organizations\Auth\Dependency\ListListener' => 'Organizations\Factory\Auth\Dependency\ListListenerFactory',
-           'Organizations\ImageFileCache\Manager' => 'Organizations\Factory\ImageFileCache\ManagerFactory',
-           'Organizations\ImageFileCache\ODMListener' => 'Organizations\Factory\ImageFileCache\ODMListenerFactory',
-           'Organizations\ImageFileCache\ApplicationListener' => 'Organizations\Factory\ImageFileCache\ApplicationListenerFactory',
+            'Organizations\Auth\Dependency\ListListener' => 'Organizations\Factory\Auth\Dependency\ListListenerFactory',
+            'Organizations\ImageFileCache\Manager' => 'Organizations\Factory\ImageFileCache\ManagerFactory',
+            'Organizations\ImageFileCache\ODMListener' => 'Organizations\Factory\ImageFileCache\ODMListenerFactory',
+            'Organizations\ImageFileCache\ApplicationListener' => 'Organizations\Factory\ImageFileCache\ApplicationListenerFactory',
         ],
     ],
 

Please login to merge, or discard this patch.

Organizations/src/Organizations/Controller/InviteEmployeeController.php 1 patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -35,7 +35,7 @@
 block discarded – undo
      */
     private $orgRepo;
 
-	public function __construct(
+    public function __construct(
         OrganizationRepository $orgRepo
     )
     {

Please login to merge, or discard this patch.

		@@ -49,7 +49,7 @@ discard block
		block discarded – undo
49	49
50	50	'controllers' => [
51	51	'factories' => [
52		- 'Organizations/InviteEmployee' => \Organizations\Factory\Controller\InviteEmployeeControllerFactory::class,
	52	+ 'Organizations/InviteEmployee' => \Organizations\Factory\Controller\InviteEmployeeControllerFactory::class,
53	53	'Organizations/Index' => 'Organizations\Factory\Controller\IndexControllerFactory',
54	54	'Organizations/Profile' => 'Organizations\Factory\Controller\ProfileControllerFactory'
55	55	]
		@@ -66,14 +66,14 @@ discard block
		block discarded – undo
66	66	'view_manager' => [
67	67	// Map template to files. Speeds up the lookup through the template stack.
68	68	'template_map' => [
69		- 'organizations/index/edit' => __DIR__ . '/../view/organizations/index/form.phtml',
70		- 'organizations/form/employees-fieldset' => __DIR__ . '/../view/form/employees-fieldset.phtml',
71		- 'organizations/form/employee-fieldset' => __DIR__ .'/../view/form/employee-fieldset.phtml',
72		- 'organizations/form/invite-employee-bar' => __DIR__ . '/../view/form/invite-employee-bar.phtml',
73		- 'organizations/error/no-parent' => __DIR__ . '/../view/error/no-parent.phtml',
74		- 'organizations/error/invite' => __DIR__ . '/../view/error/invite.phtml',
75		- 'organizations/mail/invite-employee' => __DIR__ . '/../view/mail/invite-employee.phtml',
76		- 'organizations/form/workflow-fieldset' => __DIR__ . '/../view/form/workflow-fieldset.phtml',
	69	+ 'organizations/index/edit' => __DIR__ . '/../view/organizations/index/form.phtml',
	70	+ 'organizations/form/employees-fieldset' => __DIR__ . '/../view/form/employees-fieldset.phtml',
	71	+ 'organizations/form/employee-fieldset' => __DIR__ .'/../view/form/employee-fieldset.phtml',
	72	+ 'organizations/form/invite-employee-bar' => __DIR__ . '/../view/form/invite-employee-bar.phtml',
	73	+ 'organizations/error/no-parent' => __DIR__ . '/../view/error/no-parent.phtml',
	74	+ 'organizations/error/invite' => __DIR__ . '/../view/error/invite.phtml',
	75	+ 'organizations/mail/invite-employee' => __DIR__ . '/../view/mail/invite-employee.phtml',
	76	+ 'organizations/form/workflow-fieldset' => __DIR__ . '/../view/form/workflow-fieldset.phtml',
77	77	],
78	78	// Where to look for view templates not mapped above
79	79	'template_path_stack' => [
		@@ -82,24 +82,24 @@ discard block
		block discarded – undo
82	82	],
83	83	'form_elements' => [
84	84	'invokables' => [
85		- 'Organizations/Form' => 'Organizations\Form\Organizations',
86		- 'Organizations/OrganizationsContactForm' => 'Organizations\Form\OrganizationsContactForm',
87		- 'Organizations/OrganizationsNameForm' => 'Organizations\Form\OrganizationsNameForm',
88		- 'Organizations/OrganizationsDescriptionForm' => 'Organizations\Form\OrganizationsDescriptionForm',
89		- 'Organizations/OrganizationsContactFieldset' => 'Organizations\Form\OrganizationsContactFieldset',
90		- 'Organizations/OrganizationsDescriptionFieldset' => 'Organizations\Form\OrganizationsDescriptionFieldset',
91		- //'Organizations/OrganizationFieldset' => 'Organizations\Form\OrganizationFieldset',
92		- 'Organizations/EmployeesContainer' => 'Organizations\Form\EmployeesContainer',
93		- 'Organizations/Employees' => 'Organizations\Form\Employees',
94		- 'Organizations/InviteEmployeeBar' => 'Organizations\Form\Element\InviteEmployeeBar',
95		- 'Organizations/Employee' => 'Organizations\Form\Element\Employee',
96		- 'Organizations/WorkflowSettings' => 'Organizations\Form\WorkflowSettings',
97		- 'Organizations/WorkflowSettingsFieldset' => 'Organizations\Form\WorkflowSettingsFieldset',
98		- 'Organizations/Profile' => \Organizations\Form\OrganizationsProfileForm::class,
99		- 'Organizations/ProfileFieldset' => \Organizations\Form\OrganizationsProfileFieldset::class
	85	+ 'Organizations/Form' => 'Organizations\Form\Organizations',
	86	+ 'Organizations/OrganizationsContactForm' => 'Organizations\Form\OrganizationsContactForm',
	87	+ 'Organizations/OrganizationsNameForm' => 'Organizations\Form\OrganizationsNameForm',
	88	+ 'Organizations/OrganizationsDescriptionForm' => 'Organizations\Form\OrganizationsDescriptionForm',
	89	+ 'Organizations/OrganizationsContactFieldset' => 'Organizations\Form\OrganizationsContactFieldset',
	90	+ 'Organizations/OrganizationsDescriptionFieldset' => 'Organizations\Form\OrganizationsDescriptionFieldset',
	91	+ //'Organizations/OrganizationFieldset' => 'Organizations\Form\OrganizationFieldset',
	92	+ 'Organizations/EmployeesContainer' => 'Organizations\Form\EmployeesContainer',
	93	+ 'Organizations/Employees' => 'Organizations\Form\Employees',
	94	+ 'Organizations/InviteEmployeeBar' => 'Organizations\Form\Element\InviteEmployeeBar',
	95	+ 'Organizations/Employee' => 'Organizations\Form\Element\Employee',
	96	+ 'Organizations/WorkflowSettings' => 'Organizations\Form\WorkflowSettings',
	97	+ 'Organizations/WorkflowSettingsFieldset' => 'Organizations\Form\WorkflowSettingsFieldset',
	98	+ 'Organizations/Profile' => \Organizations\Form\OrganizationsProfileForm::class,
	99	+ 'Organizations/ProfileFieldset' => \Organizations\Form\OrganizationsProfileFieldset::class
100	100	],
101	101	'factories' => [
102		- 'Organizations/OrganizationsNameFieldset' => \Organizations\Factory\Form\OrganizationsNameFieldsetFactory::class,
	102	+ 'Organizations/OrganizationsNameFieldset' => \Organizations\Factory\Form\OrganizationsNameFieldsetFactory::class,
103	103	'Organizations/Image' => \Organizations\Form\LogoImageFactory::class,
104	104	'Organizations/EmployeesFieldset' => 'Organizations\Factory\Form\EmployeesFieldsetFactory',
105	105	'Organizations/EmployeeFieldset' => 'Organizations\Factory\Form\EmployeeFieldsetFactory',
		@@ -207,13 +207,13 @@ discard block
		block discarded – undo
207	207
208	208	'service_manager' => [
209	209	'invokables' => [
210		- 'Organizations\Auth\Dependency\EmployeeListListener' => 'Organizations\Auth\Dependency\EmployeeListListener'
	210	+ 'Organizations\Auth\Dependency\EmployeeListListener' => 'Organizations\Auth\Dependency\EmployeeListListener'
211	211	],
212	212	'factories' => [
213		- 'Organizations\Auth\Dependency\ListListener' => 'Organizations\Factory\Auth\Dependency\ListListenerFactory',
214		- 'Organizations\ImageFileCache\Manager' => 'Organizations\Factory\ImageFileCache\ManagerFactory',
215		- 'Organizations\ImageFileCache\ODMListener' => 'Organizations\Factory\ImageFileCache\ODMListenerFactory',
216		- 'Organizations\ImageFileCache\ApplicationListener' => 'Organizations\Factory\ImageFileCache\ApplicationListenerFactory',
	213	+ 'Organizations\Auth\Dependency\ListListener' => 'Organizations\Factory\Auth\Dependency\ListListenerFactory',
	214	+ 'Organizations\ImageFileCache\Manager' => 'Organizations\Factory\ImageFileCache\ManagerFactory',
	215	+ 'Organizations\ImageFileCache\ODMListener' => 'Organizations\Factory\ImageFileCache\ODMListenerFactory',
	216	+ 'Organizations\ImageFileCache\ApplicationListener' => 'Organizations\Factory\ImageFileCache\ApplicationListenerFactory',
217	217	],
218	218	],
219	219

		@@ -35,7 +35,7 @@
		block discarded – undo
35	35	*/
36	36	private $orgRepo;
37	37
38		- public function __construct(
	38	+ public function __construct(
39	39	OrganizationRepository $orgRepo
40	40	)
41	41	{

cross-solution / YAWIK

Pull Request — develop (#462)

Status

Category

Indentation +30 added lines, -30 removed lines patch added patch discarded remove patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch