Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 27 | View Code Duplication | class MayChangeCv implements AssertionInterface |
|
|
|
|||
| 28 | { |
||
| 29 | /** |
||
| 30 | * Returns true if and only if the assertion conditions are met |
||
| 31 | * |
||
| 32 | * This method is passed the ACL, Role, Resource, and privilege to which the authorization query applies. If the |
||
| 33 | * $role, $resource, or $privilege parameters are null, it means that the query applies to all Roles, Resources, or |
||
| 34 | * privileges, respectively. |
||
| 35 | * |
||
| 36 | * @param Acl $acl |
||
| 37 | * @param RoleInterface $role |
||
| 38 | * @param ResourceInterface $resource |
||
| 39 | * @param string $privilege |
||
| 40 | * |
||
| 41 | * @return bool |
||
| 42 | */ |
||
| 43 | public function assert(Acl $acl, RoleInterface $role = null, ResourceInterface $resource = null, $privilege = null) |
||
| 50 | |||
| 51 | |||
| 52 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.