Settings\Controller\IndexController

Complexity

Total Complexity

9

Size/Duplication

Total Lines	89
Duplicated Lines	10.11 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	attachDefaultListeners()	9	9	1
C	indexAction()	0	71	8

<?php
/**
 * YAWIK
 *
 * @filesource
 * @copyright (c) 2013 - 2016 Cross Solution (http://cross-solution.de)
 * @license   MIT
 * @author Mathias Weitz <weitz@cross-solution.de>
 * @author Carsten Bleek <bleek@cross-solution.de>
 * @author Mathias Gelhausen <gelhausen@cross-solution.de>
 * @author Miroslav Fedeleš <miroslav.fedeles@gmail.com>
 */

/** Settings controller */
namespace Settings\Controller;

use Zend\Mvc\Controller\AbstractActionController;
use Zend\View\Model\JsonModel;
use Zend\EventManager\Event;
use Zend\Http\PhpEnvironment\Response;

/**
 * Main Action Controller for Settings module
 *
 */
class IndexController extends AbstractActionController
{
    /**
     * attaches further Listeners for generating / processing the output
     *
     * @return $this
     */
    public function attachDefaultListeners()

This method seems to be duplicated in your project.

    {
        parent::attachDefaultListeners();
        $serviceLocator  = $this->serviceLocator;
        $defaultServices = $serviceLocator->get('DefaultListeners');
        $events          = $this->getEventManager();
        $events->attach($defaultServices);

$defaultServices is of type object|array, but the function expects a string.

        return $this;
    }

    public function indexAction()
    {
        $services = $this->serviceLocator;
        $translator = $services->get('translator');
        $moduleName = $this->params('module', 'Core');
        
        
        try {
            $settings = $this->settings($moduleName);

The method settings does not exist on object<Settings\Controller\IndexController>? Since you implemented __call, maybe consider adding a @method annotation.

        } catch (\InvalidArgumentException $e) {
            $this->getResponse()->setStatusCode(Response::STATUS_CODE_404);

It seems like you code against a concrete implementation and not the interface Zend\Stdlib\ResponseInterface as the method setStatusCode() does only exist in the following implementations of said interface: Zend\Http\PhpEnvironment\Response, Zend\Http\Response, Zend\Http\Response\Stream.

            return [
                'message' => sprintf($translator->translate('Settings "%s" does not exists'), $moduleName),
                'exception' => $e
            ];
        }
        
        $jsonFormat = 'json' == $this->params()->fromQuery('format');
        if (!$this->getRequest()->isPost() && $jsonFormat) {

It seems like you code against a concrete implementation and not the interface Zend\Stdlib\RequestInterface as the method isPost() does only exist in the following implementations of said interface: Zend\Http\PhpEnvironment\Request, Zend\Http\Request.

            return $settings->toArray();
        }
        
        $mvcEvent = $this->getEvent();
        $mvcEvent->setParam('__settings_active_module', $moduleName);
        
        $formManager = $this->serviceLocator->get('FormElementManager');
        $formName = $moduleName . '/SettingsForm';
        if (!$formManager->has($formName)) {
            $formName = "Settings/Form";
        }
        
        // Fetching an distinct Settings
        
        
        // Write-Access is per default only granted to the own module - change that
        $settings->enableWriteAccess();
        
        $form = $formManager->get($formName);
        
        // Binding the Entity to the Formular
        $form->bind($settings);
        $data = $this->getRequest()->getPost();

It seems like you code against a concrete implementation and not the interface Zend\Stdlib\RequestInterface as the method getPost() does only exist in the following implementations of said interface: Zend\Http\PhpEnvironment\Request, Zend\Http\Request.

        if (0 < count($data)) {
            $form->setData($data);
            
            $valid   = $form->isValid();
            $partial = $services->get('viewhelpermanager')->get('partial');

$partial is not used, you could remove the assignment.

            $text    = $valid
                     ?  /*@translate*/'Changes successfully saved'
                     :  /*@translate*/'Changes could not be saved';

            $vars = array();
            $this->notification()->success($translator->translate($text));

The method notification does not exist on object<Settings\Controller\IndexController>? Since you implemented __call, maybe consider adding a @method annotation.

            if ($valid) {
                $event = new Event(
                    'SETTINGS_CHANGED',
                    $this,
                    array('settings' => $settings)
                );
                $this->getEventManager()->trigger($event);
            } else {
                $vars['error'] = $form->getMessages();
            }
            
            return new JsonModel($vars);
        }

        $vars['form']=$form;

$vars was never initialized. Although not strictly required by PHP, it is generally a good practice to add $vars = array(); before regardless.

        return $vars;
    }
}