LoadDependendEntities - Code Metrics - Inspection of "Merge 'purge-entities' into develop" - cross-solution/YAWIK - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 9659b8...659b85 )

by Mathias

created 2018-10-26 13:18 UTC

LoadDependendEntities A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

Metric	Value
wmc	6
lcom	0
cbo	2
dl	0
loc	35
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	__construct()	4	1
A	__invoke()	10	2
A	onDelete()	11	3

<?php
/**
 * YAWIK
 *
 * @filesource
 * @license MIT
 * @copyright  2013 - 2018 Cross Solution <http://cross-solution.de>
 */
  
/** */
namespace Applications\Listener;

use Core\Service\EntityEraser\DependencyResultEvent;
use Jobs\Entity\Job;

/**
 * ${CARET}
 * 
 * @author Mathias Gelhausen <[email protected]>
 * @todo write test 
 */
class LoadDependendEntities 
{

    private $repository;

    public function __construct($repository)
    {
        $this->repository = $repository;
    }

    public function __invoke(DependencyResultEvent $event)
    {
        $entity = $event->getEntity();

        if ($entity instanceOf Job) {
            $entities = $event->getRepository('Applications')->findBy(['isDraft' => null, 'job' => new \MongoId($entity->getId())]);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

            return ['Applications', $entities, 'These applications references the job and will also be removed:' ];
        }
    }

    public function onDelete(DependencyResultEvent $event)
    {
        $entity = $event->getEntity();

        if ($entity instanceOf Job) {
            $repository = $event->getRepository('Applications');
            $entities = $repository->findBy(['isDraft' => null, 'job' => new \MongoId($entity->getId())]);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            foreach ($entities as $ent) { $repository->remove($ent); }
            return ['Applications', $entities, 'were removed.' ];
        }
    }


}


1			<?php
2			/**
3			* YAWIK
4			*
5			* @filesource
6			* @license MIT
7			* @copyright 2013 - 2018 Cross Solution <http://cross-solution.de>
8			*/
9
10			/** */
11			namespace Applications\Listener;
12
13			use Core\Service\EntityEraser\DependencyResultEvent;
14			use Jobs\Entity\Job;
15
16			/**
17			* ${CARET}
18			*
19			* @author Mathias Gelhausen <[email protected]>
20			* @todo write test
21			*/
22			class LoadDependendEntities
23			{
24
25			private $repository;
26
27			public function __construct($repository)
28			{
29			$this->repository = $repository;
30			}
31
32			public function __invoke(DependencyResultEvent $event)
33			{
34			$entity = $event->getEntity();
35
36			if ($entity instanceOf Job) {
37			$entities = $event->getRepository('Applications')->findBy(['isDraft' => null, 'job' => new \MongoId($entity->getId())]);
			0 ignored issues – show Bug introduced 2018-10-26 13:31 UTC by Report Bug Copy Issue Report The method `findBy` does only exist in `Doctrine\Common\Persistence\ObjectRepository`, but not in `Core\Repository\RepositoryInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
38
39			return ['Applications', $entities, 'These applications references the job and will also be removed:' ];
40			}
41			}
42
43			public function onDelete(DependencyResultEvent $event)
44			{
45			$entity = $event->getEntity();
46
47			if ($entity instanceOf Job) {
48			$repository = $event->getRepository('Applications');
49			$entities = $repository->findBy(['isDraft' => null, 'job' => new \MongoId($entity->getId())]);
			0 ignored issues – show Bug introduced 2018-10-26 13:31 UTC by Report Bug Copy Issue Report The method `findBy` does only exist in `Doctrine\Common\Persistence\ObjectRepository`, but not in `Core\Repository\RepositoryInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
50			foreach ($entities as $ent) { $repository->remove($ent); }
51			return ['Applications', $entities, 'were removed.' ];
52			}
53			}
54
55
56			}
57

cross-solution / YAWIK

Push — develop ( 9659b8...659b85 )

LoadDependendEntities A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like